phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-01-27 11:43:26 -03:00
Code Issues Projects Releases Packages Wiki Activity Actions
bitcoin/src/Makefile.am

1081 lines
29 KiB
Text
Raw Normal View History

Add MIT license to Makefiles
2016-09-21 22:31:23 +00:00
# Copyright (c) 2013-2016 The Bitcoin Core developers
# Distributed under the MIT software license, see the accompanying
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
build: Add var printing target to src/Makefile.am See 181989f6c9427fc266dbdcc84cb60ac03e67cdb2 for more info. I missed this one last time.
2020-09-25 16:53:04 -04:00
# Pattern rule to print variables, e.g. make print-top_srcdir
Mark print-% target as phony. .PHONY does not take patterns (such as print-%) as prerequisites. Have print-% depend on FORCE and mark FORCE as phony. $ # on master $ make print-host host=x86_64-pc-linux-gnu $ touch print-host $ make print-host make: 'print-host' is up to date. $ $ git co mark_print_as_phony Switched to branch 'mark_print_as_phony' $ make print-host host=x86_64-pc-linux-gnu $ touch FORCE $ make print-host host=x86_64-pc-linux-gnu
2021-06-13 11:38:59 -04:00
print-%: FORCE
build: Remove spaces from variable-printing rules This simplifies parsing when using these rules from scripts.
2021-02-25 18:16:07 -05:00
@echo '$*'='$($*)'
build: Add var printing target to src/Makefile.am See 181989f6c9427fc266dbdcc84cb60ac03e67cdb2 for more info. I missed this one last time.
2020-09-25 16:53:04 -04:00
Integrate univalue into our buildsystem This addresses issues like the one in #12467, where some of our compiler flags end up being dropped during the subconfigure of Univalue. Specifically, we're still using the compiler-default c++ version rather than forcing c++17. We can drop the need subconfigure completely in favor of a tighter build integration, where the sources are listed separately from the build recipes, so that they may be included directly by upstream projects. This is similar to the way leveldb build integration works in Core. Core benefits of this approach include: - Better caching (for ex. ccache and autoconf) - No need for a slow subconfigure - Faster autoconf - No more missing compile flags - Compile only the objects needed There are no benefits to Univalue itself that I can think of. These changes should be a no-op there, and to downstreams as well until they take advantage of the new sources.mk. This also removes the option to use an external univalue to avoid similar ABI issues with mystery binaries. Co-authored-by: fanquake <fanquake@gmail.com>
2021-07-15 18:42:17 +00:00
DIST_SUBDIRS = secp256k1
configure: Simplify common AM_CPPFLAGS and AM_LDFLAGS to a Makefile.common
2013-09-09 02:02:28 +00:00
build: stop overriding user LDFLAGS Let the user have the final say in regards to LDFLAGS.
2022-02-17 11:43:30 +00:00
AM_LDFLAGS = $(LIBTOOL_LDFLAGS) $(HARDENED_LDFLAGS) $(GPROF_LDFLAGS) $(SANITIZER_LDFLAGS) $(LTO_LDFLAGS) $(CORE_LDFLAGS)
build: stop overriding user CXXFLAGS Let users have the final say in regards to CXXFLAGS.
2022-02-17 16:16:52 +00:00
AM_CXXFLAGS = $(DEBUG_CXXFLAGS) $(HARDENED_CXXFLAGS) $(WARN_CXXFLAGS) $(NOWARN_CXXFLAGS) $(ERROR_CXXFLAGS) $(GPROF_CXXFLAGS) $(SANITIZER_CXXFLAGS) $(LTO_CXXFLAGS) $(CORE_CXXFLAGS)
build: stop overriding user CPPFLAGS Let the user have the final say in regards to CPPFLAGS
2022-02-17 11:31:36 +00:00
AM_CPPFLAGS = $(DEBUG_CPPFLAGS) $(HARDENED_CPPFLAGS) $(CORE_CPPFLAGS)
Remove direct bitcoin calls from qt/splashscreen.cpp
2017-04-17 15:10:47 -04:00
AM_LIBTOOLFLAGS = --preserve-dup-deps
build: split PTHREAD_* flags out of AM_LDFLAGS Note that with this change we are no-longer including PTHREAD_* flags when building libbitcoinconsensus. Also note that we are including PTHREAD_LIBS in AM_PTHREAD_FLAGS
2020-07-17 14:43:29 +08:00
PTHREAD_FLAGS = $(PTHREAD_CFLAGS) $(PTHREAD_LIBS)
leveldb: integrate leveldb into our buildsystem leveldb's buildsystem causes us a few problems: - breaks out-of-tree builds - forces flags used for some tools - limits cross builds Rather than continuing to add wrappers around it, simply integrate it into our build.
2016-02-17 14:35:35 -05:00
EXTRA_LIBRARIES =
autotools: switch to autotools buildsystem
2013-05-27 19:55:01 -04:00
build: Separate lib_LTLIBRARIES initialization Set lib_LTLIBRARIES with '=' to an empty value at the top of the Makefile.am and append to it from the library-local block for readability. Here's the error you get if you don't set lib_LTLIBRARIES to be empty: error: lib_LTLIBRARIES must be set with '=' before using '+=' [META] In a subsequent commit, we're going to introduce a library and append it to lib_LTLIBRARIES in its local block, this makes things more readable.
2022-02-08 17:06:21 -05:00
lib_LTLIBRARIES =
build: Create .la library for bitcoincrypto Libtool will yell at you if you try to link a shared library against static ones. This change creates a libtool archive library for bitcoincrypto and allows a shared library to be linked against it portably. Also specify -static in both: - ..._la_CXXFLAGS so that libtool will avoid building two versions of each object (one PIC, one non-PIC). We just need the one that is suitable for static linking. - ..._la_LDFLAGS so that libtool will create a static library. [META] This change is done in preparation for a future commit where we link the libbitcoinkernel library against this one.
2021-12-22 01:16:00 -05:00
noinst_LTLIBRARIES =
bin_PROGRAMS =
noinst_PROGRAMS =
TESTS =
BENCHMARKS =
build: pass bdb cppflags only where needed Move bdb cppflags out of the catch-all BITCOIN_INCLUDES, and pass them only where they are needed, which is in libbitcoin_node/wallet and the tests.
2022-05-30 10:24:00 +01:00
BITCOIN_INCLUDES=-I$(builddir) -I$(srcdir)/$(MINISKETCH_INCLUDE_DIR_INT) -I$(srcdir)/secp256k1/include -I$(srcdir)/$(UNIVALUE_INCLUDE_DIR_INT) $(BOOST_CPPFLAGS) $(LEVELDB_CPPFLAGS)
secp256k1: Add build-side changes for libsecp256k1 Note: This is added to our existing automake targets rather than as a libtool-style lib. The switch to libtool-style targets can come later if it proves to not add any complications.
2014-06-06 10:57:28 -04:00
scripted-diff: Rename libbitcoin_server.a to libbitcoin_node.a Goal along with namespacing PR #23497 is to have src/node/ code in node:: namespace in libbitcoin_node.a library -BEGIN VERIFY SCRIPT- bash -c ' # Bash shell needed for brace expansion {a,b} git mv build_msvc/libbitcoin_{server,node} git mv build_msvc/libbitcoin_node/libbitcoin_{server,node}.vcxproj.in ren() { git grep -l "$1" src build_msvc | xargs sed -i "s/$1/$2/g"; } ren LIBBITCOIN_{SERVER,NODE} ren libbitcoin_{server,node} ' -END VERIFY SCRIPT-
2021-12-20 10:53:01 -05:00
LIBBITCOIN_NODE=libbitcoin_node.a
Remove unnecessary dependencies for bitcoin-cli This commit removes all the unnecessary dependencies (key, core, netbase, sync, ...) from bitcoin-cli. To do this it shards the chain parameters into BaseParams, which contains just the RPC port and data directory (as used by utils and bitcoin-cli) and Params, with the rest.
2014-06-19 15:10:04 +02:00
LIBBITCOIN_COMMON=libbitcoin_common.a
Build: Consensus: Move consensus files from common to its own module/package
2015-11-20 16:46:03 +01:00
LIBBITCOIN_CONSENSUS=libbitcoin_consensus.a
Remove unnecessary dependencies for bitcoin-cli This commit removes all the unnecessary dependencies (key, core, netbase, sync, ...) from bitcoin-cli. To do this it shards the chain parameters into BaseParams, which contains just the RPC port and data directory (as used by utils and bitcoin-cli) and Params, with the rest.
2014-06-19 15:10:04 +02:00
LIBBITCOIN_CLI=libbitcoin_cli.a
LIBBITCOIN_UTIL=libbitcoin_util.a
build: Create .la library for bitcoincrypto Libtool will yell at you if you try to link a shared library against static ones. This change creates a libtool archive library for bitcoincrypto and allows a shared library to be linked against it portably. Also specify -static in both: - ..._la_CXXFLAGS so that libtool will avoid building two versions of each object (one PIC, one non-PIC). We just need the one that is suitable for static linking. - ..._la_LDFLAGS so that libtool will create a static library. [META] This change is done in preparation for a future commit where we link the libbitcoinkernel library against this one.
2021-12-22 01:16:00 -05:00
LIBBITCOIN_CRYPTO_BASE=crypto/libbitcoin_crypto_base.la
Remove unnecessary dependencies for bitcoin-cli This commit removes all the unnecessary dependencies (key, core, netbase, sync, ...) from bitcoin-cli. To do this it shards the chain parameters into BaseParams, which contains just the RPC port and data directory (as used by utils and bitcoin-cli) and Params, with the rest.
2014-06-19 15:10:04 +02:00
LIBBITCOINQT=qt/libbitcoinqt.a
Always build and link libsecp256k1
2014-11-05 07:58:37 -08:00
LIBSECP256K1=secp256k1/libsecp256k1.la
crypter: shuffle Makefile so that crypto can be used by the wallet Wallet must come before crypto, otherwise linking fails on some platforms. Includes a tangentially-related general cleanup rather than making the Makefile sloppier.
2015-03-26 19:15:28 -04:00
if ENABLE_ZMQ
LIBBITCOIN_ZMQ=libbitcoin_zmq.a
endif
if BUILD_BITCOIN_LIBS
LIBBITCOINCONSENSUS=libbitcoinconsensus.la
endif
build: Extract the libbitcoinkernel library I strongly recommend reviewing with the following git-diff flags: --patience --color-moved=dimmed-zebra Extract out a libbitcoinkernel library linking in all files necessary for using our consensus engine as-is. Link bitcoin-chainstate against it. See previous commit "build: Add example bitcoin-chainstate executable" for more context. We explicitly specify -fvisibility=default, which effectively overrides the effects of --enable-reduced-exports since libbitcoinkernel requires default symbol visibility When compiling for mingw-w64, specify -static in both: - ..._la_CXXFLAGS so that libtool will avoid building two versions of each object (one PIC, one non-PIC). We just need the one that is suitable for static linking. - ..._la_LDFLAGS so that libtool will create a static library. If we don't specify this, then libtool will prefer the non-static PIC version of the object, which is built with -DDLL_EXPORT -DPIC for mingw-w64 targets. This can cause symbol resolution problems when we link this library against an executable that does specify -all-static, since that will be built without the -DDLL_EXPORT flag. Unfortunately, this means that for mingw-w64 we can only build a static version of the library for now. This will be fixed. However, on other targets, the shared library creation works fine. ----- Note to users: You need to either specify: --enable-experimental-util-chainstate or, --with-experimental-kernel-lib To build the libbitcionkernel library. See the configure help for more details. build shared libbitcoinkernel where we can
2021-12-21 20:10:05 -05:00
if BUILD_BITCOIN_KERNEL_LIB
LIBBITCOINKERNEL=libbitcoinkernel.la
endif
crypter: shuffle Makefile so that crypto can be used by the wallet Wallet must come before crypto, otherwise linking fails on some platforms. Includes a tangentially-related general cleanup rather than making the Makefile sloppier.
2015-03-26 19:15:28 -04:00
if ENABLE_WALLET
LIBBITCOIN_WALLET=libbitcoin_wallet.a
[tools] Add wallet inspection and modification tool This commit adds wallet-tool, a tool for creating and interacting with wallet files. Original implementation was by Jonas Schnelli <dev@jonasschnelli.ch> with modifications by John Newbery <john@johnnewbery.com> MSVC files were provided by Chun Kuan Lee <ken2812221@gmail.com>: build: Add MSVC project files for bitcoin-wallet-tool
2016-09-16 16:45:36 +02:00
LIBBITCOIN_WALLET_TOOL=libbitcoin_wallet_tool.a
crypter: shuffle Makefile so that crypto can be used by the wallet Wallet must come before crypto, otherwise linking fails on some platforms. Includes a tangentially-related general cleanup rather than making the Makefile sloppier.
2015-03-26 19:15:28 -04:00
endif
build: Create .la library for bitcoincrypto Libtool will yell at you if you try to link a shared library against static ones. This change creates a libtool archive library for bitcoincrypto and allows a shared library to be linked against it portably. Also specify -static in both: - ..._la_CXXFLAGS so that libtool will avoid building two versions of each object (one PIC, one non-PIC). We just need the one that is suitable for static linking. - ..._la_LDFLAGS so that libtool will create a static library. [META] This change is done in preparation for a future commit where we link the libbitcoinkernel library against this one.
2021-12-22 01:16:00 -05:00
LIBBITCOIN_CRYPTO = $(LIBBITCOIN_CRYPTO_BASE)
crypto: cleanup sha256 build Rather than appending all possible cpu variants to all targets, create a convenience variable that encompasses all.
2018-06-06 15:20:34 -04:00
if ENABLE_SSE41
build: Create .la library for bitcoincrypto Libtool will yell at you if you try to link a shared library against static ones. This change creates a libtool archive library for bitcoincrypto and allows a shared library to be linked against it portably. Also specify -static in both: - ..._la_CXXFLAGS so that libtool will avoid building two versions of each object (one PIC, one non-PIC). We just need the one that is suitable for static linking. - ..._la_LDFLAGS so that libtool will create a static library. [META] This change is done in preparation for a future commit where we link the libbitcoinkernel library against this one.
2021-12-22 01:16:00 -05:00
LIBBITCOIN_CRYPTO_SSE41 = crypto/libbitcoin_crypto_sse41.la
crypto: cleanup sha256 build Rather than appending all possible cpu variants to all targets, create a convenience variable that encompasses all.
2018-06-06 15:20:34 -04:00
LIBBITCOIN_CRYPTO += $(LIBBITCOIN_CRYPTO_SSE41)
endif
if ENABLE_AVX2
build: Create .la library for bitcoincrypto Libtool will yell at you if you try to link a shared library against static ones. This change creates a libtool archive library for bitcoincrypto and allows a shared library to be linked against it portably. Also specify -static in both: - ..._la_CXXFLAGS so that libtool will avoid building two versions of each object (one PIC, one non-PIC). We just need the one that is suitable for static linking. - ..._la_LDFLAGS so that libtool will create a static library. [META] This change is done in preparation for a future commit where we link the libbitcoinkernel library against this one.
2021-12-22 01:16:00 -05:00
LIBBITCOIN_CRYPTO_AVX2 = crypto/libbitcoin_crypto_avx2.la
crypto: cleanup sha256 build Rather than appending all possible cpu variants to all targets, create a convenience variable that encompasses all.
2018-06-06 15:20:34 -04:00
LIBBITCOIN_CRYPTO += $(LIBBITCOIN_CRYPTO_AVX2)
endif
Rename SHANI to X86_SHANI to allow future implementation of ARM_SHANI
2022-01-20 17:26:00 +01:00
if ENABLE_X86_SHANI
build: Create .la library for bitcoincrypto Libtool will yell at you if you try to link a shared library against static ones. This change creates a libtool archive library for bitcoincrypto and allows a shared library to be linked against it portably. Also specify -static in both: - ..._la_CXXFLAGS so that libtool will avoid building two versions of each object (one PIC, one non-PIC). We just need the one that is suitable for static linking. - ..._la_LDFLAGS so that libtool will create a static library. [META] This change is done in preparation for a future commit where we link the libbitcoinkernel library against this one.
2021-12-22 01:16:00 -05:00
LIBBITCOIN_CRYPTO_X86_SHANI = crypto/libbitcoin_crypto_x86_shani.la
Rename SHANI to X86_SHANI to allow future implementation of ARM_SHANI
2022-01-20 17:26:00 +01:00
LIBBITCOIN_CRYPTO += $(LIBBITCOIN_CRYPTO_X86_SHANI)
Add SHA256 implementation using using Intel SHA intrinsics
2018-06-24 10:50:40 -07:00
endif
Add sha256_arm_shani to build system Also rename AArch64 intrinsics to ARMv8 intrinsics as these are not necessarily limited to 64-bit
2022-01-20 18:57:27 +01:00
if ENABLE_ARM_SHANI
build: Create .la library for bitcoincrypto Libtool will yell at you if you try to link a shared library against static ones. This change creates a libtool archive library for bitcoincrypto and allows a shared library to be linked against it portably. Also specify -static in both: - ..._la_CXXFLAGS so that libtool will avoid building two versions of each object (one PIC, one non-PIC). We just need the one that is suitable for static linking. - ..._la_LDFLAGS so that libtool will create a static library. [META] This change is done in preparation for a future commit where we link the libbitcoinkernel library against this one.
2021-12-22 01:16:00 -05:00
LIBBITCOIN_CRYPTO_ARM_SHANI = crypto/libbitcoin_crypto_arm_shani.la
Add sha256_arm_shani to build system Also rename AArch64 intrinsics to ARMv8 intrinsics as these are not necessarily limited to 64-bit
2022-01-20 18:57:27 +01:00
LIBBITCOIN_CRYPTO += $(LIBBITCOIN_CRYPTO_ARM_SHANI)
Add SHA256 implementation using using Intel SHA intrinsics
2018-06-24 10:50:40 -07:00
endif
build: Create .la library for bitcoincrypto Libtool will yell at you if you try to link a shared library against static ones. This change creates a libtool archive library for bitcoincrypto and allows a shared library to be linked against it portably. Also specify -static in both: - ..._la_CXXFLAGS so that libtool will avoid building two versions of each object (one PIC, one non-PIC). We just need the one that is suitable for static linking. - ..._la_LDFLAGS so that libtool will create a static library. [META] This change is done in preparation for a future commit where we link the libbitcoinkernel library against this one.
2021-12-22 01:16:00 -05:00
noinst_LTLIBRARIES += $(LIBBITCOIN_CRYPTO)
crypto: cleanup sha256 build Rather than appending all possible cpu variants to all targets, create a convenience variable that encompasses all.
2018-06-06 15:20:34 -04:00
[build] Tune wildcards for LIBSECP256K1 target Automake would think the target was out of date every time because e.g. '.deps' was updated.
2018-03-26 18:36:17 +09:00
$(LIBSECP256K1): $(wildcard secp256k1/src/*.h) $(wildcard secp256k1/src/*.c) $(wildcard secp256k1/include/*)
build: secp256k1 as a subdir, since it's required
2014-11-05 20:56:45 -05:00
$(AM_V_at)$(MAKE) $(AM_MAKEFLAGS) -C $(@D) $(@F)
Remove unnecessary dependencies for bitcoin-cli This commit removes all the unnecessary dependencies (key, core, netbase, sync, ...) from bitcoin-cli. To do this it shards the chain parameters into BaseParams, which contains just the RPC port and data directory (as used by utils and bitcoin-cli) and Params, with the rest.
2014-06-19 15:10:04 +02:00
Build util and common before building server
2014-10-21 08:36:09 +02:00
# Make is not made aware of per-object dependencies to avoid limiting building parallelization
# But to build the less dependent modules first, we manually select their order here:
leveldb: integrate leveldb into our buildsystem leveldb's buildsystem causes us a few problems: - breaks out-of-tree builds - forces flags used for some tools - limits cross builds Rather than continuing to add wrappers around it, simply integrate it into our build.
2016-02-17 14:35:35 -05:00
EXTRA_LIBRARIES += \
crypter: shuffle Makefile so that crypto can be used by the wallet Wallet must come before crypto, otherwise linking fails on some platforms. Includes a tangentially-related general cleanup rather than making the Makefile sloppier.
2015-03-26 19:15:28 -04:00
$(LIBBITCOIN_UTIL) \
$(LIBBITCOIN_COMMON) \
$(LIBBITCOIN_CONSENSUS) \
scripted-diff: Rename libbitcoin_server.a to libbitcoin_node.a Goal along with namespacing PR #23497 is to have src/node/ code in node:: namespace in libbitcoin_node.a library -BEGIN VERIFY SCRIPT- bash -c ' # Bash shell needed for brace expansion {a,b} git mv build_msvc/libbitcoin_{server,node} git mv build_msvc/libbitcoin_node/libbitcoin_{server,node}.vcxproj.in ren() { git grep -l "$1" src build_msvc | xargs sed -i "s/$1/$2/g"; } ren LIBBITCOIN_{SERVER,NODE} ren libbitcoin_{server,node} ' -END VERIFY SCRIPT-
2021-12-20 10:53:01 -05:00
$(LIBBITCOIN_NODE) \
crypter: shuffle Makefile so that crypto can be used by the wallet Wallet must come before crypto, otherwise linking fails on some platforms. Includes a tangentially-related general cleanup rather than making the Makefile sloppier.
2015-03-26 19:15:28 -04:00
$(LIBBITCOIN_CLI) \
multiprocess: Add Ipc interface implementation
2017-12-05 15:57:12 -05:00
$(LIBBITCOIN_IPC) \
crypter: shuffle Makefile so that crypto can be used by the wallet Wallet must come before crypto, otherwise linking fails on some platforms. Includes a tangentially-related general cleanup rather than making the Makefile sloppier.
2015-03-26 19:15:28 -04:00
$(LIBBITCOIN_WALLET) \
[tools] Add wallet inspection and modification tool This commit adds wallet-tool, a tool for creating and interacting with wallet files. Original implementation was by Jonas Schnelli <dev@jonasschnelli.ch> with modifications by John Newbery <john@johnnewbery.com> MSVC files were provided by Chun Kuan Lee <ken2812221@gmail.com>: build: Add MSVC project files for bitcoin-wallet-tool
2016-09-16 16:45:36 +02:00
$(LIBBITCOIN_WALLET_TOOL) \
crypter: shuffle Makefile so that crypto can be used by the wallet Wallet must come before crypto, otherwise linking fails on some platforms. Includes a tangentially-related general cleanup rather than making the Makefile sloppier.
2015-03-26 19:15:28 -04:00
$(LIBBITCOIN_ZMQ)
autotools: switch to autotools buildsystem
2013-05-27 19:55:01 -04:00
configure: Internal changes to make building bitcoind and bitcoin-cli optional
2013-09-08 02:44:12 +00:00
if BUILD_BITCOIND
bin_PROGRAMS += bitcoind
endif
build: multiprocess autotools changes autoconf and automake changes to support multiprocess gui/node/wallet execution. This adds a new --enable-multiprocess flag, and build configuration code to detect libraries needed for multiprocess support. The --enable-multiprocess flag builds new bitcoin-node and bitcoin-gui executables, which are updated in https://github.com/bitcoin/bitcoin/pull/10102 to communicate across processes. But for now they are functionally equivalent to existing bitcoind and bitcoin-qt executables.
2019-07-10 13:46:31 -04:00
if BUILD_BITCOIN_NODE
bin_PROGRAMS += bitcoin-node
endif
configure: Make it possible to build only one of bitcoin-cli or bitcoin-tx
2014-12-25 11:43:52 +00:00
if BUILD_BITCOIN_CLI
bin_PROGRAMS += bitcoin-cli
endif
Add bitcoin-util command line utility
2020-09-10 08:09:07 +10:00
configure: Make it possible to build only one of bitcoin-cli or bitcoin-tx
2014-12-25 11:43:52 +00:00
if BUILD_BITCOIN_TX
bin_PROGRAMS += bitcoin-tx
configure: Internal changes to make building bitcoind and bitcoin-cli optional
2013-09-08 02:44:12 +00:00
endif
Add bitcoin-util command line utility
2020-09-10 08:09:07 +10:00
[tools] Add wallet inspection and modification tool This commit adds wallet-tool, a tool for creating and interacting with wallet files. Original implementation was by Jonas Schnelli <dev@jonasschnelli.ch> with modifications by John Newbery <john@johnnewbery.com> MSVC files were provided by Chun Kuan Lee <ken2812221@gmail.com>: build: Add MSVC project files for bitcoin-wallet-tool
2016-09-16 16:45:36 +02:00
if ENABLE_WALLET
if BUILD_BITCOIN_WALLET
bin_PROGRAMS += bitcoin-wallet
endif
endif
autotools: switch to autotools buildsystem
2013-05-27 19:55:01 -04:00
Add bitcoin-util command line utility
2020-09-10 08:09:07 +10:00
if BUILD_BITCOIN_UTIL
bin_PROGRAMS += bitcoin-util
endif
build: Add example bitcoin-chainstate executable The bitcoin-chainstate executable serves to surface the dependencies required by a program wishing to use Bitcoin Core's consensus engine as it is right now. More broadly, the _SOURCES list serves as a guiding "North Star" for the libbitcoinkernel project: as we decouple more and more modules of the codebase from our consensus engine, this _SOURCES list will grow shorter and shorter. One day, only what is critical to our consensus engine will remain. Right now, it's "the minimal list of files to link in to even use our consensus engine". [META] In a future commit the libbitcoinkernel library will be extracted from bitcoin-chainstate, and the libbitcoinkernel library's _SOURCES list will be the list that we aim to shrink.
2021-09-01 15:46:51 -04:00
if BUILD_BITCOIN_CHAINSTATE
bin_PROGRAMS += bitcoin-chainstate
endif
release: add check-symbols and check-security make targets These are not added to the default checks because some of them depend on release-build configs.
2016-01-26 14:52:56 -05:00
.PHONY: FORCE check-symbols check-security
autotools: switch to autotools buildsystem
2013-05-27 19:55:01 -04:00
# bitcoin core #
makefile.am: split long lines into one file per line This makes it easier to read diffs. Cosmetic change to build system only.
2014-01-11 15:22:07 +01:00
BITCOIN_CORE_H = \
net: move CBanDB and CAddrDB out of net.h/cpp This will eventually solve a circular dependency
2016-04-16 00:13:15 -04:00
addrdb.h \
makefile.am: split long lines into one file per line This makes it easier to read diffs. Cosmetic change to build system only.
2014-01-11 15:22:07 +01:00
addrman.h \
[addrman] Introduce CAddrMan::Impl to encapsulate addrman implementation. Introduce the pimpl pattern for CAddrMan to separate the implementation details from the externally used object representation. This reduces compile-time dependencies and conceptually clarifies AddrMan's interface from the implementation specifics. Since the unit & fuzz tests currently rely on accessing CAddrMan internals, this commit introduces addrman_impl.h, which is exclusively imported by addrman.cpp and test files. Review hint: git diff --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space
2021-09-01 11:21:29 -07:00
addrman_impl.h \
Add NODISCARD to all {Decode,Parse}[...](...) functions returning bool. Sort includes.
2018-09-25 07:00:36 +02:00
attributes.h \
net: move BanMan to its own files
2017-10-05 16:40:43 -04:00
banman.h \
Move bignum.h to test/
2014-05-09 17:56:16 +02:00
base58.h \
Import Bech32 C++ reference code & tests This includes a reformatted version of the Bech32 reference code (see https://github.com/sipa/bech32/tree/master/ref/c%2B%2B), with extra documentation.
2017-08-25 18:12:39 -07:00
bech32.h \
Add partial-block block encodings API
2016-04-15 12:23:57 -07:00
blockencodings.h \
blockfilter: Declare GCSFilter class for BIP 158 impl.
2018-01-23 16:10:08 -08:00
blockfilter.h \
Move CBlockIndex, CChain and related code out of main
2014-09-03 02:20:09 +02:00
chain.h \
uint256->arith_uint256 blob256->uint256 Introduce new opaque implementation of `uint256`, move old "arithmetic" implementation to `arith_uint256.
2014-12-15 10:22:19 +01:00
chainparams.h \
Alphabetic order in makefile
2015-05-13 18:59:50 +02:00
chainparamsbase.h \
Add built-in seeds for .onion This makes it possible for a node with `-onlynet=tor` to bootstrap itself. It also adds the base infrastructure for adding IPv6 seed nodes. Also represent IPv4 fixed seed addresses in 16-byte format.
2014-07-24 13:52:57 +02:00
chainparamsseeds.h \
makefile.am: split long lines into one file per line This makes it easier to read diffs. Cosmetic change to build system only.
2014-01-11 15:22:07 +01:00
checkqueue.h \
clientversion.h \
coins.h \
style: Sort
2021-09-29 17:09:55 +02:00
common/bloom.h \
makefile.am: split long lines into one file per line This makes it easier to read diffs. Cosmetic change to build system only.
2014-01-11 15:22:07 +01:00
compat.h \
Add compile time verification of assumptions we're currently making implicitly/tacitly
2019-02-11 23:52:59 +01:00
compat/assumptions.h \
Alphabetic order in makefile
2015-05-13 18:59:50 +02:00
compat/byteswap.h \
[MOVEONLY] Move cpuid code from random & sha256 to compat/cpuid
2019-10-27 12:52:31 -07:00
compat/cpuid.h \
Alphabetic order in makefile
2015-05-13 18:59:50 +02:00
compat/endian.h \
MOVEONLY: Move script/compressor out of script and put CTxOutCompressor (from core) with it
2014-10-19 04:28:43 +02:00
compressor.h \
[net] Move ConnectionType to its own file
2021-12-01 19:11:37 +00:00
node/connection_types.h \
Consensus: Create consensus/consensus.h with some constants
2015-01-24 15:29:29 +01:00
consensus/consensus.h \
[build] Move CheckTransaction from lib_server to lib_consensus CheckTransaction is a context-free function that does not require access to the blockchain or mempool. Move it from src/consensus/tx_verify in lib_server to a new unit src/consensus/tx_check in lib_consensus so that it can be called by non-server libraries.
2019-04-02 13:41:12 -04:00
consensus/tx_check.h \
MOVEONLY: tx functions to consensus/tx_verify.o Functions related to transaction verification.
2016-07-11 16:34:21 +02:00
consensus/tx_verify.h \
Consolidate CTransaction hex encode/decode into core_io.h, core_{read,write}.cpp
2014-06-23 23:10:24 -04:00
core_io.h \
Separate core memory usage computation in core_memusage.h
2015-07-17 13:46:18 -04:00
core_memusage.h \
build: Include cuckoocache header in Makefile
2016-12-21 01:39:59 +01:00
cuckoocache.h \
build: Sort Makefile.am after renaming file
2020-06-19 18:15:22 -04:00
dbwrapper.h \
[move-only] Rename versionbitsinfo to deploymentinfo
2021-03-11 12:17:22 +10:00
deploymentinfo.h \
[refactor] Add deploymentstatus.h Provides DeploymentEnabled, DeploymentActiveAt, and DeploymentActiveAfter helpers for checking the status of buried deployments. Can be overloaded so the same syntax works for non-buried deployments, allowing future soft forks to be changed from signalled to buried deployments without having to touch the implementation code. Replaces IsWitnessEnabled and IsScriptWitnessEnabled.
2020-06-16 18:58:56 +10:00
deploymentstatus.h \
[net] Move eviction logic to its own file
2022-05-26 16:07:04 +02:00
node/eviction.h \
Move external signer out of wallet module This commit moves the ExternalSigner class and RPC methods out of the wallet module. The enumeratesigners RPC can be used without a wallet since #21417. With additional modifications external signers could be used without a wallet in general, e.g. via signrawtransaction. The signerdisplayaddress RPC is ranamed to walletdisplayaddress because it requires wallet context. A future displayaddress RPC call without wallet context could take a descriptor argument. This commit fixes a rpc_help.py failure when configured with --disable-wallet.
2021-03-18 14:17:39 +01:00
external_signer.h \
validation: Extract basic block file logic into FlatFileSeq class.
2019-01-06 11:06:31 -08:00
flatfile.h \
Add fs.cpp/h
2017-03-01 15:53:56 +00:00
fs.h \
evhttpd implementation - *Replace usage of boost::asio with [libevent2](http://libevent.org/)*. boost::asio is not part of C++11, so unlike other boost there is no forwards-compatibility reason to stick with it. Together with #4738 (convert json_spirit to UniValue), this rids Bitcoin Core of the worst offenders with regard to compile-time slowness. - *Replace spit-and-duct-tape http server with evhttp*. Front-end http handling is handled by libevent, a work queue (with configurable depth and parallelism) is used to handle application requests. - *Wrap HTTP request in C++ class*; this makes the application code mostly HTTP-server-neutral - *Refactor RPC to move all http-specific code to a separate file*. Theoreticaly this can allow building without HTTP server but with another RPC backend, e.g. Qt's debug console (currently not implemented) or future RPC mechanisms people may want to use. - *HTTP dispatch mechanism*; services (e.g., RPC, REST) register which URL paths they want to handle. By using a proven, high-performance asynchronous networking library (also used by Tor) and HTTP server, problems such as #5674, #5655, #344 should be avoided. What works? bitcoind, bitcoin-cli, bitcoin-qt. Unit tests and RPC/REST tests pass. The aim for now is everything but SSL support. Configuration options: - `-rpcthreads`: repurposed as "number of work handler threads". Still defaults to 4. - `-rpcworkqueue`: maximum depth of work queue. When this is reached, new requests will return a 500 Internal Error. - `-rpctimeout`: inactivity time, in seconds, after which to disconnect a client. - `-debug=http`: low-level http activity logging
2015-01-23 07:53:17 +01:00
httprpc.h \
httpserver.h \
net: implement the necessary parts of the I2P SAM protocol Implement the following commands from the I2P SAM protocol: * HELLO: needed for all of the remaining ones * DEST GENERATE: to generate our private key and destination * NAMING LOOKUP: to convert .i2p addresses to destinations * SESSION CREATE: needed for STREAM CONNECT and STREAM ACCEPT * STREAM CONNECT: to make outgoing connections * STREAM ACCEPT: to accept incoming connections
2020-11-27 13:59:26 +01:00
i2p.h \
MOVEONLY: Move BaseIndex to its own file.
2018-05-15 15:57:48 -07:00
index/base.h \
index: Implement block filter index with write operations.
2018-08-27 17:01:24 -07:00
index/blockfilterindex.h \
index: Add Coinstats index The index holds the values previously calculated in coinstats.cpp for each block, representing the state of the UTXO set at each height.
2020-01-24 18:56:47 +01:00
index/coinstatsindex.h \
Move only: Move CDiskTxPos to its own file
2019-01-20 14:17:17 -05:00
index/disktxpos.h \
[index] Create new TxIndex class. The TxIndex will be responsible for building the transaction index concurrently with the main validation thread by implementing ValidationInterface. This does not process blocks concurrently yet.
2017-12-08 10:19:57 -08:00
index/txindex.h \
mapNextTx: use pointer as key, simplify value Saves about 10% of application memory usage once the mempool warms up. Since the mempool is DynamicUsage-regulated, this will translate to a larger mempool in the same amount of space. Map value type: eliminate the vin index; no users of the map need to know which input of the transaction is spending the prevout. Map key type: replace the COutPoint with a pointer to a COutPoint. A COutPoint is 36 bytes, but each COutPoint is accessible from the same map entry's value. A trivial DereferencingComparator functor allows indirect map keys, but the resulting syntax is misleading: `map.find(&outpoint)`. Implement an indirectmap that acts as a wrapper to a map that uses a DereferencingComparator, supporting a syntax that accurately reflect the container's semantics: inserts and iterators use pointers since they store pointers and need them to remain constant and dereferenceable, but lookup functions take const references.
2016-04-30 21:45:26 -07:00
indirectmap.h \
makefile.am: split long lines into one file per line This makes it easier to read diffs. Cosmetic change to build system only.
2014-01-11 15:22:07 +01:00
init.h \
Move common global init code to init/common
2021-04-18 18:56:12 -04:00
init/common.h \
Add skeleton chain and client classes This commit does not change behavior. It just adds new skeleton classes that don't do anything and aren't instantiated yet.
2017-05-30 15:55:17 -04:00
interfaces/chain.h \
multiprocess: Add echoipc RPC method and test Add simple interfaces::Echo IPC interface with one method that just takes and returns a string, to test multiprocess framework and provide an example of how it can be used to spawn and call between processes.
2020-11-24 13:59:33 -05:00
interfaces/echo.h \
scripted-diff: Avoid `interface` keyword to fix windows gitian build Rename `interface` to `interfaces` Build failure reported by Chun Kuan Lee <ken2812221@gmail.com> https://github.com/bitcoin/bitcoin/pull/10244#issuecomment-379434756 -BEGIN VERIFY SCRIPT- git mv src/interface src/interfaces ren() { git grep -l "$1" | xargs sed -i "s,$1,$2,g"; } ren interface/ interfaces/ ren interface:: interfaces:: ren BITCOIN_INTERFACE_ BITCOIN_INTERFACES_ ren "namespace interface" "namespace interfaces" -END VERIFY SCRIPT-
2018-04-07 03:42:02 -04:00
interfaces/handler.h \
multiprocess: Add Ipc and Init interface definitions
2017-12-05 15:57:12 -05:00
interfaces/init.h \
interfaces/ipc.h \
scripted-diff: Avoid `interface` keyword to fix windows gitian build Rename `interface` to `interfaces` Build failure reported by Chun Kuan Lee <ken2812221@gmail.com> https://github.com/bitcoin/bitcoin/pull/10244#issuecomment-379434756 -BEGIN VERIFY SCRIPT- git mv src/interface src/interfaces ren() { git grep -l "$1" | xargs sed -i "s,$1,$2,g"; } ren interface/ interfaces/ ren interface:: interfaces:: ren BITCOIN_INTERFACE_ BITCOIN_INTERFACES_ ren "namespace interface" "namespace interfaces" -END VERIFY SCRIPT-
2018-04-07 03:42:02 -04:00
interfaces/node.h \
interfaces/wallet.h \
Add ChainstateManagerOpts, using as ::Options [META] Although it seems like we don't need it for just one option, we're going to introduce another member to this struct *in the next commit*. In future patchsets for libbitcoinkernel decoupling it from ArgsManager, even more members will be added here.
2022-03-01 16:14:12 -05:00
kernel/chainstatemanager_opts.h \
Move init::SanityCheck to kernel::SanityCheck
2022-05-27 16:47:05 -04:00
kernel/checks.h \
coinstats: Split node/coinstats.h to kernel/coinstats.h Most of this commit is pure-move. After this change: - kernel/coinstats.h -> Contains declarations for: - enum class CoinStatsHashType - struct CCoinsStats - GetBogoSize(...) - TxOutSer(...) - ComputeUTXOStats(...) - node/coinstats.h -> Just GetUTXOStats, which will be removed as we change callers to directly use the hashing/indexing codepaths in future commits.
2022-02-16 17:51:57 -05:00
kernel/coinstats.h \
kernel: Introduce empty and unused kernel::Context [META] In the next commit, we will move the init::{Set,Unset}Globals logic into this struct. Co-Authored-By: Ryan Ofsky <ryan@ofsky.org>
2022-05-25 14:55:44 -04:00
kernel/context.h \
mempool: Introduce (still-unused) MemPoolLimits They live as a CTxMemPool member. [META] These limits will be used in subsequent commits to replace calls to gArgs.
2022-03-17 22:09:05 -04:00
kernel/mempool_limits.h \
pool: Add and use MemPoolOptions, ApplyArgsManOptions Reviewers: Note that CTxMemPool now requires a non-defaulted CTxMemPool::Options for its constructor. Meaning that there's no need to worry about a stray CTxMemPool constructor somewhere defaulting to something incorrect. All instances of CTxMemPool construction are addressed here in this commit. We set options for CTxMemPool and construct it in many different ways. A good example can be seen in how we determine CTxMemPool's check_ratio in AppInitMain(...). 1. We first set the default based on chainparams's DefaultConsistencyChecks() 2. Then, we apply the ArgsManager option on top of that default 3. Finally, we clamp the result of that between 0 and 1 Million With this patch, most CTxMemPool construction are along the lines of: MemPoolOptions mempool_opts{...default overrides...}; ApplyArgsManOptions(argsman, mempool_opts); ...hard overrides... CTxMemPool pool{mempool_opts}; This "compositional" style of building options means that we can omit unnecessary/irrelevant steps wherever we want but also maintain full customizability. For example: - For users of libbitcoinkernel, where we eventually want to remove ArgsManager, they simply won't call (or even know about) ApplyArgsManOptions. - See src/init.cpp to see how the check_ratio CTxMemPool option works after this change. A MemPoolOptionsForTest helper was also added and used by tests/fuzz tests where a local CTxMemPool needed to be created. The change in src/test/fuzz/tx_pool.cpp seemingly changes behaviour by applying ArgsManager options on top of the CTxMemPool::Options defaults. However, in future commits where we introduce flags like -maxmempool, the call to ApplyArgsManOptions is actually what preserves the existing behaviour. Previously, although it wasn't obvious, our CTxMemPool would consult gArgs for flags like -maxmempool when it needed it, so it already relied on ArgsManager information. This patchset just laid bare the obfuscatory perils of globals. [META] As this patchset progresses, we will move more and more CTxMemPool-relevant options into MemPoolOptions and add their ArgsMan-related logic to ApplyArgsManOptions.
2022-03-18 13:51:37 -04:00
kernel/mempool_options.h \
makefile.am: split long lines into one file per line This makes it easier to read diffs. Cosmetic change to build system only.
2014-01-11 15:22:07 +01:00
key.h \
Split key_io (address/key encodings) off from base58
2017-09-19 18:12:25 -07:00
key_io.h \
MOVEONLY: Move logging code from util.{h,cpp} to new files.
2018-04-18 10:05:05 -07:00
logging.h \
logs: add BCLog::Timer and related macros Makes logging timing information about a block of code easier.
2019-09-19 13:59:49 -04:00
logging/timer.h \
refactor: Move port mapping code to its own module This commit does not change behavior.
2020-02-06 19:00:26 +02:00
mapport.h \
pool: Add and use MemPoolOptions, ApplyArgsManOptions Reviewers: Note that CTxMemPool now requires a non-defaulted CTxMemPool::Options for its constructor. Meaning that there's no need to worry about a stray CTxMemPool constructor somewhere defaulting to something incorrect. All instances of CTxMemPool construction are addressed here in this commit. We set options for CTxMemPool and construct it in many different ways. A good example can be seen in how we determine CTxMemPool's check_ratio in AppInitMain(...). 1. We first set the default based on chainparams's DefaultConsistencyChecks() 2. Then, we apply the ArgsManager option on top of that default 3. Finally, we clamp the result of that between 0 and 1 Million With this patch, most CTxMemPool construction are along the lines of: MemPoolOptions mempool_opts{...default overrides...}; ApplyArgsManOptions(argsman, mempool_opts); ...hard overrides... CTxMemPool pool{mempool_opts}; This "compositional" style of building options means that we can omit unnecessary/irrelevant steps wherever we want but also maintain full customizability. For example: - For users of libbitcoinkernel, where we eventually want to remove ArgsManager, they simply won't call (or even know about) ApplyArgsManOptions. - See src/init.cpp to see how the check_ratio CTxMemPool option works after this change. A MemPoolOptionsForTest helper was also added and used by tests/fuzz tests where a local CTxMemPool needed to be created. The change in src/test/fuzz/tx_pool.cpp seemingly changes behaviour by applying ArgsManager options on top of the CTxMemPool::Options defaults. However, in future commits where we introduce flags like -maxmempool, the call to ApplyArgsManOptions is actually what preserves the existing behaviour. Previously, although it wasn't obvious, our CTxMemPool would consult gArgs for flags like -maxmempool when it needed it, so it already relied on ArgsManager information. This patchset just laid bare the obfuscatory perils of globals. [META] As this patchset progresses, we will move more and more CTxMemPool-relevant options into MemPoolOptions and add their ArgsMan-related logic to ApplyArgsManOptions.
2022-03-18 13:51:37 -04:00
mempool_args.h \
Add memusage.h
2015-05-04 00:20:46 +02:00
memusage.h \
Move CMerkleBlock and CPartialMerkleTree to their own file
2014-10-30 15:50:15 -07:00
merkleblock.h \
makefile.am: split long lines into one file per line This makes it easier to read diffs. Cosmetic change to build system only.
2014-01-11 15:22:07 +01:00
net.h \
Make whitebind/whitelist permissions more flexible
2019-06-20 18:37:51 +09:00
net_permissions.h \
Move network-msg-processing code out of main to its own file
2016-12-01 15:45:50 -08:00
net_processing.h \
refactor: Remove addrdb.h dependency from node.h
2019-10-29 10:49:48 +02:00
net_types.h \
net: move CNetAddr/CService/CSubNet out of netbase
2016-05-31 17:25:03 -04:00
netaddress.h \
net: fixup nits
2016-08-12 14:21:50 -04:00
netbase.h \
[build] Add netgroup.cpp|h These aren't used yet.
2021-08-31 13:22:36 +01:00
netgroup.h \
net: add CVectorWriter and CNetMsgMaker CVectorWriter is useful for overwriting or appending an existing byte vector. CNetMsgMaker is a shortcut for creating messages on-the-fly which are suitable for pushing to CConnman.
2016-11-10 17:05:23 -05:00
netmessagemaker.h \
move-only: Move ThreadImport to blockstorage Can be reviewed with the git options --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space
2021-04-02 19:17:00 +02:00
node/blockstorage.h \
node/caches: Extract cache calculation logic I strongly recommend reviewing with the following git-diff flags: --color-moved=dimmed_zebra --color-moved-ws=allow-indentation-change [META] In a future commit, this function will be re-used in TestingSetup so that the behaviour matches across test and non-test init codepaths.
2021-09-21 11:37:03 -04:00
node/caches.h \
node: Extract chainstate loading sequence I strongly recommend reviewing with the following git-diff flags: --color-moved=dimmed_zebra --color-moved-ws=allow-indentation-change [META] This commit is intended to be as close to a move-only commit as possible, and lingering ugliness will be resolved in subsequent commits. A few variables that are passed in by value instead of by reference deserve explanation: - fReset and fReindexChainstate are both local variables in AppInitMain and are not modified in the sequence - fPruneMode, despite being a global, is only modified in AppInitParameterInteraction, long before LoadChainstate is called ---- [META] This semantic will change in a future commit named "node/chainstate: Decouple from stringy errors"
2021-09-20 16:12:18 -04:00
node/chainstate.h \
Remove use of CCoinsViewMemPool::GetCoin in wallet code This commit does not change behavior.
2018-07-17 13:04:35 -04:00
node/coin.h \
MOVEONLY: Move NodeContext struct to node/context.h
2019-09-17 17:11:31 -04:00
node/context.h \
style: Sort file list after rename
2021-11-15 13:48:58 +01:00
node/miner.h \
Sort file list after rename
2021-11-12 10:59:36 +01:00
node/minisketchwrapper.h \
[build] Move AnalyzePSBT from psbt.cpp to node/psbt.cpp psbt.cpp definitions except for AnalyzePSBT are used by the wallet and need to be linked into the wallet binary. AnalyzePSBT is an exception in that it is not used by the wallet, and depends on node classes like CCoinsViewCache, and on node global variables like nBytesPerSigOp. So AnalyzePSBT is more at home in libbitcoin_server than libbitcoin_common, and in any case needs to be defined in a separate object file than other PSBT utilities, to avoid dragging link dependencies on node functions and global variables into the wallet.
2019-04-08 16:33:05 -04:00
node/psbt.h \
Factor BroadcastTransaction out of sendrawtransaction Factor out a new BroadcastTransaction function, performing the core work of the sendrawtransaction rpc, so that it can be used from the GUI code. Move it from src/rpc/ to src/node/.
2019-01-08 22:16:50 -08:00
node/transaction.h \
scripted-diff: Avoid incompatibility with CMake AUTOUIC feature -BEGIN VERIFY SCRIPT- sed -i "s|node/ui_interface|node/interface_ui|g" $(git grep -l "node/ui_interface" ./src) git mv src/node/ui_interface.cpp src/node/interface_ui.cpp git mv src/node/ui_interface.h src/node/interface_ui.h sed -i "s|BITCOIN_NODE_UI_INTERFACE_H|BITCOIN_NODE_INTERFACE_UI_H|g" src/node/interface_ui.h -END VERIFY SCRIPT-
2022-06-14 10:38:51 +02:00
node/interface_ui.h \
add unused SnapshotMetadata class
2019-03-28 12:08:32 -04:00
node/utxo_snapshot.h \
makefile.am: split long lines into one file per line This makes it easier to read diffs. Cosmetic change to build system only.
2014-01-11 15:22:07 +01:00
noui.h \
Add outputtype module Moves OutputType into its own module
2018-07-09 18:15:50 +10:00
outputtype.h \
Consensus: Policy: MOVEONLY: Move CFeeRate out of the consensus module ...from amount.o to policy/feerate.o Policy, because it moves policy code to the policy directory (common module)
2016-03-31 23:30:17 +02:00
policy/feerate.h \
Create new BlockPolicyEstimator for fee estimates This class groups transactions that have been confirmed in blocks into buckets, based on either their fee or their priority. Then for each bucket, the class calculates what percentage of the transactions were confirmed within various numbers of blocks. It does this by keeping an exponentially decaying moving history for each bucket and confirm block count of the percentage of transactions in that bucket that were confirmed within that number of blocks. -Eliminate txs which didn't have all inputs available at entry from fee/pri calcs -Add dynamic breakpoints and tracking of confirmation delays in mempool transactions -Remove old CMinerPolicyEstimator and CBlockAverage code -New smartfees.py -Pass a flag to the estimation code, using IsInitialBlockDownload as a proxy for when we are still catching up and we shouldn't be counting how many blocks it takes for transactions to be included. -Add a policyestimator unit test
2014-08-26 16:28:32 -04:00
policy/fees.h \
fees: Pass in a filepath instead of referencing gArgs
2021-12-08 16:19:31 -05:00
policy/fees_args.h \
[policy] Define packages Define the Package type as an alias for a vector of transactions for now. Add PackageValidationResult, similar to TxValidationResult and BlockValidationResult for package-wide errors that cannot be reported within a single transaction result, such as having too many transactions in the package. We can update the concept of what a package is and have different logic for packages vs lists of transactions in the future, e.g. for package relay.
2021-02-11 09:50:42 -08:00
policy/packages.h \
Policy: MOVEONLY: Create policy/policy.h with some constants
2015-06-24 07:25:30 +02:00
policy/policy.h \
RPC: indicate which transactions are replaceable Add "bip125-replaceable" output field to listtransactions and gettransaction which indicates if an unconfirmed transaction, or any unconfirmed parent, is signaling opt-in RBF according to BIP 125.
2015-12-16 14:57:54 -05:00
policy/rbf.h \
[build] Move policy settings to new src/policy/settings unit This moves the following policy settings functions and globals to a new src/policy/settings unit in lib_server: - `incrementalRelayFee` - `dustRelayFee` - `nBytesPerSigOp` - `fIsBareMultisigStd` These settings are only required by the node and should not be accessed by other libraries.
2019-04-02 14:14:58 -04:00
policy/settings.h \
Refactor proof of work related functions out of main
2014-03-10 08:46:53 -07:00
pow.h \
makefile.am: split long lines into one file per line This makes it easier to read diffs. Cosmetic change to build system only.
2014-01-11 15:22:07 +01:00
protocol.h \
Move PSBT definitions and code to separate files Move non-wallet PSBT code to src/psbt.{h,cpp}, and PSBT wallet code to src/wallet/psbtwallet.{h,cpp}. This commit contains only code movement (and adjustments to includes and Makefile.am.)
2019-01-09 02:06:29 -08:00
psbt.h \
move rand functions from util to new random.h/.cpp
2014-06-26 14:41:53 +02:00
random.h \
[MOVEONLY] Move perfmon data gathering to new randomenv module
2019-10-26 12:20:12 -07:00
randomenv.h \
Refactoring: move declarations to rest.h This facilitates unit testing
2022-01-27 21:20:05 +00:00
rest.h \
Introduce src/reverse_iterator.hpp and include it... ...where it will be needed Taken from https://gist.github.com/arvidsson/7231973 with small modifications to fit the bitcoin core project
2017-04-13 00:24:40 +02:00
reverse_iterator.h \
refactor: Move GetDifficulty out of `rpc/server.h` It has no business in `rpcserver.h`. Define it in the interface header of the implementation unit `rpcblockchain` where it is defined. Also modernize the signature to: double GetDifficulty(const CBlockIndex* blockindex = nullptr); (remove `extern`, replace `NULL` with `nullptr`)
2017-03-27 12:14:43 +02:00
rpc/blockchain.h \
move rpc* to rpc/
2016-01-15 11:55:17 +11:00
rpc/client.h \
rpc: Move mempool RPCs to new file Can be reviewed with: --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space
2022-03-11 17:51:36 +01:00
rpc/mempool.h \
rpc: create rpc/mining.h, hoist default max tries values to constant
2020-05-31 14:11:21 +02:00
rpc/mining.h \
move rpc* to rpc/
2016-01-15 11:55:17 +11:00
rpc/protocol.h \
[build] Move rpc rawtransaction util functions to rpc/rawtransaction_util.cpp rpc/rawtransaction.cpp moves to libbitcoin_server since it should not be accessed by non-node libraries. The utility following utility methods move to their own unit rpc/rawtransaction_util since they need to be accessed by non-node libraries: - `ConstructTransaction` - `TxInErrorToJSON` - `SignTransaction`
2019-04-02 16:51:32 -04:00
rpc/rawtransaction_util.h \
rpc: Register calls where they are defined Split out methods to every module, apart from 'help' and 'stop' which are implemented in rpcserver.cpp itself. - This makes it easier to add or remove RPC commands - no longer everything that includes rpcserver.h has to be rebuilt when there's a change there. - Cleans up `rpc/server.h` by getting rid of the huge cluttered list of function definitions. - Removes most of the bitcoin-specific code from rpcserver.cpp and .h. Continues #7307 for the non-wallet.
2016-03-29 19:43:02 +02:00
rpc/register.h \
rpc: migrate JSONRPCRequest functionality into request.cpp
2019-06-20 02:39:38 +09:00
rpc/request.h \
rpc/server.h \
rpc: move Ensure* helpers to server_util.h
2021-04-21 16:39:40 +02:00
rpc/server_util.h \
Disallow using addresses in createmultisig Make createmultisig only accept public keys with the old functionality marked as deprecated. Splits _createmultisig_redeemscript into two functions, one for getting public keys from UniValue and one for getting addresses from UniValue and then their respective public keys. The one for retrieving address's public keys is located in rpcwallet.cpp Changes addwitnessaddress's output to be a JSON object with two fields, address and redeemscript. Adds a test to deprecated_rpc.py for testing the deprecation. Update the tests to use addwitnessaddress or give only public keys to createmultisig. Anything that used addwitnessaddress was also updated to reflect the new API.
2017-09-29 00:21:28 -04:00
rpc/util.h \
CScheduler class for lightweight task scheduling Simple class to manage a task queue that is serviced by one or more threads.
2015-04-02 10:33:45 -04:00
scheduler.h \
Output descriptors module
2018-07-04 18:08:19 -07:00
script/descriptor.h \
Move KeyOriginInfo to its own header file
2019-06-17 15:47:12 -04:00
script/keyorigin.h \
Miniscript: type system, script creation, text notation, tests More information about Miniscript can be found at https://bitcoin.sipa.be/miniscript/ (the website source is hosted at https://github.com/sipa/miniscript/). This commit defines all fragments, their composition, parsing from string representation and conversion to Script. Co-Authored-By: Antoine Poinsot <darosior@protonmail.com> Co-Authored-By: Sanket Kanjalkar <sanket1729@gmail.com> Co-Authored-By: Samuel Dobson <dobsonsa68@gmail.com>
2019-08-28 16:23:03 -07:00
script/miniscript.h \
Make signature cache optional
2014-09-10 16:16:09 +02:00
script/sigcache.h \
Separate script/sign
2014-08-27 17:22:33 +02:00
script/sign.h \
Move various SigningProviders to signingprovider.{cpp,h} Moves all of the various SigningProviders out of sign.{cpp,h} and keystore.{cpp,h}. As such, keystore.{cpp,h} is also removed. Includes and the Makefile are updated to reflect this. Includes were largely changed using: git grep -l "keystore.h" | xargs sed -i -e 's;keystore.h;script/signingprovider.h;g'
2019-06-06 22:52:24 +02:00
script/signingprovider.h \
Separate script/standard
2014-08-23 03:35:51 +02:00
script/standard.h \
Break circular dependency: init -> * -> init by extracting shutdown.h Most includers just wanted to react to pending shutdown. This isolates access to `fRequestShutdown` and limits access to the shutdown api functions, including the new `AbortShutdown` for setting it to `false`. Note I originally called `AbortShutdown` `CancelShutdown` but that name was already taken by winuser.h https://travis-ci.org/bitcoin/bitcoin/jobs/386913329 This change also triggered a build error in bench. Fixing it required moving LIBBITCOIN_SERVER after LIBBITCOIN_WALLET in bench_bench_bitcoin_LDADD To make server definitions in src/net.cpp available to wallet methods in src/wallet/wallet.cpp. Specifically, solving: libbitcoin_wallet.a(libbitcoin_wallet_a-wallet.o): In function `CWalletTx::RelayWalletTransaction(CConnman*)': wallet.cpp:(.text+0x3f0e): undefined reference to `CConnman::NodeFullyConnected(CNode const*)' collect2: error: ld returned 1 exit status https://travis-ci.org/bitcoin/bitcoin/jobs/392133581 Need for remaining init.h includes confirmed via a thorough search with a more specific regex: \bInterrupt\(\)|\bShutdown\(\)|\bInitLogging\(\)|\bInitParameterInteraction\(\)|\bAppInitBasicSetup\(\)|\bAppInitParameterInteraction\(\)|\bAppInitSanityChecks\(\)|\bAppInitLockDataDirectory\(\)|\bAppInitMain\(\)|\bSetupServerArgs\(\)|\bLicenseInfo\(\)|g_wallet_init_interface|init.h
2018-05-16 19:17:40 +00:00
shutdown.h \
add signet basic support (signet.cpp) Co-authored-by: Anthony Towns <aj@erisian.com.au>
2019-07-17 17:41:32 +09:00
signet.h \
boost: split stream classes out of serialize.h serialization now has no dependencies.
2014-10-22 15:08:30 -04:00
streams.h \
allocators: split allocators and pagelocker Pagelocker is only needed for secure (usually wallet) operations, so don't make the zero-after-free allocator depend on it.
2015-01-22 15:02:44 -05:00
support/allocators/secure.h \
support/allocators/zeroafterfree.h \
openssl: abstract out OPENSSL_cleanse This makes it easier for us to replace it if desired, since it's now only in one spot. Also, it avoids the openssl include from allocators.h, which essentially forced openssl to be included from every compilation unit.
2015-01-20 19:23:25 -05:00
support/cleanse.h \
Added std::unique_ptr<> wrappers with deleters for libevent modules.
2016-12-20 15:59:42 +09:00
support/events.h \
support: Add LockedPool Add a pool for locked memory chunks, replacing LockedPageManager. This is something I've been wanting to do for a long time. The current approach of locking objects where they happen to be on the stack or heap in-place causes a lot of mlock/munlock system call overhead, slowing down any handling of keys. Also locked memory is a limited resource on many operating systems (and using a lot of it bogs down the system), so the previous approach of locking every page that may contain any key information (but also other information) is wasteful.
2016-09-18 09:55:14 +02:00
support/lockedpool.h \
makefile.am: split long lines into one file per line This makes it easier to read diffs. Cosmetic change to build system only.
2014-01-11 15:22:07 +01:00
sync.h \
net: add CThreadInterrupt and InterruptibleSleep
2016-12-27 17:12:15 -05:00
threadinterrupt.h \
build: Sort Makefile.am after renaming file
2020-06-19 18:15:22 -04:00
threadsafety.h \
Move network-time related functions to timedata.cpp/h The network time-offset-mangement functions from util.cpp are moved to timedata.(cpp|h). This breaks the dependency of util on netbase.
2014-06-19 15:08:37 +02:00
timedata.h \
net: Automatically create hidden service, listen on Tor Starting with Tor version 0.2.7.1 it is possible, through Tor's control socket API, to create and destroy 'ephemeral' hidden services programmatically. https://stem.torproject.org/api/control.html#stem.control.Controller.create_ephemeral_hidden_service This means that if Tor is running (and proper authorization is available), bitcoin automatically creates a hidden service to listen on, without user manual configuration. This will positively affect the number of available .onion nodes. - When the node is started, connect to Tor through control socket - Send `ADD_ONION` command - First time: - Make it create a hidden service key - Save the key in the data directory for later usage - Make it redirect port 8333 to the local port 8333 (or whatever port we're listening on). - Keep control socket connection open for as long node is running. The hidden service will (by default) automatically go away when the connection is closed.
2015-08-25 20:12:08 +02:00
torcontrol.h \
makefile.am: split long lines into one file per line This makes it easier to read diffs. Cosmetic change to build system only.
2014-01-11 15:22:07 +01:00
txdb.h \
txmempool.h \
move-only: Add txorphanage module This module captures orphan tracking code for tx relay. Can be reviewed with --color-moved=dimmed-zebra
2021-01-31 00:55:54 +10:00
txorphanage.h \
txrequest.h \
MOVEONLY: separate CTxUndo out of core
2014-10-18 19:53:37 +02:00
undo.h \
Add asmap utility which queries a mapping The scripts for creating a compact IP->ASN mapping are here: https://github.com/sipa/asmap Co-authored-by: Pieter Wuille <pieter.wuille@gmail.com>
2019-12-18 14:27:03 -05:00
util/asmap.h \
Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp} Creates new files util/bip32.h and util/bip32.cpp for containing BIP 32 stuff. Moves FormatKeyPath from descriptor.cpp to util/bip32. Adds a wrapper around it to prepent the 'm' for when just the BIP 32 style keypath is needed.
2018-11-06 09:23:43 -05:00
util/bip32.h \
blockfilter: Use unordered_set instead of set in blockfilter.
2018-08-20 23:35:29 -07:00
util/bytevectorhash.h \
util: Add CHECK_NONFATAL and use it in src/rpc
2019-09-23 14:45:51 -04:00
util/check.h \
Use designated initializers
2022-03-11 10:14:31 +01:00
util/designator.h \
[refactor] txmempool: split epoch logic into class
2020-12-04 12:49:22 +10:00
util/epochguard.h \
[build] Add several util units Adds the following util units and adds them to libbitcoin_util: - `util/url.cpp` takes `urlDecode` from `httpserver.cpp` - `util/error.cpp` takes `TransactionErrorString` from `node/transaction.cpp` and `AmountHighWarn` and `AmountErrMsg` from `ui_interface.cpp` - `util/fees.cpp` takes `StringForFeeReason` and `FeeModeFromString` from `policy/fees.cpp` - `util/rbf.cpp` takes `SignalsOptInRBF` from `policy/rbf.cpp` - 'util/validation.cpp` takes `FormatStateMessage` and `strMessageMagic` from 'validation.cpp`
2019-04-02 17:03:37 -04:00
util/error.h \
[moveonly] Move MapIntoRange() to separate util/fastrange.h
2022-01-06 11:27:06 -05:00
util/fastrange.h \
[build] Add several util units Adds the following util units and adds them to libbitcoin_util: - `util/url.cpp` takes `urlDecode` from `httpserver.cpp` - `util/error.cpp` takes `TransactionErrorString` from `node/transaction.cpp` and `AmountHighWarn` and `AmountErrMsg` from `ui_interface.cpp` - `util/fees.cpp` takes `StringForFeeReason` and `FeeModeFromString` from `policy/fees.cpp` - `util/rbf.cpp` takes `SignalsOptInRBF` from `policy/rbf.cpp` - 'util/validation.cpp` takes `FormatStateMessage` and `strMessageMagic` from 'validation.cpp`
2019-04-02 17:03:37 -04:00
util/fees.h \
Introduce GetUniquePath(base) helper method to replace boost::filesystem::unique_path() which is not available in std::filesystem.
2021-02-01 13:35:28 +01:00
util/getuniquepath.h \
tests: Add fuzzing harness for Golomb-Rice coding (GolombRiceEncode/GolombRiceDecode)
2020-02-21 15:57:02 +00:00
util/golombrice.h \
move-only: Add util/hash_type Can be reviewed with --color-moved=dimmed-zebra
2021-04-04 12:25:56 +02:00
util/hash_type.h \
Move Hashers to util/hasher.{cpp/h} Move the hashers that we use for hash tables to a common place. Moved hashers: - SaltedTxidHasher - SaltedOutpointHasher - FilterHeaderHasher - SignatureCacheHasher - BlockHasher
2019-09-17 17:02:56 -04:00
util/hasher.h \
refactor: consolidate PASTE macros
2019-09-25 10:55:52 -04:00
util/macros.h \
Deduplicate the message verifying code The logic of verifying a message was duplicated in 2 places: src/qt/signverifymessagedialog.cpp SignVerifyMessageDialog::on_verifyMessageButton_VM_clicked() src/rpc/misc.cpp verifymessage() with the only difference being the result handling. Move the logic into a dedicated src/util/message.cpp MessageVerify() which returns a set of result codes, call it from the 2 places and just handle the results differently in the callers.
2019-11-19 15:49:35 +01:00
util/message.h \
scripted-diff: Move util files to separate directory. -BEGIN VERIFY SCRIPT- mkdir -p src/util git mv src/util.h src/util/system.h git mv src/util.cpp src/util/system.cpp git mv src/utilmemory.h src/util/memory.h git mv src/utilmoneystr.h src/util/moneystr.h git mv src/utilmoneystr.cpp src/util/moneystr.cpp git mv src/utilstrencodings.h src/util/strencodings.h git mv src/utilstrencodings.cpp src/util/strencodings.cpp git mv src/utiltime.h src/util/time.h git mv src/utiltime.cpp src/util/time.cpp sed -i 's/<util\.h>/<util\/system\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilmemory\.h>/<util\/memory\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilmoneystr\.h>/<util\/moneystr\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilstrencodings\.h>/<util\/strencodings\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utiltime\.h>/<util\/time\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/BITCOIN_UTIL_H/BITCOIN_UTIL_SYSTEM_H/g' src/util/system.h sed -i 's/BITCOIN_UTILMEMORY_H/BITCOIN_UTIL_MEMORY_H/g' src/util/memory.h sed -i 's/BITCOIN_UTILMONEYSTR_H/BITCOIN_UTIL_MONEYSTR_H/g' src/util/moneystr.h sed -i 's/BITCOIN_UTILSTRENCODINGS_H/BITCOIN_UTIL_STRENCODINGS_H/g' src/util/strencodings.h sed -i 's/BITCOIN_UTILTIME_H/BITCOIN_UTIL_TIME_H/g' src/util/time.h sed -i 's/ util\.\(h\|cpp\)/ util\/system\.\1/g' src/Makefile.am sed -i 's/utilmemory\.\(h\|cpp\)/util\/memory\.\1/g' src/Makefile.am sed -i 's/utilmoneystr\.\(h\|cpp\)/util\/moneystr\.\1/g' src/Makefile.am sed -i 's/utilstrencodings\.\(h\|cpp\)/util\/strencodings\.\1/g' src/Makefile.am sed -i 's/utiltime\.\(h\|cpp\)/util\/time\.\1/g' src/Makefile.am sed -i 's/-> util ->/-> util\/system ->/' test/lint/lint-circular-dependencies.sh sed -i 's/src\/util\.cpp/src\/util\/system\.cpp/g' test/lint/lint-format-strings.py test/lint/lint-locale-dependence.sh sed -i 's/src\/utilmoneystr\.cpp/src\/util\/moneystr\.cpp/g' test/lint/lint-locale-dependence.sh sed -i 's/src\/utilstrencodings\.\(h\|cpp\)/src\/util\/strencodings\.\1/g' test/lint/lint-locale-dependence.sh sed -i 's/src\\utilstrencodings\.cpp/src\\util\\strencodings\.cpp/' build_msvc/libbitcoinconsensus/libbitcoinconsensus.vcxproj -END VERIFY SCRIPT-
2018-10-22 15:51:11 -07:00
util/moneystr.h \
Move AdditionOverflow to util, Add CheckedAdd with unit tests
2021-11-02 09:48:10 +01:00
util/overflow.h \
refactor: Make CWalletTx sync state type-safe Current CWalletTx state representation makes it possible to set inconsistent states that won't be handled correctly by wallet sync code or serialized & deserialized back into the same form. For example, it is possible to call setConflicted without setting a conflicting block hash, or setConfirmed with no transaction index. And it's possible update individual m_confirm and fInMempool data fields without setting an overall consistent state that can be serialized and handled correctly. Fix this without changing behavior by using std::variant, instead of an enum and collection of fields, to represent sync state, so state tracking code is safer and more legible. This is a first step to fixing state tracking bugs https://github.com/bitcoin-core/bitcoin-devwiki/wiki/Wallet-Transaction-Conflict-Tracking, by adding an extra margin of safety that can prevent new bugs from being introduced as existing bugs are fixed.
2021-02-16 22:36:26 -05:00
util/overloaded.h \
[build] Add several util units Adds the following util units and adds them to libbitcoin_util: - `util/url.cpp` takes `urlDecode` from `httpserver.cpp` - `util/error.cpp` takes `TransactionErrorString` from `node/transaction.cpp` and `AmountHighWarn` and `AmountErrMsg` from `ui_interface.cpp` - `util/fees.cpp` takes `StringForFeeReason` and `FeeModeFromString` from `policy/fees.cpp` - `util/rbf.cpp` takes `SignalsOptInRBF` from `policy/rbf.cpp` - 'util/validation.cpp` takes `FormatStateMessage` and `strMessageMagic` from 'validation.cpp`
2019-04-02 17:03:37 -04:00
util/rbf.h \
util: extract {Read,Write}BinaryFile() to its own files Extract `ReadBinaryFile()` and `WriteBinaryFile()` from `torcontrol.cpp` to its own `readwritefile.{h,cpp}` files, so that it can be reused from other modules.
2020-11-18 17:13:27 +01:00
util/readwritefile.h \
Introduce generic 'Result' class Useful to encapsulate the function result object (in case of having it) or, in case of failure, the failure reason. This let us clean lot of boilerplate code, as now instead of returning a boolean and having to add a ref arg for the return object and another ref for the error string. We can simply return a 'BResult<Obj>'. Example of what we currently have: ``` bool doSomething(arg1, arg2, arg3, arg4, &result, &error_string) { do something... if (error) { error_string = "something bad happened"; return false; } result = goodResult; return true; } ``` Example of what we will get with this commit: ``` BResult<Obj> doSomething(arg1, arg2, arg3, arg4) { do something... if (error) return {"something happened"}; // good return {goodResult}; } ``` This allows a similar boilerplate cleanup on the function callers side as well. They don't have to add the extra pre-function-call error string and result object declarations to pass the references to the function.
2022-04-08 16:24:46 -03:00
util/result.h \
Add platform-independent float encoder/decoder
2021-05-16 17:23:17 -07:00
util/serfloat.h \
Add util::Settings struct and helper functions. Implement merging of settings from different sources (command line and config file) separately from parsing code in system.cpp, so it is easier to add new sources. Document current inconsistent merging behavior without changing it. This commit only adds new settings code without using it. The next commit calls the new code to replace existing code in system.cpp. Co-authored-by: John Newbery <john@johnnewbery.com>
2019-03-05 16:07:48 -05:00
util/settings.h \
net: move CloseSocket() from netbase to util/sock Move `CloseSocket()` (and `NetworkErrorString()` which it uses) from `netbase.{h,cpp}` to newly added `src/util/sock.{h,cpp}`. This is necessary in order to use `CloseSocket()` from a newly introduced Sock class (which will live in `src/util/sock.{h,cpp}`). `sock.{h,cpp}` cannot depend on netbase because netbase will depend on it.
2021-01-04 13:02:43 +01:00
util/sock.h \
build: Sort Makefile.am after renaming file
2020-06-19 18:15:22 -04:00
util/spanparsing.h \
util: Add Join helper to join a list of strings
2019-08-20 14:51:43 -04:00
util/string.h \
Add syscall sandboxing (seccomp-bpf)
2021-10-01 13:53:59 +00:00
util/syscall_sandbox.h \
util: Replace non-threadsafe strerror Some uses of non-threadsafe `strerror` have snuck into the code since they were removed in #4152. Add a wrapper `SysErrorString` for thread-safe strerror alternatives and replace all uses of `strerror` with this.
2022-04-20 16:17:19 +02:00
util/syserror.h \
build: Sort Makefile.am after renaming file
2020-06-19 18:15:22 -04:00
util/system.h \
refactor: Make TraceThread a non-template free function Also it is moved into its own module.
2021-04-13 20:44:46 +03:00
util/thread.h \
threads: introduce util/threadnames, refactor thread naming This work is prerequisite to attaching thread names to log lines and deadlock debug utilities. This code allows setting of an "internal" threadname per thread on platforms where thread_local is available. This commit also moves RenameThread() out of a more general module and adds a numeric suffix to disambiguate between threads with the same name. It explicitly names a few main threads using the new util::ThreadRename().
2018-06-13 14:50:59 -04:00
util/threadnames.h \
scripted-diff: Move util files to separate directory. -BEGIN VERIFY SCRIPT- mkdir -p src/util git mv src/util.h src/util/system.h git mv src/util.cpp src/util/system.cpp git mv src/utilmemory.h src/util/memory.h git mv src/utilmoneystr.h src/util/moneystr.h git mv src/utilmoneystr.cpp src/util/moneystr.cpp git mv src/utilstrencodings.h src/util/strencodings.h git mv src/utilstrencodings.cpp src/util/strencodings.cpp git mv src/utiltime.h src/util/time.h git mv src/utiltime.cpp src/util/time.cpp sed -i 's/<util\.h>/<util\/system\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilmemory\.h>/<util\/memory\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilmoneystr\.h>/<util\/moneystr\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilstrencodings\.h>/<util\/strencodings\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utiltime\.h>/<util\/time\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/BITCOIN_UTIL_H/BITCOIN_UTIL_SYSTEM_H/g' src/util/system.h sed -i 's/BITCOIN_UTILMEMORY_H/BITCOIN_UTIL_MEMORY_H/g' src/util/memory.h sed -i 's/BITCOIN_UTILMONEYSTR_H/BITCOIN_UTIL_MONEYSTR_H/g' src/util/moneystr.h sed -i 's/BITCOIN_UTILSTRENCODINGS_H/BITCOIN_UTIL_STRENCODINGS_H/g' src/util/strencodings.h sed -i 's/BITCOIN_UTILTIME_H/BITCOIN_UTIL_TIME_H/g' src/util/time.h sed -i 's/ util\.\(h\|cpp\)/ util\/system\.\1/g' src/Makefile.am sed -i 's/utilmemory\.\(h\|cpp\)/util\/memory\.\1/g' src/Makefile.am sed -i 's/utilmoneystr\.\(h\|cpp\)/util\/moneystr\.\1/g' src/Makefile.am sed -i 's/utilstrencodings\.\(h\|cpp\)/util\/strencodings\.\1/g' src/Makefile.am sed -i 's/utiltime\.\(h\|cpp\)/util\/time\.\1/g' src/Makefile.am sed -i 's/-> util ->/-> util\/system ->/' test/lint/lint-circular-dependencies.sh sed -i 's/src\/util\.cpp/src\/util\/system\.cpp/g' test/lint/lint-format-strings.py test/lint/lint-locale-dependence.sh sed -i 's/src\/utilmoneystr\.cpp/src\/util\/moneystr\.cpp/g' test/lint/lint-locale-dependence.sh sed -i 's/src\/utilstrencodings\.\(h\|cpp\)/src\/util\/strencodings\.\1/g' test/lint/lint-locale-dependence.sh sed -i 's/src\\utilstrencodings\.cpp/src\\util\\strencodings\.cpp/' build_msvc/libbitcoinconsensus/libbitcoinconsensus.vcxproj -END VERIFY SCRIPT-
2018-10-22 15:51:11 -07:00
util/time.h \
util: Add RAII TokenPipe
2021-01-26 19:36:41 +01:00
util/tokenpipe.h \
tracing: add tracing framework Signed-off-by: William Casarin <jb55@jb55.com>
2020-05-20 13:35:27 -07:00
util/trace.h \
Refactor out translation.h This is a prerequisite for introducing bilingual error messages. Note: #includes are arranged by clang-format-diff.py script.
2019-06-17 10:56:52 +03:00
util/translation.h \
Add util/types.h with ALWAYS_FALSE template
2021-05-31 15:59:24 +02:00
util/types.h \
wallet: Do not include server symbols ui_interface is in libbitcoin_server and can not be included in the wallet because the wallet does not link with server symbols.
2020-06-19 18:07:18 -04:00
util/ui_change_type.h \
[build] Add several util units Adds the following util units and adds them to libbitcoin_util: - `util/url.cpp` takes `urlDecode` from `httpserver.cpp` - `util/error.cpp` takes `TransactionErrorString` from `node/transaction.cpp` and `AmountHighWarn` and `AmountErrMsg` from `ui_interface.cpp` - `util/fees.cpp` takes `StringForFeeReason` and `FeeModeFromString` from `policy/fees.cpp` - `util/rbf.cpp` takes `SignalsOptInRBF` from `policy/rbf.cpp` - 'util/validation.cpp` takes `FormatStateMessage` and `strMessageMagic` from 'validation.cpp`
2019-04-02 17:03:37 -04:00
util/url.h \
Add some general std::vector utility functions Added are: * Vector(arg1,arg2,arg3,...) constructs a vector with the specified arguments as elements. The vector's type is derived from the arguments. If some of the arguments are rvalue references, they will be moved into place rather than copied (which can't be achieved using list initialization). * Cat(vector1,vector2) returns a concatenation of the two vectors, efficiently moving elements when relevant. Vector generalizes (and replaces) the Singleton function in src/descriptor.cpp, and Cat replaces the Cat function in bech32.cpp
2019-08-28 15:12:51 -07:00
util/vector.h \
Rename the remaining main.{h,cpp} to validation.{h,cpp}
2016-12-01 16:06:41 -08:00
validation.h \
Includes: Refactor: Move CValidationInterface and CMainSignals out of main
2015-02-05 01:11:44 +01:00
validationinterface.h \
BIP9 Implementation Inspired by former implementations by Eric Lombrozo and Rusty Russell, and based on code by Jorge Timon.
2016-02-15 05:13:27 +01:00
versionbits.h \
walletdb: Move BDB specific things into bdb.{cpp/h} Leave wallet/db.{cpp/h} for generic WalletDatabase stuff. The BDB specific stuff goes into bdb.{cpp/h}
2020-06-15 14:29:29 -04:00
wallet/bdb.h \
moveonly: move `coincontrol` to `src/wallet`
2016-10-21 11:47:10 +02:00
wallet/coincontrol.h \
build: Sort Makefile.am after renaming file
2020-06-19 18:15:22 -04:00
wallet/coinselection.h \
Remove g_rpc_chain global Replace with RPC request reference to new WalletContext struct similar to the existing NodeContext struct and reference. This PR is a followup to 25ad2c623af30056ffb36dcd203a52edda2b170f https://github.com/bitcoin/bitcoin/pull/18740 removing the g_rpc_node global. Some later PRs will follow this up and move more wallet globals to the WalletContext struct. Co-authored-by: João Barbosa <joao.paulo.barbosa@gmail.com>
2020-05-28 02:13:19 -04:00
wallet/context.h \
wallet: move crypter to wallet
2015-03-22 15:18:55 -04:00
wallet/crypter.h \
Alphabetic order in makefile
2015-05-13 18:59:50 +02:00
wallet/db.h \
wallettool: Add dump command Adds a new dump command to bitcoin-wallet which prints out all of the wallet's records in hex.
2020-06-01 16:31:25 -04:00
wallet/dump.h \
wallet: add ExternalSignerScriptPubKeyMan
2020-02-19 16:40:00 +01:00
wallet/external_signer_scriptpubkeyman.h \
Refactor Bumpfee core functionality
2017-03-03 16:15:47 +01:00
wallet/feebumper.h \
Move some static functions out of wallet.h/cpp This commit just moves a few function declarations and updates callers. Function bodies are moved in two followup MOVEONLY commits. This change is desirable because wallet.h/cpp are monolithic and hard to navigate, so pulling things out and grouping together pieces of related functionality should improve the organization. Another proximate motivation is the wallet process separation work in https://github.com/bitcoin/bitcoin/pull/10973, where (at least initially) parameter parsing and fee estimation are still done in the main process rather than the wallet process, and having functions that run in different processes scrambled up throughout wallet.cpp is unnecessarily confusing.
2017-08-02 07:19:28 -04:00
wallet/fees.h \
Move ismine to wallet module
2019-06-06 09:53:16 +02:00
wallet/ismine.h \
[build] Move wallet load functions to wallet/load unit Moves the following wallet load functions to a new wallet/load unit in the libbitcoin_wallet library. All other functions in wallet/init remain in libbitcoin_server: - `VerifyWallets` - `LoadWallets` - `StartWallets` - `FlushWallets` - `StopWallets` - `UnloadWallets`
2019-04-02 17:11:26 -04:00
wallet/load.h \
MOVEONLY: CWallet transaction code out of wallet.cpp/.h This commit just moves functions without making any changes. It can be reviewed with `git log -p -n1 --color-moved=dimmed_zebra` Motivation for this change is to make wallet.cpp/h less monolithic and start to make wallet transaction state tracking comprehensible so bugs in https://github.com/bitcoin-core/bitcoin-devwiki/wiki/Wallet-Transaction-Conflict-Tracking can be fixed safely without introducing new problems. This commit moves wallet classes and methods that deal with transactions out of wallet.cpp/.h into better organized files: - transaction.cpp/.h - CWalletTx and CMerkleTx class definitions - receive.cpp/.h - functions checking received transactions and computing balances - spend.cpp/.h - functions creating transactions and finding spendable coins After #20773, when loading is separated from syncing it will also be possible to move more wallet.cpp/.h functions to: - sync.cpp/.h - functions handling chain notifications and rescanning This commit arranges receive.cpp and spend.cpp functions in dependency order so it's possible to skim receive.cpp and get an idea of how computing balances works, and skim spend.cpp and get an idea of how transactions are created, without having to jump all over wallet.cpp where functions are not in order and there is a lot of unrelated code. Followup commit "refactor: Detach wallet transaction methods" in https://github.com/bitcoin/bitcoin/pull/21206 follows up this PR and tweaks function names and arguments to reflect new locations. The two commits are split into separate PRs because this commit is more work to maintain and less work to review, while the other commit is less work to maintain and more work to review, so hopefully this commit can be merged earlier.
2021-02-10 16:06:01 -05:00
wallet/receive.h \
Introduce wallet/rpc/util
2021-12-01 13:10:43 +13:00
wallet/rpc/util.h \
MOVEONLY: Move rpcwallet to rpc/wallet
2021-12-01 16:43:31 +13:00
wallet/rpc/wallet.h \
Move RecoverDatabaseFile and RecoverKeysOnlyFilter into salvage.{cpp/h}
2020-05-15 19:37:55 -04:00
wallet/salvage.h \
MOVEONLY: Move key handling code out of wallet to keyman file Start moving wallet and ismine code to scriptpubkeyman.h, scriptpubkeyman.cpp The easiest way to review this commit is to run: git log -p -n1 --color-moved=dimmed_zebra And check that everything is a move (other than includes and copyrights comments). This commit is move-only and doesn't change code or affect behavior.
2019-10-07 14:11:34 -04:00
wallet/scriptpubkeyman.h \
MOVEONLY: CWallet transaction code out of wallet.cpp/.h This commit just moves functions without making any changes. It can be reviewed with `git log -p -n1 --color-moved=dimmed_zebra` Motivation for this change is to make wallet.cpp/h less monolithic and start to make wallet transaction state tracking comprehensible so bugs in https://github.com/bitcoin-core/bitcoin-devwiki/wiki/Wallet-Transaction-Conflict-Tracking can be fixed safely without introducing new problems. This commit moves wallet classes and methods that deal with transactions out of wallet.cpp/.h into better organized files: - transaction.cpp/.h - CWalletTx and CMerkleTx class definitions - receive.cpp/.h - functions checking received transactions and computing balances - spend.cpp/.h - functions creating transactions and finding spendable coins After #20773, when loading is separated from syncing it will also be possible to move more wallet.cpp/.h functions to: - sync.cpp/.h - functions handling chain notifications and rescanning This commit arranges receive.cpp and spend.cpp functions in dependency order so it's possible to skim receive.cpp and get an idea of how computing balances works, and skim spend.cpp and get an idea of how transactions are created, without having to jump all over wallet.cpp where functions are not in order and there is a lot of unrelated code. Followup commit "refactor: Detach wallet transaction methods" in https://github.com/bitcoin/bitcoin/pull/21206 follows up this PR and tweaks function names and arguments to reflect new locations. The two commits are split into separate PRs because this commit is more work to maintain and less work to review, while the other commit is less work to maintain and more work to review, so hopefully this commit can be merged earlier.
2021-02-10 16:06:01 -05:00
wallet/spend.h \
Add SQLiteDatabase and SQLiteBatch dummy classes
2020-05-26 20:53:01 -04:00
wallet/sqlite.h \
MOVEONLY: CWallet transaction code out of wallet.cpp/.h This commit just moves functions without making any changes. It can be reviewed with `git log -p -n1 --color-moved=dimmed_zebra` Motivation for this change is to make wallet.cpp/h less monolithic and start to make wallet transaction state tracking comprehensible so bugs in https://github.com/bitcoin-core/bitcoin-devwiki/wiki/Wallet-Transaction-Conflict-Tracking can be fixed safely without introducing new problems. This commit moves wallet classes and methods that deal with transactions out of wallet.cpp/.h into better organized files: - transaction.cpp/.h - CWalletTx and CMerkleTx class definitions - receive.cpp/.h - functions checking received transactions and computing balances - spend.cpp/.h - functions creating transactions and finding spendable coins After #20773, when loading is separated from syncing it will also be possible to move more wallet.cpp/.h functions to: - sync.cpp/.h - functions handling chain notifications and rescanning This commit arranges receive.cpp and spend.cpp functions in dependency order so it's possible to skim receive.cpp and get an idea of how computing balances works, and skim spend.cpp and get an idea of how transactions are created, without having to jump all over wallet.cpp where functions are not in order and there is a lot of unrelated code. Followup commit "refactor: Detach wallet transaction methods" in https://github.com/bitcoin/bitcoin/pull/21206 follows up this PR and tweaks function names and arguments to reflect new locations. The two commits are split into separate PRs because this commit is more work to maintain and less work to review, while the other commit is less work to maintain and more work to review, so hopefully this commit can be merged earlier.
2021-02-10 16:06:01 -05:00
wallet/transaction.h \
[Move Only] Move wallet related things to src/wallet/ could once be renamed from /src/wallet to /src/legacywallet.
2015-02-03 21:09:47 +01:00
wallet/wallet.h \
Add ZeroMQ support. Notify blocks and transactions via ZeroMQ Continues Johnathan Corgan's work. Publishing multipart messages Bugfix: Add missing zmq header includes Bugfix: Adjust build system to link ZeroMQ code for Qt binaries
2014-11-18 12:06:32 -05:00
wallet/walletdb.h \
[tools] Add wallet inspection and modification tool This commit adds wallet-tool, a tool for creating and interacting with wallet files. Original implementation was by Jonas Schnelli <dev@jonasschnelli.ch> with modifications by John Newbery <john@johnnewbery.com> MSVC files were provided by Chun Kuan Lee <ken2812221@gmail.com>: build: Add MSVC project files for bitcoin-wallet-tool
2016-09-16 16:45:36 +02:00
wallet/wallettool.h \
Add -walletdir parameter to specify custom wallet dir
2017-10-09 09:48:07 +13:00
wallet/walletutil.h \
build: Sort Makefile.am after renaming file
2020-06-19 18:15:22 -04:00
walletinitinterface.h \
Move GetWarnings() into its own file.
2016-11-30 06:07:42 +00:00
warnings.h \
Add ZeroMQ support. Notify blocks and transactions via ZeroMQ Continues Johnathan Corgan's work. Publishing multipart messages Bugfix: Add missing zmq header includes Bugfix: Adjust build system to link ZeroMQ code for Qt binaries
2014-11-18 12:06:32 -05:00
zmq/zmqabstractnotifier.h \
zmq/zmqnotificationinterface.h \
RPC: Add new getzmqnotifications method. This adds a new RPC method "getzmqnotifications", which returns information about all active ZMQ notification endpoints. This is useful for software that layers on top of bitcoind, so it can verify that ZeroMQ is enabled and also figure out where it should listen. See https://github.com/bitcoin/bitcoin/issues/13526.
2018-06-29 16:10:01 +02:00
zmq/zmqpublishnotifier.h \
Replace zmqconfig.h by a simple zmqutil. zmqconfig.h is currently not really needed anywhere, except that it declares zmqError (which is then defined in zmqnotificationinterface.cpp). Note in particular that there is no need to conditionally include zmq.h only if ZMQ is enabled, because the place in the core code where the ZMQ library itself is included (init.cpp) is conditional already on that. This commit removes zmqconfig.h and replaces it by a much simpler zmqutil.h library for zmqError. The definition of the function is moved to the matching (newly created) zmqutil.cpp.
2018-07-17 12:51:23 +02:00
zmq/zmqrpc.h \
zmq/zmqutil.h
Add ZeroMQ support. Notify blocks and transactions via ZeroMQ Continues Johnathan Corgan's work. Publishing multipart messages Bugfix: Add missing zmq header includes Bugfix: Adjust build system to link ZeroMQ code for Qt binaries
2014-11-18 12:06:32 -05:00
makefile.am: split long lines into one file per line This makes it easier to read diffs. Cosmetic change to build system only.
2014-01-11 15:22:07 +01:00
autotools: switch to autotools buildsystem
2013-05-27 19:55:01 -04:00
obj/build.h: FORCE
build: avoid the use of top_ and abs_ dir paths Using them has the side effect of confusing the dependency-tracking logic.
2014-06-05 14:22:54 -04:00
@$(MKDIR_P) $(builddir)/obj
fix build if spaces in src dir path
2017-03-23 10:54:18 -07:00
@$(top_srcdir)/share/genbuild.sh "$(abs_top_builddir)/src/obj/build.h" \
"$(abs_top_srcdir)"
Separate protocol versioning from clientversion
2014-10-28 21:33:23 -04:00
libbitcoin_util_a-clientversion.$(OBJEXT): obj/build.h
autotools: switch to autotools buildsystem
2013-05-27 19:55:01 -04:00
multiprocess: Add Ipc interface implementation
2017-12-05 15:57:12 -05:00
Remove unnecessary dependencies for bitcoin-cli This commit removes all the unnecessary dependencies (key, core, netbase, sync, ...) from bitcoin-cli. To do this it shards the chain parameters into BaseParams, which contains just the RPC port and data directory (as used by utils and bitcoin-cli) and Params, with the rest.
2014-06-19 15:10:04 +02:00
# server: shared between bitcoind and bitcoin-qt
[docs] Document src subdirectories and different libraries
2019-04-02 17:14:35 -04:00
# Contains code accessing mempool and chain state that is meant to be separated
# from wallet and gui code (see node/README.md). Shared code should go in
# libbitcoin_common or libbitcoin_util libraries, instead.
scripted-diff: Rename libbitcoin_server.a to libbitcoin_node.a Goal along with namespacing PR #23497 is to have src/node/ code in node:: namespace in libbitcoin_node.a library -BEGIN VERIFY SCRIPT- bash -c ' # Bash shell needed for brace expansion {a,b} git mv build_msvc/libbitcoin_{server,node} git mv build_msvc/libbitcoin_node/libbitcoin_{server,node}.vcxproj.in ren() { git grep -l "$1" src build_msvc | xargs sed -i "s/$1/$2/g"; } ren LIBBITCOIN_{SERVER,NODE} ren libbitcoin_{server,node} ' -END VERIFY SCRIPT-
2021-12-20 10:53:01 -05:00
libbitcoin_node_a_CPPFLAGS = $(AM_CPPFLAGS) $(BITCOIN_INCLUDES) $(MINIUPNPC_CPPFLAGS) $(NATPMP_CPPFLAGS) $(EVENT_CFLAGS) $(EVENT_PTHREADS_CFLAGS)
libbitcoin_node_a_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS)
libbitcoin_node_a_SOURCES = \
net: move CBanDB and CAddrDB out of net.h/cpp This will eventually solve a circular dependency
2016-04-16 00:13:15 -04:00
addrdb.cpp \
[Makefile] Alphabetically Reorder addrdb.cpp To keep conformity.
2017-04-30 13:25:39 +02:00
addrman.cpp \
net: move BanMan to its own files
2017-10-05 16:40:43 -04:00
banman.cpp \
Add partial-block block encodings API
2016-04-15 12:23:57 -07:00
blockencodings.cpp \
blockfilter: Implement GCSFilter constructors.
2018-01-23 16:25:21 -08:00
blockfilter.cpp \
Move CBlockIndex, CChain and related code out of main
2014-09-03 02:20:09 +02:00
chain.cpp \
MOVEONLY: tx functions to consensus/tx_verify.o Functions related to transaction verification.
2016-07-11 16:34:21 +02:00
consensus/tx_verify.cpp \
build: Sort Makefile.am after renaming file
2020-06-19 18:15:22 -04:00
dbwrapper.cpp \
[refactor] Add versionbits deployments to deploymentstatus.h Adds support for versionbits deployments to DeploymentEnabled, DeploymentActiveAfter and DeploymentActiveAt. Also moves versionbitscache from validation to deploymentstatus.
2020-07-03 04:01:23 +10:00
deploymentstatus.cpp \
validation: Extract basic block file logic into FlatFileSeq class.
2019-01-06 11:06:31 -08:00
flatfile.cpp \
evhttpd implementation - *Replace usage of boost::asio with [libevent2](http://libevent.org/)*. boost::asio is not part of C++11, so unlike other boost there is no forwards-compatibility reason to stick with it. Together with #4738 (convert json_spirit to UniValue), this rids Bitcoin Core of the worst offenders with regard to compile-time slowness. - *Replace spit-and-duct-tape http server with evhttp*. Front-end http handling is handled by libevent, a work queue (with configurable depth and parallelism) is used to handle application requests. - *Wrap HTTP request in C++ class*; this makes the application code mostly HTTP-server-neutral - *Refactor RPC to move all http-specific code to a separate file*. Theoreticaly this can allow building without HTTP server but with another RPC backend, e.g. Qt's debug console (currently not implemented) or future RPC mechanisms people may want to use. - *HTTP dispatch mechanism*; services (e.g., RPC, REST) register which URL paths they want to handle. By using a proven, high-performance asynchronous networking library (also used by Tor) and HTTP server, problems such as #5674, #5655, #344 should be avoided. What works? bitcoind, bitcoin-cli, bitcoin-qt. Unit tests and RPC/REST tests pass. The aim for now is everything but SSL support. Configuration options: - `-rpcthreads`: repurposed as "number of work handler threads". Still defaults to 4. - `-rpcworkqueue`: maximum depth of work queue. When this is reached, new requests will return a 500 Internal Error. - `-rpctimeout`: inactivity time, in seconds, after which to disconnect a client. - `-debug=http`: low-level http activity logging
2015-01-23 07:53:17 +01:00
httprpc.cpp \
httpserver.cpp \
net: implement the necessary parts of the I2P SAM protocol Implement the following commands from the I2P SAM protocol: * HELLO: needed for all of the remaining ones * DEST GENERATE: to generate our private key and destination * NAMING LOOKUP: to convert .i2p addresses to destinations * SESSION CREATE: needed for STREAM CONNECT and STREAM ACCEPT * STREAM CONNECT: to make outgoing connections * STREAM ACCEPT: to accept incoming connections
2020-11-27 13:59:26 +01:00
i2p.cpp \
MOVEONLY: Move BaseIndex to its own file.
2018-05-15 15:57:48 -07:00
index/base.cpp \
index: Implement block filter index with write operations.
2018-08-27 17:01:24 -07:00
index/blockfilterindex.cpp \
index: Add Coinstats index The index holds the values previously calculated in coinstats.cpp for each block, representing the state of the UTXO set at each height.
2020-01-24 18:56:47 +01:00
index/coinstatsindex.cpp \
[index] Create new TxIndex class. The TxIndex will be responsible for building the transaction index concurrently with the main validation thread by implementing ValidationInterface. This does not process blocks concurrently yet.
2017-12-08 10:19:57 -08:00
index/txindex.cpp \
build: Sort Makefile.am after renaming file
2020-06-19 18:15:22 -04:00
init.cpp \
Move init::SanityCheck to kernel::SanityCheck
2022-05-27 16:47:05 -04:00
kernel/checks.cpp \
coinstats: Move hasher codepath to kernel/coinstats As mentioned in a previous commit, the hashing codepath can now be moved to a separate file. This decouples callers that only rely on the hashing codepath from the indexing one. This is key for libbitcoinkernel, which needs to have the CoinsStats hashing codepath for AssumeUTXO, but does not wish to be coupled with indexes. Note that only the .cpp file is split in this commit, the header files will be split in a subsequent commit and the #includes to node/coinstats.h will be adjusted to only #include the necessary headers.
2022-02-16 15:31:02 -05:00
kernel/coinstats.cpp \
init: Initialize globals with kernel::Context's life ...instead of explicitly calling init::{Set,Unset}Globals. Cool thing about this is that in both the testing and bitcoin-chainstate codepaths, we no longer need to explicitly unset globals. The kernel::Context goes out of scope and the globals are unset "automatically". Also construct kernel::Context outside of AppInitSanityChecks()
2022-05-25 14:31:54 -04:00
kernel/context.cpp \
refactor: Move port mapping code to its own module This commit does not change behavior.
2020-02-06 19:00:26 +02:00
mapport.cpp \
pool: Add and use MemPoolOptions, ApplyArgsManOptions Reviewers: Note that CTxMemPool now requires a non-defaulted CTxMemPool::Options for its constructor. Meaning that there's no need to worry about a stray CTxMemPool constructor somewhere defaulting to something incorrect. All instances of CTxMemPool construction are addressed here in this commit. We set options for CTxMemPool and construct it in many different ways. A good example can be seen in how we determine CTxMemPool's check_ratio in AppInitMain(...). 1. We first set the default based on chainparams's DefaultConsistencyChecks() 2. Then, we apply the ArgsManager option on top of that default 3. Finally, we clamp the result of that between 0 and 1 Million With this patch, most CTxMemPool construction are along the lines of: MemPoolOptions mempool_opts{...default overrides...}; ApplyArgsManOptions(argsman, mempool_opts); ...hard overrides... CTxMemPool pool{mempool_opts}; This "compositional" style of building options means that we can omit unnecessary/irrelevant steps wherever we want but also maintain full customizability. For example: - For users of libbitcoinkernel, where we eventually want to remove ArgsManager, they simply won't call (or even know about) ApplyArgsManOptions. - See src/init.cpp to see how the check_ratio CTxMemPool option works after this change. A MemPoolOptionsForTest helper was also added and used by tests/fuzz tests where a local CTxMemPool needed to be created. The change in src/test/fuzz/tx_pool.cpp seemingly changes behaviour by applying ArgsManager options on top of the CTxMemPool::Options defaults. However, in future commits where we introduce flags like -maxmempool, the call to ApplyArgsManOptions is actually what preserves the existing behaviour. Previously, although it wasn't obvious, our CTxMemPool would consult gArgs for flags like -maxmempool when it needed it, so it already relied on ArgsManager information. This patchset just laid bare the obfuscatory perils of globals. [META] As this patchset progresses, we will move more and more CTxMemPool-relevant options into MemPoolOptions and add their ArgsMan-related logic to ApplyArgsManOptions.
2022-03-18 13:51:37 -04:00
mempool_args.cpp \
Add --disable-wallet option to build system Make it possible to build Bitcoin without wallet (and thus without BDB) so that it only functions as node.
2013-11-29 16:50:11 +01:00
net.cpp \
[build] Add netgroup.cpp|h These aren't used yet.
2021-08-31 13:22:36 +01:00
netgroup.cpp \
Move network-msg-processing code out of main to its own file
2016-12-01 15:45:50 -08:00
net_processing.cpp \
move-only: Move ThreadImport to blockstorage Can be reviewed with the git options --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space
2021-04-02 19:17:00 +02:00
node/blockstorage.cpp \
node/caches: Extract cache calculation logic I strongly recommend reviewing with the following git-diff flags: --color-moved=dimmed_zebra --color-moved-ws=allow-indentation-change [META] In a future commit, this function will be re-used in TestingSetup so that the behaviour matches across test and non-test init codepaths.
2021-09-21 11:37:03 -04:00
node/caches.cpp \
node: Extract chainstate loading sequence I strongly recommend reviewing with the following git-diff flags: --color-moved=dimmed_zebra --color-moved-ws=allow-indentation-change [META] This commit is intended to be as close to a move-only commit as possible, and lingering ugliness will be resolved in subsequent commits. A few variables that are passed in by value instead of by reference deserve explanation: - fReset and fReindexChainstate are both local variables in AppInitMain and are not modified in the sequence - fPruneMode, despite being a global, is only modified in AppInitParameterInteraction, long before LoadChainstate is called ---- [META] This semantic will change in a future commit named "node/chainstate: Decouple from stringy errors"
2021-09-20 16:12:18 -04:00
node/chainstate.cpp \
Remove use of CCoinsViewMemPool::GetCoin in wallet code This commit does not change behavior.
2018-07-17 13:04:35 -04:00
node/coin.cpp \
[net] Move ConnectionType to its own file
2021-12-01 19:11:37 +00:00
node/connection_types.cpp \
Pass NodeContext, ConnMan, BanMan references more places So g_connman and g_banman globals can be removed next commit.
2019-09-17 18:28:03 -04:00
node/context.cpp \
[net] Move eviction logic to its own file
2022-05-26 16:07:04 +02:00
node/eviction.cpp \
Move NodeImpl from interfaces/node.cpp to node/interfaces.cpp
2020-11-24 10:13:23 -05:00
node/interfaces.cpp \
style: Sort file list after rename
2021-11-15 13:48:58 +01:00
node/miner.cpp \
Sort file list after rename
2021-11-12 10:59:36 +01:00
node/minisketchwrapper.cpp \
[build] Move AnalyzePSBT from psbt.cpp to node/psbt.cpp psbt.cpp definitions except for AnalyzePSBT are used by the wallet and need to be linked into the wallet binary. AnalyzePSBT is an exception in that it is not used by the wallet, and depends on node classes like CCoinsViewCache, and on node global variables like nBytesPerSigOp. So AnalyzePSBT is more at home in libbitcoin_server than libbitcoin_common, and in any case needs to be defined in a separate object file than other PSBT utilities, to avoid dragging link dependencies on node functions and global variables into the wallet.
2019-04-08 16:33:05 -04:00
node/psbt.cpp \
Factor BroadcastTransaction out of sendrawtransaction Factor out a new BroadcastTransaction function, performing the core work of the sendrawtransaction rpc, so that it can be used from the GUI code. Move it from src/rpc/ to src/node/.
2019-01-08 22:16:50 -08:00
node/transaction.cpp \
scripted-diff: Avoid incompatibility with CMake AUTOUIC feature -BEGIN VERIFY SCRIPT- sed -i "s|node/ui_interface|node/interface_ui|g" $(git grep -l "node/ui_interface" ./src) git mv src/node/ui_interface.cpp src/node/interface_ui.cpp git mv src/node/ui_interface.h src/node/interface_ui.h sed -i "s|BITCOIN_NODE_UI_INTERFACE_H|BITCOIN_NODE_INTERFACE_UI_H|g" src/node/interface_ui.h -END VERIFY SCRIPT-
2022-06-14 10:38:51 +02:00
node/interface_ui.cpp \
Add --disable-wallet option to build system Make it possible to build Bitcoin without wallet (and thus without BDB) so that it only functions as node.
2013-11-29 16:50:11 +01:00
noui.cpp \
Create new BlockPolicyEstimator for fee estimates This class groups transactions that have been confirmed in blocks into buckets, based on either their fee or their priority. Then for each bucket, the class calculates what percentage of the transactions were confirmed within various numbers of blocks. It does this by keeping an exponentially decaying moving history for each bucket and confirm block count of the percentage of transactions in that bucket that were confirmed within that number of blocks. -Eliminate txs which didn't have all inputs available at entry from fee/pri calcs -Add dynamic breakpoints and tracking of confirmation delays in mempool transactions -Remove old CMinerPolicyEstimator and CBlockAverage code -New smartfees.py -Pass a flag to the estimation code, using IsInitialBlockDownload as a proxy for when we are still catching up and we shouldn't be counting how many blocks it takes for transactions to be included. -Add a policyestimator unit test
2014-08-26 16:28:32 -04:00
policy/fees.cpp \
fees: Pass in a filepath instead of referencing gArgs
2021-12-08 16:19:31 -05:00
policy/fees_args.cpp \
MOVEONLY: context-free package policies Co-authored-by: ariard <antoine.riard@gmail.com>
2021-06-02 16:19:29 +01:00
policy/packages.cpp \
RPC/rawtransaction: createrawtransaction: Check opt_into_rbf when provided with either value
2017-02-03 19:23:22 +00:00
policy/rbf.cpp \
[build] Move policy settings to new src/policy/settings unit This moves the following policy settings functions and globals to a new src/policy/settings unit in lib_server: - `incrementalRelayFee` - `dustRelayFee` - `nBytesPerSigOp` - `fIsBareMultisigStd` These settings are only required by the node and should not be accessed by other libraries.
2019-04-02 14:14:58 -04:00
policy/settings.cpp \
Refactor proof of work related functions out of main
2014-03-10 08:46:53 -07:00
pow.cpp \
Add unauthenticated HTTP REST interface to public blockchain data.
2014-11-11 04:52:43 -05:00
rest.cpp \
move rpc* to rpc/
2016-01-15 11:55:17 +11:00
rpc/blockchain.cpp \
rpc: Move fee estimation RPCs to separate file Can be reviewed with --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space
2022-04-29 15:37:25 +02:00
rpc/fees.cpp \
rpc: Move mempool RPCs to new file Can be reviewed with: --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space
2022-03-11 17:51:36 +01:00
rpc/mempool.cpp \
move rpc* to rpc/
2016-01-15 11:55:17 +11:00
rpc/mining.cpp \
scripted-diff: Rename rpc/misc.cpp to rpc/node.cpp -BEGIN VERIFY SCRIPT- git mv src/rpc/misc.cpp src/rpc/node.cpp sed -i 's@rpc/misc.cpp@rpc/node.cpp@g' $(git grep -l misc.cpp) sed -i 's,RegisterMiscRPCCommands,RegisterNodeRPCCommands,g' $(git grep -l RegisterMiscRPCCommands) -END VERIFY SCRIPT-
2022-05-03 09:05:07 +02:00
rpc/node.cpp \
move rpc* to rpc/
2016-01-15 11:55:17 +11:00
rpc/net.cpp \
rpc: Move output script RPCs to separate file Can be reviewed with --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space
2022-05-03 08:30:16 +02:00
rpc/output_script.cpp \
move rpc* to rpc/
2016-01-15 11:55:17 +11:00
rpc/rawtransaction.cpp \
rpc/server.cpp \
rpc: move Ensure* helpers to server_util.h
2021-04-21 16:39:40 +02:00
rpc/server_util.cpp \
rpc: Move signmessage RPC util to new file Can be reviewed with --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space
2022-04-28 10:30:40 +02:00
rpc/signmessage.cpp \
Move txoutproof RPCs to txoutproof.cpp
2022-03-16 12:06:15 +01:00
rpc/txoutproof.cpp \
Reduce bitcoin-tx dependencies
2014-11-06 00:24:41 -08:00
script/sigcache.cpp \
Break circular dependency: init -> * -> init by extracting shutdown.h Most includers just wanted to react to pending shutdown. This isolates access to `fRequestShutdown` and limits access to the shutdown api functions, including the new `AbortShutdown` for setting it to `false`. Note I originally called `AbortShutdown` `CancelShutdown` but that name was already taken by winuser.h https://travis-ci.org/bitcoin/bitcoin/jobs/386913329 This change also triggered a build error in bench. Fixing it required moving LIBBITCOIN_SERVER after LIBBITCOIN_WALLET in bench_bench_bitcoin_LDADD To make server definitions in src/net.cpp available to wallet methods in src/wallet/wallet.cpp. Specifically, solving: libbitcoin_wallet.a(libbitcoin_wallet_a-wallet.o): In function `CWalletTx::RelayWalletTransaction(CConnman*)': wallet.cpp:(.text+0x3f0e): undefined reference to `CConnman::NodeFullyConnected(CNode const*)' collect2: error: ld returned 1 exit status https://travis-ci.org/bitcoin/bitcoin/jobs/392133581 Need for remaining init.h includes confirmed via a thorough search with a more specific regex: \bInterrupt\(\)|\bShutdown\(\)|\bInitLogging\(\)|\bInitParameterInteraction\(\)|\bAppInitBasicSetup\(\)|\bAppInitParameterInteraction\(\)|\bAppInitSanityChecks\(\)|\bAppInitLockDataDirectory\(\)|\bAppInitMain\(\)|\bSetupServerArgs\(\)|\bLicenseInfo\(\)|g_wallet_init_interface|init.h
2018-05-16 19:17:40 +00:00
shutdown.cpp \
add signet basic support (signet.cpp) Co-authored-by: Anthony Towns <aj@erisian.com.au>
2019-07-17 17:41:32 +09:00
signet.cpp \
Move network-time related functions to timedata.cpp/h The network time-offset-mangement functions from util.cpp are moved to timedata.(cpp|h). This breaks the dependency of util on netbase.
2014-06-19 15:08:37 +02:00
timedata.cpp \
net: Automatically create hidden service, listen on Tor Starting with Tor version 0.2.7.1 it is possible, through Tor's control socket API, to create and destroy 'ephemeral' hidden services programmatically. https://stem.torproject.org/api/control.html#stem.control.Controller.create_ephemeral_hidden_service This means that if Tor is running (and proper authorization is available), bitcoin automatically creates a hidden service to listen on, without user manual configuration. This will positively affect the number of available .onion nodes. - When the node is started, connect to Tor through control socket - Send `ADD_ONION` command - First time: - Make it create a hidden service key - Save the key in the data directory for later usage - Make it redirect port 8333 to the local port 8333 (or whatever port we're listening on). - Keep control socket connection open for as long node is running. The hidden service will (by default) automatically go away when the connection is closed.
2015-08-25 20:12:08 +02:00
torcontrol.cpp \
Add --disable-wallet option to build system Make it possible to build Bitcoin without wallet (and thus without BDB) so that it only functions as node.
2013-11-29 16:50:11 +01:00
txdb.cpp \
txmempool.cpp \
move-only: Add txorphanage module This module captures orphan tracking code for tx relay. Can be reviewed with --color-moved=dimmed-zebra
2021-01-31 00:55:54 +10:00
txorphanage.cpp \
txrequest.cpp \
Rename the remaining main.{h,cpp} to validation.{h,cpp}
2016-12-01 16:06:41 -08:00
validation.cpp \
Includes: Refactor: Move CValidationInterface and CMainSignals out of main
2015-02-05 01:11:44 +01:00
validationinterface.cpp \
BIP9 Implementation Inspired by former implementations by Eric Lombrozo and Rusty Russell, and based on code by Jorge Timon.
2016-02-15 05:13:27 +01:00
versionbits.cpp \
Add --disable-wallet option to build system Make it possible to build Bitcoin without wallet (and thus without BDB) so that it only functions as node.
2013-11-29 16:50:11 +01:00
$(BITCOIN_CORE_H)
[build] Move wallet load functions to wallet/load unit Moves the following wallet load functions to a new wallet/load unit in the libbitcoin_wallet library. All other functions in wallet/init remain in libbitcoin_server: - `VerifyWallets` - `LoadWallets` - `StartWallets` - `FlushWallets` - `StopWallets` - `UnloadWallets`
2019-04-02 17:11:26 -04:00
if ENABLE_WALLET
scripted-diff: Rename libbitcoin_server.a to libbitcoin_node.a Goal along with namespacing PR #23497 is to have src/node/ code in node:: namespace in libbitcoin_node.a library -BEGIN VERIFY SCRIPT- bash -c ' # Bash shell needed for brace expansion {a,b} git mv build_msvc/libbitcoin_{server,node} git mv build_msvc/libbitcoin_node/libbitcoin_{server,node}.vcxproj.in ren() { git grep -l "$1" src build_msvc | xargs sed -i "s/$1/$2/g"; } ren LIBBITCOIN_{SERVER,NODE} ren libbitcoin_{server,node} ' -END VERIFY SCRIPT-
2021-12-20 10:53:01 -05:00
libbitcoin_node_a_SOURCES += wallet/init.cpp
build: pass bdb cppflags only where needed Move bdb cppflags out of the catch-all BITCOIN_INCLUDES, and pass them only where they are needed, which is in libbitcoin_node/wallet and the tests.
2022-05-30 10:24:00 +01:00
libbitcoin_node_a_CPPFLAGS += $(BDB_CPPFLAGS)
[build] Move wallet load functions to wallet/load unit Moves the following wallet load functions to a new wallet/load unit in the libbitcoin_wallet library. All other functions in wallet/init remain in libbitcoin_server: - `VerifyWallets` - `LoadWallets` - `StartWallets` - `FlushWallets` - `StopWallets` - `UnloadWallets`
2019-04-02 17:11:26 -04:00
endif
[build] Move dummy wallet into its own .cpp file. Removes the ifdef ENABLE_WALLET from init.cpp.
2018-09-07 12:35:42 -04:00
if !ENABLE_WALLET
scripted-diff: Rename libbitcoin_server.a to libbitcoin_node.a Goal along with namespacing PR #23497 is to have src/node/ code in node:: namespace in libbitcoin_node.a library -BEGIN VERIFY SCRIPT- bash -c ' # Bash shell needed for brace expansion {a,b} git mv build_msvc/libbitcoin_{server,node} git mv build_msvc/libbitcoin_node/libbitcoin_{server,node}.vcxproj.in ren() { git grep -l "$1" src build_msvc | xargs sed -i "s/$1/$2/g"; } ren LIBBITCOIN_{SERVER,NODE} ren libbitcoin_{server,node} ' -END VERIFY SCRIPT-
2021-12-20 10:53:01 -05:00
libbitcoin_node_a_SOURCES += dummywallet.cpp
[build] Move dummy wallet into its own .cpp file. Removes the ifdef ENABLE_WALLET from init.cpp.
2018-09-07 12:35:42 -04:00
endif
Add ZeroMQ support. Notify blocks and transactions via ZeroMQ Continues Johnathan Corgan's work. Publishing multipart messages Bugfix: Add missing zmq header includes Bugfix: Adjust build system to link ZeroMQ code for Qt binaries
2014-11-18 12:06:32 -05:00
if ENABLE_ZMQ
Specify AM_CPPFLAGS for ZMQ. When building the ZMQ static library, add AM_CPPFLAGS to the library CPPFLAGS. Otherwise, we may miss important flags that are specified elsewhere. For instance, if --enable-debug is passed and -DDEBUG_LOCKORDER set, then that would not apply to the ZMQ library before (causing potential for hard-to-find bugs).
2019-07-22 14:26:18 +02:00
libbitcoin_zmq_a_CPPFLAGS = $(AM_CPPFLAGS) $(BITCOIN_INCLUDES) $(ZMQ_CFLAGS)
build: Split hardening/fPIE options out This allows for fPIE to be used selectively.
2015-11-09 20:50:25 -05:00
libbitcoin_zmq_a_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS)
Add ZeroMQ support. Notify blocks and transactions via ZeroMQ Continues Johnathan Corgan's work. Publishing multipart messages Bugfix: Add missing zmq header includes Bugfix: Adjust build system to link ZeroMQ code for Qt binaries
2014-11-18 12:06:32 -05:00
libbitcoin_zmq_a_SOURCES = \
zmq/zmqabstractnotifier.cpp \
zmq/zmqnotificationinterface.cpp \
RPC: Add new getzmqnotifications method. This adds a new RPC method "getzmqnotifications", which returns information about all active ZMQ notification endpoints. This is useful for software that layers on top of bitcoind, so it can verify that ZeroMQ is enabled and also figure out where it should listen. See https://github.com/bitcoin/bitcoin/issues/13526.
2018-06-29 16:10:01 +02:00
zmq/zmqpublishnotifier.cpp \
Replace zmqconfig.h by a simple zmqutil. zmqconfig.h is currently not really needed anywhere, except that it declares zmqError (which is then defined in zmqnotificationinterface.cpp). Note in particular that there is no need to conditionally include zmq.h only if ZMQ is enabled, because the place in the core code where the ZMQ library itself is included (init.cpp) is conditional already on that. This commit removes zmqconfig.h and replaces it by a much simpler zmqutil.h library for zmqError. The definition of the function is moved to the matching (newly created) zmqutil.cpp.
2018-07-17 12:51:23 +02:00
zmq/zmqrpc.cpp \
zmq/zmqutil.cpp
Add ZeroMQ support. Notify blocks and transactions via ZeroMQ Continues Johnathan Corgan's work. Publishing multipart messages Bugfix: Add missing zmq header includes Bugfix: Adjust build system to link ZeroMQ code for Qt binaries
2014-11-18 12:06:32 -05:00
endif
Remove unnecessary dependencies for bitcoin-cli This commit removes all the unnecessary dependencies (key, core, netbase, sync, ...) from bitcoin-cli. To do this it shards the chain parameters into BaseParams, which contains just the RPC port and data directory (as used by utils and bitcoin-cli) and Params, with the rest.
2014-06-19 15:10:04 +02:00
# wallet: shared between bitcoind and bitcoin-qt, but only linked
# when wallet enabled
build: pass bdb cppflags only where needed Move bdb cppflags out of the catch-all BITCOIN_INCLUDES, and pass them only where they are needed, which is in libbitcoin_node/wallet and the tests.
2022-05-30 10:24:00 +01:00
libbitcoin_wallet_a_CPPFLAGS = $(AM_CPPFLAGS) $(BITCOIN_INCLUDES) $(BDB_CPPFLAGS) $(SQLITE_CFLAGS)
build: Split hardening/fPIE options out This allows for fPIE to be used selectively.
2015-11-09 20:50:25 -05:00
libbitcoin_wallet_a_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS)
Add --disable-wallet option to build system Make it possible to build Bitcoin without wallet (and thus without BDB) so that it only functions as node.
2013-11-29 16:50:11 +01:00
libbitcoin_wallet_a_SOURCES = \
Add -avoidpartialspends and m_avoid_partial_spends
2018-07-17 14:26:35 +09:00
wallet/coincontrol.cpp \
Remove g_rpc_chain global Replace with RPC request reference to new WalletContext struct similar to the existing NodeContext struct and reference. This PR is a followup to 25ad2c623af30056ffb36dcd203a52edda2b170f https://github.com/bitcoin/bitcoin/pull/18740 removing the g_rpc_node global. Some later PRs will follow this up and move more wallet globals to the WalletContext struct. Co-authored-by: João Barbosa <joao.paulo.barbosa@gmail.com>
2020-05-28 02:13:19 -04:00
wallet/context.cpp \
wallet: move crypter to wallet
2015-03-22 15:18:55 -04:00
wallet/crypter.cpp \
[Move Only] Move wallet related things to src/wallet/ could once be renamed from /src/wallet to /src/legacywallet.
2015-02-03 21:09:47 +01:00
wallet/db.cpp \
wallettool: Add dump command Adds a new dump command to bitcoin-wallet which prints out all of the wallet's records in hex.
2020-06-01 16:31:25 -04:00
wallet/dump.cpp \
wallet: add ExternalSignerScriptPubKeyMan
2020-02-19 16:40:00 +01:00
wallet/external_signer_scriptpubkeyman.cpp \
Refactor Bumpfee core functionality
2017-03-03 16:15:47 +01:00
wallet/feebumper.cpp \
Move some static functions out of wallet.h/cpp This commit just moves a few function declarations and updates callers. Function bodies are moved in two followup MOVEONLY commits. This change is desirable because wallet.h/cpp are monolithic and hard to navigate, so pulling things out and grouping together pieces of related functionality should improve the organization. Another proximate motivation is the wallet process separation work in https://github.com/bitcoin/bitcoin/pull/10973, where (at least initially) parameter parsing and fee estimation are still done in the main process rather than the wallet process, and having functions that run in different processes scrambled up throughout wallet.cpp is unnecessarily confusing.
2017-08-02 07:19:28 -04:00
wallet/fees.cpp \
Move WalletImpl from interfaces/wallet.cpp to wallet/interfaces.cpp
2020-11-24 10:20:16 -05:00
wallet/interfaces.cpp \
[build] Move wallet load functions to wallet/load unit Moves the following wallet load functions to a new wallet/load unit in the libbitcoin_wallet library. All other functions in wallet/init remain in libbitcoin_server: - `VerifyWallets` - `LoadWallets` - `StartWallets` - `FlushWallets` - `StopWallets` - `UnloadWallets`
2019-04-02 17:11:26 -04:00
wallet/load.cpp \
MOVEONLY: CWallet transaction code out of wallet.cpp/.h This commit just moves functions without making any changes. It can be reviewed with `git log -p -n1 --color-moved=dimmed_zebra` Motivation for this change is to make wallet.cpp/h less monolithic and start to make wallet transaction state tracking comprehensible so bugs in https://github.com/bitcoin-core/bitcoin-devwiki/wiki/Wallet-Transaction-Conflict-Tracking can be fixed safely without introducing new problems. This commit moves wallet classes and methods that deal with transactions out of wallet.cpp/.h into better organized files: - transaction.cpp/.h - CWalletTx and CMerkleTx class definitions - receive.cpp/.h - functions checking received transactions and computing balances - spend.cpp/.h - functions creating transactions and finding spendable coins After #20773, when loading is separated from syncing it will also be possible to move more wallet.cpp/.h functions to: - sync.cpp/.h - functions handling chain notifications and rescanning This commit arranges receive.cpp and spend.cpp functions in dependency order so it's possible to skim receive.cpp and get an idea of how computing balances works, and skim spend.cpp and get an idea of how transactions are created, without having to jump all over wallet.cpp where functions are not in order and there is a lot of unrelated code. Followup commit "refactor: Detach wallet transaction methods" in https://github.com/bitcoin/bitcoin/pull/21206 follows up this PR and tweaks function names and arguments to reflect new locations. The two commits are split into separate PRs because this commit is more work to maintain and less work to review, while the other commit is less work to maintain and more work to review, so hopefully this commit can be merged earlier.
2021-02-10 16:06:01 -05:00
wallet/receive.cpp \
MOVEONLY: Move address related functions from rpcwallet to addresses.cpp
2021-12-01 15:40:40 +13:00
wallet/rpc/addresses.cpp \
MOVEONLY: Move rpcdump.cpp to wallet/rpc/backup.cpp
2021-11-30 14:49:00 +13:00
wallet/rpc/backup.cpp \
MOVEONLY: Move balance and utxo RPCs to coins.cpp
2021-12-01 16:09:30 +13:00
wallet/rpc/coins.cpp \
MOVEONLY: Move wallet encryption RPCs to encrypt.cpp
2021-12-01 14:50:19 +13:00
wallet/rpc/encrypt.cpp \
MOVEONLY: Move spending RPCs to spend.cpp
2021-12-01 16:40:55 +13:00
wallet/rpc/spend.cpp \
wallet: Split signmessage from rpcwallet Can be reviewed with --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space
2021-11-26 13:48:32 +01:00
wallet/rpc/signmessage.cpp \
MOVEONLY: Move transaction related wallet RPCs to transactions.cpp
2021-12-01 15:06:45 +13:00
wallet/rpc/transactions.cpp \
Introduce wallet/rpc/util
2021-12-01 13:10:43 +13:00
wallet/rpc/util.cpp \
MOVEONLY: Move rpcwallet to rpc/wallet
2021-12-01 16:43:31 +13:00
wallet/rpc/wallet.cpp \
MOVEONLY: Move key handling code out of wallet to keyman file Start moving wallet and ismine code to scriptpubkeyman.h, scriptpubkeyman.cpp The easiest way to review this commit is to run: git log -p -n1 --color-moved=dimmed_zebra And check that everything is a move (other than includes and copyrights comments). This commit is move-only and doesn't change code or affect behavior.
2019-10-07 14:11:34 -04:00
wallet/scriptpubkeyman.cpp \
MOVEONLY: CWallet transaction code out of wallet.cpp/.h This commit just moves functions without making any changes. It can be reviewed with `git log -p -n1 --color-moved=dimmed_zebra` Motivation for this change is to make wallet.cpp/h less monolithic and start to make wallet transaction state tracking comprehensible so bugs in https://github.com/bitcoin-core/bitcoin-devwiki/wiki/Wallet-Transaction-Conflict-Tracking can be fixed safely without introducing new problems. This commit moves wallet classes and methods that deal with transactions out of wallet.cpp/.h into better organized files: - transaction.cpp/.h - CWalletTx and CMerkleTx class definitions - receive.cpp/.h - functions checking received transactions and computing balances - spend.cpp/.h - functions creating transactions and finding spendable coins After #20773, when loading is separated from syncing it will also be possible to move more wallet.cpp/.h functions to: - sync.cpp/.h - functions handling chain notifications and rescanning This commit arranges receive.cpp and spend.cpp functions in dependency order so it's possible to skim receive.cpp and get an idea of how computing balances works, and skim spend.cpp and get an idea of how transactions are created, without having to jump all over wallet.cpp where functions are not in order and there is a lot of unrelated code. Followup commit "refactor: Detach wallet transaction methods" in https://github.com/bitcoin/bitcoin/pull/21206 follows up this PR and tweaks function names and arguments to reflect new locations. The two commits are split into separate PRs because this commit is more work to maintain and less work to review, while the other commit is less work to maintain and more work to review, so hopefully this commit can be merged earlier.
2021-02-10 16:06:01 -05:00
wallet/spend.cpp \
wallet/transaction.cpp \
[Move Only] Move wallet related things to src/wallet/ could once be renamed from /src/wallet to /src/legacywallet.
2015-02-03 21:09:47 +01:00
wallet/wallet.cpp \
wallet/walletdb.cpp \
Add -walletdir parameter to specify custom wallet dir
2017-10-09 09:48:07 +13:00
wallet/walletutil.cpp \
Implement Branch and Bound coin selection in a new file Create a new file for coin selection logic and implement the BnB algorithm in it.
2018-03-05 16:29:37 -05:00
wallet/coinselection.cpp \
bitcoin-cli: remove unneeded dependencies (only code movement) Remove unnecessary dependencies for bitcoin-cli (leveldb, berkelydb, wallet, RPC server) Build system changes: - split libbitcoin.a into libbitcoin_common.a, libbitcoin_server.a and libbitcoin_cli.a Code changes (movement only): - split up HelpMessage into HelpMessage in init.cpp and HelpMessageCli in rpcclient.cpp - move uiInterface from init.cpp to util.cpp
2013-11-27 15:41:12 +01:00
$(BITCOIN_CORE_H)
Make sqlite support optional (compile-time)
2020-10-15 13:50:00 +00:00
if USE_SQLITE
libbitcoin_wallet_a_SOURCES += wallet/sqlite.cpp
endif
Do not compile BDB things when USE_BDB is defined
2020-10-19 15:34:21 -04:00
if USE_BDB
libbitcoin_wallet_a_SOURCES += wallet/bdb.cpp wallet/salvage.cpp
endif
Make sqlite support optional (compile-time)
2020-10-15 13:50:00 +00:00
[tools] Add wallet inspection and modification tool This commit adds wallet-tool, a tool for creating and interacting with wallet files. Original implementation was by Jonas Schnelli <dev@jonasschnelli.ch> with modifications by John Newbery <john@johnnewbery.com> MSVC files were provided by Chun Kuan Lee <ken2812221@gmail.com>: build: Add MSVC project files for bitcoin-wallet-tool
2016-09-16 16:45:36 +02:00
libbitcoin_wallet_tool_a_CPPFLAGS = $(AM_CPPFLAGS) $(BITCOIN_INCLUDES)
libbitcoin_wallet_tool_a_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS)
libbitcoin_wallet_tool_a_SOURCES = \
wallet/wallettool.cpp \
$(BITCOIN_CORE_H)
Remove unnecessary dependencies for bitcoin-cli This commit removes all the unnecessary dependencies (key, core, netbase, sync, ...) from bitcoin-cli. To do this it shards the chain parameters into BaseParams, which contains just the RPC port and data directory (as used by utils and bitcoin-cli) and Params, with the rest.
2014-06-19 15:10:04 +02:00
# crypto primitives library
build: Create .la library for bitcoincrypto Libtool will yell at you if you try to link a shared library against static ones. This change creates a libtool archive library for bitcoincrypto and allows a shared library to be linked against it portably. Also specify -static in both: - ..._la_CXXFLAGS so that libtool will avoid building two versions of each object (one PIC, one non-PIC). We just need the one that is suitable for static linking. - ..._la_LDFLAGS so that libtool will create a static library. [META] This change is done in preparation for a future commit where we link the libbitcoinkernel library against this one.
2021-12-22 01:16:00 -05:00
crypto_libbitcoin_crypto_base_la_CPPFLAGS = $(AM_CPPFLAGS)
# Specify -static in both CXXFLAGS and LDFLAGS so libtool will only build a
# static version of this library. We don't need a dynamic version, and a dynamic
# version can't be used on windows anyway because the library doesn't currently
# export DLL symbols.
crypto_libbitcoin_crypto_base_la_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS) -static
crypto_libbitcoin_crypto_base_la_LDFLAGS = $(AM_LDFLAGS) -static
crypto_libbitcoin_crypto_base_la_SOURCES = \
Add ctaes-based constant time AES implementation
2016-03-30 15:37:41 +02:00
crypto/aes.cpp \
crypto/aes.h \
Add ChaCha20Poly1305@Bitcoin AEAD implementation
2019-03-11 16:15:45 +01:00
crypto/chacha_poly_aead.h \
crypto/chacha_poly_aead.cpp \
Add ChaCha20
2017-02-15 12:29:23 -08:00
crypto/chacha20.h \
crypto/chacha20.cpp \
crypto: create a separate lib for crypto functions This lib has no dependencies on other bitcoin functionality. Attempting to use bitcoin headers will result in a failure to compile.
2014-06-09 15:17:27 -04:00
crypto/common.h \
Add HKDF HMAC_SHA256 L=32 implementations
2018-08-24 11:10:43 +02:00
crypto/hkdf_sha256_32.cpp \
crypto/hkdf_sha256_32.h \
Alphabetic order in makefile
2015-05-13 18:59:50 +02:00
crypto/hmac_sha256.cpp \
Add HMAC-SHA256
2014-10-26 01:38:13 -07:00
crypto/hmac_sha256.h \
Alphabetic order in makefile
2015-05-13 18:59:50 +02:00
crypto/hmac_sha512.cpp \
Split up crypto/sha2
2014-10-26 01:23:23 -07:00
crypto/hmac_sha512.h \
Add Poly1305 implementation
2019-03-03 21:12:34 +01:00
crypto/poly1305.h \
crypto/poly1305.cpp \
crypto: Add MuHash3072 implementation Co-authored-by: Pieter Wuille <pieter.wuille@gmail.com>
2020-12-20 22:27:14 +01:00
crypto/muhash.h \
crypto/muhash.cpp \
Alphabetic order in makefile
2015-05-13 18:59:50 +02:00
crypto/ripemd160.cpp \
crypto/ripemd160.h \
crypto/sha1.cpp \
crypto: create a separate lib for crypto functions This lib has no dependencies on other bitcoin functionality. Attempting to use bitcoin headers will result in a failure to compile.
2014-06-09 15:17:27 -04:00
crypto/sha1.h \
Alphabetic order in makefile
2015-05-13 18:59:50 +02:00
crypto/sha256.cpp \
crypto/sha256.h \
Implement keccak-f[1600] and SHA3-256
2020-08-30 12:54:45 -07:00
crypto/sha3.cpp \
crypto/sha3.h \
Alphabetic order in makefile
2015-05-13 18:59:50 +02:00
crypto/sha512.cpp \
Extract CSipHasher to it's own file in crypto/ directory. This is a move-only commit with the exception of changes to includes.
2018-08-24 14:48:23 -07:00
crypto/sha512.h \
crypto/siphash.cpp \
crypto/siphash.h
crypto: create a separate lib for crypto functions This lib has no dependencies on other bitcoin functionality. Attempting to use bitcoin headers will result in a failure to compile.
2014-06-09 15:17:27 -04:00
build: Rename --enable-experimental-asm to --enable-asm and enable by default Now that 0.15 is branched off, enable assembler SHA256 optimizations by default.
2017-08-28 11:01:28 +02:00
if USE_ASM
build: Create .la library for bitcoincrypto Libtool will yell at you if you try to link a shared library against static ones. This change creates a libtool archive library for bitcoincrypto and allows a shared library to be linked against it portably. Also specify -static in both: - ..._la_CXXFLAGS so that libtool will avoid building two versions of each object (one PIC, one non-PIC). We just need the one that is suitable for static linking. - ..._la_LDFLAGS so that libtool will create a static library. [META] This change is done in preparation for a future commit where we link the libbitcoinkernel library against this one.
2021-12-22 01:16:00 -05:00
crypto_libbitcoin_crypto_base_la_SOURCES += crypto/sha256_sse4.cpp
Protect SSE4 code behind a compile-time flag
2017-07-18 01:06:11 -07:00
endif
build: Create .la library for bitcoincrypto Libtool will yell at you if you try to link a shared library against static ones. This change creates a libtool archive library for bitcoincrypto and allows a shared library to be linked against it portably. Also specify -static in both: - ..._la_CXXFLAGS so that libtool will avoid building two versions of each object (one PIC, one non-PIC). We just need the one that is suitable for static linking. - ..._la_LDFLAGS so that libtool will create a static library. [META] This change is done in preparation for a future commit where we link the libbitcoinkernel library against this one.
2021-12-22 01:16:00 -05:00
# See explanation for -static in crypto_libbitcoin_crypto_base_la's LDFLAGS and
# CXXFLAGS above
crypto_libbitcoin_crypto_sse41_la_LDFLAGS = $(AM_LDFLAGS) -static
crypto_libbitcoin_crypto_sse41_la_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS) -static
crypto_libbitcoin_crypto_sse41_la_CPPFLAGS = $(AM_CPPFLAGS)
crypto_libbitcoin_crypto_sse41_la_CXXFLAGS += $(SSE41_CXXFLAGS)
crypto_libbitcoin_crypto_sse41_la_CPPFLAGS += -DENABLE_SSE41
crypto_libbitcoin_crypto_sse41_la_SOURCES = crypto/sha256_sse41.cpp
# See explanation for -static in crypto_libbitcoin_crypto_base_la's LDFLAGS and
# CXXFLAGS above
crypto_libbitcoin_crypto_avx2_la_LDFLAGS = $(AM_LDFLAGS) -static
crypto_libbitcoin_crypto_avx2_la_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS) -static
crypto_libbitcoin_crypto_avx2_la_CPPFLAGS = $(AM_CPPFLAGS)
crypto_libbitcoin_crypto_avx2_la_CXXFLAGS += $(AVX2_CXXFLAGS)
crypto_libbitcoin_crypto_avx2_la_CPPFLAGS += -DENABLE_AVX2
crypto_libbitcoin_crypto_avx2_la_SOURCES = crypto/sha256_avx2.cpp
# See explanation for -static in crypto_libbitcoin_crypto_base_la's LDFLAGS and
# CXXFLAGS above
crypto_libbitcoin_crypto_x86_shani_la_LDFLAGS = $(AM_LDFLAGS) -static
crypto_libbitcoin_crypto_x86_shani_la_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS) -static
crypto_libbitcoin_crypto_x86_shani_la_CPPFLAGS = $(AM_CPPFLAGS)
crypto_libbitcoin_crypto_x86_shani_la_CXXFLAGS += $(X86_SHANI_CXXFLAGS)
crypto_libbitcoin_crypto_x86_shani_la_CPPFLAGS += -DENABLE_X86_SHANI
crypto_libbitcoin_crypto_x86_shani_la_SOURCES = crypto/sha256_x86_shani.cpp
# See explanation for -static in crypto_libbitcoin_crypto_base_la's LDFLAGS and
# CXXFLAGS above
crypto_libbitcoin_crypto_arm_shani_la_LDFLAGS = $(AM_LDFLAGS) -static
crypto_libbitcoin_crypto_arm_shani_la_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS) -static
crypto_libbitcoin_crypto_arm_shani_la_CPPFLAGS = $(AM_CPPFLAGS)
crypto_libbitcoin_crypto_arm_shani_la_CXXFLAGS += $(ARM_SHANI_CXXFLAGS)
crypto_libbitcoin_crypto_arm_shani_la_CPPFLAGS += -DENABLE_ARM_SHANI
crypto_libbitcoin_crypto_arm_shani_la_SOURCES = crypto/sha256_arm_shani.cpp
Add SHA256 implementation using using Intel SHA intrinsics
2018-06-24 10:50:40 -07:00
Build: Consensus: Move consensus files from common to its own module/package
2015-11-20 16:46:03 +01:00
# consensus: shared between all executables that validate any consensus rules.
libbitcoin_consensus_a_CPPFLAGS = $(AM_CPPFLAGS) $(BITCOIN_INCLUDES)
libbitcoin_consensus_a_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS)
libbitcoin_consensus_a_SOURCES = \
Build: Libconsensus: Move libconsensus-ready files to the consensus package
2015-11-24 06:26:15 +01:00
arith_uint256.cpp \
arith_uint256.h \
[MOVEONLY] consensus: move amount.h into consensus Move amount.h to consensus/amount.h. Renames, adds missing and removes uneeded includes.
2021-09-11 10:29:00 +08:00
consensus/amount.h \
Build: Libconsensus: Move libconsensus-ready files to the consensus package
2015-11-24 06:26:15 +01:00
consensus/merkle.cpp \
consensus/merkle.h \
consensus/params.h \
[build] Move CheckTransaction from lib_server to lib_consensus CheckTransaction is a context-free function that does not require access to the blockchain or mempool. Move it from src/consensus/tx_verify in lib_server to a new unit src/consensus/tx_check in lib_consensus so that it can be called by non-server libraries.
2019-04-02 13:41:12 -04:00
consensus/tx_check.cpp \
Build: Libconsensus: Move libconsensus-ready files to the consensus package
2015-11-24 06:26:15 +01:00
consensus/validation.h \
Build: Consensus: Move consensus files from common to its own module/package
2015-11-20 16:46:03 +01:00
hash.cpp \
hash.h \
prevector.h \
Build: Libconsensus: Move libconsensus-ready files to the consensus package
2015-11-24 06:26:15 +01:00
primitives/block.cpp \
primitives/block.h \
Build: Consensus: Move consensus files from common to its own module/package
2015-11-20 16:46:03 +01:00
primitives/transaction.cpp \
primitives/transaction.h \
pubkey.cpp \
pubkey.h \
script/bitcoinconsensus.cpp \
script/interpreter.cpp \
script/interpreter.h \
script/script.cpp \
script/script.h \
script/script_error.cpp \
script/script_error.h \
serialize.h \
Add Slice: a (pointer, size) array view that acts like a container
2018-04-04 11:56:22 -07:00
span.h \
Build: Consensus: Move consensus files from common to its own module/package
2015-11-20 16:46:03 +01:00
tinyformat.h \
uint256.cpp \
uint256.h \
scripted-diff: Move util files to separate directory. -BEGIN VERIFY SCRIPT- mkdir -p src/util git mv src/util.h src/util/system.h git mv src/util.cpp src/util/system.cpp git mv src/utilmemory.h src/util/memory.h git mv src/utilmoneystr.h src/util/moneystr.h git mv src/utilmoneystr.cpp src/util/moneystr.cpp git mv src/utilstrencodings.h src/util/strencodings.h git mv src/utilstrencodings.cpp src/util/strencodings.cpp git mv src/utiltime.h src/util/time.h git mv src/utiltime.cpp src/util/time.cpp sed -i 's/<util\.h>/<util\/system\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilmemory\.h>/<util\/memory\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilmoneystr\.h>/<util\/moneystr\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilstrencodings\.h>/<util\/strencodings\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utiltime\.h>/<util\/time\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/BITCOIN_UTIL_H/BITCOIN_UTIL_SYSTEM_H/g' src/util/system.h sed -i 's/BITCOIN_UTILMEMORY_H/BITCOIN_UTIL_MEMORY_H/g' src/util/memory.h sed -i 's/BITCOIN_UTILMONEYSTR_H/BITCOIN_UTIL_MONEYSTR_H/g' src/util/moneystr.h sed -i 's/BITCOIN_UTILSTRENCODINGS_H/BITCOIN_UTIL_STRENCODINGS_H/g' src/util/strencodings.h sed -i 's/BITCOIN_UTILTIME_H/BITCOIN_UTIL_TIME_H/g' src/util/time.h sed -i 's/ util\.\(h\|cpp\)/ util\/system\.\1/g' src/Makefile.am sed -i 's/utilmemory\.\(h\|cpp\)/util\/memory\.\1/g' src/Makefile.am sed -i 's/utilmoneystr\.\(h\|cpp\)/util\/moneystr\.\1/g' src/Makefile.am sed -i 's/utilstrencodings\.\(h\|cpp\)/util\/strencodings\.\1/g' src/Makefile.am sed -i 's/utiltime\.\(h\|cpp\)/util\/time\.\1/g' src/Makefile.am sed -i 's/-> util ->/-> util\/system ->/' test/lint/lint-circular-dependencies.sh sed -i 's/src\/util\.cpp/src\/util\/system\.cpp/g' test/lint/lint-format-strings.py test/lint/lint-locale-dependence.sh sed -i 's/src\/utilmoneystr\.cpp/src\/util\/moneystr\.cpp/g' test/lint/lint-locale-dependence.sh sed -i 's/src\/utilstrencodings\.\(h\|cpp\)/src\/util\/strencodings\.\1/g' test/lint/lint-locale-dependence.sh sed -i 's/src\\utilstrencodings\.cpp/src\\util\\strencodings\.cpp/' build_msvc/libbitcoinconsensus/libbitcoinconsensus.vcxproj -END VERIFY SCRIPT-
2018-10-22 15:51:11 -07:00
util/strencodings.cpp \
util/strencodings.h \
Build: Consensus: Move consensus files from common to its own module/package
2015-11-20 16:46:03 +01:00
version.h
Remove unnecessary dependencies for bitcoin-cli This commit removes all the unnecessary dependencies (key, core, netbase, sync, ...) from bitcoin-cli. To do this it shards the chain parameters into BaseParams, which contains just the RPC port and data directory (as used by utils and bitcoin-cli) and Params, with the rest.
2014-06-19 15:10:04 +02:00
# common: shared between bitcoind, and bitcoin-qt and non-server tools
build: Split hardening/fPIE options out This allows for fPIE to be used selectively.
2015-11-09 20:50:25 -05:00
libbitcoin_common_a_CPPFLAGS = $(AM_CPPFLAGS) $(BITCOIN_INCLUDES)
libbitcoin_common_a_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS)
bitcoin-cli: remove unneeded dependencies (only code movement) Remove unnecessary dependencies for bitcoin-cli (leveldb, berkelydb, wallet, RPC server) Build system changes: - split libbitcoin.a into libbitcoin_common.a, libbitcoin_server.a and libbitcoin_cli.a Code changes (movement only): - split up HelpMessage into HelpMessage in init.cpp and HelpMessageCli in rpcclient.cpp - move uiInterface from init.cpp to util.cpp
2013-11-27 15:41:12 +01:00
libbitcoin_common_a_SOURCES = \
Move coins.cpp and keystore.cpp to libbitcoin_common Prepare for introduction of `bitcoin-tx` tool.
2014-06-25 10:03:00 +02:00
base58.cpp \
Import Bech32 C++ reference code & tests This includes a reformatted version of the Bech32 reference code (see https://github.com/sipa/bech32/tree/master/ref/c%2B%2B), with extra documentation.
2017-08-25 18:12:39 -07:00
bech32.cpp \
bitcoin-cli: remove unneeded dependencies (only code movement) Remove unnecessary dependencies for bitcoin-cli (leveldb, berkelydb, wallet, RPC server) Build system changes: - split libbitcoin.a into libbitcoin_common.a, libbitcoin_server.a and libbitcoin_cli.a Code changes (movement only): - split up HelpMessage into HelpMessage in init.cpp and HelpMessageCli in rpcclient.cpp - move uiInterface from init.cpp to util.cpp
2013-11-27 15:41:12 +01:00
chainparams.cpp \
Move coins.cpp and keystore.cpp to libbitcoin_common Prepare for introduction of `bitcoin-tx` tool.
2014-06-25 10:03:00 +02:00
coins.cpp \
style: Sort
2021-09-29 17:09:55 +02:00
common/bloom.cpp \
MOVEONLY: Move script/compressor out of script and put CTxOutCompressor (from core) with it
2014-10-19 04:28:43 +02:00
compressor.cpp \
Consolidate CTransaction hex encode/decode into core_io.h, core_{read,write}.cpp
2014-06-23 23:10:24 -04:00
core_read.cpp \
core_write.cpp \
[move-only] Rename versionbitsinfo to deploymentinfo
2021-03-11 12:17:22 +10:00
deploymentinfo.cpp \
Move external signer out of wallet module This commit moves the ExternalSigner class and RPC methods out of the wallet module. The enumeratesigners RPC can be used without a wallet since #21417. With additional modifications external signers could be used without a wallet in general, e.g. via signrawtransaction. The signerdisplayaddress RPC is ranamed to walletdisplayaddress because it requires wallet context. A future displayaddress RPC call without wallet context could take a descriptor argument. This commit fixes a rpc_help.py failure when configured with --disable-wallet.
2021-03-18 14:17:39 +01:00
external_signer.cpp \
Move common global init code to init/common
2021-04-18 18:56:12 -04:00
init/common.cpp \
bitcoin-cli: remove unneeded dependencies (only code movement) Remove unnecessary dependencies for bitcoin-cli (leveldb, berkelydb, wallet, RPC server) Build system changes: - split libbitcoin.a into libbitcoin_common.a, libbitcoin_server.a and libbitcoin_cli.a Code changes (movement only): - split up HelpMessage into HelpMessage in init.cpp and HelpMessageCli in rpcclient.cpp - move uiInterface from init.cpp to util.cpp
2013-11-27 15:41:12 +01:00
key.cpp \
Split key_io (address/key encodings) off from base58
2017-09-19 18:12:25 -07:00
key_io.cpp \
[build] Move several units into common libraries Moves the following units into libbitcoin_util or libbitcoin_common since they are required by multiple libraries: - bloom - interfaces/handler - merkleblock - outputtype
2019-04-02 16:57:36 -04:00
merkleblock.cpp \
MOVEONLY: Expose BanMapToJson / BanMapFromJson CSubNet serialization code that was removed in fa4e6afdae7b82df638b60edf37ac36d57a8cb4f was needed by multiprocess code to share ban map between gui and node processes. Rather than adding it back, use suggestion from MarcoFalke <falke.marco@gmail.com> https://github.com/bitcoin/bitcoin/pull/10102#discussion_r690922929 to use JSON serialization. This requires making BanMapToJson / BanMapFromJson functions public.
2021-08-31 09:59:12 -04:00
net_types.cpp \
net: move CNetAddr/CService/CSubNet out of netbase
2016-05-31 17:25:03 -04:00
netaddress.cpp \
bitcoin-cli: remove unneeded dependencies (only code movement) Remove unnecessary dependencies for bitcoin-cli (leveldb, berkelydb, wallet, RPC server) Build system changes: - split libbitcoin.a into libbitcoin_common.a, libbitcoin_server.a and libbitcoin_cli.a Code changes (movement only): - split up HelpMessage into HelpMessage in init.cpp and HelpMessageCli in rpcclient.cpp - move uiInterface from init.cpp to util.cpp
2013-11-27 15:41:12 +01:00
netbase.cpp \
Make whitebind/whitelist permissions more flexible
2019-06-20 18:37:51 +09:00
net_permissions.cpp \
[build] Move several units into common libraries Moves the following units into libbitcoin_util or libbitcoin_common since they are required by multiple libraries: - bloom - interfaces/handler - merkleblock - outputtype
2019-04-02 16:57:36 -04:00
outputtype.cpp \
Consensus: Policy: MOVEONLY: Move CFeeRate out of the consensus module ...from amount.o to policy/feerate.o Policy, because it moves policy code to the policy directory (common module)
2016-03-31 23:30:17 +02:00
policy/feerate.cpp \
[build] Move policy settings to new src/policy/settings unit This moves the following policy settings functions and globals to a new src/policy/settings unit in lib_server: - `incrementalRelayFee` - `dustRelayFee` - `nBytesPerSigOp` - `fIsBareMultisigStd` These settings are only required by the node and should not be accessed by other libraries.
2019-04-02 14:14:58 -04:00
policy/policy.cpp \
bitcoin-cli: remove unneeded dependencies (only code movement) Remove unnecessary dependencies for bitcoin-cli (leveldb, berkelydb, wallet, RPC server) Build system changes: - split libbitcoin.a into libbitcoin_common.a, libbitcoin_server.a and libbitcoin_cli.a Code changes (movement only): - split up HelpMessage into HelpMessage in init.cpp and HelpMessageCli in rpcclient.cpp - move uiInterface from init.cpp to util.cpp
2013-11-27 15:41:12 +01:00
protocol.cpp \
Move PSBT decoding functions from core_io to psbt.cpp Move PSBT decoding functions from core_io.h/core_read.cpp to psbt.h/psbt.cpp, to deal with a linker issue.
2019-03-05 18:55:40 -08:00
psbt.cpp \
[build] Move rpc rawtransaction util functions to rpc/rawtransaction_util.cpp rpc/rawtransaction.cpp moves to libbitcoin_server since it should not be accessed by non-node libraries. The utility following utility methods move to their own unit rpc/rawtransaction_util since they need to be accessed by non-node libraries: - `ConstructTransaction` - `TxInErrorToJSON` - `SignTransaction`
2019-04-02 16:51:32 -04:00
rpc/rawtransaction_util.cpp \
Move external signer out of wallet module This commit moves the ExternalSigner class and RPC methods out of the wallet module. The enumeratesigners RPC can be used without a wallet since #21417. With additional modifications external signers could be used without a wallet in general, e.g. via signrawtransaction. The signerdisplayaddress RPC is ranamed to walletdisplayaddress because it requires wallet context. A future displayaddress RPC call without wallet context could take a descriptor argument. This commit fixes a rpc_help.py failure when configured with --disable-wallet.
2021-03-18 14:17:39 +01:00
rpc/external_signer.cpp \
[build] Move rpc utility methods to rpc/util Moves the following utility methods to rpc/util and moves that unit to libbitcoin_common so they can be accessed by all libraries. - `RPCTypeCheck` - `RPCTypeCheckArgument` - `RPCTypeCheckObj` - `AmountFromValue` - `ParseHashV``ParseHashO` - `ParseHexV` - `ParseHexO` - `HelpExampleCli` - `HelpExampleRpc`
2019-04-02 16:42:51 -04:00
rpc/util.cpp \
CScheduler class for lightweight task scheduling Simple class to manage a task queue that is serviced by one or more threads.
2015-04-02 10:33:45 -04:00
scheduler.cpp \
Output descriptors module
2018-07-04 18:08:19 -07:00
script/descriptor.cpp \
Miniscript: type system, script creation, text notation, tests More information about Miniscript can be found at https://bitcoin.sipa.be/miniscript/ (the website source is hosted at https://github.com/sipa/miniscript/). This commit defines all fragments, their composition, parsing from string representation and conversion to Script. Co-Authored-By: Antoine Poinsot <darosior@protonmail.com> Co-Authored-By: Sanket Kanjalkar <sanket1729@gmail.com> Co-Authored-By: Samuel Dobson <dobsonsa68@gmail.com>
2019-08-28 16:23:03 -07:00
script/miniscript.cpp \
Separate script/sign
2014-08-27 17:22:33 +02:00
script/sign.cpp \
Move various SigningProviders to signingprovider.{cpp,h} Moves all of the various SigningProviders out of sign.{cpp,h} and keystore.{cpp,h}. As such, keystore.{cpp,h} is also removed. Includes and the Makefile are updated to reflect this. Includes were largely changed using: git grep -l "keystore.h" | xargs sed -i -e 's;keystore.h;script/signingprovider.h;g'
2019-06-06 22:52:24 +02:00
script/signingprovider.cpp \
Separate script/standard
2014-08-23 03:35:51 +02:00
script/standard.cpp \
Move GetWarnings() into its own file.
2016-11-30 06:07:42 +00:00
warnings.cpp \
Remove unnecessary dependencies for bitcoin-cli This commit removes all the unnecessary dependencies (key, core, netbase, sync, ...) from bitcoin-cli. To do this it shards the chain parameters into BaseParams, which contains just the RPC port and data directory (as used by utils and bitcoin-cli) and Params, with the rest.
2014-06-19 15:10:04 +02:00
$(BITCOIN_CORE_H)
# util: shared between all executables.
build: Split hardening/fPIE options out This allows for fPIE to be used selectively.
2015-11-09 20:50:25 -05:00
libbitcoin_util_a_CPPFLAGS = $(AM_CPPFLAGS) $(BITCOIN_INCLUDES)
libbitcoin_util_a_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS)
Remove unnecessary dependencies for bitcoin-cli This commit removes all the unnecessary dependencies (key, core, netbase, sync, ...) from bitcoin-cli. To do this it shards the chain parameters into BaseParams, which contains just the RPC port and data directory (as used by utils and bitcoin-cli) and Params, with the rest.
2014-06-19 15:10:04 +02:00
libbitcoin_util_a_SOURCES = \
support: Add LockedPool Add a pool for locked memory chunks, replacing LockedPageManager. This is something I've been wanting to do for a long time. The current approach of locking objects where they happen to be on the stack or heap in-place causes a lot of mlock/munlock system call overhead, slowing down any handling of keys. Also locked memory is a limited resource on many operating systems (and using a lot of it bogs down the system), so the previous approach of locking every page that may contain any key information (but also other information) is wasteful.
2016-09-18 09:55:14 +02:00
support/lockedpool.cpp \
Remove unnecessary dependencies for bitcoin-cli This commit removes all the unnecessary dependencies (key, core, netbase, sync, ...) from bitcoin-cli. To do this it shards the chain parameters into BaseParams, which contains just the RPC port and data directory (as used by utils and bitcoin-cli) and Params, with the rest.
2014-06-19 15:10:04 +02:00
chainparamsbase.cpp \
Separate protocol versioning from clientversion
2014-10-28 21:33:23 -04:00
clientversion.cpp \
Add fs.cpp/h
2017-03-01 15:53:56 +00:00
fs.cpp \
multiprocess: Add echoipc RPC method and test Add simple interfaces::Echo IPC interface with one method that just takes and returns a string, to test multiprocess framework and provide an example of how it can be used to spawn and call between processes.
2020-11-24 13:59:33 -05:00
interfaces/echo.cpp \
[build] Move several units into common libraries Moves the following units into libbitcoin_util or libbitcoin_common since they are required by multiple libraries: - bloom - interfaces/handler - merkleblock - outputtype
2019-04-02 16:57:36 -04:00
interfaces/handler.cpp \
multiprocess: Add Ipc and Init interface definitions
2017-12-05 15:57:12 -05:00
interfaces/init.cpp \
MOVEONLY: Move logging code from util.{h,cpp} to new files.
2018-04-18 10:05:05 -07:00
logging.cpp \
move rand functions from util to new random.h/.cpp
2014-06-26 14:41:53 +02:00
random.cpp \
[MOVEONLY] Move perfmon data gathering to new randomenv module
2019-10-26 12:20:12 -07:00
randomenv.cpp \
rpc: migrate JSONRPCRequest functionality into request.cpp
2019-06-20 02:39:38 +09:00
rpc/request.cpp \
openssl: abstract out OPENSSL_cleanse This makes it easier for us to replace it if desired, since it's now only in one spot. Also, it avoids the openssl include from allocators.h, which essentially forced openssl to be included from every compilation unit.
2015-01-20 19:23:25 -05:00
support/cleanse.cpp \
bitcoin-cli: remove unneeded dependencies (only code movement) Remove unnecessary dependencies for bitcoin-cli (leveldb, berkelydb, wallet, RPC server) Build system changes: - split libbitcoin.a into libbitcoin_common.a, libbitcoin_server.a and libbitcoin_cli.a Code changes (movement only): - split up HelpMessage into HelpMessage in init.cpp and HelpMessageCli in rpcclient.cpp - move uiInterface from init.cpp to util.cpp
2013-11-27 15:41:12 +01:00
sync.cpp \
net: add CThreadInterrupt and InterruptibleSleep
2016-12-27 17:12:15 -05:00
threadinterrupt.cpp \
Add asmap utility which queries a mapping The scripts for creating a compact IP->ASN mapping are here: https://github.com/sipa/asmap Co-authored-by: Pieter Wuille <pieter.wuille@gmail.com>
2019-12-18 14:27:03 -05:00
util/asmap.cpp \
Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp} Creates new files util/bip32.h and util/bip32.cpp for containing BIP 32 stuff. Moves FormatKeyPath from descriptor.cpp to util/bip32. Adds a wrapper around it to prepent the 'm' for when just the BIP 32 style keypath is needed.
2018-11-06 09:23:43 -05:00
util/bip32.cpp \
blockfilter: Use unordered_set instead of set in blockfilter.
2018-08-20 23:35:29 -07:00
util/bytevectorhash.cpp \
util/check: stop using lambda for Assert/Assume
2022-03-26 12:41:28 +10:00
util/check.cpp \
[build] Add several util units Adds the following util units and adds them to libbitcoin_util: - `util/url.cpp` takes `urlDecode` from `httpserver.cpp` - `util/error.cpp` takes `TransactionErrorString` from `node/transaction.cpp` and `AmountHighWarn` and `AmountErrMsg` from `ui_interface.cpp` - `util/fees.cpp` takes `StringForFeeReason` and `FeeModeFromString` from `policy/fees.cpp` - `util/rbf.cpp` takes `SignalsOptInRBF` from `policy/rbf.cpp` - 'util/validation.cpp` takes `FormatStateMessage` and `strMessageMagic` from 'validation.cpp`
2019-04-02 17:03:37 -04:00
util/error.cpp \
util/fees.cpp \
Introduce GetUniquePath(base) helper method to replace boost::filesystem::unique_path() which is not available in std::filesystem.
2021-02-01 13:35:28 +01:00
util/getuniquepath.cpp \
Move Hashers to util/hasher.{cpp/h} Move the hashers that we use for hash tables to a common place. Moved hashers: - SaltedTxidHasher - SaltedOutpointHasher - FilterHeaderHasher - SignatureCacheHasher - BlockHasher
2019-09-17 17:02:56 -04:00
util/hasher.cpp \
net: move CloseSocket() from netbase to util/sock Move `CloseSocket()` (and `NetworkErrorString()` which it uses) from `netbase.{h,cpp}` to newly added `src/util/sock.{h,cpp}`. This is necessary in order to use `CloseSocket()` from a newly introduced Sock class (which will live in `src/util/sock.{h,cpp}`). `sock.{h,cpp}` cannot depend on netbase because netbase will depend on it.
2021-01-04 13:02:43 +01:00
util/sock.cpp \
util: Replace non-threadsafe strerror Some uses of non-threadsafe `strerror` have snuck into the code since they were removed in #4152. Add a wrapper `SysErrorString` for thread-safe strerror alternatives and replace all uses of `strerror` with this.
2022-04-20 16:17:19 +02:00
util/syserror.cpp \
scripted-diff: Move util files to separate directory. -BEGIN VERIFY SCRIPT- mkdir -p src/util git mv src/util.h src/util/system.h git mv src/util.cpp src/util/system.cpp git mv src/utilmemory.h src/util/memory.h git mv src/utilmoneystr.h src/util/moneystr.h git mv src/utilmoneystr.cpp src/util/moneystr.cpp git mv src/utilstrencodings.h src/util/strencodings.h git mv src/utilstrencodings.cpp src/util/strencodings.cpp git mv src/utiltime.h src/util/time.h git mv src/utiltime.cpp src/util/time.cpp sed -i 's/<util\.h>/<util\/system\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilmemory\.h>/<util\/memory\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilmoneystr\.h>/<util\/moneystr\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilstrencodings\.h>/<util\/strencodings\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utiltime\.h>/<util\/time\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/BITCOIN_UTIL_H/BITCOIN_UTIL_SYSTEM_H/g' src/util/system.h sed -i 's/BITCOIN_UTILMEMORY_H/BITCOIN_UTIL_MEMORY_H/g' src/util/memory.h sed -i 's/BITCOIN_UTILMONEYSTR_H/BITCOIN_UTIL_MONEYSTR_H/g' src/util/moneystr.h sed -i 's/BITCOIN_UTILSTRENCODINGS_H/BITCOIN_UTIL_STRENCODINGS_H/g' src/util/strencodings.h sed -i 's/BITCOIN_UTILTIME_H/BITCOIN_UTIL_TIME_H/g' src/util/time.h sed -i 's/ util\.\(h\|cpp\)/ util\/system\.\1/g' src/Makefile.am sed -i 's/utilmemory\.\(h\|cpp\)/util\/memory\.\1/g' src/Makefile.am sed -i 's/utilmoneystr\.\(h\|cpp\)/util\/moneystr\.\1/g' src/Makefile.am sed -i 's/utilstrencodings\.\(h\|cpp\)/util\/strencodings\.\1/g' src/Makefile.am sed -i 's/utiltime\.\(h\|cpp\)/util\/time\.\1/g' src/Makefile.am sed -i 's/-> util ->/-> util\/system ->/' test/lint/lint-circular-dependencies.sh sed -i 's/src\/util\.cpp/src\/util\/system\.cpp/g' test/lint/lint-format-strings.py test/lint/lint-locale-dependence.sh sed -i 's/src\/utilmoneystr\.cpp/src\/util\/moneystr\.cpp/g' test/lint/lint-locale-dependence.sh sed -i 's/src\/utilstrencodings\.\(h\|cpp\)/src\/util\/strencodings\.\1/g' test/lint/lint-locale-dependence.sh sed -i 's/src\\utilstrencodings\.cpp/src\\util\\strencodings\.cpp/' build_msvc/libbitcoinconsensus/libbitcoinconsensus.vcxproj -END VERIFY SCRIPT-
2018-10-22 15:51:11 -07:00
util/system.cpp \
Deduplicate the message verifying code The logic of verifying a message was duplicated in 2 places: src/qt/signverifymessagedialog.cpp SignVerifyMessageDialog::on_verifyMessageButton_VM_clicked() src/rpc/misc.cpp verifymessage() with the only difference being the result handling. Move the logic into a dedicated src/util/message.cpp MessageVerify() which returns a set of result codes, call it from the 2 places and just handle the results differently in the callers.
2019-11-19 15:49:35 +01:00
util/message.cpp \
scripted-diff: Move util files to separate directory. -BEGIN VERIFY SCRIPT- mkdir -p src/util git mv src/util.h src/util/system.h git mv src/util.cpp src/util/system.cpp git mv src/utilmemory.h src/util/memory.h git mv src/utilmoneystr.h src/util/moneystr.h git mv src/utilmoneystr.cpp src/util/moneystr.cpp git mv src/utilstrencodings.h src/util/strencodings.h git mv src/utilstrencodings.cpp src/util/strencodings.cpp git mv src/utiltime.h src/util/time.h git mv src/utiltime.cpp src/util/time.cpp sed -i 's/<util\.h>/<util\/system\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilmemory\.h>/<util\/memory\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilmoneystr\.h>/<util\/moneystr\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilstrencodings\.h>/<util\/strencodings\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utiltime\.h>/<util\/time\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/BITCOIN_UTIL_H/BITCOIN_UTIL_SYSTEM_H/g' src/util/system.h sed -i 's/BITCOIN_UTILMEMORY_H/BITCOIN_UTIL_MEMORY_H/g' src/util/memory.h sed -i 's/BITCOIN_UTILMONEYSTR_H/BITCOIN_UTIL_MONEYSTR_H/g' src/util/moneystr.h sed -i 's/BITCOIN_UTILSTRENCODINGS_H/BITCOIN_UTIL_STRENCODINGS_H/g' src/util/strencodings.h sed -i 's/BITCOIN_UTILTIME_H/BITCOIN_UTIL_TIME_H/g' src/util/time.h sed -i 's/ util\.\(h\|cpp\)/ util\/system\.\1/g' src/Makefile.am sed -i 's/utilmemory\.\(h\|cpp\)/util\/memory\.\1/g' src/Makefile.am sed -i 's/utilmoneystr\.\(h\|cpp\)/util\/moneystr\.\1/g' src/Makefile.am sed -i 's/utilstrencodings\.\(h\|cpp\)/util\/strencodings\.\1/g' src/Makefile.am sed -i 's/utiltime\.\(h\|cpp\)/util\/time\.\1/g' src/Makefile.am sed -i 's/-> util ->/-> util\/system ->/' test/lint/lint-circular-dependencies.sh sed -i 's/src\/util\.cpp/src\/util\/system\.cpp/g' test/lint/lint-format-strings.py test/lint/lint-locale-dependence.sh sed -i 's/src\/utilmoneystr\.cpp/src\/util\/moneystr\.cpp/g' test/lint/lint-locale-dependence.sh sed -i 's/src\/utilstrencodings\.\(h\|cpp\)/src\/util\/strencodings\.\1/g' test/lint/lint-locale-dependence.sh sed -i 's/src\\utilstrencodings\.cpp/src\\util\\strencodings\.cpp/' build_msvc/libbitcoinconsensus/libbitcoinconsensus.vcxproj -END VERIFY SCRIPT-
2018-10-22 15:51:11 -07:00
util/moneystr.cpp \
[build] Add several util units Adds the following util units and adds them to libbitcoin_util: - `util/url.cpp` takes `urlDecode` from `httpserver.cpp` - `util/error.cpp` takes `TransactionErrorString` from `node/transaction.cpp` and `AmountHighWarn` and `AmountErrMsg` from `ui_interface.cpp` - `util/fees.cpp` takes `StringForFeeReason` and `FeeModeFromString` from `policy/fees.cpp` - `util/rbf.cpp` takes `SignalsOptInRBF` from `policy/rbf.cpp` - 'util/validation.cpp` takes `FormatStateMessage` and `strMessageMagic` from 'validation.cpp`
2019-04-02 17:03:37 -04:00
util/rbf.cpp \
util: extract {Read,Write}BinaryFile() to its own files Extract `ReadBinaryFile()` and `WriteBinaryFile()` from `torcontrol.cpp` to its own `readwritefile.{h,cpp}` files, so that it can be reused from other modules.
2020-11-18 17:13:27 +01:00
util/readwritefile.cpp \
Add util::Settings struct and helper functions. Implement merging of settings from different sources (command line and config file) separately from parsing code in system.cpp, so it is easier to add new sources. Document current inconsistent merging behavior without changing it. This commit only adds new settings code without using it. The next commit calls the new code to replace existing code in system.cpp. Co-authored-by: John Newbery <john@johnnewbery.com>
2019-03-05 16:07:48 -05:00
util/settings.cpp \
refactor: Make TraceThread a non-template free function Also it is moved into its own module.
2021-04-13 20:44:46 +03:00
util/thread.cpp \
threads: introduce util/threadnames, refactor thread naming This work is prerequisite to attaching thread names to log lines and deadlock debug utilities. This code allows setting of an "internal" threadname per thread on platforms where thread_local is available. This commit also moves RenameThread() out of a more general module and adds a numeric suffix to disambiguate between threads with the same name. It explicitly names a few main threads using the new util::ThreadRename().
2018-06-13 14:50:59 -04:00
util/threadnames.cpp \
Add platform-independent float encoder/decoder
2021-05-16 17:23:17 -07:00
util/serfloat.cpp \
Abstract out some of the descriptor Span-parsing helpers
2019-07-30 14:53:05 -07:00
util/spanparsing.cpp \
scripted-diff: Move util files to separate directory. -BEGIN VERIFY SCRIPT- mkdir -p src/util git mv src/util.h src/util/system.h git mv src/util.cpp src/util/system.cpp git mv src/utilmemory.h src/util/memory.h git mv src/utilmoneystr.h src/util/moneystr.h git mv src/utilmoneystr.cpp src/util/moneystr.cpp git mv src/utilstrencodings.h src/util/strencodings.h git mv src/utilstrencodings.cpp src/util/strencodings.cpp git mv src/utiltime.h src/util/time.h git mv src/utiltime.cpp src/util/time.cpp sed -i 's/<util\.h>/<util\/system\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilmemory\.h>/<util\/memory\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilmoneystr\.h>/<util\/moneystr\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilstrencodings\.h>/<util\/strencodings\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utiltime\.h>/<util\/time\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/BITCOIN_UTIL_H/BITCOIN_UTIL_SYSTEM_H/g' src/util/system.h sed -i 's/BITCOIN_UTILMEMORY_H/BITCOIN_UTIL_MEMORY_H/g' src/util/memory.h sed -i 's/BITCOIN_UTILMONEYSTR_H/BITCOIN_UTIL_MONEYSTR_H/g' src/util/moneystr.h sed -i 's/BITCOIN_UTILSTRENCODINGS_H/BITCOIN_UTIL_STRENCODINGS_H/g' src/util/strencodings.h sed -i 's/BITCOIN_UTILTIME_H/BITCOIN_UTIL_TIME_H/g' src/util/time.h sed -i 's/ util\.\(h\|cpp\)/ util\/system\.\1/g' src/Makefile.am sed -i 's/utilmemory\.\(h\|cpp\)/util\/memory\.\1/g' src/Makefile.am sed -i 's/utilmoneystr\.\(h\|cpp\)/util\/moneystr\.\1/g' src/Makefile.am sed -i 's/utilstrencodings\.\(h\|cpp\)/util\/strencodings\.\1/g' src/Makefile.am sed -i 's/utiltime\.\(h\|cpp\)/util\/time\.\1/g' src/Makefile.am sed -i 's/-> util ->/-> util\/system ->/' test/lint/lint-circular-dependencies.sh sed -i 's/src\/util\.cpp/src\/util\/system\.cpp/g' test/lint/lint-format-strings.py test/lint/lint-locale-dependence.sh sed -i 's/src\/utilmoneystr\.cpp/src\/util\/moneystr\.cpp/g' test/lint/lint-locale-dependence.sh sed -i 's/src\/utilstrencodings\.\(h\|cpp\)/src\/util\/strencodings\.\1/g' test/lint/lint-locale-dependence.sh sed -i 's/src\\utilstrencodings\.cpp/src\\util\\strencodings\.cpp/' build_msvc/libbitcoinconsensus/libbitcoinconsensus.vcxproj -END VERIFY SCRIPT-
2018-10-22 15:51:11 -07:00
util/strencodings.cpp \
util: Add Join helper to join a list of strings
2019-08-20 14:51:43 -04:00
util/string.cpp \
Add syscall sandboxing (seccomp-bpf)
2021-10-01 13:53:59 +00:00
util/syscall_sandbox.cpp \
scripted-diff: Move util files to separate directory. -BEGIN VERIFY SCRIPT- mkdir -p src/util git mv src/util.h src/util/system.h git mv src/util.cpp src/util/system.cpp git mv src/utilmemory.h src/util/memory.h git mv src/utilmoneystr.h src/util/moneystr.h git mv src/utilmoneystr.cpp src/util/moneystr.cpp git mv src/utilstrencodings.h src/util/strencodings.h git mv src/utilstrencodings.cpp src/util/strencodings.cpp git mv src/utiltime.h src/util/time.h git mv src/utiltime.cpp src/util/time.cpp sed -i 's/<util\.h>/<util\/system\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilmemory\.h>/<util\/memory\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilmoneystr\.h>/<util\/moneystr\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilstrencodings\.h>/<util\/strencodings\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utiltime\.h>/<util\/time\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/BITCOIN_UTIL_H/BITCOIN_UTIL_SYSTEM_H/g' src/util/system.h sed -i 's/BITCOIN_UTILMEMORY_H/BITCOIN_UTIL_MEMORY_H/g' src/util/memory.h sed -i 's/BITCOIN_UTILMONEYSTR_H/BITCOIN_UTIL_MONEYSTR_H/g' src/util/moneystr.h sed -i 's/BITCOIN_UTILSTRENCODINGS_H/BITCOIN_UTIL_STRENCODINGS_H/g' src/util/strencodings.h sed -i 's/BITCOIN_UTILTIME_H/BITCOIN_UTIL_TIME_H/g' src/util/time.h sed -i 's/ util\.\(h\|cpp\)/ util\/system\.\1/g' src/Makefile.am sed -i 's/utilmemory\.\(h\|cpp\)/util\/memory\.\1/g' src/Makefile.am sed -i 's/utilmoneystr\.\(h\|cpp\)/util\/moneystr\.\1/g' src/Makefile.am sed -i 's/utilstrencodings\.\(h\|cpp\)/util\/strencodings\.\1/g' src/Makefile.am sed -i 's/utiltime\.\(h\|cpp\)/util\/time\.\1/g' src/Makefile.am sed -i 's/-> util ->/-> util\/system ->/' test/lint/lint-circular-dependencies.sh sed -i 's/src\/util\.cpp/src\/util\/system\.cpp/g' test/lint/lint-format-strings.py test/lint/lint-locale-dependence.sh sed -i 's/src\/utilmoneystr\.cpp/src\/util\/moneystr\.cpp/g' test/lint/lint-locale-dependence.sh sed -i 's/src\/utilstrencodings\.\(h\|cpp\)/src\/util\/strencodings\.\1/g' test/lint/lint-locale-dependence.sh sed -i 's/src\\utilstrencodings\.cpp/src\\util\\strencodings\.cpp/' build_msvc/libbitcoinconsensus/libbitcoinconsensus.vcxproj -END VERIFY SCRIPT-
2018-10-22 15:51:11 -07:00
util/time.cpp \
util: Add RAII TokenPipe
2021-01-26 19:36:41 +01:00
util/tokenpipe.cpp \
autotools: switch to autotools buildsystem
2013-05-27 19:55:01 -04:00
$(BITCOIN_CORE_H)
Drop unintended bitcoin-tx dependency on libevent Don't include util/url.cpp to libbitcoin_util.a when libevent isn't available. This fixes a compile error trying to build bitcoin-tx without libevent reported by Luke Dashjr in https://github.com/bitcoin/bitcoin/issues/18465 Fixes #18465
2020-04-02 08:28:11 -04:00
if USE_LIBEVENT
libbitcoin_util_a_SOURCES += util/url.cpp
endif
Remove unnecessary dependencies for bitcoin-cli This commit removes all the unnecessary dependencies (key, core, netbase, sync, ...) from bitcoin-cli. To do this it shards the chain parameters into BaseParams, which contains just the RPC port and data directory (as used by utils and bitcoin-cli) and Params, with the rest.
2014-06-19 15:10:04 +02:00
# cli: shared between bitcoin-cli and bitcoin-qt
build: Split hardening/fPIE options out This allows for fPIE to be used selectively.
2015-11-09 20:50:25 -05:00
libbitcoin_cli_a_CPPFLAGS = $(AM_CPPFLAGS) $(BITCOIN_INCLUDES)
libbitcoin_cli_a_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS)
bitcoin-cli: remove unneeded dependencies (only code movement) Remove unnecessary dependencies for bitcoin-cli (leveldb, berkelydb, wallet, RPC server) Build system changes: - split libbitcoin.a into libbitcoin_common.a, libbitcoin_server.a and libbitcoin_cli.a Code changes (movement only): - split up HelpMessage into HelpMessage in init.cpp and HelpMessageCli in rpcclient.cpp - move uiInterface from init.cpp to util.cpp
2013-11-27 15:41:12 +01:00
libbitcoin_cli_a_SOURCES = \
add stdin helpers for password input support
2018-07-19 23:48:38 +09:00
compat/stdin.h \
compat/stdin.cpp \
move rpc* to rpc/
2016-01-15 11:55:17 +11:00
rpc/client.cpp \
bitcoin-cli: remove unneeded dependencies (only code movement) Remove unnecessary dependencies for bitcoin-cli (leveldb, berkelydb, wallet, RPC server) Build system changes: - split libbitcoin.a into libbitcoin_common.a, libbitcoin_server.a and libbitcoin_cli.a Code changes (movement only): - split up HelpMessage into HelpMessage in init.cpp and HelpMessageCli in rpcclient.cpp - move uiInterface from init.cpp to util.cpp
2013-11-27 15:41:12 +01:00
$(BITCOIN_CORE_H)
Remove unnecessary dependencies for bitcoin-cli This commit removes all the unnecessary dependencies (key, core, netbase, sync, ...) from bitcoin-cli. To do this it shards the chain parameters into BaseParams, which contains just the RPC port and data directory (as used by utils and bitcoin-cli) and Params, with the rest.
2014-06-19 15:10:04 +02:00
nodist_libbitcoin_util_a_SOURCES = $(srcdir)/obj/build.h
autotools: switch to autotools buildsystem
2013-05-27 19:55:01 -04:00
#
build: multiprocess autotools changes autoconf and automake changes to support multiprocess gui/node/wallet execution. This adds a new --enable-multiprocess flag, and build configuration code to detect libraries needed for multiprocess support. The --enable-multiprocess flag builds new bitcoin-node and bitcoin-gui executables, which are updated in https://github.com/bitcoin/bitcoin/pull/10102 to communicate across processes. But for now they are functionally equivalent to existing bitcoind and bitcoin-qt executables.
2019-07-10 13:46:31 -04:00
# bitcoind & bitcoin-node binaries #
bitcoin_daemon_sources = bitcoind.cpp
bitcoin_bin_cppflags = $(AM_CPPFLAGS) $(BITCOIN_INCLUDES)
bitcoin_bin_cxxflags = $(AM_CXXFLAGS) $(PIE_FLAGS)
build: split PTHREAD_* flags out of AM_LDFLAGS Note that with this change we are no-longer including PTHREAD_* flags when building libbitcoinconsensus. Also note that we are including PTHREAD_LIBS in AM_PTHREAD_FLAGS
2020-07-17 14:43:29 +08:00
bitcoin_bin_ldflags = $(RELDFLAGS) $(AM_LDFLAGS) $(LIBTOOL_APP_LDFLAGS) $(PTHREAD_FLAGS)
Format build flags in src/Makefile.am.
2014-11-21 12:24:50 +13:00
if TARGET_WINDOWS
build: multiprocess autotools changes autoconf and automake changes to support multiprocess gui/node/wallet execution. This adds a new --enable-multiprocess flag, and build configuration code to detect libraries needed for multiprocess support. The --enable-multiprocess flag builds new bitcoin-node and bitcoin-gui executables, which are updated in https://github.com/bitcoin/bitcoin/pull/10102 to communicate across processes. But for now they are functionally equivalent to existing bitcoind and bitcoin-qt executables.
2019-07-10 13:46:31 -04:00
bitcoin_daemon_sources += bitcoind-res.rc
Format build flags in src/Makefile.am.
2014-11-21 12:24:50 +13:00
endif
build: multiprocess autotools changes autoconf and automake changes to support multiprocess gui/node/wallet execution. This adds a new --enable-multiprocess flag, and build configuration code to detect libraries needed for multiprocess support. The --enable-multiprocess flag builds new bitcoin-node and bitcoin-gui executables, which are updated in https://github.com/bitcoin/bitcoin/pull/10102 to communicate across processes. But for now they are functionally equivalent to existing bitcoind and bitcoin-qt executables.
2019-07-10 13:46:31 -04:00
bitcoin_bin_ldadd = \
Create getaddressinfo RPC and deprecate parts of validateaddress Moves the parts of validateaddress which require the wallet into getaddressinfo which is part of the wallet RPCs. Mark those parts of validateaddress which require the wallet as deprecated. Validateaddress will call getaddressinfo for the data that both share for right now. Moves IsMine functions to libbitcoin_common and then links libbitcoin_wallet before libbitcoin_common in order to prevent linker errors since IsMine is no longer used in libbitcoin_server.
2017-06-12 18:53:46 -07:00
$(LIBBITCOIN_WALLET) \
Remove unnecessary dependencies for bitcoin-cli This commit removes all the unnecessary dependencies (key, core, netbase, sync, ...) from bitcoin-cli. To do this it shards the chain parameters into BaseParams, which contains just the RPC port and data directory (as used by utils and bitcoin-cli) and Params, with the rest.
2014-06-19 15:10:04 +02:00
$(LIBBITCOIN_COMMON) \
Revert "Merge #16367: Multiprocess build support" This reverts the changes made in merge commit 1b307613604883daea4913a65da30ae073c9dc4d: This reverts commit b919efadff3d0393f4a8c3c1dc735f7ac5c665bb. This reverts commit d54f64c6c700be0604190f52c84fc5f1cdd9f02f. This reverts commit 787f40668dc15980c3d6de028d7950c08175d84a. This reverts commit d6306466626635e6fee44385e6a688c8dc118eb5. This reverts commit e6e44eedd56ecaf59f3fabf8e07ab7dee0ddb1b6.
2020-04-10 19:36:19 -04:00
$(LIBBITCOIN_UTIL) \
build: multiprocess autotools changes autoconf and automake changes to support multiprocess gui/node/wallet execution. This adds a new --enable-multiprocess flag, and build configuration code to detect libraries needed for multiprocess support. The --enable-multiprocess flag builds new bitcoin-node and bitcoin-gui executables, which are updated in https://github.com/bitcoin/bitcoin/pull/10102 to communicate across processes. But for now they are functionally equivalent to existing bitcoind and bitcoin-qt executables.
2019-07-10 13:46:31 -04:00
$(LIBUNIVALUE) \
crypter: shuffle Makefile so that crypto can be used by the wallet Wallet must come before crypto, otherwise linking fails on some platforms. Includes a tangentially-related general cleanup rather than making the Makefile sloppier.
2015-03-26 19:15:28 -04:00
$(LIBBITCOIN_ZMQ) \
Build: Consensus: Move consensus files from common to its own module/package
2015-11-20 16:46:03 +01:00
$(LIBBITCOIN_CONSENSUS) \
Remove unnecessary dependencies for bitcoin-cli This commit removes all the unnecessary dependencies (key, core, netbase, sync, ...) from bitcoin-cli. To do this it shards the chain parameters into BaseParams, which contains just the RPC port and data directory (as used by utils and bitcoin-cli) and Params, with the rest.
2014-06-19 15:10:04 +02:00
$(LIBBITCOIN_CRYPTO) \
Cleanup LevelDB library dependencies
2013-11-12 20:09:55 +00:00
$(LIBLEVELDB) \
Always build and link libsecp256k1
2014-11-05 07:58:37 -08:00
$(LIBMEMENV) \
$(LIBSECP256K1)
secp256k1: Add build-side changes for libsecp256k1 Note: This is added to our existing automake targets rather than as a libtool-style lib. The switch to libtool-style targets can come later if it proves to not add any complications.
2014-06-06 10:57:28 -04:00
build: header-only Boost
2022-02-09 18:16:34 +00:00
bitcoin_bin_ldadd += $(BDB_LIBS) $(MINIUPNPC_LIBS) $(NATPMP_LIBS) $(EVENT_PTHREADS_LIBS) $(EVENT_LIBS) $(ZMQ_LIBS) $(SQLITE_LIBS)
build: multiprocess autotools changes autoconf and automake changes to support multiprocess gui/node/wallet execution. This adds a new --enable-multiprocess flag, and build configuration code to detect libraries needed for multiprocess support. The --enable-multiprocess flag builds new bitcoin-node and bitcoin-gui executables, which are updated in https://github.com/bitcoin/bitcoin/pull/10102 to communicate across processes. But for now they are functionally equivalent to existing bitcoind and bitcoin-qt executables.
2019-07-10 13:46:31 -04:00
multiprocess: Add bitcoin-node process spawning support Add bitcoin-node startup code to let it spawn and be spawned by other processes
2017-12-05 15:57:12 -05:00
bitcoind_SOURCES = $(bitcoin_daemon_sources) init/bitcoind.cpp
build: multiprocess autotools changes autoconf and automake changes to support multiprocess gui/node/wallet execution. This adds a new --enable-multiprocess flag, and build configuration code to detect libraries needed for multiprocess support. The --enable-multiprocess flag builds new bitcoin-node and bitcoin-gui executables, which are updated in https://github.com/bitcoin/bitcoin/pull/10102 to communicate across processes. But for now they are functionally equivalent to existing bitcoind and bitcoin-qt executables.
2019-07-10 13:46:31 -04:00
bitcoind_CPPFLAGS = $(bitcoin_bin_cppflags)
bitcoind_CXXFLAGS = $(bitcoin_bin_cxxflags)
bitcoind_LDFLAGS = $(bitcoin_bin_ldflags)
scripted-diff: Rename libbitcoin_server.a to libbitcoin_node.a Goal along with namespacing PR #23497 is to have src/node/ code in node:: namespace in libbitcoin_node.a library -BEGIN VERIFY SCRIPT- bash -c ' # Bash shell needed for brace expansion {a,b} git mv build_msvc/libbitcoin_{server,node} git mv build_msvc/libbitcoin_node/libbitcoin_{server,node}.vcxproj.in ren() { git grep -l "$1" src build_msvc | xargs sed -i "s/$1/$2/g"; } ren LIBBITCOIN_{SERVER,NODE} ren libbitcoin_{server,node} ' -END VERIFY SCRIPT-
2021-12-20 10:53:01 -05:00
bitcoind_LDADD = $(LIBBITCOIN_NODE) $(bitcoin_bin_ldadd)
build: multiprocess autotools changes autoconf and automake changes to support multiprocess gui/node/wallet execution. This adds a new --enable-multiprocess flag, and build configuration code to detect libraries needed for multiprocess support. The --enable-multiprocess flag builds new bitcoin-node and bitcoin-gui executables, which are updated in https://github.com/bitcoin/bitcoin/pull/10102 to communicate across processes. But for now they are functionally equivalent to existing bitcoind and bitcoin-qt executables.
2019-07-10 13:46:31 -04:00
multiprocess: Add bitcoin-node process spawning support Add bitcoin-node startup code to let it spawn and be spawned by other processes
2017-12-05 15:57:12 -05:00
bitcoin_node_SOURCES = $(bitcoin_daemon_sources) init/bitcoin-node.cpp
build: multiprocess autotools changes autoconf and automake changes to support multiprocess gui/node/wallet execution. This adds a new --enable-multiprocess flag, and build configuration code to detect libraries needed for multiprocess support. The --enable-multiprocess flag builds new bitcoin-node and bitcoin-gui executables, which are updated in https://github.com/bitcoin/bitcoin/pull/10102 to communicate across processes. But for now they are functionally equivalent to existing bitcoind and bitcoin-qt executables.
2019-07-10 13:46:31 -04:00
bitcoin_node_CPPFLAGS = $(bitcoin_bin_cppflags)
bitcoin_node_CXXFLAGS = $(bitcoin_bin_cxxflags)
bitcoin_node_LDFLAGS = $(bitcoin_bin_ldflags)
scripted-diff: Rename libbitcoin_server.a to libbitcoin_node.a Goal along with namespacing PR #23497 is to have src/node/ code in node:: namespace in libbitcoin_node.a library -BEGIN VERIFY SCRIPT- bash -c ' # Bash shell needed for brace expansion {a,b} git mv build_msvc/libbitcoin_{server,node} git mv build_msvc/libbitcoin_node/libbitcoin_{server,node}.vcxproj.in ren() { git grep -l "$1" src build_msvc | xargs sed -i "s/$1/$2/g"; } ren LIBBITCOIN_{SERVER,NODE} ren libbitcoin_{server,node} ' -END VERIFY SCRIPT-
2021-12-20 10:53:01 -05:00
bitcoin_node_LDADD = $(LIBBITCOIN_NODE) $(bitcoin_bin_ldadd) $(LIBBITCOIN_IPC) $(LIBMULTIPROCESS_LIBS)
autotools: switch to autotools buildsystem
2013-05-27 19:55:01 -04:00
Format build flags in src/Makefile.am.
2014-11-21 12:24:50 +13:00
# bitcoin-cli binary #
bitcoin_cli_SOURCES = bitcoin-cli.cpp
build: Split hardening/fPIE options out This allows for fPIE to be used selectively.
2015-11-09 20:50:25 -05:00
bitcoin_cli_CPPFLAGS = $(AM_CPPFLAGS) $(BITCOIN_INCLUDES) $(EVENT_CFLAGS)
bitcoin_cli_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS)
build: split PTHREAD_* flags out of AM_LDFLAGS Note that with this change we are no-longer including PTHREAD_* flags when building libbitcoinconsensus. Also note that we are including PTHREAD_LIBS in AM_PTHREAD_FLAGS
2020-07-17 14:43:29 +08:00
bitcoin_cli_LDFLAGS = $(RELDFLAGS) $(AM_LDFLAGS) $(LIBTOOL_APP_LDFLAGS) $(PTHREAD_FLAGS)
Format build flags in src/Makefile.am.
2014-11-21 12:24:50 +13:00
win32: add version info to bitcoind.exe TODO: Add icon info
2013-09-18 15:53:29 -04:00
if TARGET_WINDOWS
Format build flags in src/Makefile.am.
2014-11-21 12:24:50 +13:00
bitcoin_cli_SOURCES += bitcoin-cli-res.rc
win32: add version info to bitcoind.exe TODO: Add icon info
2013-09-18 15:53:29 -04:00
endif
makefile.am: split long lines into one file per line This makes it easier to read diffs. Cosmetic change to build system only.
2014-01-11 15:22:07 +01:00
bitcoin_cli_LDADD = \
Remove unnecessary dependencies for bitcoin-cli This commit removes all the unnecessary dependencies (key, core, netbase, sync, ...) from bitcoin-cli. To do this it shards the chain parameters into BaseParams, which contains just the RPC port and data directory (as used by utils and bitcoin-cli) and Params, with the rest.
2014-06-19 15:10:04 +02:00
$(LIBBITCOIN_CLI) \
[Univalue] add univalue over subtree similar to secp256k1 include and compile univalue over a subtree
2015-09-04 16:11:34 +02:00
$(LIBUNIVALUE) \
Always require OS randomness when generating secret keys
2016-04-16 12:25:12 +02:00
$(LIBBITCOIN_UTIL) \
crypto: cleanup sha256 build Rather than appending all possible cpu variants to all targets, create a convenience variable that encompasses all.
2018-06-06 15:20:34 -04:00
$(LIBBITCOIN_CRYPTO)
secp256k1: Add build-side changes for libsecp256k1 Note: This is added to our existing automake targets rather than as a libtool-style lib. The switch to libtool-style targets can come later if it proves to not add any complications.
2014-06-06 10:57:28 -04:00
build: header-only Boost
2022-02-09 18:16:34 +00:00
bitcoin_cli_LDADD += $(EVENT_LIBS)
Add separate bitcoin-rpc client This adds an executable `bitcoin-rpc` that only serves as a Bitcoin RPC client. The commit does not remove RPC functionality from the `bitcoind` yet, this functionality should be deprecated but is left for a later version to give users some time to switch.
2013-10-11 23:09:59 +02:00
#
Add "bitcoin-tx" command line utility and supporting modules. This is a simple utility that provides command line manipulation of a hex-encoded TX. The utility takes a hex string on the command line as input, performs zero or more mutations, and outputs a hex string to standard output. This utility is also an intentional exercise of the "bitcoin library" concept. It is designed to require minimal libraries, and works entirely without need for any RPC or P2P communication. See "bitcoin-tx --help" for command and options summary.
2014-07-29 11:12:44 -04:00
# bitcoin-tx binary #
Format build flags in src/Makefile.am.
2014-11-21 12:24:50 +13:00
bitcoin_tx_SOURCES = bitcoin-tx.cpp
build: Split hardening/fPIE options out This allows for fPIE to be used selectively.
2015-11-09 20:50:25 -05:00
bitcoin_tx_CPPFLAGS = $(AM_CPPFLAGS) $(BITCOIN_INCLUDES)
bitcoin_tx_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS)
build: split PTHREAD_* flags out of AM_LDFLAGS Note that with this change we are no-longer including PTHREAD_* flags when building libbitcoinconsensus. Also note that we are including PTHREAD_LIBS in AM_PTHREAD_FLAGS
2020-07-17 14:43:29 +08:00
bitcoin_tx_LDFLAGS = $(RELDFLAGS) $(AM_LDFLAGS) $(LIBTOOL_APP_LDFLAGS) $(PTHREAD_FLAGS)
Format build flags in src/Makefile.am.
2014-11-21 12:24:50 +13:00
Update Windows resource files (and add one for bitcoin-tx)
2015-05-02 15:30:38 +00:00
if TARGET_WINDOWS
bitcoin_tx_SOURCES += bitcoin-tx-res.rc
endif
Add "bitcoin-tx" command line utility and supporting modules. This is a simple utility that provides command line manipulation of a hex-encoded TX. The utility takes a hex string on the command line as input, performs zero or more mutations, and outputs a hex string to standard output. This utility is also an intentional exercise of the "bitcoin library" concept. It is designed to require minimal libraries, and works entirely without need for any RPC or P2P communication. See "bitcoin-tx --help" for command and options summary.
2014-07-29 11:12:44 -04:00
bitcoin_tx_LDADD = \
[Univalue] add univalue over subtree similar to secp256k1 include and compile univalue over a subtree
2015-09-04 16:11:34 +02:00
$(LIBUNIVALUE) \
Add "bitcoin-tx" command line utility and supporting modules. This is a simple utility that provides command line manipulation of a hex-encoded TX. The utility takes a hex string on the command line as input, performs zero or more mutations, and outputs a hex string to standard output. This utility is also an intentional exercise of the "bitcoin library" concept. It is designed to require minimal libraries, and works entirely without need for any RPC or P2P communication. See "bitcoin-tx --help" for command and options summary.
2014-07-29 11:12:44 -04:00
$(LIBBITCOIN_COMMON) \
$(LIBBITCOIN_UTIL) \
Build: Consensus: Move consensus files from common to its own module/package
2015-11-20 16:46:03 +01:00
$(LIBBITCOIN_CONSENSUS) \
Always build and link libsecp256k1
2014-11-05 07:58:37 -08:00
$(LIBBITCOIN_CRYPTO) \
Format build flags in src/Makefile.am.
2014-11-21 12:24:50 +13:00
$(LIBSECP256K1)
Add "bitcoin-tx" command line utility and supporting modules. This is a simple utility that provides command line manipulation of a hex-encoded TX. The utility takes a hex string on the command line as input, performs zero or more mutations, and outputs a hex string to standard output. This utility is also an intentional exercise of the "bitcoin library" concept. It is designed to require minimal libraries, and works entirely without need for any RPC or P2P communication. See "bitcoin-tx --help" for command and options summary.
2014-07-29 11:12:44 -04:00
#
Add separate bitcoin-rpc client This adds an executable `bitcoin-rpc` that only serves as a Bitcoin RPC client. The commit does not remove RPC functionality from the `bitcoind` yet, this functionality should be deprecated but is left for a later version to give users some time to switch.
2013-10-11 23:09:59 +02:00
[tools] Add wallet inspection and modification tool This commit adds wallet-tool, a tool for creating and interacting with wallet files. Original implementation was by Jonas Schnelli <dev@jonasschnelli.ch> with modifications by John Newbery <john@johnnewbery.com> MSVC files were provided by Chun Kuan Lee <ken2812221@gmail.com>: build: Add MSVC project files for bitcoin-wallet-tool
2016-09-16 16:45:36 +02:00
# bitcoin-wallet binary #
bitcoin_wallet_SOURCES = bitcoin-wallet.cpp
multiprocess: Add new bitcoin-gui, bitcoin-qt, bitcoin-wallet init implementations Add separate init implementations instead of sharing existing bitcoind and bitcoin-node ones, so they can start to be differentiated in upcoming commits with node and wallet code no longer linked into the bitcoin-gui binary and wallet code no longer linked into the bitcoin-node binary.
2017-12-05 15:57:12 -05:00
bitcoin_wallet_SOURCES += init/bitcoin-wallet.cpp
build: multiprocess autotools changes autoconf and automake changes to support multiprocess gui/node/wallet execution. This adds a new --enable-multiprocess flag, and build configuration code to detect libraries needed for multiprocess support. The --enable-multiprocess flag builds new bitcoin-node and bitcoin-gui executables, which are updated in https://github.com/bitcoin/bitcoin/pull/10102 to communicate across processes. But for now they are functionally equivalent to existing bitcoind and bitcoin-qt executables.
2019-07-10 13:46:31 -04:00
bitcoin_wallet_CPPFLAGS = $(bitcoin_bin_cppflags)
bitcoin_wallet_CXXFLAGS = $(bitcoin_bin_cxxflags)
bitcoin_wallet_LDFLAGS = $(bitcoin_bin_ldflags)
build: Drop unneeded dependencies for bitcoin-wallet tool
2021-10-24 16:54:54 +03:00
bitcoin_wallet_LDADD = \
$(LIBBITCOIN_WALLET_TOOL) \
$(LIBBITCOIN_WALLET) \
$(LIBBITCOIN_COMMON) \
$(LIBBITCOIN_UTIL) \
$(LIBUNIVALUE) \
$(LIBBITCOIN_CONSENSUS) \
$(LIBBITCOIN_CRYPTO) \
$(LIBSECP256K1) \
$(BDB_LIBS) \
$(SQLITE_LIBS)
[tools] Add wallet inspection and modification tool This commit adds wallet-tool, a tool for creating and interacting with wallet files. Original implementation was by Jonas Schnelli <dev@jonasschnelli.ch> with modifications by John Newbery <john@johnnewbery.com> MSVC files were provided by Chun Kuan Lee <ken2812221@gmail.com>: build: Add MSVC project files for bitcoin-wallet-tool
2016-09-16 16:45:36 +02:00
if TARGET_WINDOWS
bitcoin_wallet_SOURCES += bitcoin-wallet-res.rc
endif
#
Add bitcoin-util command line utility
2020-09-10 08:09:07 +10:00
# bitcoin-util binary #
bitcoin_util_SOURCES = bitcoin-util.cpp
bitcoin_util_CPPFLAGS = $(AM_CPPFLAGS) $(BITCOIN_INCLUDES)
bitcoin_util_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS)
build: don't build or use Boost Thread
2021-02-02 10:57:06 +08:00
bitcoin_util_LDFLAGS = $(RELDFLAGS) $(AM_LDFLAGS) $(LIBTOOL_APP_LDFLAGS) $(PTHREAD_FLAGS)
Add bitcoin-util command line utility
2020-09-10 08:09:07 +10:00
if TARGET_WINDOWS
bitcoin_util_SOURCES += bitcoin-util-res.rc
endif
bitcoin_util_LDADD = \
$(LIBBITCOIN_COMMON) \
$(LIBBITCOIN_UTIL) \
$(LIBUNIVALUE) \
$(LIBBITCOIN_CONSENSUS) \
$(LIBBITCOIN_CRYPTO) \
$(LIBSECP256K1)
#
build: Add example bitcoin-chainstate executable The bitcoin-chainstate executable serves to surface the dependencies required by a program wishing to use Bitcoin Core's consensus engine as it is right now. More broadly, the _SOURCES list serves as a guiding "North Star" for the libbitcoinkernel project: as we decouple more and more modules of the codebase from our consensus engine, this _SOURCES list will grow shorter and shorter. One day, only what is critical to our consensus engine will remain. Right now, it's "the minimal list of files to link in to even use our consensus engine". [META] In a future commit the libbitcoinkernel library will be extracted from bitcoin-chainstate, and the libbitcoinkernel library's _SOURCES list will be the list that we aim to shrink.
2021-09-01 15:46:51 -04:00
# bitcoin-chainstate binary #
build: Extract the libbitcoinkernel library I strongly recommend reviewing with the following git-diff flags: --patience --color-moved=dimmed-zebra Extract out a libbitcoinkernel library linking in all files necessary for using our consensus engine as-is. Link bitcoin-chainstate against it. See previous commit "build: Add example bitcoin-chainstate executable" for more context. We explicitly specify -fvisibility=default, which effectively overrides the effects of --enable-reduced-exports since libbitcoinkernel requires default symbol visibility When compiling for mingw-w64, specify -static in both: - ..._la_CXXFLAGS so that libtool will avoid building two versions of each object (one PIC, one non-PIC). We just need the one that is suitable for static linking. - ..._la_LDFLAGS so that libtool will create a static library. If we don't specify this, then libtool will prefer the non-static PIC version of the object, which is built with -DDLL_EXPORT -DPIC for mingw-w64 targets. This can cause symbol resolution problems when we link this library against an executable that does specify -all-static, since that will be built without the -DDLL_EXPORT flag. Unfortunately, this means that for mingw-w64 we can only build a static version of the library for now. This will be fixed. However, on other targets, the shared library creation works fine. ----- Note to users: You need to either specify: --enable-experimental-util-chainstate or, --with-experimental-kernel-lib To build the libbitcionkernel library. See the configure help for more details. build shared libbitcoinkernel where we can
2021-12-21 20:10:05 -05:00
bitcoin_chainstate_SOURCES = bitcoin-chainstate.cpp
bitcoin_chainstate_CPPFLAGS = $(AM_CPPFLAGS) $(BITCOIN_INCLUDES)
bitcoin_chainstate_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS)
build: Remove LIBTOOL_APP_LDFLAGS for bitcoin-chainstate See added comment. Note that this won't actually have any effect until we add the mingw-w64 DLL fix since LIBTOOL_APP_LDFLAGS is undefined for other platforms.
2022-04-27 20:03:58 +00:00
# $(LIBTOOL_APP_LDFLAGS) deliberately omitted here so that we can test linking
# bitcoin-chainstate against libbitcoinkernel as a shared or static library by
# setting --{en,dis}able-shared.
bitcoin_chainstate_LDFLAGS = $(RELDFLAGS) $(AM_LDFLAGS) $(PTHREAD_FLAGS)
build: Extract the libbitcoinkernel library I strongly recommend reviewing with the following git-diff flags: --patience --color-moved=dimmed-zebra Extract out a libbitcoinkernel library linking in all files necessary for using our consensus engine as-is. Link bitcoin-chainstate against it. See previous commit "build: Add example bitcoin-chainstate executable" for more context. We explicitly specify -fvisibility=default, which effectively overrides the effects of --enable-reduced-exports since libbitcoinkernel requires default symbol visibility When compiling for mingw-w64, specify -static in both: - ..._la_CXXFLAGS so that libtool will avoid building two versions of each object (one PIC, one non-PIC). We just need the one that is suitable for static linking. - ..._la_LDFLAGS so that libtool will create a static library. If we don't specify this, then libtool will prefer the non-static PIC version of the object, which is built with -DDLL_EXPORT -DPIC for mingw-w64 targets. This can cause symbol resolution problems when we link this library against an executable that does specify -all-static, since that will be built without the -DDLL_EXPORT flag. Unfortunately, this means that for mingw-w64 we can only build a static version of the library for now. This will be fixed. However, on other targets, the shared library creation works fine. ----- Note to users: You need to either specify: --enable-experimental-util-chainstate or, --with-experimental-kernel-lib To build the libbitcionkernel library. See the configure help for more details. build shared libbitcoinkernel where we can
2021-12-21 20:10:05 -05:00
bitcoin_chainstate_LDADD = $(LIBBITCOINKERNEL)
#
# bitcoinkernel library #
if BUILD_BITCOIN_KERNEL_LIB
lib_LTLIBRARIES += $(LIBBITCOINKERNEL)
libbitcoinkernel_la_LDFLAGS = $(AM_LDFLAGS) -no-undefined $(RELDFLAGS) $(PTHREAD_FLAGS)
libbitcoinkernel_la_LIBADD = $(LIBBITCOIN_CRYPTO) $(LIBUNIVALUE) $(LIBLEVELDB) $(LIBMEMENV) $(LIBSECP256K1)
libbitcoinkernel_la_CPPFLAGS = $(AM_CPPFLAGS) -I$(builddir)/obj -I$(srcdir)/secp256k1/include -DBUILD_BITCOIN_INTERNAL $(BOOST_CPPFLAGS) $(LEVELDB_CPPFLAGS) -I$(srcdir)/$(UNIVALUE_INCLUDE_DIR_INT)
# libbitcoinkernel requires default symbol visibility, explicitly specify that
# here so that things still work even when user configures with
# --enable-reduce-exports
#
# Note this is a quick hack that will be removed as we incrementally define what
# to export from the library.
libbitcoinkernel_la_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS) -fvisibility=default
# TODO: For now, Specify -static in both CXXFLAGS and LDFLAGS when building for
# windows targets so libtool will only build a static version of this
# library. There are unresolved problems when building dll's for mingw-w64
# and attempting to statically embed libstdc++, libpthread, etc.
if TARGET_WINDOWS
libbitcoinkernel_la_LDFLAGS += -static
libbitcoinkernel_la_CXXFLAGS += -static
endif
docs: Add libbitcoinkernel_la_SOURCES explanation
2022-04-22 13:28:33 -04:00
# TODO: libbitcoinkernel is a work in progress consensus engine library, as more
# and more modules are decoupled from the consensus engine, this list will
Remove outdated comment
2022-07-01 14:34:25 +07:00
# shrink to only those which are absolutely necessary.
build: Extract the libbitcoinkernel library I strongly recommend reviewing with the following git-diff flags: --patience --color-moved=dimmed-zebra Extract out a libbitcoinkernel library linking in all files necessary for using our consensus engine as-is. Link bitcoin-chainstate against it. See previous commit "build: Add example bitcoin-chainstate executable" for more context. We explicitly specify -fvisibility=default, which effectively overrides the effects of --enable-reduced-exports since libbitcoinkernel requires default symbol visibility When compiling for mingw-w64, specify -static in both: - ..._la_CXXFLAGS so that libtool will avoid building two versions of each object (one PIC, one non-PIC). We just need the one that is suitable for static linking. - ..._la_LDFLAGS so that libtool will create a static library. If we don't specify this, then libtool will prefer the non-static PIC version of the object, which is built with -DDLL_EXPORT -DPIC for mingw-w64 targets. This can cause symbol resolution problems when we link this library against an executable that does specify -all-static, since that will be built without the -DDLL_EXPORT flag. Unfortunately, this means that for mingw-w64 we can only build a static version of the library for now. This will be fixed. However, on other targets, the shared library creation works fine. ----- Note to users: You need to either specify: --enable-experimental-util-chainstate or, --with-experimental-kernel-lib To build the libbitcionkernel library. See the configure help for more details. build shared libbitcoinkernel where we can
2021-12-21 20:10:05 -05:00
libbitcoinkernel_la_SOURCES = \
b-cs: Define G_TRANSLATION_FUN in bitcoinkernel.cpp [META] This is done in preparation for extracting libbitcoinkernel in a following commit. It seems logical that generally users of a library shouldn't need to export its own symbols to use the library.
2022-02-10 21:38:32 -05:00
kernel/bitcoinkernel.cpp \
build: Add example bitcoin-chainstate executable The bitcoin-chainstate executable serves to surface the dependencies required by a program wishing to use Bitcoin Core's consensus engine as it is right now. More broadly, the _SOURCES list serves as a guiding "North Star" for the libbitcoinkernel project: as we decouple more and more modules of the codebase from our consensus engine, this _SOURCES list will grow shorter and shorter. One day, only what is critical to our consensus engine will remain. Right now, it's "the minimal list of files to link in to even use our consensus engine". [META] In a future commit the libbitcoinkernel library will be extracted from bitcoin-chainstate, and the libbitcoinkernel library's _SOURCES list will be the list that we aim to shrink.
2021-09-01 15:46:51 -04:00
arith_uint256.cpp \
chain.cpp \
chainparamsbase.cpp \
chainparams.cpp \
clientversion.cpp \
coins.cpp \
compressor.cpp \
consensus/merkle.cpp \
consensus/tx_check.cpp \
consensus/tx_verify.cpp \
core_read.cpp \
dbwrapper.cpp \
deploymentinfo.cpp \
deploymentstatus.cpp \
flatfile.cpp \
fs.cpp \
hash.cpp \
Move init::SanityCheck to kernel::SanityCheck
2022-05-27 16:47:05 -04:00
kernel/checks.cpp \
coinstats: Move hasher codepath to kernel/coinstats As mentioned in a previous commit, the hashing codepath can now be moved to a separate file. This decouples callers that only rely on the hashing codepath from the indexing one. This is key for libbitcoinkernel, which needs to have the CoinsStats hashing codepath for AssumeUTXO, but does not wish to be coupled with indexes. Note that only the .cpp file is split in this commit, the header files will be split in a subsequent commit and the #includes to node/coinstats.h will be adjusted to only #include the necessary headers.
2022-02-16 15:31:02 -05:00
kernel/coinstats.cpp \
init: Initialize globals with kernel::Context's life ...instead of explicitly calling init::{Set,Unset}Globals. Cool thing about this is that in both the testing and bitcoin-chainstate codepaths, we no longer need to explicitly unset globals. The kernel::Context goes out of scope and the globals are unset "automatically". Also construct kernel::Context outside of AppInitSanityChecks()
2022-05-25 14:31:54 -04:00
kernel/context.cpp \
build: Add example bitcoin-chainstate executable The bitcoin-chainstate executable serves to surface the dependencies required by a program wishing to use Bitcoin Core's consensus engine as it is right now. More broadly, the _SOURCES list serves as a guiding "North Star" for the libbitcoinkernel project: as we decouple more and more modules of the codebase from our consensus engine, this _SOURCES list will grow shorter and shorter. One day, only what is critical to our consensus engine will remain. Right now, it's "the minimal list of files to link in to even use our consensus engine". [META] In a future commit the libbitcoinkernel library will be extracted from bitcoin-chainstate, and the libbitcoinkernel library's _SOURCES list will be the list that we aim to shrink.
2021-09-01 15:46:51 -04:00
key.cpp \
logging.cpp \
node/blockstorage.cpp \
node/chainstate.cpp \
scripted-diff: Avoid incompatibility with CMake AUTOUIC feature -BEGIN VERIFY SCRIPT- sed -i "s|node/ui_interface|node/interface_ui|g" $(git grep -l "node/ui_interface" ./src) git mv src/node/ui_interface.cpp src/node/interface_ui.cpp git mv src/node/ui_interface.h src/node/interface_ui.h sed -i "s|BITCOIN_NODE_UI_INTERFACE_H|BITCOIN_NODE_INTERFACE_UI_H|g" src/node/interface_ui.h -END VERIFY SCRIPT-
2022-06-14 10:38:51 +02:00
node/interface_ui.cpp \
build: Add example bitcoin-chainstate executable The bitcoin-chainstate executable serves to surface the dependencies required by a program wishing to use Bitcoin Core's consensus engine as it is right now. More broadly, the _SOURCES list serves as a guiding "North Star" for the libbitcoinkernel project: as we decouple more and more modules of the codebase from our consensus engine, this _SOURCES list will grow shorter and shorter. One day, only what is critical to our consensus engine will remain. Right now, it's "the minimal list of files to link in to even use our consensus engine". [META] In a future commit the libbitcoinkernel library will be extracted from bitcoin-chainstate, and the libbitcoinkernel library's _SOURCES list will be the list that we aim to shrink.
2021-09-01 15:46:51 -04:00
policy/feerate.cpp \
policy/fees.cpp \
policy/packages.cpp \
policy/policy.cpp \
policy/rbf.cpp \
policy/settings.cpp \
pow.cpp \
primitives/block.cpp \
primitives/transaction.cpp \
pubkey.cpp \
random.cpp \
randomenv.cpp \
scheduler.cpp \
script/interpreter.cpp \
script/script.cpp \
script/script_error.cpp \
script/sigcache.cpp \
script/standard.cpp \
shutdown.cpp \
signet.cpp \
support/cleanse.cpp \
support/lockedpool.cpp \
sync.cpp \
threadinterrupt.cpp \
txdb.cpp \
txmempool.cpp \
uint256.cpp \
util/bytevectorhash.cpp \
util/check: stop using lambda for Assert/Assume
2022-03-26 12:41:28 +10:00
util/check.cpp \
build: Add example bitcoin-chainstate executable The bitcoin-chainstate executable serves to surface the dependencies required by a program wishing to use Bitcoin Core's consensus engine as it is right now. More broadly, the _SOURCES list serves as a guiding "North Star" for the libbitcoinkernel project: as we decouple more and more modules of the codebase from our consensus engine, this _SOURCES list will grow shorter and shorter. One day, only what is critical to our consensus engine will remain. Right now, it's "the minimal list of files to link in to even use our consensus engine". [META] In a future commit the libbitcoinkernel library will be extracted from bitcoin-chainstate, and the libbitcoinkernel library's _SOURCES list will be the list that we aim to shrink.
2021-09-01 15:46:51 -04:00
util/getuniquepath.cpp \
util/hasher.cpp \
util/moneystr.cpp \
util/rbf.cpp \
util/serfloat.cpp \
util/settings.cpp \
util/strencodings.cpp \
Wrap boost::replace_all
2022-05-05 08:28:29 +02:00
util/string.cpp \
build: Add example bitcoin-chainstate executable The bitcoin-chainstate executable serves to surface the dependencies required by a program wishing to use Bitcoin Core's consensus engine as it is right now. More broadly, the _SOURCES list serves as a guiding "North Star" for the libbitcoinkernel project: as we decouple more and more modules of the codebase from our consensus engine, this _SOURCES list will grow shorter and shorter. One day, only what is critical to our consensus engine will remain. Right now, it's "the minimal list of files to link in to even use our consensus engine". [META] In a future commit the libbitcoinkernel library will be extracted from bitcoin-chainstate, and the libbitcoinkernel library's _SOURCES list will be the list that we aim to shrink.
2021-09-01 15:46:51 -04:00
util/syscall_sandbox.cpp \
util: Replace non-threadsafe strerror Some uses of non-threadsafe `strerror` have snuck into the code since they were removed in #4152. Add a wrapper `SysErrorString` for thread-safe strerror alternatives and replace all uses of `strerror` with this.
2022-04-20 16:17:19 +02:00
util/syserror.cpp \
build: Add example bitcoin-chainstate executable The bitcoin-chainstate executable serves to surface the dependencies required by a program wishing to use Bitcoin Core's consensus engine as it is right now. More broadly, the _SOURCES list serves as a guiding "North Star" for the libbitcoinkernel project: as we decouple more and more modules of the codebase from our consensus engine, this _SOURCES list will grow shorter and shorter. One day, only what is critical to our consensus engine will remain. Right now, it's "the minimal list of files to link in to even use our consensus engine". [META] In a future commit the libbitcoinkernel library will be extracted from bitcoin-chainstate, and the libbitcoinkernel library's _SOURCES list will be the list that we aim to shrink.
2021-09-01 15:46:51 -04:00
util/system.cpp \
util/thread.cpp \
util/threadnames.cpp \
util/time.cpp \
util/tokenpipe.cpp \
validation.cpp \
validationinterface.cpp \
versionbits.cpp \
warnings.cpp
ci: Build bitcoin-chainstate ...to make sure that the linker errors that arise from coupling regressions are caught by CI. Adding to the "no wallet" ci job as suggested by MarcoFalke.
2022-02-10 16:08:07 -05:00
# Required for obj/build.h to be generated first.
# More details: https://www.gnu.org/software/automake/manual/html_node/Built-Sources-Example.html
build: Extract the libbitcoinkernel library I strongly recommend reviewing with the following git-diff flags: --patience --color-moved=dimmed-zebra Extract out a libbitcoinkernel library linking in all files necessary for using our consensus engine as-is. Link bitcoin-chainstate against it. See previous commit "build: Add example bitcoin-chainstate executable" for more context. We explicitly specify -fvisibility=default, which effectively overrides the effects of --enable-reduced-exports since libbitcoinkernel requires default symbol visibility When compiling for mingw-w64, specify -static in both: - ..._la_CXXFLAGS so that libtool will avoid building two versions of each object (one PIC, one non-PIC). We just need the one that is suitable for static linking. - ..._la_LDFLAGS so that libtool will create a static library. If we don't specify this, then libtool will prefer the non-static PIC version of the object, which is built with -DDLL_EXPORT -DPIC for mingw-w64 targets. This can cause symbol resolution problems when we link this library against an executable that does specify -all-static, since that will be built without the -DDLL_EXPORT flag. Unfortunately, this means that for mingw-w64 we can only build a static version of the library for now. This will be fixed. However, on other targets, the shared library creation works fine. ----- Note to users: You need to either specify: --enable-experimental-util-chainstate or, --with-experimental-kernel-lib To build the libbitcionkernel library. See the configure help for more details. build shared libbitcoinkernel where we can
2021-12-21 20:10:05 -05:00
libbitcoinkernel_la-clientversion.l$(OBJEXT): obj/build.h
endif # BUILD_BITCOIN_KERNEL_LIB
build: Add example bitcoin-chainstate executable The bitcoin-chainstate executable serves to surface the dependencies required by a program wishing to use Bitcoin Core's consensus engine as it is right now. More broadly, the _SOURCES list serves as a guiding "North Star" for the libbitcoinkernel project: as we decouple more and more modules of the codebase from our consensus engine, this _SOURCES list will grow shorter and shorter. One day, only what is critical to our consensus engine will remain. Right now, it's "the minimal list of files to link in to even use our consensus engine". [META] In a future commit the libbitcoinkernel library will be extracted from bitcoin-chainstate, and the libbitcoinkernel library's _SOURCES list will be the list that we aim to shrink.
2021-09-01 15:46:51 -04:00
#
Format build flags in src/Makefile.am.
2014-11-21 12:24:50 +13:00
# bitcoinconsensus library #
build: add libbitcoinconsensus files and hook up the lib build Credit BlueMatt for libbitcoinsonsensus.h/cpp
2014-10-14 18:22:55 -04:00
if BUILD_BITCOIN_LIBS
build: Separate lib_LTLIBRARIES initialization Set lib_LTLIBRARIES with '=' to an empty value at the top of the Makefile.am and append to it from the library-local block for readability. Here's the error you get if you don't set lib_LTLIBRARIES to be empty: error: lib_LTLIBRARIES must be set with '=' before using '+=' [META] In a subsequent commit, we're going to introduce a library and append it to lib_LTLIBRARIES in its local block, this makes things more readable.
2022-02-08 17:06:21 -05:00
lib_LTLIBRARIES += $(LIBBITCOINCONSENSUS)
build: add libbitcoinconsensus files and hook up the lib build Credit BlueMatt for libbitcoinsonsensus.h/cpp
2014-10-14 18:22:55 -04:00
include_HEADERS = script/bitcoinconsensus.h
build: Create .la library for bitcoincrypto Libtool will yell at you if you try to link a shared library against static ones. This change creates a libtool archive library for bitcoincrypto and allows a shared library to be linked against it portably. Also specify -static in both: - ..._la_CXXFLAGS so that libtool will avoid building two versions of each object (one PIC, one non-PIC). We just need the one that is suitable for static linking. - ..._la_LDFLAGS so that libtool will create a static library. [META] This change is done in preparation for a future commit where we link the libbitcoinkernel library against this one.
2021-12-22 01:16:00 -05:00
libbitcoinconsensus_la_SOURCES = support/cleanse.cpp $(crypto_libbitcoin_crypto_base_la_SOURCES) $(libbitcoin_consensus_a_SOURCES)
build: add libbitcoinconsensus files and hook up the lib build Credit BlueMatt for libbitcoinsonsensus.h/cpp
2014-10-14 18:22:55 -04:00
build: Split hardening/fPIE options out This allows for fPIE to be used selectively.
2015-11-09 20:50:25 -05:00
libbitcoinconsensus_la_LDFLAGS = $(AM_LDFLAGS) -no-undefined $(RELDFLAGS)
Switch to libsecp256k1-based validation for ECDSA
2015-07-28 20:11:20 +02:00
libbitcoinconsensus_la_LIBADD = $(LIBSECP256K1)
libbitcoinconsensus_la_CPPFLAGS = $(AM_CPPFLAGS) -I$(builddir)/obj -I$(srcdir)/secp256k1/include -DBUILD_BITCOIN_INTERNAL
build: Split hardening/fPIE options out This allows for fPIE to be used selectively.
2015-11-09 20:50:25 -05:00
libbitcoinconsensus_la_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS)
Format build flags in src/Makefile.am.
2014-11-21 12:24:50 +13:00
build: add --with-libs so that libs are optional
2014-11-06 22:43:19 -05:00
endif
Format build flags in src/Makefile.am.
2014-11-21 12:24:50 +13:00
#
build: add libbitcoinconsensus files and hook up the lib build Credit BlueMatt for libbitcoinsonsensus.h/cpp
2014-10-14 18:22:55 -04:00
build: Enumerate ctaes rather than globbing
2016-05-27 14:14:44 -04:00
CTAES_DIST = crypto/ctaes/bench.c
CTAES_DIST += crypto/ctaes/ctaes.c
CTAES_DIST += crypto/ctaes/ctaes.h
CTAES_DIST += crypto/ctaes/README.md
CTAES_DIST += crypto/ctaes/test.c
build: out-of-tree fixups Don't glob the leveldb for dist. That means we need to enumerate the headers.
2016-06-01 18:05:09 -04:00
CLEANFILES = $(EXTRA_LIBRARIES)
Remove coverage and test related files, when cleaning up Until now there were quite a few leftovers, and only the coverage related files in `src/` were cleaned, while the ones in the other dirs remained. `qa/tmp/` is related to the BitcoinJ tests, and `cache/` is related to RPC tests.
2015-05-28 02:47:53 +02:00
CLEANFILES += *.gcda *.gcno
CLEANFILES += compat/*.gcda compat/*.gcno
CLEANFILES += consensus/*.gcda consensus/*.gcno
build: Add missed gcov files to 'make clean'
2020-08-14 14:38:28 +03:00
CLEANFILES += crc32c/src/*.gcda crc32c/src/*.gcno
Remove coverage and test related files, when cleaning up Until now there were quite a few leftovers, and only the coverage related files in `src/` were cleaned, while the ones in the other dirs remained. `qa/tmp/` is related to the BitcoinJ tests, and `cache/` is related to RPC tests.
2015-05-28 02:47:53 +02:00
CLEANFILES += crypto/*.gcda crypto/*.gcno
build: Add missed gcov files to 'make clean'
2020-08-14 14:38:28 +03:00
CLEANFILES += index/*.gcda index/*.gcno
CLEANFILES += interfaces/*.gcda interfaces/*.gcno
CLEANFILES += node/*.gcda node/*.gcno
Remove coverage and test related files, when cleaning up Until now there were quite a few leftovers, and only the coverage related files in `src/` were cleaned, while the ones in the other dirs remained. `qa/tmp/` is related to the BitcoinJ tests, and `cache/` is related to RPC tests.
2015-05-28 02:47:53 +02:00
CLEANFILES += policy/*.gcda policy/*.gcno
CLEANFILES += primitives/*.gcda primitives/*.gcno
build: Add missed gcov files to 'make clean'
2020-08-14 14:38:28 +03:00
CLEANFILES += rpc/*.gcda rpc/*.gcno
Remove coverage and test related files, when cleaning up Until now there were quite a few leftovers, and only the coverage related files in `src/` were cleaned, while the ones in the other dirs remained. `qa/tmp/` is related to the BitcoinJ tests, and `cache/` is related to RPC tests.
2015-05-28 02:47:53 +02:00
CLEANFILES += script/*.gcda script/*.gcno
CLEANFILES += support/*.gcda support/*.gcno
CLEANFILES += univalue/*.gcda univalue/*.gcno
build: Add missed gcov files to 'make clean'
2020-08-14 14:38:28 +03:00
CLEANFILES += util/*.gcda util/*.gcno
Remove coverage and test related files, when cleaning up Until now there were quite a few leftovers, and only the coverage related files in `src/` were cleaned, while the ones in the other dirs remained. `qa/tmp/` is related to the BitcoinJ tests, and `cache/` is related to RPC tests.
2015-05-28 02:47:53 +02:00
CLEANFILES += wallet/*.gcda wallet/*.gcno
CLEANFILES += wallet/test/*.gcda wallet/test/*.gcno
CLEANFILES += zmq/*.gcda zmq/*.gcno
build: Make "make clean" remove all files created when running "make check" More specifically: remove also obj/build.h and bench/data/block413567.raw.h. Before this patch: ``` $ diff -rq bitcoin-before-make/ bitcoin-after-make-and-make-clean/ | grep -E "^Only in bitcoin-after-make-and-make-clean/" | grep -v dirstamp Only in bitcoin-after-make-and-make-clean/src/bench/data: block413567.raw.h Only in bitcoin-after-make-and-make-clean/src/obj: build.h $ ``` After this patch: ``` $ diff -rq bitcoin-before-make/ bitcoin-after-make-and-make-clean/ | grep -E "^Only in bitcoin-after-make-and-make-clean/" | grep -v dirstamp $ ```
2017-10-01 23:07:23 +02:00
CLEANFILES += obj/build.h
autotools: switch to autotools buildsystem
2013-05-27 19:55:01 -04:00
build: out-of-tree fixups Don't glob the leveldb for dist. That means we need to enumerate the headers.
2016-06-01 18:05:09 -04:00
EXTRA_DIST = $(CTAES_DIST)
autotools: switch to autotools buildsystem
2013-05-27 19:55:01 -04:00
build: fix bitcoin-config.h regeneration after touching build files This was a long-standing and annoying problem. If autogen.sh was not manually run after touching configure.ac, bitcoin-config.h would not be properly regenerated. This causes very subtle problems when configure appears to enable a new value, but it does not end up reflected in the build.
2017-04-18 19:14:22 -04:00
config/bitcoin-config.h: config/stamp-h1
@$(MAKE) -C $(top_builddir) $(subdir)/$(@)
config/stamp-h1: $(top_srcdir)/$(subdir)/config/bitcoin-config.h.in $(top_builddir)/config.status
$(AM_V_at)$(MAKE) -C $(top_builddir) $(subdir)/$(@)
$(top_srcdir)/$(subdir)/config/bitcoin-config.h.in: $(am__configure_deps)
$(AM_V_at)$(MAKE) -C $(top_srcdir) $(subdir)/config/bitcoin-config.h.in
autotools: switch to autotools buildsystem
2013-05-27 19:55:01 -04:00
clean-local:
build: secp256k1 as a subdir, since it's required
2014-11-05 20:56:45 -05:00
-$(MAKE) -C secp256k1 clean
Remove coverage and test related files, when cleaning up Until now there were quite a few leftovers, and only the coverage related files in `src/` were cleaned, while the ones in the other dirs remained. `qa/tmp/` is related to the BitcoinJ tests, and `cache/` is related to RPC tests.
2015-05-28 02:47:53 +02:00
-rm -f leveldb/*/*.gcda leveldb/*/*.gcno leveldb/helpers/memenv/*.gcda leveldb/helpers/memenv/*.gcno
build: move bitcoin-config.h to its own directory This allows us to include its path without making other header includes valid.
2014-06-09 14:58:30 -04:00
-rm -f config.h
build: more out-of-tree fixups - clear the __pycache__ during 'make clean' - Copy the qrc locale file to a temp location and remove it when finished (rcc expects everything to be in the same path)
2016-06-01 18:06:40 -04:00
-rm -rf test/__pycache__
build: Switch to non-recursive make Build logic moves from individual Makefile.am's to include files, which the main src/Makefile.am includes. This avoids having to manage a gigantic single Makefile. TODO: Move the rules from the old Makefile.include to where they actually belong and nuke the old file.
2014-05-28 13:38:41 -04:00
build: nuke Makefile.include from orbit Rules and targets no longer need to be shared between subdirectories, so this is no longer needed.
2014-06-04 17:13:03 -04:00
.rc.o:
build: Tidy up file generation output - Some file generation was still noisy, silence it. - AM_V_GEN is used rather than @ so that 'make V=1' works as intended - Cut down on file copies and moves when using sed, use pipes instead - Avoid the use of top_ and abs_ dirs where possible
2014-06-05 14:17:50 -04:00
@test -f $(WINDRES)
Unify package name to as few places as possible without major changes
2015-12-09 10:53:12 +00:00
## FIXME: How to get the appropriate modulename_CPPFLAGS in here?
$(AM_V_GEN) $(WINDRES) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(CPPFLAGS) -DWINDRES_PREPROC -i $< -o $@
build: nuke Makefile.include from orbit Rules and targets no longer need to be shared between subdirectories, so this is no longer needed.
2014-06-04 17:13:03 -04:00
release: add check-symbols and check-security make targets These are not added to the default checks because some of them depend on release-build configs.
2016-01-26 14:52:56 -05:00
check-symbols: $(bin_PROGRAMS)
scripts: use LIEF for ELF checks in symbol-check.py Co-authored-by: Carl Dong <contact@carldong.me>
2021-07-02 14:22:04 +08:00
@echo "Running symbol and dynamic library checks..."
devtools: Improve *-check.py tool detection This is important to make sure that we're not testing tools different from the one we're building with. Introduce determine_wellknown_cmd, which encapsulates how we should handle well-known tools specification (IFS splitting, env override, etc.).
2021-01-21 13:52:40 -05:00
$(AM_V_at) $(PYTHON) $(top_srcdir)/contrib/devtools/symbol-check.py $(bin_PROGRAMS)
release: add check-symbols and check-security make targets These are not added to the default checks because some of them depend on release-build configs.
2016-01-26 14:52:56 -05:00
check-security: $(bin_PROGRAMS)
if HARDEN
@echo "Checking binary security..."
devtools: Improve *-check.py tool detection This is important to make sure that we're not testing tools different from the one we're building with. Introduce determine_wellknown_cmd, which encapsulates how we should handle well-known tools specification (IFS splitting, env override, etc.).
2021-01-21 13:52:40 -05:00
$(AM_V_at) $(PYTHON) $(top_srcdir)/contrib/devtools/security-check.py $(bin_PROGRAMS)
release: add check-symbols and check-security make targets These are not added to the default checks because some of them depend on release-build configs.
2016-01-26 14:52:56 -05:00
endif
multiprocess: Add Ipc interface implementation
2017-12-05 15:57:12 -05:00
libbitcoin_ipc_mpgen_input = \
multiprocess: Add echoipc RPC method and test Add simple interfaces::Echo IPC interface with one method that just takes and returns a string, to test multiprocess framework and provide an example of how it can be used to spawn and call between processes.
2020-11-24 13:59:33 -05:00
ipc/capnp/echo.capnp \
multiprocess: Add Ipc interface implementation
2017-12-05 15:57:12 -05:00
ipc/capnp/init.capnp
EXTRA_DIST += $(libbitcoin_ipc_mpgen_input)
%.capnp:
multiprocess build cleanup: comment on manual dependencies Also move manual dependency closer to actual build target
2022-05-25 18:01:22 -04:00
# Explicitly list dependencies on generated headers as described in
# https://www.gnu.org/software/automake/manual/html_node/Built-Sources-Example.html#Recording-Dependencies-manually
ipc/capnp/libbitcoin_ipc_a-protocol.$(OBJEXT): $(libbitcoin_ipc_mpgen_input:=.h)
multiprocess: Add Ipc interface implementation
2017-12-05 15:57:12 -05:00
if BUILD_MULTIPROCESS
LIBBITCOIN_IPC=libbitcoin_ipc.a
libbitcoin_ipc_a_SOURCES = \
Add ipc::Context and ipc::capnp::Context structs These are currently empty structs but they will be used to pass some function and object pointers from bitcoin application code to IPC hooks that run, for example, when a remote object is created or destroyed, or a new process is created.
2017-12-05 15:57:12 -05:00
ipc/capnp/context.h \
multiprocess: Add Ipc interface implementation
2017-12-05 15:57:12 -05:00
ipc/capnp/init-types.h \
ipc/capnp/protocol.cpp \
ipc/capnp/protocol.h \
Add ipc::Context and ipc::capnp::Context structs These are currently empty structs but they will be used to pass some function and object pointers from bitcoin application code to IPC hooks that run, for example, when a remote object is created or destroyed, or a new process is created.
2017-12-05 15:57:12 -05:00
ipc/context.h \
multiprocess: Add Ipc interface implementation
2017-12-05 15:57:12 -05:00
ipc/exception.h \
ipc/interfaces.cpp \
ipc/process.cpp \
ipc/process.h \
ipc/protocol.h
libbitcoin_ipc_a_CPPFLAGS = $(AM_CPPFLAGS) $(BITCOIN_INCLUDES)
libbitcoin_ipc_a_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS) $(LIBMULTIPROCESS_CFLAGS)
include $(MPGEN_PREFIX)/include/mpgen.mk
libbitcoin_ipc_mpgen_output = \
$(libbitcoin_ipc_mpgen_input:=.c++) \
$(libbitcoin_ipc_mpgen_input:=.h) \
$(libbitcoin_ipc_mpgen_input:=.proxy-client.c++) \
$(libbitcoin_ipc_mpgen_input:=.proxy-server.c++) \
$(libbitcoin_ipc_mpgen_input:=.proxy-types.c++) \
$(libbitcoin_ipc_mpgen_input:=.proxy-types.h) \
$(libbitcoin_ipc_mpgen_input:=.proxy.h)
nodist_libbitcoin_ipc_a_SOURCES = $(libbitcoin_ipc_mpgen_output)
CLEANFILES += $(libbitcoin_ipc_mpgen_output)
endif
build: add minisketch build file and include it
2021-07-20 18:28:19 +00:00
include Makefile.minisketch.include
build: CRC32C build system integration
2019-11-07 15:52:44 +01:00
include Makefile.crc32c.include
leveldb: integrate leveldb into our buildsystem leveldb's buildsystem causes us a few problems: - breaks out-of-tree builds - forces flags used for some tools - limits cross builds Rather than continuing to add wrappers around it, simply integrate it into our build.
2016-02-17 14:35:35 -05:00
include Makefile.leveldb.include
build: add minisketch build file and include it
2021-07-20 18:28:19 +00:00
build: Create test utility library from src/test/util/
2019-11-21 21:13:08 +01:00
include Makefile.test_util.include
build: create test_fuzz library from src/test/fuzz/fuzz.cpp
2020-04-05 01:01:13 +02:00
include Makefile.test_fuzz.include
build: Create test utility library from src/test/util/
2019-11-21 21:13:08 +01:00
build: Switch to non-recursive make Build logic moves from individual Makefile.am's to include files, which the main src/Makefile.am includes. This avoids having to manage a gigantic single Makefile. TODO: Move the rules from the old Makefile.include to where they actually belong and nuke the old file.
2014-05-28 13:38:41 -04:00
include Makefile.test.include
Simple benchmarking framework Benchmarking framework, loosely based on google's micro-benchmarking library (https://github.com/google/benchmark) Wny not use the Google Benchmark framework? Because adding Even More Dependencies isn't worth it. If we get a dozen or three benchmarks and need nanosecond-accurate timings of threaded code then switching to the full-blown Google Benchmark library should be considered. The benchmark framework is hard-coded to run each benchmark for one wall-clock second, and then spits out .csv-format timing information to stdout. It is left as an exercise for later (or maybe never) to add command-line arguments to specify which benchmark(s) to run, how long to run them for, how to format results, etc etc etc. Again, see the Google Benchmark framework for where that might end up. See src/bench/MilliSleep.cpp for a sanity-test benchmark that just benchmarks 'sleep 100 milliseconds.' To compile and run benchmarks: cd src; make bench Sample output: Benchmark,count,min,max,average Sleep100ms,10,0.101854,0.105059,0.103881
2015-09-24 13:13:38 -04:00
if ENABLE_BENCH
include Makefile.bench.include
endif
build: Switch to non-recursive make Build logic moves from individual Makefile.am's to include files, which the main src/Makefile.am includes. This avoids having to manage a gigantic single Makefile. TODO: Move the rules from the old Makefile.include to where they actually belong and nuke the old file.
2014-05-28 13:38:41 -04:00
if ENABLE_QT
include Makefile.qt.include
endif
if ENABLE_QT_TESTS
include Makefile.qttest.include
endif
Integrate univalue into our buildsystem This addresses issues like the one in #12467, where some of our compiler flags end up being dropped during the subconfigure of Univalue. Specifically, we're still using the compiler-default c++ version rather than forcing c++17. We can drop the need subconfigure completely in favor of a tighter build integration, where the sources are listed separately from the build recipes, so that they may be included directly by upstream projects. This is similar to the way leveldb build integration works in Core. Core benefits of this approach include: - Better caching (for ex. ccache and autoconf) - No need for a slow subconfigure - Faster autoconf - No more missing compile flags - Compile only the objects needed There are no benefits to Univalue itself that I can think of. These changes should be a no-op there, and to downstreams as well until they take advantage of the new sources.mk. This also removes the option to use an external univalue to avoid similar ABI issues with mystery binaries. Co-authored-by: fanquake <fanquake@gmail.com>
2021-07-15 18:42:17 +00:00
include Makefile.univalue.include
Reference in a new issue Copy permalink