Instead of disabling the settings button when share is active, hide it, and show it again when the share stops

install/onionshare.nsi

@@ -209,7 +209,6 @@ Section "install"
     File "${BINPATH}\share\images\server_stopped.png"
     File "${BINPATH}\share\images\server_working.png"
     File "${BINPATH}\share\images\settings.png"
-    File "${BINPATH}\share\images\settings_inactive.png"
 
     SetOutPath "$INSTDIR\share\locale"
     File "${BINPATH}\share\locale\cs.json"
@@ -388,7 +387,6 @@ FunctionEnd
         Delete "$INSTDIR\share\images\server_stopped.png"
         Delete "$INSTDIR\share\images\server_working.png"
         Delete "$INSTDIR\share\images\settings.png"
-        Delete "$INSTDIR\share\images\settings_inactive.png"
         Delete "$INSTDIR\share\license.txt"
         Delete "$INSTDIR\share\locale\cs.json"
         Delete "$INSTDIR\share\locale\de.json"

onionshare_gui/onionshare_gui.py

@@ -569,11 +569,10 @@ class OnionShareGui(QtWidgets.QMainWindow):
         """
         Disable the Settings button while an OnionShare server is active.
         """
-        self.settings_button.setEnabled(not active)
         if active:
-            self.settings_button.setIcon( QtGui.QIcon(common.get_resource_path('images/settings_inactive.png')) )
+            self.settings_button.hide()
         else:
-            self.settings_button.setIcon( QtGui.QIcon(common.get_resource_path('images/settings.png')) )
+            self.settings_button.show()
 
         # Disable settings menu action when server is active
         self.settingsAction.setEnabled(not active)