phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-01-15 22:32:37 -03:00
Code Issues Projects Releases Packages Wiki Activity Actions 1
bitcoin/src/wallet/test
History
Samuel Dobson e890c15e2c
Merge #18671: wallet: Add BlockUntilSyncedToCurrentChain to dumpwallet 
fa60afc4fb wallet: Add BlockUntilSyncedToCurrentChain to dumpwallet (MarcoFalke)

Pull request description:

  dumpwallet includes the block hash in the output, so this method depends on the chainstate. According to the developer notes e84a5f0004/doc/developer-notes.md (L1095) it must include a `BlockUntilSyncedToCurrentChain`.

  This is a minor fix and does not need backport, I think.

  It fixes test failures such as https://travis-ci.org/github/bitcoin/bitcoin/jobs/675487097#L2657 , which can only happen in master because the test was not backported.

ACKs for top commit:
  promag:
    Code review ACK fa60afc4fb.
  ryanofsky:
    Code review ACK fa60afc4fb
  meshcollider:
    utACK fa60afc4fb

Tree-SHA512: 8df70b06b226b2cdf880dec9264adb72d66fd81b09b404fd1665a79e5f5236d26122eebf15df00fe71ee292b5c91b2dc23a0a42b2aa50a8d690604b23832723f
2020-04-23 14:12:35 +12:00
..
coinselector_tests.cpp Merge #18673: scripted-diff: Sort test includes 2020-04-17 10:12:13 -04:00
db_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
init_test_fixture.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
init_test_fixture.h scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
init_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
ismine_tests.cpp Refactor: Allow LegacyScriptPubKeyMan to be null 2020-01-23 16:34:28 -05:00
psbt_wallet_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
scriptpubkeyman_tests.cpp wallet: Improve LegacyScriptPubKeyMan::CanProvide script recognition 2020-02-12 11:48:30 -05:00
wallet_crypto_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
wallet_test_fixture.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
wallet_test_fixture.h scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
wallet_tests.cpp Merge #18671: wallet: Add BlockUntilSyncedToCurrentChain to dumpwallet 2020-04-23 14:12:35 +12:00