phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-01-15 14:22:37 -03:00
Code Issues Projects Releases Packages Wiki Activity Actions 1
bitcoin/src/wallet
History
Samuel Dobson e890c15e2c
Merge #18671: wallet: Add BlockUntilSyncedToCurrentChain to dumpwallet 
fa60afc4fb wallet: Add BlockUntilSyncedToCurrentChain to dumpwallet (MarcoFalke)

Pull request description:

  dumpwallet includes the block hash in the output, so this method depends on the chainstate. According to the developer notes e84a5f0004/doc/developer-notes.md (L1095) it must include a `BlockUntilSyncedToCurrentChain`.

  This is a minor fix and does not need backport, I think.

  It fixes test failures such as https://travis-ci.org/github/bitcoin/bitcoin/jobs/675487097#L2657 , which can only happen in master because the test was not backported.

ACKs for top commit:
  promag:
    Code review ACK fa60afc4fb.
  ryanofsky:
    Code review ACK fa60afc4fb
  meshcollider:
    utACK fa60afc4fb

Tree-SHA512: 8df70b06b226b2cdf880dec9264adb72d66fd81b09b404fd1665a79e5f5236d26122eebf15df00fe71ee292b5c91b2dc23a0a42b2aa50a8d690604b23832723f
2020-04-23 14:12:35 +12:00
..
test Merge #18671: wallet: Add BlockUntilSyncedToCurrentChain to dumpwallet 2020-04-23 14:12:35 +12:00
coincontrol.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
coincontrol.h refactor: Nuke coincontrol circular dependency 2019-11-23 08:30:03 +02:00
coinselection.cpp bnb: exit selection when best_waste is 0 2020-03-04 16:35:15 -05:00
coinselection.h amount: Move CAmount CENT to unit test header 2018-09-17 14:34:56 -04:00
crypter.cpp Fix occurences of c_str() used with size() to data() 2019-10-28 13:41:45 +01:00
crypter.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
db.cpp Merge #18241: wallet/refactor: refer to CWallet immutably when possible 2020-03-07 07:24:54 +08:00
db.h scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
feebumper.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
feebumper.h scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
fees.cpp Remove unused includes 2019-10-15 22:56:43 +00:00
fees.h Remove uses of fee globals in wallet code 2019-02-22 15:43:02 -04:00
init.cpp Merge #15761: Replace -upgradewallet startup option with upgradewallet RPC 2020-04-19 07:06:42 -04:00
ismine.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
load.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
load.h wallet: Fix documentation around WalletParameterInteraction 2019-09-03 14:10:25 -04:00
rpcdump.cpp Merge #18671: wallet: Add BlockUntilSyncedToCurrentChain to dumpwallet 2020-04-23 14:12:35 +12:00
rpcwallet.cpp Merge #17579: [refactor] Merge getreceivedby tally into GetReceived function 2020-04-20 10:05:32 -04:00
rpcwallet.h scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
scriptpubkeyman.cpp Merge #17219: wallet: allow transaction without change if keypool is empty 2020-04-18 22:00:26 +12:00
scriptpubkeyman.h Replace GetSigningProvider with GetSolvingProvider 2020-03-09 11:16:20 -04:00
wallet.cpp wallet: Refactor WalletRescanReserver to use wallet reference 2020-04-19 14:04:37 +01:00
wallet.h wallet: Refactor WalletRescanReserver to use wallet reference 2020-04-19 14:04:37 +01:00
walletdb.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
walletdb.h scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
wallettool.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
wallettool.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
walletutil.cpp Merge #15870: wallet: Only fail rescan when blocks have actually been pruned 2019-05-16 11:18:27 -04:00
walletutil.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00