Wladimir J. van der Laan 8db23349fe Merge #19335: wallet: Cleanup and separate BerkeleyDatabase and BerkeleyBatch ... 74507ce71e walletdb: Remove BerkeleyBatch friend class from BerkeleyDatabase (Andrew Chow) 00f0041351 No need to check for duplicate fileids in all dbenvs (Andrew Chow) d86efab370 walletdb: Move Db->open to BerkeleyDatabase::Open (Andrew Chow) 4fe4b3bf1b walletdb: track database file use as m_refcount within BerkeleyDatabase (Andrew Chow) 65fb8807ac Combine BerkeleyEnvironment::Verify into BerkeleyDatabase::Verify (Andrew Chow) Pull request description: `BerkeleyBatch` and `BerkeleyDatabase` are kind of messy. The goal of this is to clean up them up so that they are logically separated. `BerkeleyBatch` currently handles the creation of the `BerkeleyDatabase`'s `Db` handle. This is instead moved into `BerkeleyDatabase` and is called by `BerkeleyBatch`. Instead of having `BerkeleyEnvironment` track each database's usage, have `BerkeleyDatabase` track this usage itself with the `m_refcount` variable that is present in `WalletDatabase`. Lastly, instead of having each `BerkeleyEnvironment` store the fileids of the databases open in it, have a global `g_fileids` to track those fileids. We were already checking fileid uniqueness globally (by checking the fileids in every environment when opening a database) so it's cleaner to do this with a global variable. All of these changes allow us to make `BerkeleyBatch` and `BerkeleyDatabase` no longer be friend classes. The diff of this PR is currently the same as in ##18971 Requires #19334 ACKs for top commit: laanwj: Code review ACK 74507ce71e ryanofsky: Code review ACK 74507ce71e. No changes since last review other than rebase Tree-SHA512: 845d84ee1a470e2bf5d2e2e3d7738183d8ce43ddd06a0bbd57edecf5779b2f55d70728b1b57f5daab0f078650a8d60c3e19dc30b75b36e7aa952ce268399d5f6		2020-07-29 18:24:16 +02:00
..
bench	Merge #19214: Auto-detect SHA256 implementation in benchmarks	2020-07-15 15:35:11 +02:00
compat	net: Use C++11 member initialization in protocol	2020-05-20 08:27:07 -04:00
config
consensus	Merge #18044: Use wtxid for transaction relay	2020-07-22 20:58:55 +02:00
crc32c	Import crc32c using subtree merge as as 'src/crc32c'	2020-01-28 17:00:01 +01:00
crypto	build: improve builtin_clz* detection	2020-06-29 11:31:17 +08:00
index	scripted-diff: Move ui_interface to the node lib	2020-06-27 11:49:28 -04:00
interfaces	Merge #15935: Add <datadir>/settings.json persistent settings storage	2020-07-23 18:39:42 +02:00
leveldb	Update to leveldb upstream using subtree merge	2020-01-28 16:59:07 +01:00
logging	Remove use of non-standard zero variadic macros	2020-04-30 18:02:04 +08:00
node	Add support for tx-relay via wtxid	2020-07-19 02:05:29 -04:00
policy	doc: Add non-thread-safe note to FeeFilterRounder::round()	2020-07-05 13:46:38 +03:00
primitives	Merge #18317: Serialization improvements step 6 (all except wallet/gui)	2020-05-20 07:30:29 -04:00
qt	Merge #15935: Add <datadir>/settings.json persistent settings storage	2020-07-23 18:39:42 +02:00
rpc	rpc: Avoid useless mempool query in gettxoutproof	2020-07-26 16:44:07 +02:00
script	span: Add Span::empty() and use it in script/descriptor	2020-07-19 20:51:06 +02:00
secp256k1	Update src/secp256k1 subtree	2020-06-09 13:39:09 -07:00
support	Limit scope of all global std::once_flag	2020-05-29 17:22:07 -04:00
test	Merge #19534: net: save the network type explicitly in CNetAddr	2020-07-29 13:31:16 +02:00
univalue	Update univalue subtree	2020-02-09 07:44:29 -08:00
util	Merge #15935: Add <datadir>/settings.json persistent settings storage	2020-07-23 18:39:42 +02:00
wallet	walletdb: Remove BerkeleyBatch friend class from BerkeleyDatabase	2020-07-22 23:30:19 -04:00
zmq	scripted-diff: Bump copyright headers	2020-04-16 13:33:09 -04:00
.clang-format	tools: clang-format 6 compatibility	2020-07-06 03:52:37 +02:00
addrdb.cpp	refactor: Use uint16_t instead of unsigned short	2020-06-22 12:12:22 +02:00
addrdb.h	Clean up separated ban/discourage interface	2020-07-03 20:43:55 -07:00
addrman.cpp	Merge #18512: Improve asmap checks and add sanity check	2020-05-06 14:59:28 +02:00
addrman.h	logging: asmap logging and #include fixups	2020-03-04 14:24:19 +01:00
amount.h
arith_uint256.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
arith_uint256.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
attributes.h
banman.cpp	banlist: log post-swept banlist size at startup	2020-07-08 21:44:45 +08:00
banman.h	Clean up separated ban/discourage interface	2020-07-03 20:43:55 -07:00
base58.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
base58.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
bech32.cpp	Add some general std::vector utility functions	2019-10-16 08:56:57 -07:00
bech32.h	Assert that the HRP is lowercase in Bech32::Encode	2019-09-05 13:25:11 +12:00
bitcoin-cli-res.rc
bitcoin-cli.cpp	cli: reduce DefaultRequestHandler memory allocations	2020-07-05 16:39:17 +02:00
bitcoin-tx-res.rc
bitcoin-tx.cpp	scripted-diff: Bump copyright headers	2020-04-16 13:33:09 -04:00
bitcoin-wallet-res.rc	[tools] Add wallet inspection and modification tool	2019-01-30 16:26:52 -05:00
bitcoin-wallet.cpp	wallettool: Add a salvage command	2020-05-25 12:36:48 -04:00
bitcoind-res.rc
bitcoind.cpp	Add <datadir>/settings.json persistent settings storage.	2020-07-11 05:41:12 -04:00
blockencodings.cpp	Get rid of -Wthread-safety-precise warnings	2020-05-28 09:55:39 +03:00
blockencodings.h	Get rid of -Wthread-safety-precise warnings	2020-05-28 09:55:39 +03:00
blockfilter.cpp	tests: Add fuzzing harness for Golomb-Rice coding (GolombRiceEncode/GolombRiceDecode)	2020-04-20 14:57:48 +00:00
blockfilter.h	[indexes] Fix default [de]serialization of BlockFilter.	2020-05-26 17:27:15 -04:00
bloom.cpp	scripted-diff: TxoutType C++11 scoped enum class	2020-06-21 06:41:55 -04:00
bloom.h	Merge #18317: Serialization improvements step 6 (all except wallet/gui)	2020-05-20 07:30:29 -04:00
chain.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
chain.h	scripted-diff: Bump copyright headers	2020-04-16 13:33:09 -04:00
chainparams.cpp	[net] Add seed.bitcoin.wiz.biz to DNS seeds	2020-06-15 18:22:52 +09:00
chainparams.h	scripted-diff: Bump copyright headers	2020-04-16 13:33:09 -04:00
chainparamsbase.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
chainparamsbase.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
chainparamsseeds.h	net: Hardcoded seeds update for 0.20	2020-04-03 16:29:26 +02:00
checkqueue.h	scripted-diff: Bump copyright headers	2020-04-16 13:33:09 -04:00
clientversion.cpp	Drop unused GIT_COMMIT_DATE macro	2020-05-04 19:53:58 +03:00
clientversion.h
coins.cpp	Add CChainState::ResizeCoinsCaches	2020-07-01 14:44:28 -04:00
coins.h	Add CChainState::ResizeCoinsCaches	2020-07-01 14:44:28 -04:00
compat.h	windows: Set _WIN32_WINNT to 0x0601 (Windows 7)	2019-01-23 16:28:27 +08:00
compressor.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
compressor.h	scripted-diff: Bump copyright headers	2020-04-16 13:33:09 -04:00
core_io.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
core_memusage.h
core_read.cpp	refactor: Replace const char* to std::string	2020-05-22 01:40:31 +09:00
core_write.cpp	Merge #16525: Dump transaction version as an unsigned integer in RPC/TxToUniv	2020-07-16 21:38:09 +02:00
cuckoocache.h	tests: Add fuzzing harness for classes/functions in cuckoocache.h	2020-04-08 14:45:27 +00:00
dbwrapper.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
dbwrapper.h	Drop unused CDBWrapper methods	2020-07-08 14:26:14 +03:00
dummywallet.cpp	wallet: Avoid translating RPC errors when loading wallets	2020-05-01 07:39:00 -04:00
flatfile.cpp	Style cleanup.	2019-02-22 17:38:45 -08:00
flatfile.h	Merge #18317: Serialization improvements step 6 (all except wallet/gui)	2020-05-20 07:30:29 -04:00
fs.cpp	Add missing includes to fix compile errors	2020-06-16 15:15:46 -04:00
fs.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
hash.cpp
hash.h	Squashed 'src/secp256k1/' changes from 0b70241850..b19c000063	2019-03-31 11:41:05 -07:00
httprpc.cpp	Merge #18740: Remove g_rpc_node global	2020-05-21 06:53:39 -04:00
httprpc.h	refactor: Pass NodeContext to RPC and REST methods through util::Ref	2020-05-13 16:20:13 -04:00
httpserver.cpp	scripted-diff: Move ui_interface to the node lib	2020-06-27 11:49:28 -04:00
httpserver.h	scripted-diff: Bump copyright headers	2020-04-16 13:33:09 -04:00
indirectmap.h	scripted-diff: Bump copyright headers	2020-04-16 13:33:09 -04:00
init.cpp	Merge #18637: coins: allow cache resize after init	2020-07-29 07:53:19 +02:00
init.h	refactor: Pass NodeContext to RPC and REST methods through util::Ref	2020-05-13 16:20:13 -04:00
key.cpp	scripted-diff: rename privkey with seckey in secp256k1 interface	2020-06-10 18:29:33 -07:00
key.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
key_io.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
key_io.h
limitedmap.h
logging.cpp	log: remove deprecated db log category	2020-06-07 17:03:49 +02:00
logging.h	refactor: Rename LockGuard to StdLockGuard for consistency with StdMutex	2020-05-28 09:54:24 +03:00
Makefile.am	build: Sort Makefile.am after renaming file	2020-06-27 11:49:35 -04:00
Makefile.bench.include	Add Hash Padding Microbenchmarks	2020-04-29 00:31:41 -07:00
Makefile.crc32c.include	build: CRC32C build system integration	2020-01-28 17:01:48 +01:00
Makefile.leveldb.include	build: Enable -Wsuggest-override	2020-05-12 18:03:39 +03:00
Makefile.qt.include	scripted-diff: rename movie folder to animation	2020-06-29 18:49:13 +01:00
Makefile.qt_locale.include	qt: Translations update pre-branch	2020-04-01 12:49:15 +02:00
Makefile.qttest.include	build: Create test utility library from src/test/util/	2019-11-21 21:13:08 +01:00
Makefile.test.include	Merge #18637: coins: allow cache resize after init	2020-07-29 07:53:19 +02:00
Makefile.test_fuzz.include	build: create test_fuzz library from src/test/fuzz/fuzz.cpp	2020-04-05 01:01:13 +02:00
Makefile.test_util.include	fuzz: Add process_messages harness	2020-04-05 10:46:24 +08:00
memusage.h	scripted-diff: Bump copyright headers	2020-04-16 13:33:09 -04:00
merkleblock.cpp	Convert merkleblock to new serialization	2020-03-30 16:09:51 -07:00
merkleblock.h	Convert merkleblock to new serialization	2020-03-30 16:09:51 -07:00
miner.cpp	refactor: Remove unused BlockAssembler::pblock member var	2020-06-15 08:08:19 -04:00
miner.h	refactor: Remove unused BlockAssembler::pblock member var	2020-06-15 08:08:19 -04:00
net.cpp	Merge #19473: net: Add -networkactive option	2020-07-23 18:32:59 +02:00
net.h	Merge #19473: net: Add -networkactive option	2020-07-23 18:32:59 +02:00
net_permissions.cpp	net: Extract download permission from noban	2020-07-09 12:48:05 +02:00
net_permissions.h	net: Extract download permission from noban	2020-07-09 12:48:05 +02:00
net_processing.cpp	[net processing] Tidy up Misbehaving()	2020-07-25 15:52:23 +01:00
net_processing.h	Merge #19472: [net processing] Reduce cs_main scope in MaybeDiscourageAndDisconnect()	2020-07-24 17:20:58 +02:00
net_types.h	refactor: Remove addrdb.h dependency from node.h	2019-10-29 11:30:12 +02:00
netaddress.cpp	net: save the network type explicitly in CNetAddr	2020-07-27 15:13:24 +02:00
netaddress.h	net: save the network type explicitly in CNetAddr	2020-07-27 15:13:24 +02:00
netbase.cpp	refactor: Use uint16_t instead of unsigned short	2020-06-22 12:12:22 +02:00
netbase.h	net: Avoid using C-style NUL-terminated strings as arguments in the netbase interface	2020-01-08 12:35:59 +00:00
netmessagemaker.h	refactor: s/command/msg_type/ in CNetMsgMaker and CSerializedNetMsg	2020-05-11 00:20:57 +02:00
noui.cpp	scripted-diff: Move ui_interface to the node lib	2020-06-27 11:49:28 -04:00
noui.h	Make ThreadSafe{MessageBox|Question} bilingual	2020-05-05 04:45:59 +03:00
optional.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
outputtype.cpp	Enable Wswitch for OutputType	2020-07-01 18:03:12 -04:00
outputtype.h	Remove confusing OutputType::CHANGE_AUTO	2020-07-01 18:02:38 -04:00
pow.cpp
pow.h
prevector.h	prevector: Avoid unnamed struct, which is a GNU extension	2020-04-30 18:02:03 +08:00
protocol.cpp	Add p2p message "wtxidrelay"	2020-07-19 02:10:41 -04:00
protocol.h	Add p2p message "wtxidrelay"	2020-07-19 02:10:41 -04:00
psbt.cpp	psbt: always put a non_witness_utxo and don't remove it	2020-06-24 16:32:19 -04:00
psbt.h	psbt: always put a non_witness_utxo and don't remove it	2020-06-24 16:32:19 -04:00
pubkey.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
pubkey.h	Check size after Unserializing CPubKey	2020-06-10 17:35:43 +03:00
random.cpp	Merge #18781: Add templated GetRandDuration<>	2020-05-15 08:58:49 -04:00
random.h	Add templated GetRandomDuration<>	2020-04-30 09:19:14 -04:00
randomenv.cpp	scripted-diff: Bump copyright headers	2020-04-16 13:33:09 -04:00
randomenv.h	[MOVEONLY] Move perfmon data gathering to new randomenv module	2019-11-12 14:50:44 -08:00
rest.cpp	rpc: Avoid useless mempool query in gettxoutproof	2020-07-26 16:44:07 +02:00
reverse_iterator.h
scheduler.cpp	clang-format scheduler	2020-06-21 06:02:59 -04:00
scheduler.h	clang-format scheduler	2020-06-21 06:02:59 -04:00
serialize.h	refactor: Use uint16_t instead of unsigned short	2020-06-22 12:12:22 +02:00
shutdown.cpp
shutdown.h
span.h	span: Add Span::empty() and use it in script/descriptor	2020-07-19 20:51:06 +02:00
streams.h	refactor: Drop unused CBufferedFile::Seek()	2020-07-26 22:46:28 +03:00
sync.cpp	Improve "detected inconsistent lock order" error message	2020-06-25 21:27:34 +03:00
sync.h	Add means to handle negative capabilities in thread safety annotations	2020-06-11 15:49:39 +03:00
threadinterrupt.cpp
threadinterrupt.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
threadsafety.h	Add means to handle negative capabilities in thread safety annotations	2020-06-11 15:49:39 +03:00
timedata.cpp	scripted-diff: Move ui_interface to the node lib	2020-06-27 11:49:28 -04:00
timedata.h
tinyformat.h	util: Update tinyformat to upstream	2019-12-06 10:02:08 +01:00
torcontrol.cpp	net: Avoid using C-style NUL-terminated strings as arguments in the netbase interface	2020-01-08 12:35:59 +00:00
torcontrol.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
txdb.cpp	Merge #18637: coins: allow cache resize after init	2020-07-29 07:53:19 +02:00
txdb.h	txdb: add CCoinsViewDB::ChangeCacheSize	2020-07-01 14:44:24 -04:00
txmempool.cpp	Add a wtxid-index to the mempool	2020-07-18 19:00:01 -04:00
txmempool.h	Add wtxid to mempool unbroadcast tracking	2020-07-18 19:00:01 -04:00
uint256.cpp	refactor: define a UINT256_ONE global constant	2020-01-23 16:35:08 -05:00
uint256.h	refactor: define a UINT256_ONE global constant	2020-01-23 16:35:08 -05:00
undo.h	scripted-diff: Bump copyright headers	2020-04-16 13:33:09 -04:00
validation.cpp	Merge #18637: coins: allow cache resize after init	2020-07-29 07:53:19 +02:00
validation.h	Merge #18637: coins: allow cache resize after init	2020-07-29 07:53:19 +02:00
validationinterface.cpp	trivial: Suggested cleanups to surrounding code	2020-05-22 16:30:07 -04:00
validationinterface.h	trivial: Suggested cleanups to surrounding code	2020-05-22 16:30:07 -04:00
version.h	Add p2p message "wtxidrelay"	2020-07-19 02:10:41 -04:00
versionbits.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
versionbits.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
versionbitsinfo.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
versionbitsinfo.h
walletinitinterface.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
warnings.cpp	Make SetMiscWarning() accept bilingual_str argument	2020-06-10 15:01:20 +03:00
warnings.h	Make SetMiscWarning() accept bilingual_str argument	2020-06-10 15:01:20 +03:00