Andrew Chow
886e0d75f5
Implement CWallet::IsSpentKey for non-LegacySPKMans
2020-04-23 13:59:48 -04:00
Andrew Chow
3c19fdd2a2
Return error when no ScriptPubKeyMan is available for specified type
...
When a CWallet doesn't have a ScriptPubKeyMan for the requested type
in GetNewDestination, give a meaningful error. Also handle this in
Qt which did not do anything with errors.
2020-04-23 13:59:48 -04:00
Andrew Chow
388ba94231
Change wallet_encryption.py to use signmessage instead of dumpprivkey
2020-04-23 13:59:48 -04:00
Andrew Chow
1346e14831
Functional tests for descriptor wallets
2020-04-23 13:59:48 -04:00
Hugo Nguyen
f193ea889d
add importdescriptors RPC and tests for native descriptor wallets
...
Co-authored-by: Andrew Chow <achow101-github@achow101.com>
2020-04-23 13:59:48 -04:00
Andrew Chow
ce24a94494
Add IsLegacy to CWallet so that the GUI knows whether to show watchonly
2020-04-23 13:59:48 -04:00
Andrew Chow
1cb42b22b1
Generate new descriptors when encrypting
2020-04-23 13:59:48 -04:00
Andrew Chow
82ae02b165
Be able to create new wallets with DescriptorScriptPubKeyMans as backing
2020-04-23 13:59:48 -04:00
Andrew Chow
b713baa75a
Implement GetMetadata in DescriptorScriptPubKeyMan
2020-04-23 13:59:48 -04:00
Andrew Chow
8b9603bd0b
Change GetMetadata to use unique_ptr<CKeyMetadata>
2020-04-23 13:59:48 -04:00
Andrew Chow
72a9540df9
Implement FillPSBT in DescriptorScriptPubKeyMan
...
FillPSBT will add our own scripts to the PSBT if those inputs are ours.
If an input also lists pubkeys that we happen to know the private keys
for, we will sign those inputs too.
2020-04-23 13:59:48 -04:00
Andrew Chow
84b4978c02
Implement SignMessage for descriptor wallets
2020-04-23 13:59:48 -04:00
Andrew Chow
bde7c9fa38
Implement SignTransaction in DescriptorScriptPubKeyMan
2020-04-23 13:59:48 -04:00
Andrew Chow
d50c8ddd41
Implement GetSolvingProvider for DescriptorScriptPubKeyMan
...
Internally, a GetSigningProvider function is introduced which allows for
some private keys to be optionally included. This can be called with a
script as the argument (i.e. a scriptPubKey from our wallet when we are
signing) or with a pubkey. In order to know what index to expand the
private keys for that pubkey, we need to also cache all of the pubkeys
involved when we expand the descriptor. So SetCache and TopUp are
updated to do this too.
2020-04-23 13:59:48 -04:00
Andrew Chow
f1ca5feb4a
Implement GetKeypoolOldestTime and only display it if greater than 0
2020-04-23 13:59:48 -04:00
Andrew Chow
586b57a9a6
Implement ReturnDestination in DescriptorScriptPubKeyMan
2020-04-23 13:59:48 -04:00
Andrew Chow
f866957979
Implement GetReservedDestination in DescriptorScriptPubKeyMan
2020-04-23 13:59:48 -04:00
Andrew Chow
a775f7c7fd
Implement Unlock and Encrypt in DescriptorScriptPubKeyMan
2020-04-23 13:59:48 -04:00
Andrew Chow
bfdd073486
Implement GetNewDestination for DescriptorScriptPubKeyMan
2020-04-23 13:59:48 -04:00
Andrew Chow
58c7651821
Implement TopUp in DescriptorScriptPubKeyMan
2020-04-23 13:59:48 -04:00
Andrew Chow
e014886a34
Implement SetupGeneration for DescriptorScriptPubKeyMan
2020-04-23 13:59:48 -04:00
Andrew Chow
46dfb99768
Implement writing descriptorkeys, descriptorckeys, and descriptors to wallet file
2020-04-23 13:59:48 -04:00
Andrew Chow
4cb9b69be0
Implement several simple functions in DescriptorScriptPubKeyMan
...
Implements a bunch of one liners: UpgradeKeyMetadata, IsFirstRun, HavePrivateKeys,
KeypoolCountExternalKeys, GetKeypoolSize, GetTimeFirstKey, CanGetAddresses,
RewriteDB
2020-04-23 13:59:48 -04:00
Andrew Chow
d1ec3e4f19
Add IsSingleType to Descriptors
...
IsSingleType will return whether the descriptor will give one or multiple scriptPubKeys
2020-04-23 13:59:48 -04:00
Andrew Chow
953feb3d27
Implement loading of keys for DescriptorScriptPubKeyMan
2020-04-23 13:59:48 -04:00
Andrew Chow
2363e9fcaa
Load the descriptor cache from the wallet file
2020-04-23 13:59:48 -04:00
Andrew Chow
46c46aebb7
Implement GetID for DescriptorScriptPubKeyMan
2020-04-23 13:59:48 -04:00
Andrew Chow
ec2f9e1178
Implement IsHDEnabled in DescriptorScriptPubKeyMan
2020-04-23 13:59:48 -04:00
Andrew Chow
741122d4c1
Implement MarkUnusedAddresses in DescriptorScriptPubKeyMan
2020-04-23 13:59:48 -04:00
Andrew Chow
2db7ca765c
Implement IsMine for DescriptorScriptPubKeyMan
...
Adds a set of scriptPubKeys that DescriptorScriptPubKeyMan tracks.
If the given script is in that set, it is considered ISMINE_SPENDABLE
2020-04-23 13:59:48 -04:00
Andrew Chow
db7177af8c
Add LoadDescriptorScriptPubKeyMan and SetActiveScriptPubKeyMan to CWallet
2020-04-23 13:59:42 -04:00
Andrew Chow
78f8a92910
Implement SetType in DescriptorScriptPubKeyMan
2020-04-23 13:25:50 -04:00
Andrew Chow
834de0300c
Store WalletDescriptor in DescriptorScriptPubKeyMan
2020-04-23 13:25:50 -04:00
Andrew Chow
d8132669e1
Add a lock cs_desc_man for DescriptorScriptPubKeyMan
2020-04-23 13:25:50 -04:00
Andrew Chow
3194a7f88a
Introduce WalletDescriptor class
...
WalletDescriptor is a Descriptor with other wallet metadata
2020-04-23 13:25:50 -04:00
Andrew Chow
6b13cd3fa8
Create LegacyScriptPubKeyMan when not a descriptor wallet
2020-04-23 13:25:50 -04:00
Andrew Chow
aeac157c9d
Return nullptr from GetLegacyScriptPubKeyMan if descriptor wallet
2020-04-23 13:25:50 -04:00
Andrew Chow
96accc73f0
Add WALLET_FLAG_DESCRIPTORS
2020-04-23 13:25:50 -04:00
Andrew Chow
6b8119af53
Introduce DescriptorScriptPubKeyMan as a dummy class
2020-04-23 13:25:50 -04:00
Andrew Chow
06620302c7
Introduce SetType function to tell ScriptPubKeyMans the type and internal-ness of it
2020-04-23 13:25:50 -04:00
MarcoFalke
64139803f1
Merge #18690 : test: Check object hashes in wait_for_getdata
...
9f5608c289#18614 , but closing that issue would also involve some additional changes to `wait_for_getheaders`.
ACKs for top commit:
theStack:
ACK 9f5608c289🍻
Tree-SHA512: 8e7f95881c19631db014d4bb2399fea0d14686a32542f6ca3b60809744b0d684eac4e4c107c87143991f3cd0c2d4ab09d0c17486239768a9b40bee25f2e4d54a
2020-04-23 06:37:53 -04:00
Samuel Dobson
e890c15e2c
Merge #18671 : wallet: Add BlockUntilSyncedToCurrentChain to dumpwallet
...
fa60afc4fbe84a5f0004/doc/developer-notes.md (L1095)https://travis-ci.org/github/bitcoin/bitcoin/jobs/675487097#L2657 , which can only happen in master because the test was not backported.
ACKs for top commit:
promag:
Code review ACK fa60afc4fbfa60afc4fbfa60afc4fb
2020-04-23 14:12:35 +12:00
Samuel Dobson
4f802e59a0
Merge #17509 : gui: save and load PSBT
...
764bfe4cba1cd8dc2556f6895301f71d05a9d80b86e22d23bb6ab3aad9a5https://user-images.githubusercontent.com/10217/71765684-ba60d580-2f32-11ea-8dea-0c4398eb6e15.png ">
<img width="287" alt="Schermafbeelding 2020-01-04 om 20 40 35" src="https://user-images.githubusercontent.com/10217/71765677-a0bf8e00-2f32-11ea-8172-12dfd34a89f3.png ">
<img width="594" alt="Schermafbeelding 2020-01-04 om 20 41 12" src="https://user-images.githubusercontent.com/10217/71765681-aa48f600-2f32-11ea-8e2c-c4f6bf9f5309.png ">
<img width="632" alt="Schermafbeelding 2020-01-04 om 20 41 28" src="https://user-images.githubusercontent.com/10217/71765691-d19fc300-2f32-11ea-97ff-70f5dd59987a.png ">
By default the file name contains the destination address(es) and amount(s).
We only use the binary format for files, in order to avoid compatibility hell. If we do want to add base64 file format support, we should use a different extension for that (`.psbt64`?).
## Load flow
Select a file:
<img width="649" alt="Schermafbeelding 2020-01-04 om 21 08 57" src="https://user-images.githubusercontent.com/10217/71766089-2ba28780-2f37-11ea-875d-074794b5707d.png ">
Offer to send if complete:
<img width="308" alt="Schermafbeelding 2020-01-04 om 21 09 06" src="https://user-images.githubusercontent.com/10217/71766088-2a715a80-2f37-11ea-807d-394c8b840c59.png ">
Tell user if signatures are missing, offer to copy to clipboard:
<img width="308" alt="Schermafbeelding 2020-01-04 om 21 15 57" src="https://user-images.githubusercontent.com/10217/71766115-702e2300-2f37-11ea-9f62-a6ede499c0fa.png ">
Incomplete for another reason:
<img width="309" alt="Schermafbeelding 2020-01-04 om 21 07 51" src="https://user-images.githubusercontent.com/10217/71766090-2c3b1e00-2f37-11ea-8a22-6188377b67a1.png ">
ACKs for top commit:
instagibbs:
re-ACK 764bfe4cba764bfe4cba764bfe4cba764bfe4c764bfe4cba
2020-04-23 13:16:23 +12:00
MarcoFalke
47b94a337e
Merge #18732 : test: Remove unused, undocumented and misleading CScript.__add__
...
faff9e4bb4#18612
ACKs for top commit:
laanwj:
ACK faff9e4bb4
2020-04-22 15:49:22 -04:00
MarcoFalke
fb89af26d8
Merge #18733 : doc: Add wallet release notes for 0.21.0
...
facaefadd3faa4243c11facaefadd3facaefadd3
2020-04-22 15:45:56 -04:00
Danny Lee
9f5608c289
test: check for matching object hashes in wait_for_getdata
2020-04-22 10:46:08 -07:00
MarcoFalke
a7a6f1ff41
Merge #18575 : bench: Remove requirement that all benches use same testing setup
...
fa1fdb02fcfab1170964#13687 should prevent this already.
Top commit has no ACKs.
Tree-SHA512: 7c98aea7725a20f4b9225221f4279b9e9f7257ed5c14712ad01ea80d87c3b0fed760b40f413892498bbb354a917ee02d4c575cbe8423a403b86755e8ee11f33b
2020-04-22 10:52:40 -04:00
MarcoFalke
facaefadd3
doc: Add wallet release notes for 0.21.0
2020-04-22 09:22:49 -04:00
Wladimir J. van der Laan
5dcb061589
Merge #18702 : build: fix ASLR for bitcoin-cli on Windows
...
315a4d36f7https://sourceware.org/bugzilla/show_bug.cgi?id=19011 .
All other Windows binaries that we distribute (bitcoind, bitcoin-qt,
bitcoin-wallet, bitcoin-tx and test_bitcoin) do not suffer this issue,
and currently having working ASLR. This is due to them exporting
(inadvertent or not) libsecp256k1 symbols, and, as a result, the .reloc
section is not stripped by ld.
This change is a temporary workaround, also the same one described here:
https://www.kb.cert.org/vuls/id/307144/ , that causes main() to be
exported. Exporting a symbol will mean that the .reloc section is not
stripped, and ASLR will function correctly.
Ultimately, this will be fixed by using a newer version of binutils (that has this [change](https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=dc9bd8c92af67947db44b3cb428c050259b15cd0 )). Whether that's through bumping our gitian distro, or Guix.
Related to #18629 , which has a bunch of additional information in the PR description. If you would like to verify whether or not ASLR is indeed working, with or without this change. One easy way to check is using a tool like [VMMap](https://docs.microsoft.com/en-us/sysinternals/downloads/vmmap ).
Here are the memory mappings for the 0.20.0rc1 `bitcoind.exe` and `bitcoin-cli.exe` binaries. You'll notice that over machine restarts, even though the image is marked `(ASLR)` (which I assume may be due to the header bit being set), no ASLR is actually occuring for `bitcoin-cli.exe`:
#### bitcoind.exe
#### bitcoin-cli.exe
ACKs for top commit:
dongcarl:
ACK 315a4d36f7315a4d36f7
2020-04-22 15:18:11 +02:00
MarcoFalke
faa4243c11
Add release notes skeleton, so that notes can be filled easier
2020-04-22 09:16:05 -04:00
