phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-04-29 14:59:39 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

REMOVE-ME: Some small changes to try to debug CI failure

Browse source
This commit is contained in:
Sergi Delgado Segura 2025-04-24 10:23:09 -04:00
parent 236dd9b8bb
commit b71131e1af
2 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/net_processing.cpp
View file

@ -6032,6 +6032,10 @@ bool PeerManagerImpl::SendMessages(CNode* pto)
for (auto& [hash, out_fanout_count] : to_be_announced) { for (auto& [hash, out_fanout_count] : to_be_announced) {
// Send // Send
bool should_fanout = true; bool should_fanout = true;
// FIXME: Remove. A functional test about how many peers to fanout to has failed in CI and I'm currently clueless about why.
// Trying to get some context.
LogDebug(BCLog::NET, "%d outbound peers currently know about %s\n", out_fanout_count, hash.ToString());
// For non-Erlay and inbound peer simply fanout. Erlay-enabled inbounds have been assigned transaction to reconcile // For non-Erlay and inbound peer simply fanout. Erlay-enabled inbounds have been assigned transaction to reconcile
// in RelayTransaction, so everything that was added to m_tx_inventory_to_send is to be fanout // in RelayTransaction, so everything that was added to m_tx_inventory_to_send is to be fanout
if (!pto->IsInboundConn() && m_txreconciliation && m_txreconciliation->IsPeerRegistered(pto->GetId())) { if (!pto->IsInboundConn() && m_txreconciliation && m_txreconciliation->IsPeerRegistered(pto->GetId())) {

3
src/node/txreconciliation.cpp
View file

@ -700,6 +700,9 @@ public:
Wtxid collision; Wtxid collision;
uint32_t short_id; uint32_t short_id;
if (HasCollision(peer_state, wtxid, collision, short_id)) { if (HasCollision(peer_state, wtxid, collision, short_id)) {
LogPrintLevel(BCLog::TXRECONCILIATION, BCLog::Level::Debug, "%s has had a short id collision with %s for peer=%d. The transaction was not "
"added to the set\n", wtxid.ToString(), collision.ToString(), peer_id);
return AddToSetResult::Collision(collision); return AddToSetResult::Collision(collision);
} }