From b71131e1af1fa462e8feef3845eae055759fed95 Mon Sep 17 00:00:00 2001 From: Sergi Delgado Segura Date: Thu, 24 Apr 2025 10:23:09 -0400 Subject: [PATCH] REMOVE-ME: Some small changes to try to debug CI failure --- src/net_processing.cpp | 4 ++++ src/node/txreconciliation.cpp | 3 +++ 2 files changed, 7 insertions(+) diff --git a/src/net_processing.cpp b/src/net_processing.cpp index 565aab70883..2de88fca3fb 100644 --- a/src/net_processing.cpp +++ b/src/net_processing.cpp @@ -6032,6 +6032,10 @@ bool PeerManagerImpl::SendMessages(CNode* pto) for (auto& [hash, out_fanout_count] : to_be_announced) { // Send bool should_fanout = true; + + // FIXME: Remove. A functional test about how many peers to fanout to has failed in CI and I'm currently clueless about why. + // Trying to get some context. + LogDebug(BCLog::NET, "%d outbound peers currently know about %s\n", out_fanout_count, hash.ToString()); // For non-Erlay and inbound peer simply fanout. Erlay-enabled inbounds have been assigned transaction to reconcile // in RelayTransaction, so everything that was added to m_tx_inventory_to_send is to be fanout if (!pto->IsInboundConn() && m_txreconciliation && m_txreconciliation->IsPeerRegistered(pto->GetId())) { diff --git a/src/node/txreconciliation.cpp b/src/node/txreconciliation.cpp index f5026cafc20..945ab7b2ce1 100644 --- a/src/node/txreconciliation.cpp +++ b/src/node/txreconciliation.cpp @@ -700,6 +700,9 @@ public: Wtxid collision; uint32_t short_id; if (HasCollision(peer_state, wtxid, collision, short_id)) { + + LogPrintLevel(BCLog::TXRECONCILIATION, BCLog::Level::Debug, "%s has had a short id collision with %s for peer=%d. The transaction was not " + "added to the set\n", wtxid.ToString(), collision.ToString(), peer_id); return AddToSetResult::Collision(collision); }