phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-01-25 10:43:19 -03:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

doc: banman: reference past vuln due to unbounded banlist

Browse source
This commit is contained in:
Antoine Poinsot 2024-07-28 11:06:55 +02:00
parent 70992f59de
commit 7fea8eeeb9
No known key found for this signature in database
GPG key ID: E13FC145CD3F4304
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/banman.h
View file

@ -54,6 +54,11 @@ class CSubNet;
// transaction that fails a policy check and a future version changes the
// policy check so the transaction is accepted, then that transaction could
// cause the network to split between old nodes and new nodes.
//
// NOTE: previously a misbehaving peer would get banned instead of discouraged.
// This meant a peer could unboundedly grow our in-memory map of banned ips. When
// receiving an ADDR message we would also compare every address received to every
// item in the map. See https://bitcoincore.org/en/2024/07/03/disclose-unbounded-banlist.
class BanMan
{