From 7fea8eeeb9984ff6f3ed661f3970b1aaa68548de Mon Sep 17 00:00:00 2001 From: Antoine Poinsot Date: Sun, 28 Jul 2024 11:06:55 +0200 Subject: [PATCH] doc: banman: reference past vuln due to unbounded banlist --- src/banman.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/banman.h b/src/banman.h index 57ba2ac23c..23e19506df 100644 --- a/src/banman.h +++ b/src/banman.h @@ -54,6 +54,11 @@ class CSubNet; // transaction that fails a policy check and a future version changes the // policy check so the transaction is accepted, then that transaction could // cause the network to split between old nodes and new nodes. +// +// NOTE: previously a misbehaving peer would get banned instead of discouraged. +// This meant a peer could unboundedly grow our in-memory map of banned ips. When +// receiving an ADDR message we would also compare every address received to every +// item in the map. See https://bitcoincore.org/en/2024/07/03/disclose-unbounded-banlist. class BanMan {