phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-04-29 14:59:39 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

test: Remove redundant repeated test

Browse source 
We do not need to repeat the same test multiple times because BnB is
deterministic and will therefore always have the same outcome.
Additionally, this test was redundant because it repeats the "Smallest
combination too big" test.
This commit is contained in:
Murch 2024-03-01 15:42:08 -05:00
parent ad230e58a5
commit 11ef133ea2
No known key found for this signature in database
GPG key ID: 7BA035CA5B901713
1 changed files with 0 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/wallet/test/coinselector_tests.cpp
View file

@ -209,15 +209,6 @@ BOOST_AUTO_TEST_CASE(bnb_search_test)
//////////////////// ////////////////////
// Behavior tests // // Behavior tests //
//////////////////// ////////////////////
// Select 1 Cent with pool of only greater than 5 Cent
utxo_pool.clear();
for (int i = 5; i <= 20; ++i) {
add_coin(i * CENT, i, utxo_pool);
}
// Run 100 times, to make sure it is never finding a solution
for (int i = 0; i < 100; ++i) {
BOOST_CHECK(!SelectCoinsBnB(GroupCoins(utxo_pool), 1 * CENT, 2 * CENT));
}
// Make sure that effective value is working in AttemptSelection when BnB is used // Make sure that effective value is working in AttemptSelection when BnB is used
CoinSelectionParams coin_selection_params_bnb{ CoinSelectionParams coin_selection_params_bnb{