phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-04-29 14:59:39 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

test: Recreate simple BnB failure tests

Browse source
This commit is contained in:
Murch 2024-03-01 15:41:19 -05:00
parent 3921017ff2
commit ad230e58a5
No known key found for this signature in database
GPG key ID: 7BA035CA5B901713
2 changed files with 17 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/wallet/test/coinselection_tests.cpp
View file

@ -114,9 +114,18 @@ static void TestBnBSuccess(std::string test_title, std::vector<OutputGroup>& utx
BOOST_CHECK_MESSAGE(result->GetSelectedValue() == expected_amount, strprintf("Selected amount mismatch in BnB-Success: %s. Expected %d, but got %d", test_title, expected_amount, result->GetSelectedValue()));
}
static void TestBnBFail(std::string test_title, std::vector<OutputGroup>& utxo_pool, const CAmount& selection_target)
{
BOOST_CHECK_MESSAGE(!SelectCoinsBnB(utxo_pool, selection_target, /*cost_of_change=*/default_cs_params.m_cost_of_change, /*max_selection_weight=*/MAX_STANDARD_TX_WEIGHT), "BnB-Fail: " + test_title);
}
BOOST_AUTO_TEST_CASE(bnb_test)
{
std::vector<OutputGroup> utxo_pool;
// Fail for empty UTXO pool
TestBnBFail("Empty UTXO pool", utxo_pool, /*selection_target=*/1 * CENT);
AddCoins(utxo_pool, {1 * CENT, 3 * CENT, 5 * CENT});
// Simple success cases
@ -129,6 +138,14 @@ BOOST_AUTO_TEST_CASE(bnb_test)
// BnB finds changeless solution while overshooting by up to cost_of_change
TestBnBSuccess("Select upper bound", utxo_pool, /*selection_target=*/4 * CENT - default_cs_params.m_cost_of_change, /*expected_input_amounts=*/{1 * CENT, 3 * CENT});
// BnB fails to find changeless solution when overshooting by cost_of_change + 1 sat
TestBnBFail("Overshoot upper bound", utxo_pool, /*selection_target=*/4 * CENT - default_cs_params.m_cost_of_change - 1);
// Simple cases without BnB solution
TestBnBFail("Smallest combination too big", utxo_pool, /*selection_target=*/0.5 * CENT);
TestBnBFail("No UTXO combination in target window", utxo_pool, /*selection_target=*/7 * CENT);
TestBnBFail("Select more than available", utxo_pool, /*selection_target=*/10 * CENT);
// Test skipping of equivalent input sets
std::vector<OutputGroup> clone_pool;
AddCoins(clone_pool, {2 * CENT, 7 * CENT, 7 * CENT});

21
src/wallet/test/coinselector_tests.cpp
View file

@ -199,27 +199,6 @@ BOOST_AUTO_TEST_CASE(bnb_search_test)
// Known Outcome tests //
/////////////////////////
// Empty utxo pool
BOOST_CHECK(!SelectCoinsBnB(GroupCoins(utxo_pool), 1 * CENT, 0.5 * CENT));
// Add utxos
add_coin(1 * CENT, 1, utxo_pool);
add_coin(2 * CENT, 2, utxo_pool);
add_coin(3 * CENT, 3, utxo_pool);
add_coin(4 * CENT, 4, utxo_pool);
// Select 11 Cent, not possible
BOOST_CHECK(!SelectCoinsBnB(GroupCoins(utxo_pool), 11 * CENT, 0.5 * CENT));
expected_result.Clear();
// Cost of change is less than the difference between target value and utxo sum
BOOST_CHECK(!SelectCoinsBnB(GroupCoins(utxo_pool), 0.9 * CENT, 0));
expected_result.Clear();
// Select 0.25 Cent, not possible
BOOST_CHECK(!SelectCoinsBnB(GroupCoins(utxo_pool), 0.25 * CENT, 0.5 * CENT));
expected_result.Clear();
// Iteration exhaustion test
CAmount target = make_hard_case(17, utxo_pool);
BOOST_CHECK(!SelectCoinsBnB(GroupCoins(utxo_pool), target, 1)); // Should exhaust