UI: add option to hide the icon column #604

Open

SSimco wants to merge 3 commits from SSimco/iconcol into main

pull from: SSimco/iconcol

merge into: cemu-project_Mirror:main

cemu-project_Mirror:main

Conversation 2 Commits 3 Files changed 3 +18 -2

SSimco commented 2023-01-06 06:24:33 -03:00 (Migrated from github.com)

Copy link

Remove the icon column and display the icon in the name column.
Before:

After:

Remove the icon column and display the icon in the name column. Before:  After: 

👍 6 👎 3 😕 2

Cexer6 commented 2023-01-08 20:23:07 -03:00 (Migrated from github.com)

Copy link

Hi, since you are taking the trouble to modify this aspect of the emulator, if I may, would you accept a suggestion?

How about instead, we keep the columns unlinked and also add the "Icon" column along with the rest?

This way you could hide/show each column at will as other emulators do (eg: Dolphin and RPCS3).
Thank you very much.

Hi, since you are taking the trouble to modify this aspect of the emulator, if I may, would you accept a suggestion? How about instead, we keep the columns unlinked and also add the "Icon" column along with the rest? This way you could hide/show each column at will as other emulators do (eg: Dolphin and RPCS3). Thank you very much. 

👍 22

SSimco commented 2023-01-09 08:35:48 -03:00 (Migrated from github.com)

Copy link

Hi, since you are taking the trouble to modify this aspect of the emulator, if I may, would you accept a suggestion?

How about instead, we keep the columns unlinked and also add the "Icon" column along with the rest?

This way you could hide/show each column at will as other emulators do (eg: Dolphin and RPCS3). Thank you very much.

Sure, it might be a better idea than the original one to merge them.
With the current changes you should be able to hide the icon column when right clicking the header, just like the rest of the columns.

> > Hi, since you are taking the trouble to modify this aspect of the emulator, if I may, would you accept a suggestion? > > How about instead, we keep the columns unlinked and also add the "Icon" column along with the rest? > > This way you could hide/show each column at will as other emulators do (eg: Dolphin and RPCS3). Thank you very much.  Sure, it might be a better idea than the original one to merge them. With the current changes you should be able to hide the icon column when right clicking the header, just like the rest of the columns.

👍 3 ❤️ 1

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin SSimco/iconcol:SSimco/iconcol

git checkout SSimco/iconcol

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout main

git merge --no-ff SSimco/iconcol

git checkout SSimco/iconcol

git rebase main

git checkout main

git merge --ff-only SSimco/iconcol

git checkout SSimco/iconcol

git rebase main

git checkout main

git merge --no-ff SSimco/iconcol

git checkout main

git merge --squash SSimco/iconcol

git checkout main

git merge --ff-only SSimco/iconcol

git checkout main

git merge SSimco/iconcol

git push origin main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: cemu-project_Mirror/Cemu-2024-03-05#604

No description provided.