Update thorium-shell.desktop #370

Open

sahashirshendu wants to merge 1 commit from sahashirshendu/patch-1 into main

sahashirshendu commented

2023-10-29 11:04:23 -03:00

(Migrated from github.com)

The path doesn't exist (in Arch, installed from AUR package)

gz83 (Migrated from github.com) reviewed 2023-10-29 11:04:23 -03:00

Alex313031 (Migrated from github.com) reviewed 2023-10-29 11:04:23 -03:00

gz83 commented

2023-10-29 11:09:38 -03:00

(Migrated from github.com)

It's LGTM for me, but can you provide more error information or link to some issues?

@sahashirshendu

It's LGTM for me, but can you provide more error information or link to some issues? @sahashirshendu

sahashirshendu commented

2023-10-29 11:14:53 -03:00

(Migrated from github.com)

Not much of an error, but in my system (Arch with KDE) there is no icon in application menu for thorium shell due to the faulty path which does not exist. Doing the above correction in icon-path in the desktop file works. [Because the AUR pkgbuild installs thorium in /opt/thorium-browser link, not sure about other systems]

Not much of an error, but in my system (Arch with KDE) there is no icon in application menu for `thorium shell` due to the faulty path which does not exist. Doing the above correction in icon-path in the desktop file works. [Because the AUR pkgbuild installs thorium in `/opt/thorium-browser` [link](https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=thorium-browser-bin#n97), not sure about other systems]

gz83 commented

2023-10-29 11:18:53 -03:00

(Migrated from github.com)

Handed over to Alex for further review

👍 1

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin sahashirshendu/patch-1:sahashirshendu/patch-1

git checkout sahashirshendu/patch-1

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout main

git merge --no-ff sahashirshendu/patch-1

git checkout sahashirshendu/patch-1

git rebase main

git checkout main

git merge --ff-only sahashirshendu/patch-1

git checkout sahashirshendu/patch-1

git rebase main

git checkout main

git merge --no-ff sahashirshendu/patch-1

git checkout main

git merge --squash sahashirshendu/patch-1