Update hardcoded icons in toolbar #257

Open

Aman9das wants to merge 3 commits from Aman9das/patch-1 into main

Aman9das commented

2023-10-18 04:01:46 -03:00

(Migrated from github.com)

I changed the icons back to the chromium ones, but this method is probably rudimentary. It'd be better to ship a thorium theme by default which can be replaced by the user easily

👍 2

Alex313031 (Migrated from github.com) reviewed 2023-10-18 04:01:46 -03:00

gz83 (Migrated from github.com) requested changes 2023-10-18 09:45:47 -03:00

gz83 (Migrated from github.com) left a comment

Please talk to Alex before making such changes.

If it's really necessary to change it, my idea would be to make a switch for the existing icon and the default icon that can be freely toggled on and off, rather than just simply changing the icon to the default.

@Aman9das @Alex313031

Please talk to Alex before making such changes. If it's really necessary to change it, my idea would be to make a switch for the existing icon and the default icon that can be freely toggled on and off, rather than just simply changing the icon to the default. @Aman9das @Alex313031

Aman9das commented

2023-10-19 10:37:05 -03:00

(Migrated from github.com)

I do not expect this to be merged, any way to enable both default and branded icons are better.

This is just present in case such a thing is not possible, it'd easy to revert back to default icons.

I do not expect this to be merged, any way to enable both default and branded icons are better. This is just present in case such a thing is not possible, it'd easy to revert back to default icons.

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin Aman9das/patch-1:Aman9das/patch-1

git checkout Aman9das/patch-1

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout main

git merge --no-ff Aman9das/patch-1

git checkout Aman9das/patch-1

git rebase main

git checkout main

git merge --ff-only Aman9das/patch-1

git checkout Aman9das/patch-1

git rebase main

git checkout main

git merge --no-ff Aman9das/patch-1

git checkout main

git merge --squash Aman9das/patch-1