serg2-mirrors/GDBrowser
1
0
Fork 0
Code Issues 8 Pull requests 10 Projects Releases Packages Wiki Activity Actions

typeof output gets coerced to bool #246

New issue
Open
opened 2022-06-15 18:57:29 -04:00 by Rudxain · 1 comment
Rudxain commented 2022-06-15 18:57:29 -04:00 (Migrated from github.com)
Copy link

The parseIconPlist script is checking the truthiness value of typeof at line 23. Is it supposed to be typeof fileData[innerKey] == "string"? Or is the expression not needed there?

The `parseIconPlist` script is checking the truthiness value of `typeof` [at line 23](https://github.com/GDColon/GDBrowser/blob/master/misc/manual%20parsers/parseIconPlist.js#L23). Is it supposed to be `typeof fileData[innerKey] == "string"`? Or is the expression not needed there?
GDColon commented 2022-06-15 22:36:03 -04:00 (Migrated from github.com)
Copy link

LMAO honestly I have no idea, probably meant to be string but considering the script works fine as is it can probably just be removed entirely

LMAO honestly I have no idea, probably meant to be string but considering the script works fine as is it can probably just be removed entirely
👍 1 😆 2
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
april-fools-2021
No results found.
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: serg2-mirrors/GDBrowser#246
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?