serg2-mirrors/GDBrowser
1
0
Fork 0
Code Issues 8 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Refactored XOR.js to call replace once #221

Merged
Rudxain merged 2 commits from patch-1 into master 2022-05-07 21:10:43 -04:00
Conversation 1 Commits 2 Files changed 1 +3 -3
Rudxain commented 2022-05-07 19:22:25 -04:00 (Migrated from github.com)
Copy link

Now it's optimized and refactored to replace the same chars as before and leave other chars intact. The s (dot-all) flag is used to reduce conditional branching. I don't know if this code is actually better in the Node env, I just wanted to suggest this as a possible alternative

Now it's optimized and refactored to replace the same chars as before and leave other chars intact. The `s` (dot-all) flag is used to reduce conditional branching. I don't know if this code is actually better in the Node env, I just wanted to suggest this as a possible alternative
GDColon commented 2022-05-07 21:10:45 -04:00 (Migrated from github.com)
Copy link

Looks like I learned something new today

Looks like I learned something new today
🎉 1
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: serg2-mirrors/GDBrowser#221
No description provided.
Delete branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?