phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-01-15 22:32:37 -03:00
Code Issues Projects Releases Packages Wiki Activity Actions 1
bitcoin/src/wallet
History
Wladimir J. van der Laan e9b3012654
Merge #19750: refactor: remove unused c-string variant of atoi64() 
71e0f07e9c util: remove unused c-string variant of atoi64() (Sebastian Falbesoner)

Pull request description:

  This is another micro-PR "removing old cruft with potentially sharp edges" (quote by practicalswift, see #19739). Gets rid of the c-string variant of the function `atoi64()`, which is only used in fuzzers and on one place with `wallet/wallet.h` (where it is originally a `std::string` anyways and uses `.c_str()` -- this method call can simply be removed.)

ACKs for top commit:
  practicalswift:
    ACK 71e0f07e9c -- diff looks correct
  laanwj:
    ACK 71e0f07e9c

Tree-SHA512: 4d1d28e2f5274fdbe0652e7a0f83dd416f4d19c1e1a49979927960a3ad40b0990eeaa4374656bf2c6998a965a14d62c1bc78303b7d583d3307c17828030a8e3b
2020-08-19 15:04:34 +02:00
..
test Make Hash[160] consume range-like objects 2020-07-30 13:57:54 -07:00
bdb.cpp refactor: Make HexStr take a span 2020-08-06 19:41:43 +02:00
bdb.h Remove BDB dummy databases 2020-07-29 12:30:23 -04:00
coincontrol.cpp [rpc] walletcreatefundedpsbt: don't automatically append inputs 2020-03-12 13:07:17 +01:00
coincontrol.h [rpc] walletcreatefundedpsbt: don't automatically append inputs 2020-03-12 13:07:17 +01:00
coinselection.cpp Refactor OutputGroups to handle effective values, fees, and filtering 2020-08-11 14:25:02 -04:00
coinselection.h Refactor OutputGroups to handle effective values, fees, and filtering 2020-08-11 14:25:02 -04:00
context.cpp Remove g_rpc_chain global 2020-05-28 02:13:19 -04:00
context.h wallet: Pass unused args to StartWallets 2020-07-09 13:07:37 +02:00
crypter.cpp Fix occurences of c_str() used with size() to data() 2019-10-28 13:41:45 +01:00
crypter.h Convert wallet to new serialization 2020-05-24 10:34:52 -07:00
db.cpp walletdb: Move BDB specific things into bdb.{cpp/h} 2020-06-15 20:41:05 -04:00
db.h Introduce DummyDatabase and use it in the tests 2020-07-29 12:28:30 -04:00
feebumper.cpp wallet: Remove trailing whitespace from potential translation strings 2020-05-01 07:41:32 -04:00
feebumper.h wallet: Avoid translating RPC errors when creating txs 2020-05-01 07:39:06 -04:00
fees.cpp Remove unused includes 2019-10-15 22:56:43 +00:00
fees.h Remove uses of fee globals in wallet code 2019-02-22 15:43:02 -04:00
init.cpp Merge #14582: wallet: always do avoid partial spends if fees are within a specified range 2020-08-17 16:18:28 +12:00
ismine.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
load.cpp Add loadwallet and createwallet RPC load_on_startup options 2020-08-13 09:44:48 -04:00
load.h Add loadwallet and createwallet RPC load_on_startup options 2020-08-13 09:44:48 -04:00
rpcdump.cpp refactor: Make HexStr take a span 2020-08-06 19:41:43 +02:00
rpcwallet.cpp Merge #15937: Add loadwallet and createwallet load_on_startup options 2020-08-15 12:19:48 +12:00
rpcwallet.h refactor: Combine GetWalletForJSONRPCRequest and EnsureWalletIsAvailable functions 2020-06-05 08:29:18 -04:00
salvage.cpp wallettool: Have RecoverDatabaseFile return errors and warnings 2020-07-26 20:22:45 -04:00
salvage.h wallettool: Have RecoverDatabaseFile return errors and warnings 2020-07-26 20:22:45 -04:00
scriptpubkeyman.cpp Merge #19046: Replace CWallet::Set* functions that use memonly with Add/Load variants 2020-07-11 23:08:54 +12:00
scriptpubkeyman.h Merge #19046: Replace CWallet::Set* functions that use memonly with Add/Load variants 2020-07-11 23:08:54 +12:00
wallet.cpp -maxapsfee: follow-up fixes 2020-08-18 19:24:39 +09:00
wallet.h util: remove unused c-string variant of atoi64() 2020-08-17 17:56:59 +02:00
walletdb.cpp Make Hash[160] consume range-like objects 2020-07-30 13:57:54 -07:00
walletdb.h Merge #19457: wallet: Cleanup wallettool salvage and walletdb extraneous declarations 2020-08-14 15:12:44 +02:00
wallettool.cpp build: Add Werror=range-loop-analysis 2020-08-14 15:27:38 +02:00
wallettool.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
walletutil.cpp Correctly check for default wallet 2020-04-23 13:59:48 -04:00
walletutil.h Convert wallet to new serialization 2020-05-24 10:34:52 -07:00