mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-02-02 14:37:42 -03:00
b3db8c9d5c
The current argument name and description are dangerous as it don't describe the case where the user selects the recipient output as the change address. This one could end up been increased by the inputs minus outputs remainder. Which, when bumpfee adds new inputs to the transaction, leads the process to send more coins to the recipient. Which is not what the user would expect from a 'reduce_output' param naming. Co-authored-by: Murch <murch@murch.one>
127 lines
4.1 KiB
C++
127 lines
4.1 KiB
C++
// Copyright (c) 2017-2021 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#ifndef BITCOIN_WALLET_FEEBUMPER_H
|
|
#define BITCOIN_WALLET_FEEBUMPER_H
|
|
|
|
#include <consensus/consensus.h>
|
|
#include <script/interpreter.h>
|
|
#include <primitives/transaction.h>
|
|
|
|
class uint256;
|
|
enum class FeeEstimateMode;
|
|
struct bilingual_str;
|
|
|
|
namespace wallet {
|
|
class CCoinControl;
|
|
class CWallet;
|
|
class CWalletTx;
|
|
|
|
namespace feebumper {
|
|
|
|
enum class Result
|
|
{
|
|
OK,
|
|
INVALID_ADDRESS_OR_KEY,
|
|
INVALID_REQUEST,
|
|
INVALID_PARAMETER,
|
|
WALLET_ERROR,
|
|
MISC_ERROR,
|
|
};
|
|
|
|
//! Return whether transaction can be bumped.
|
|
bool TransactionCanBeBumped(const CWallet& wallet, const uint256& txid);
|
|
|
|
/** Create bumpfee transaction based on feerate estimates.
|
|
*
|
|
* @param[in] wallet The wallet to use for this bumping
|
|
* @param[in] txid The txid of the transaction to bump
|
|
* @param[in] coin_control A CCoinControl object which provides feerates and other information used for coin selection
|
|
* @param[out] errors Errors
|
|
* @param[out] old_fee The fee the original transaction pays
|
|
* @param[out] new_fee the fee that the bump transaction pays
|
|
* @param[out] mtx The bump transaction itself
|
|
* @param[in] require_mine Whether the original transaction must consist of inputs that can be spent by the wallet
|
|
* @param[in] outputs Vector of new outputs to replace the bumped transaction's outputs
|
|
* @param[in] original_change_index The position of the change output to deduct the fee from in the transaction being bumped
|
|
*/
|
|
Result CreateRateBumpTransaction(CWallet& wallet,
|
|
const uint256& txid,
|
|
const CCoinControl& coin_control,
|
|
std::vector<bilingual_str>& errors,
|
|
CAmount& old_fee,
|
|
CAmount& new_fee,
|
|
CMutableTransaction& mtx,
|
|
bool require_mine,
|
|
const std::vector<CTxOut>& outputs,
|
|
std::optional<uint32_t> original_change_index = std::nullopt);
|
|
|
|
//! Sign the new transaction,
|
|
//! @return false if the tx couldn't be found or if it was
|
|
//! impossible to create the signature(s)
|
|
bool SignTransaction(CWallet& wallet, CMutableTransaction& mtx);
|
|
|
|
//! Commit the bumpfee transaction.
|
|
//! @return success in case of CWallet::CommitTransaction was successful,
|
|
//! but sets errors if the tx could not be added to the mempool (will try later)
|
|
//! or if the old transaction could not be marked as replaced.
|
|
Result CommitTransaction(CWallet& wallet,
|
|
const uint256& txid,
|
|
CMutableTransaction&& mtx,
|
|
std::vector<bilingual_str>& errors,
|
|
uint256& bumped_txid);
|
|
|
|
struct SignatureWeights
|
|
{
|
|
private:
|
|
int m_sigs_count{0};
|
|
int64_t m_sigs_weight{0};
|
|
|
|
public:
|
|
void AddSigWeight(const size_t weight, const SigVersion sigversion)
|
|
{
|
|
switch (sigversion) {
|
|
case SigVersion::BASE:
|
|
m_sigs_weight += weight * WITNESS_SCALE_FACTOR;
|
|
m_sigs_count += 1 * WITNESS_SCALE_FACTOR;
|
|
break;
|
|
case SigVersion::WITNESS_V0:
|
|
m_sigs_weight += weight;
|
|
m_sigs_count++;
|
|
break;
|
|
case SigVersion::TAPROOT:
|
|
case SigVersion::TAPSCRIPT:
|
|
assert(false);
|
|
}
|
|
}
|
|
|
|
int64_t GetWeightDiffToMax() const
|
|
{
|
|
// Note: the witness scaling factor is already accounted for because the count is multiplied by it.
|
|
return (/* max signature size=*/ 72 * m_sigs_count) - m_sigs_weight;
|
|
}
|
|
};
|
|
|
|
class SignatureWeightChecker : public DeferringSignatureChecker
|
|
{
|
|
private:
|
|
SignatureWeights& m_weights;
|
|
|
|
public:
|
|
SignatureWeightChecker(SignatureWeights& weights, const BaseSignatureChecker& checker) : DeferringSignatureChecker(checker), m_weights(weights) {}
|
|
|
|
bool CheckECDSASignature(const std::vector<unsigned char>& sig, const std::vector<unsigned char>& pubkey, const CScript& script, SigVersion sigversion) const override
|
|
{
|
|
if (m_checker.CheckECDSASignature(sig, pubkey, script, sigversion)) {
|
|
m_weights.AddSigWeight(sig.size(), sigversion);
|
|
return true;
|
|
}
|
|
return false;
|
|
}
|
|
};
|
|
|
|
} // namespace feebumper
|
|
} // namespace wallet
|
|
|
|
#endif // BITCOIN_WALLET_FEEBUMPER_H
|