W. J. van der Laan 39d597d362 Merge bitcoin/bitcoin#21659: net: flag relevant Sock methods with [[nodiscard]] ... e286cd0d7b net: flag relevant Sock methods with [[nodiscard]] (Vasil Dimov) Pull request description: Flag relevant Sock methods with `[[nodiscard]]` to avoid issues like the one fixed in https://github.com/bitcoin/bitcoin/pull/21631. ACKs for top commit: practicalswift: cr ACK e286cd0d7b: the only changes made are additions of `[[nodiscard]]` and `(void)` where appropriate laanwj: Code review ACK e286cd0d7b Tree-SHA512: addc361968d24912bb625b42f4db557791556bf0ffad818252a89a32d76ac22758ec70f8282dcfbfd77eebec20a8e6bb7557c8ed08d50a58de95378c34955973		2021-05-19 15:08:56 +02:00
..
asmap.cpp	refactor: Avoid sign-compare compiler warning in util/asmap	2021-04-29 11:38:18 +02:00
asmap.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
bip32.cpp	scripted-diff: Bump copyright headers	2020-04-16 13:33:09 -04:00
bip32.h	scripted-diff: Use [[nodiscard]] (C++17) instead of NODISCARD	2020-11-26 09:05:59 +00:00
bytevectorhash.cpp	blockfilter: Use unordered_set instead of set in blockfilter.	2018-11-05 09:30:56 -08:00
bytevectorhash.h	blockfilter: Use unordered_set instead of set in blockfilter.	2018-11-05 09:30:56 -08:00
check.h	util: Make Assume() usable as unary expression	2021-03-04 12:03:50 +01:00
epochguard.h	[refactor] txmempool: split epoch logic into class	2021-02-09 15:10:46 +10:00
error.cpp	rpc: send: support external signer	2021-02-23 14:34:32 +01:00
error.h	rpc: send: support external signer	2021-02-23 14:34:32 +01:00
fees.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
fees.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
getuniquepath.cpp	Introduce GetUniquePath(base) helper method to replace boost::filesystem::unique_path() which is not available in std::filesystem.	2021-02-04 11:38:09 +01:00
getuniquepath.h	Introduce GetUniquePath(base) helper method to replace boost::filesystem::unique_path() which is not available in std::filesystem.	2021-02-04 11:38:09 +01:00
golombrice.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
hash_type.h	move-only: Add util/hash_type	2021-05-11 10:38:18 +02:00
hasher.cpp	Add generic SaltedSipHasher	2020-11-10 14:33:37 -05:00
hasher.h	Add generic SaltedSipHasher	2020-11-10 14:33:37 -05:00
macros.h	refactor: Move STRINGIZE macro to macros.h	2021-02-01 22:30:05 +02:00
message.cpp	Replace boost::variant with std::variant	2021-01-05 10:10:50 +01:00
message.h	Move direct calls to MessageSign into new SignMessage functions in CWallet and ScriptPubKeyMan	2020-03-09 11:16:20 -04:00
moneystr.cpp	util: Avoid invalid integer negation in FormatMoney: make FormatMoney(const CAmount& n) well-defined also when n is std::numeric_limits<CAmount>::min()	2021-03-02 16:05:28 +00:00
moneystr.h	util: Avoid invalid integer negation in FormatMoney: make FormatMoney(const CAmount& n) well-defined also when n is std::numeric_limits<CAmount>::min()	2021-03-02 16:05:28 +00:00
rbf.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
rbf.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
readwritefile.cpp	util: fix WriteBinaryFile() claiming success even if error occurred	2021-03-01 12:57:00 +01:00
readwritefile.h	util: extract {Read,Write}BinaryFile() to its own files	2021-03-01 12:56:56 +01:00
settings.cpp	Add <datadir>/settings.json persistent settings storage.	2020-07-11 05:41:12 -04:00
settings.h	Add <datadir>/settings.json persistent settings storage.	2020-07-11 05:41:12 -04:00
sock.cpp	net: flag relevant Sock methods with [[nodiscard]]	2021-04-13 17:26:20 +02:00
sock.h	net: flag relevant Sock methods with [[nodiscard]]	2021-04-13 17:26:20 +02:00
spanparsing.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
spanparsing.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
strencodings.cpp	Merge bitcoin/bitcoin#21173: util: faster HexStr => 13% faster blockToJSON	2021-05-19 10:07:53 +02:00
strencodings.h	util: add ParseUInt16(), use it in SplitHostPort()	2021-03-16 19:52:33 +01:00
string.cpp	util: Add Join helper to join a list of strings	2019-08-20 16:51:41 -04:00
string.h	log: Prefix log messages with function name if -logsourcelocations is set	2021-01-15 09:57:32 +00:00
system.cpp	Change ClearDataDirPathCache() to ArgsManager.ClearPathCache().	2021-04-18 12:07:00 +02:00
system.h	Merge bitcoin/bitcoin#19064: refactor: Cleanup thread ctor calls	2021-05-12 08:51:32 +02:00
thread.cpp	refactor: Make TraceThread a non-template free function	2021-04-25 12:28:44 +03:00
thread.h	refactor: Make TraceThread a non-template free function	2021-04-25 12:28:44 +03:00
threadnames.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
threadnames.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
time.cpp	Merge #21110: util: remove Boost posix_time usage from GetTime*	2021-02-17 20:38:08 +01:00
time.h	Make all Poisson delays use std::chrono types	2021-03-03 09:48:07 -08:00
tokenpipe.cpp	refactor: post Optional<> removal cleanups	2021-03-17 14:56:20 +08:00
tokenpipe.h	util: Add RAII TokenPipe	2021-03-04 18:24:00 +01:00
trace.h	tracing: add tracing framework	2020-12-07 11:55:51 +01:00
translation.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
ui_change_type.h	wallet: Do not include server symbols	2020-06-27 11:39:09 -04:00
url.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
url.h	scripted-diff: Bump copyright headers	2020-04-16 13:33:09 -04:00
vector.h	Add some general std::vector utility functions	2019-10-16 08:56:57 -07:00