bitcoin/test/functional
Ava Chow 88b1229c13
Merge bitcoin/bitcoin#29400: test: Fix SegwitV0SignatureMsg nLockTime signedness
fab15723b0 test: Fix SegwitV0SignatureMsg nLockTime signedness (MarcoFalke)

Pull request description:

  It is unsigned in Bitcoin Core, so the tests should match it:

  5b8990a1f3/src/script/interpreter.cpp (L1611)

  The bug was introduced when the code was written in 330b0f31ee.

  (Lowercase `i` means signed, see https://docs.python.org/3/library/struct.html#format-characters)

ACKs for top commit:
  epiccurious:
    Tested ACK fab15723b0.
  Eunovo:
    Tested ACK fab15723b0
  achow101:
    ACK fab15723b0

Tree-SHA512: 68cb8582f6af22e6abb2fc9d6770277501baa0f9873e2e8d47699e87096fc5d4b9de45fa07199757b6e945c99d4c4ea95f01478322f2c093ef95cf5e0c78522b
2024-02-21 13:16:51 -05:00
..
data descriptor: InferScript, do not return top-level only func as sub descriptor 2023-07-20 11:04:52 -03:00
mocks script, test: fix python linter E275 errors with flake8 5.0.4 2023-01-03 10:59:56 -08:00
test_framework Merge bitcoin/bitcoin#29400: test: Fix SegwitV0SignatureMsg nLockTime signedness 2024-02-21 13:16:51 -05:00
.gitignore
combine_logs.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
combined_log_template.html
create_cache.py
example_test.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
feature_abortnode.py scripted-diff: Use blocks_path where possible 2023-07-25 15:51:36 +02:00
feature_addrman.py [test] Move MAGIC_BYTES to messages.py 2024-01-23 22:04:55 +05:30
feature_anchors.py [test] make v2transport arg in addconnection mandatory and few cleanups 2024-01-31 22:37:54 +05:30
feature_asmap.py net: Add continuous ASMap health check logging 2023-12-02 22:03:08 +01:00
feature_assumeutxo.py test, assumeutxo: Add test to ensure failure when mempool not empty 2024-02-09 00:30:17 -03:00
feature_assumevalid.py test: refactor: introduce generate_keypair helper with WIF support 2023-06-19 17:38:14 +02:00
feature_bind_extra.py test: use skip_if_platform_not_linux helper where possible 2023-12-08 18:15:34 +01:00
feature_bind_port_discover.py net: only assume all local addresses if listening on any 2022-03-02 15:42:40 +01:00
feature_bind_port_externalip.py net: fix GetListenPort() to derive the proper port 2022-03-02 15:42:37 +01:00
feature_bip68_sequence.py test framework: Add and use option for tx-version in MiniWallet methods 2024-02-08 21:50:55 +00:00
feature_block.py test: refactor: deduplicate legacy ECDSA signing for tx inputs 2023-07-03 17:33:41 +02:00
feature_blocksdir.py test: Use pathlib over os.path #28362 2023-10-10 09:26:56 -04:00
feature_cltv.py Make post-p2sh consensus rules mandatory for tx relay 2023-08-18 00:59:27 +10:00
feature_coinstatsindex.py scripted-diff: Rename hash_serialized_2 to hash_serialized_3 2023-10-20 22:53:06 +02:00
feature_config_args.py test: detect OS consistently using platform.system() 2023-12-08 18:16:24 +01:00
feature_csv_activation.py Make post-p2sh consensus rules mandatory for tx relay 2023-08-18 00:59:27 +10:00
feature_dbcrash.py scripted-diff: Rename hash_serialized_2 to hash_serialized_3 2023-10-20 22:53:06 +02:00
feature_dersig.py Make post-p2sh consensus rules mandatory for tx relay 2023-08-18 00:59:27 +10:00
feature_dirsymlinks.py scripted-diff: Use blocks_path where possible 2023-07-25 15:51:36 +02:00
feature_discover.py test: add functional test for -discover 2022-09-30 08:26:45 -03:00
feature_fastprune.py test: Simplify feature_fastprune.py 2023-05-02 14:14:00 +02:00
feature_fee_estimation.py scripted-diff: Use wallets_path and chain_path where possible 2023-06-21 08:48:34 +02:00
feature_filelock.py init: don't delete PID file if it was not generated 2023-12-04 12:54:20 +00:00
feature_help.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_includeconf.py test: Use TestNode *_path properties where possible 2023-06-21 08:49:18 +02:00
feature_index_prune.py init: don't start indexes sync thread prematurely 2023-07-10 10:50:50 -03:00
feature_init.py test: detect OS consistently using platform.system() 2023-12-08 18:16:24 +01:00
feature_loadblock.py test: Use pathlib over os.path #28362 2023-10-10 09:26:56 -04:00
feature_logging.py scripted-diff: Use wallets_path and chain_path where possible 2023-06-21 08:48:34 +02:00
feature_maxtipage.py test: add -maxtipage test for the maximum allowable value 2022-11-14 10:33:17 -05:00
feature_maxuploadtarget.py test: check that mempool msgs lead to disconnect if uploadtarget is reached 2024-02-05 18:08:25 +01:00
feature_minchainwork.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
feature_notifications.py test: detect OS consistently using platform.system() 2023-12-08 18:16:24 +01:00
feature_nulldummy.py Make post-p2sh consensus rules mandatory for tx relay 2023-08-18 00:59:27 +10:00
feature_posix_fs_permissions.py test: Use TestNode *_path properties where possible 2023-06-21 08:49:18 +02:00
feature_presegwit_node_upgrade.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_proxy.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
feature_pruning.py scripted-diff: Use blocks_path where possible 2023-08-01 15:26:55 +02:00
feature_rbf.py test: Return dict in MiniWallet::send_to 2023-05-12 15:26:50 +02:00
feature_reindex.py [test] Move MAGIC_BYTES to messages.py 2024-01-23 22:04:55 +05:30
feature_reindex_readonly.py test: enable reindex readonly test on *BSD and macOS as root 2023-10-23 10:58:54 -04:00
feature_remove_pruned_files_on_startup.py test: detect OS consistently using platform.system() 2023-12-08 18:16:24 +01:00
feature_segwit.py Remove deprecated -rpcserialversion 2023-12-11 18:22:13 +01:00
feature_settings.py settings: add auto-generated warning msg for editing the file manually 2024-01-22 10:50:03 -03:00
feature_shutdown.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
feature_signet.py test: Throw error when -signetchallenge is non-hex 2023-05-25 19:24:05 +02:00
feature_startupnotify.py Merge bitcoin/bitcoin#27884: test: Use TestNode datadir_path or chain_path where possible 2023-06-29 09:51:53 +01:00
feature_taproot.py Merge bitcoin/bitcoin#28374: test: python cryptography required for BIP 324 functional tests 2023-11-07 16:48:57 -05:00
feature_uacomment.py
feature_unsupported_utxo_db.py scripted-diff: Use blocks_path where possible 2023-07-25 15:51:36 +02:00
feature_utxo_set_hash.py test: Fix utxo set hash serialisation signedness 2024-02-07 11:47:17 +01:00
feature_versionbits_warning.py Remove the syscall sandbox 2023-06-16 10:38:19 +01:00
interface_bitcoin_cli.py test: Use pathlib over os.path #28362 2023-10-10 09:26:56 -04:00
interface_http.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
interface_rest.py test: use built-in collection types for type hints (Python 3.9 / PEP 585) 2023-10-25 01:10:21 +02:00
interface_rpc.py scripted-diff: Use wallets_path and chain_path where possible 2023-06-21 08:48:34 +02:00
interface_usdt_coinselection.py wallet: fix coin selection tracing to return -1 when no change pos 2024-01-20 14:56:41 +01:00
interface_usdt_mempool.py test: fix usdt undeclared function errors on mantis 2023-10-09 21:01:38 +01:00
interface_usdt_net.py test: fix usdt undeclared function errors on mantis 2023-10-09 21:01:38 +01:00
interface_usdt_utxocache.py test: fix usdt undeclared function errors on mantis 2023-10-09 21:01:38 +01:00
interface_usdt_validation.py test: fix usdt undeclared function errors on mantis 2023-10-09 21:01:38 +01:00
interface_zmq.py test: refactor: replace unnecessary BytesIO uses 2023-04-01 14:15:17 +02:00
mempool_accept.py rpc: Fixed signed integer overflow for large feerates 2024-02-15 10:56:01 +01:00
mempool_accept_v3.py [test] second child of a v3 tx can be replaced individually 2024-02-12 14:57:19 +00:00
mempool_accept_wtxid.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
mempool_compatibility.py mempool: persist with XOR 2023-11-09 19:44:50 +01:00
mempool_datacarrier.py test: replace random_bytes with randbytes #28720 2023-10-25 08:56:41 -04:00
mempool_dust.py tests: ensure functional tests set permitbaremultisig=1 when needed 2023-12-15 18:37:29 +10:00
mempool_expiry.py rpc: exposing modified_fee in getprioritisedtransactions 2024-01-11 08:16:22 -06:00
mempool_limit.py RPC submitpackage: change return format to allow partial errors 2023-11-29 12:56:26 -05:00
mempool_package_limits.py [rpc] return full string for package_msg and package-error 2024-01-26 15:58:35 +00:00
mempool_package_onemore.py test: add rescan_utxos in MiniWallet's initialization 2023-01-16 19:01:09 +02:00
mempool_packages.py test: Move test_chain_listunspent wallet check from mempool_packages to wallet_basic 2023-05-26 09:02:55 +02:00
mempool_persist.py Add importmempool RPC 2023-08-07 11:33:34 +02:00
mempool_reorg.py test: Fix intermittent issue in mempool_reorg 2023-08-22 11:08:46 +02:00
mempool_resurrect.py test: simplify tests by using the pre-mined chain 2023-01-16 19:14:21 +02:00
mempool_sigoplimit.py [refactor] use MAX_PUBKEYS_PER_MULTISIG instead of magic numbers in test 2024-02-12 14:47:12 +00:00
mempool_spend_coinbase.py test: add rescan_utxos in MiniWallet's initialization 2023-01-16 19:01:09 +02:00
mempool_unbroadcast.py test: add rescan_utxos in MiniWallet's initialization 2023-01-16 19:01:09 +02:00
mempool_updatefromblock.py test: simplify and speedup mempool_updatefromblock.py by using MiniWallet 2023-02-03 17:23:26 +01:00
mining_basic.py RPC/Mining: Document template_request better for getblocktemplate 2023-07-22 01:29:11 +00:00
mining_getblocktemplate_longpoll.py test: Fix intermittent issue in mining_getblocktemplate_longpoll.py 2023-06-23 15:21:29 +02:00
mining_prioritisetransaction.py test: Assert that a new tx with a delta of 0 is never added 2024-01-11 08:16:42 -06:00
p2p_add_connections.py test: p2p: adhere to typical VERSION message protocol flow 2024-02-01 13:33:23 +01:00
p2p_addr_relay.py test: p2p: adhere to typical VERSION message protocol flow 2024-02-01 13:33:23 +01:00
p2p_addrfetch.py test: Combine sync_send_with_ping and sync_with_ping 2023-09-05 12:11:10 +02:00
p2p_addrv2_relay.py test: cover TorV3 address in p2p_addrv2_relay 2023-07-10 10:07:45 -04:00
p2p_block_sync.py Add functional test for block sync from inbound peers 2022-05-17 09:36:49 -04:00
p2p_blockfilters.py test: add bip157 coverage for (start height > stop height) disconnect 2023-08-07 12:20:22 +02:00
p2p_blocksonly.py test: Combine sync_send_with_ping and sync_with_ping 2023-09-05 12:11:10 +02:00
p2p_compactblocks.py Add tests for parallel compact block downloads 2023-05-23 13:07:49 -04:00
p2p_compactblocks_blocksonly.py test: Combine sync_send_with_ping and sync_with_ping 2023-09-05 12:11:10 +02:00
p2p_compactblocks_hb.py scripted-diff: Remove redundant sync_all and sync_blocks 2021-11-10 11:10:15 +01:00
p2p_disconnect_ban.py Merge bitcoin/bitcoin#26794: test: test banlist database recreation 2023-04-27 10:18:57 +01:00
p2p_dns_seeds.py [test] Test the delay before querying DNS seeds 2021-07-30 11:15:49 -07:00
p2p_dos_header_tree.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
p2p_eviction.py test: refactor: simplify p2p_eviction.py by using MiniWallet 2023-01-19 16:11:27 +01:00
p2p_feefilter.py test: remove redundant blocks generation logic 2023-01-16 19:14:11 +02:00
p2p_filter.py test: Extends MEMPOOL msg functional test 2023-12-06 13:21:58 -05:00
p2p_fingerprint.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_getaddr_caching.py test: drop duplicate getaddrs from p2p_getaddr_caching 2023-07-25 10:34:29 -04:00
p2p_getdata.py test: use explicit p2p objects where available 2020-09-26 10:48:54 +02:00
p2p_headers_sync_with_minchainwork.py test: Avoid rpc timeout in p2p_headers_sync_with_minchainwork 2023-01-23 16:35:13 +01:00
p2p_i2p_ports.py test: ensure I2P ports are handled as expected 2021-07-09 11:19:37 +02:00
p2p_i2p_sessions.py doc: clarify -i2pacceptincoming help documentation 2023-01-09 08:18:47 -08:00
p2p_ibd_stalling.py test: Combine sync_send_with_ping and sync_with_ping 2023-09-05 12:11:10 +02:00
p2p_ibd_txrelay.py test: Combine sync_send_with_ping and sync_with_ping 2023-09-05 12:11:10 +02:00
p2p_initial_headers_sync.py Add functional test for block announcements during initial headers sync 2022-08-12 17:13:00 -04:00
p2p_invalid_block.py test: remove unused variables in p2p_invalid_block 2023-09-05 09:09:45 -03:00
p2p_invalid_locator.py test: python E721 updates 2023-07-31 12:13:46 -06:00
p2p_invalid_messages.py addrman: log AS only when using asmap 2023-10-30 18:46:06 -03:00
p2p_invalid_tx.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
p2p_leak.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
p2p_leak_tx.py test: fix intermittent failure in p2p_leak_tx.py 2023-06-12 14:46:15 -04:00
p2p_message_capture.py script, test: add missing python type annotations 2023-06-29 16:13:51 -06:00
p2p_net_deadlock.py test: replace random_bytes with randbytes #28720 2023-10-25 08:56:41 -04:00
p2p_nobloomfilter_messages.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
p2p_node_network_limited.py test: enable v2 transport for p2p_node_network_limited.py 2023-11-08 17:34:50 -05:00
p2p_orphan_handling.py [functional test] transaction orphan handling 2023-08-14 15:54:31 +01:00
p2p_permissions.py [log] include wtxid in tx {relay,validation,orphanage} logging 2023-08-29 16:41:22 +01:00
p2p_ping.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
p2p_segwit.py test: fix assert_debug_log call-site bugs, add type checks 2023-10-13 12:42:49 +02:00
p2p_sendheaders.py scripted-diff: Rename nUnconnectingHeaders and fPreferHeaders 2023-03-30 14:56:34 +02:00
p2p_sendtxrcncl.py test: p2p: adhere to typical VERSION message protocol flow 2024-02-01 13:33:23 +01:00
p2p_timeouts.py test: enable v2 transport for p2p_timeouts.py 2023-11-08 17:34:50 -05:00
p2p_tx_download.py test: refactor: simplify p2p_tx_download.py by using MiniWallet 2023-01-19 16:08:55 +01:00
p2p_tx_privacy.py test: add rescan_utxos in MiniWallet's initialization 2023-01-16 19:01:09 +02:00
p2p_unrequested_blocks.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
p2p_v2_earlykeyresponse.py test: fix intermittent failure in p2p_v2_earlykeyresponse 2024-01-31 10:21:44 -05:00
p2p_v2_encrypted.py [test] Check whether v2 TestNode performs downgrading 2024-01-25 11:10:50 +05:30
p2p_v2_transport.py test: assert rpc error for addnode v2transport not enabled 2024-02-20 22:04:53 -06:00
README.md doc: test: mention OS detection preferences in style guideline 2023-12-08 18:16:27 +01:00
rpc_bind.py test: use skip_if_platform_not_linux helper where possible 2023-12-08 18:15:34 +01:00
rpc_blockchain.py Throw error if invalid parameters passed to getnetworkhashps RPC endpoint 2023-11-07 12:58:42 -05:00
rpc_createmultisig.py Merge bitcoin/bitcoin#27884: test: Use TestNode datadir_path or chain_path where possible 2023-06-29 09:51:53 +01:00
rpc_decodescript.py descriptor: InferScript, do not return top-level only func as sub descriptor 2023-07-20 11:04:52 -03:00
rpc_deprecated.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
rpc_deriveaddresses.py Add PubKeyDestination for P2PK scripts 2023-09-12 12:14:31 -04:00
rpc_dumptxoutset.py coinstats: Fix hash_serialized2 calculation 2023-10-20 22:53:05 +02:00
rpc_estimatefee.py test: added coverage to estimatefee 2023-06-22 08:27:38 -05:00
rpc_generate.py rpc: Add submit option to generateblock 2023-03-10 10:39:14 +01:00
rpc_getblockfilter.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
rpc_getblockfrompeer.py test: add block sync to getblockfrompeer.py 2023-05-30 14:17:17 -04:00
rpc_getblockstats.py test: Test exclusion of OP_RETURN from getblockstats 2022-10-23 01:33:41 +02:00
rpc_getchaintips.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
rpc_getdescriptorinfo.py Switch hardened derivation marker to h in descriptors 2023-04-04 18:33:08 +02:00
rpc_help.py RPC: Allow RPC methods accepting options to take named parameters 2023-05-03 11:27:51 -05:00
rpc_invalid_address_message.py use 'byte'/'bytes' for bech32(m) validation error 2023-05-25 06:30:10 +00:00
rpc_invalidateblock.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
rpc_mempool_info.py test: add rescan_utxos in MiniWallet's initialization 2023-01-16 19:01:09 +02:00
rpc_misc.py removed StrFormatInternalBug quote delimitation 2023-08-18 04:04:06 +00:00
rpc_named_arguments.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
rpc_net.py Merge bitcoin/bitcoin#24748: test/BIP324: functional tests for v2 P2P encryption 2024-01-29 12:31:31 -05:00
rpc_packages.py test_submitpackage: only make a chain of 3 txns 2023-11-29 12:56:26 -05:00
rpc_preciousblock.py lint: enable E722 do not use bare except 2023-02-18 11:24:09 +00:00
rpc_psbt.py Merge bitcoin/bitcoin#28727: test: replace random_bytes with random.randbytes 2023-10-29 10:14:59 +01:00
rpc_rawtransaction.py test: add regression test for the getrawtransaction segfault 2023-12-05 17:12:56 -05:00
rpc_scanblocks.py Merge bitcoin/bitcoin#26780: rpc: simplify scan blocks 2023-05-01 09:10:11 -04:00
rpc_scantxoutset.py Merge bitcoin/bitcoin#26076: Switch hardened derivation marker to h 2023-05-08 13:31:28 -04:00
rpc_setban.py test: fix intermittent failure in rpc_setban.py --v2transport 2024-02-02 13:24:29 -05:00
rpc_signer.py scripted-diff: Specify Python major version explicitly on Windows 2023-08-03 14:57:45 +01:00
rpc_signmessagewithprivkey.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
rpc_signrawtransactionwithkey.py test: use common assert_signing_completed_successfully helper 2023-07-27 06:37:55 -06:00
rpc_txoutproof.py test: simplify tests by using the pre-mined chain 2023-01-16 19:14:21 +02:00
rpc_uptime.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
rpc_users.py test: Use TestNode *_path properties where possible 2023-06-21 08:49:18 +02:00
rpc_validateaddress.py use 'byte'/'bytes' for bech32(m) validation error 2023-05-25 06:30:10 +00:00
rpc_whitelist.py test: Use TestNode *_path properties where possible 2023-06-21 08:49:18 +02:00
test-shell.md doc: test: update TestShell instructions 2023-06-16 22:55:36 +01:00
test_runner.py Merge bitcoin/bitcoin#28948: v3 transaction policy for anti-pinning 2024-02-09 23:37:57 -05:00
tool_signet_miner.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
tool_wallet.py test: Use pathlib over os.path #28362 2023-10-10 09:26:56 -04:00
wallet_abandonconflict.py wallet, tests: mark unconflicted txs as inactive 2023-05-14 10:45:21 -04:00
wallet_address_types.py Switch hardened derivation marker to h in descriptors 2023-04-04 18:33:08 +02:00
wallet_assumeutxo.py test: Assumeutxo with more than just coinbase transactions 2024-01-31 12:39:51 +01:00
wallet_avoid_mixing_output_types.py test: Remove wallet option from non-wallet tests 2022-11-10 17:19:13 +01:00
wallet_avoidreuse.py doc: fix typos 2023-11-07 10:21:51 +09:00
wallet_backup.py test: Use pathlib over os.path #28362 2023-10-10 09:26:56 -04:00
wallet_backwards_compatibility.py test: roundtrip wallet backwards compat downgrade 2023-08-23 16:49:41 -04:00
wallet_balance.py rpc: return block hash & height in getbalances, gettransaction & getwalletinfo JSONs 2023-04-26 16:07:47 +02:00
wallet_basic.py wallet, mempool: propagete checkChainLimits error message to wallet 2023-12-17 21:13:44 +01:00
wallet_blank.py test: Use pathlib over os.path #28362 2023-10-10 09:26:56 -04:00
wallet_bumpfee.py rpc: bumpfee, improve doc for 'reduce_output' arg 2023-09-26 20:17:02 -03:00
wallet_change_address.py wallet: reuse change dest when recreating TX with avoidpartialspends 2023-02-15 10:14:30 -05:00
wallet_coinbase_category.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
wallet_conflicts.py Add wallets_conflicts 2023-05-14 10:45:27 -04:00
wallet_create_tx.py test: wallet_create_tx.py fix race 2023-03-23 17:06:54 -03:00
wallet_createwallet.py test: Add Wallet Unlock Context Manager 2023-10-10 18:12:31 +03:00
wallet_crosschain.py test: Use pathlib over os.path #28362 2023-10-10 09:26:56 -04:00
wallet_descriptor.py tests: Test for concurrent writes with db tx 2024-02-06 12:24:36 -05:00
wallet_disable.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
wallet_dump.py Merge bitcoin/bitcoin#28617: test: Add Wallet Unlock Context Manager 2023-10-19 10:23:44 +01:00
wallet_encryption.py test: Add Wallet Unlock Context Manager 2023-10-10 18:12:31 +03:00
wallet_fallbackfee.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
wallet_fast_rescan.py test: use built-in collection types for type hints (Python 3.9 / PEP 585) 2023-10-25 01:10:21 +02:00
wallet_fundrawtransaction.py test: add tests for fundrawtx and sendmany rpcs 2024-01-19 15:04:56 +01:00
wallet_groups.py test: fix immediate tx relay in wallet_groups.py 2023-01-26 02:56:34 +01:00
wallet_hd.py test: Use pathlib over os.path #28362 2023-10-10 09:26:56 -04:00
wallet_implicitsegwit.py script, test: fix python linter E275 errors with flake8 5.0.4 2023-01-03 10:59:56 -08:00
wallet_import_rescan.py test: fix wallet_import_rescan unrounded minimum amount 2024-01-29 11:45:08 +01:00
wallet_import_with_label.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
wallet_importdescriptors.py test: refactor: support sending funds with outpoint result 2023-10-24 11:13:51 +02:00
wallet_importmulti.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
wallet_importprunedfunds.py wallet: batch and simplify ZapSelectTx process 2024-02-09 14:54:50 -03:00
wallet_inactive_hdchains.py test: Use TestNode *_path properties where possible 2023-06-21 08:49:18 +02:00
wallet_keypool.py test: Add Wallet Unlock Context Manager 2023-10-10 18:12:31 +03:00
wallet_keypool_topup.py test: Use pathlib over os.path #28362 2023-10-10 09:26:56 -04:00
wallet_labels.py wallet: Replace use of purpose strings with an enum 2023-04-11 15:55:31 -04:00
wallet_listdescriptors.py Merge bitcoin/bitcoin#26076: Switch hardened derivation marker to h 2023-05-08 13:31:28 -04:00
wallet_listreceivedby.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
wallet_listsinceblock.py test: refactor: introduce generate_keypair helper with WIF support 2023-06-19 17:38:14 +02:00
wallet_listtransactions.py test: Add gettransaction test for "coin-join" tx 2023-11-23 14:11:01 +01:00
wallet_migration.py Merge bitcoin/bitcoin#28868: wallet: Fix migration of wallets with txs that have both spendable and watchonly outputs 2024-02-02 21:50:22 -05:00
wallet_miniscript.py tests: Increase wallet_miniscript.py rpc timeout to 90 seconds 2023-11-07 18:32:28 -05:00
wallet_multisig_descriptor_psbt.py test: remove unnecessary finalizepsbt rpc calls 2023-09-06 11:52:19 -04:00
wallet_multiwallet.py test: detect OS consistently using platform.system() 2023-12-08 18:16:24 +01:00
wallet_orphanedreward.py rpc: return block hash & height in getbalances, gettransaction & getwalletinfo JSONs 2023-04-26 16:07:47 +02:00
wallet_pruning.py test: Use pathlib over os.path #28362 2023-10-10 09:26:56 -04:00
wallet_reindex.py rpc: getwalletinfo, return wallet 'birthtime' 2023-12-05 18:55:35 -03:00
wallet_reorgsrestore.py test: fix intermittent failure in wallet_reorgrestore.py 2024-02-12 15:27:18 -05:00
wallet_rescan_unconfirmed.py [test] import descriptor wallet with reorged parent + IsFromMe child in mempool 2024-01-12 14:51:16 +00:00
wallet_resendwallettransactions.py tests: Use manual bumps instead of bumpfee for resendwallettransactions 2023-09-27 11:39:07 -04:00
wallet_send.py test: remove unnecessary finalizepsbt rpc calls 2023-09-06 11:52:19 -04:00
wallet_sendall.py test: Update python tests to use named parameters instead of options objects 2023-05-03 11:27:51 -05:00
wallet_sendmany.py test: add tests for fundrawtx and sendmany rpcs 2024-01-19 15:04:56 +01:00
wallet_signer.py test: remove unnecessary finalizepsbt rpc calls 2023-09-06 11:52:19 -04:00
wallet_signmessagewithaddress.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
wallet_signrawtransactionwithwallet.py test: refactor: support sending funds with outpoint result 2023-10-24 11:13:51 +02:00
wallet_simulaterawtx.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
wallet_spend_unconfirmed.py Amend bumpfee for inputs with overlapping ancestry 2023-09-13 15:46:59 -04:00
wallet_startup.py scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
wallet_taproot.py test: Update python tests to use named parameters instead of options objects 2023-05-03 11:27:51 -05:00
wallet_timelock.py test: Update python tests to use named parameters instead of options objects 2023-05-03 11:27:51 -05:00
wallet_transactiontime_rescan.py test: Replace threading with concurrent.futures 2023-03-21 09:49:39 +01:00
wallet_txn_clone.py test: refactor: support sending funds with outpoint result 2023-10-24 11:13:51 +02:00
wallet_txn_doublespend.py test: refactor: support sending funds with outpoint result 2023-10-24 11:13:51 +02:00
wallet_upgradewallet.py test: Use TestNode *_path properties where possible 2023-06-21 08:49:18 +02:00
wallet_watchonly.py test: Update python tests to use named parameters instead of options objects 2023-05-03 11:27:51 -05:00

Functional tests

Writing Functional Tests

Example test

The file test/functional/example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test/functional/test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The CI linter job also checks this, but possibly not in all cases.
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Use type hints in your code to improve code readability and to detect possible bugs earlier.
  • Avoid wildcard imports.
  • If more than one name from a module is needed, use lexicographically sorted multi-line imports in order to reduce the possibility of potential merge conflicts.
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramework, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use f'{x}' for string formatting in preference to '{}'.format(x) or '%s' % x.
  • Use platform.system() for detecting the running operating system and os.name to check whether it's a POSIX system (see also the skip_if_platform_not_{linux,posix} methods in the BitcoinTestFramework class, which can be used to skip a whole test depending on the platform).

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • tool for tests for tools, eg tool_wallet.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • Use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Instead of inline comments or no test documentation at all, log the comments to the test log, e.g. self.log.info('Create enough transactions to fill a block'). Logs make the test code easier to read and the test logic easier to debug.
  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to True to initialize an empty blockchain and start from the Genesis block, rather than load a premined blockchain from cache with the default value of False. The cached data directories contain a 200-block pre-mined blockchain with the spendable mining rewards being split between four nodes. Each node has 25 mature block subsidies (25x50=1250 BTC) in its wallet. Using them is much more efficient than mining blocks in your test.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
  • Many of the core test framework classes such as CBlock and CTransaction don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • P2Ps can be used to test specific P2P protocol behavior. p2p.py contains test framework p2p objects and messages.py contains all the definitions for objects passed over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

P2PConnections can be used as such:

p2p_conn = node.add_p2p_connection(P2PInterface())
p2p_conn.send_and_ping(msg)

They can also be referenced by indexing into a TestNode's p2ps list, which contains the list of test framework p2p objects connected to itself (it does not include any TestNodes):

node.p2ps[0].sync_with_ping()

More examples can be found in p2p_unrequested_blocks.py, p2p_compactblocks.py.

Prototyping tests

The TestShell class exposes the BitcoinTestFramework functionality to interactive Python3 environments and can be used to prototype tests. This may be especially useful in a REPL environment with session logging utilities, such as IPython. The logs of such interactive sessions can later be adapted into permanent test cases.

Test framework modules

The following are useful modules for test developers. They are located in test/functional/test_framework/.

authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework.py

Base class for functional tests.

util.py

Generally useful functions.

p2p.py

Test objects for interacting with a bitcoind node over the p2p interface.

script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

key.py

Test-only secp256k1 elliptic curve implementation

blocktools.py

Helper functions for creating blocks and transactions.

Benchmarking with perf

An easy way to profile node performance during functional tests is provided for Linux platforms using perf.

Perf will sample the running node and will generate profile data in the node's datadir. The profile data can then be presented using perf report or a graphical tool like hotspot.

There are two ways of invoking perf: one is to use the --perf flag when running tests, which will profile each node during the entire test run: perf begins to profile when the node starts and ends when it shuts down. The other way is the use the profile_with_perf context manager, e.g.

with node.profile_with_perf("send-big-msgs"):
    # Perform activity on the node you're interested in profiling, e.g.:
    for _ in range(10000):
        node.p2ps[0].send_message(some_large_message)

To see useful textual output, run

perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less

See also: