bitcoin/test/functional
W. J. van der Laan 2b45cf0bcd
Merge bitcoin/bitcoin#19521: Coinstats Index
5f96d7d22d rpc: gettxoutsetinfo rejects hash_serialized_2 for specific height (Fabian Jahr)
23fe50436b test: Add test for coinstatsindex behavior in reorgs (Fabian Jahr)
90c966b0f3 rpc: Allow gettxoutsetinfo and getblockstats for stale blocks (Fabian Jahr)
b9362392ae index, rpc: Add use_index option for gettxoutsetinfo (Fabian Jahr)
bb7788b121 test: Test coinstatsindex robustness across restarts (Fabian Jahr)
e0938c2909 test: Add tests for block_info in gettxoutsetinfo (Fabian Jahr)
2501576ecc rpc, index: Add verbose amounts tracking to Coinstats index (Fabian Jahr)
655d929836 test: add coinstatsindex getindexinfo coverage, improve current tests (Jon Atack)
ca01bb8d68 rpc: Add Coinstats index to getindexinfo (Fabian Jahr)
57a026c30f test: Add unit test for Coinstats index (Fabian Jahr)
6a4c0c09ab test: Add functional test for Coinstats index (Fabian Jahr)
3f166ecc12 rpc: gettxoutsetinfo can be requested for specific blockheights (Fabian Jahr)
3c914d58ff index: Coinstats index can be activated with command line flag (Fabian Jahr)
dd58a4de21 index: Add Coinstats index (Fabian Jahr)
a8a46c4b3c refactor: Simplify ApplyStats and ApplyHash (Fabian Jahr)
9c8a265fd2 refactor: Pass hash_type to CoinsStats in stats object (Fabian Jahr)
2e2648a902 crypto: Make MuHash Remove method efficient (Fabian Jahr)

Pull request description:

  This is part of the coinstats index project tracked in #18000

  While the review of the new UTXO set hash algorithm (MuHash) takes longer recently #19328 was merged which added the possibility to run `gettxoutsetinfo` with a specific hash type. As the first type it added `hash_type=none` which skips the hashing of the UTXO set altogether. This alone did not make `gettxoutsetinfo` much faster but it allows the use of an index for the remaining coin statistics even before a new hashing algorithm has been added. Credit to Sjors for the idea to take this intermediate step.

  Features summary:
  - Users can start their node with the option `-coinstatsindex` which syncs the index in the background
  - After the index is synced the user can  use `gettxoutsetinfo` with `hash_type=none` or `hash_type=muhash` and will get the response instantly out of the index
  - The user can specify a height or block hash when calling `gettxoutsetinfo` to see coin statistics at a specific block height

ACKs for top commit:
  Sjors:
    re-tACK 5f96d7d22d
  jonatack:
    Code review re-ACK 5f96d7d22d per `git range-diff 13d27b4 07201d3 5f96d7d`
  promag:
    Tested ACK 5f96d7d22d. Light code review ACK 5f96d7d22d.

Tree-SHA512: cbca78bee8e9605c19da4fbcd184625fb280200718396c694a56c7daab6f44ad23ca9fb5456d09f245d8b8d9659fdc2b3f3ce5e953c1c6cf4003dbc74c0463c2
2021-04-30 17:27:19 +02:00
..
data test: remove type: comments in favour of actual annotations 2021-02-08 13:24:44 +08:00
mocks rpc: send: support external signer 2021-02-23 14:34:32 +01:00
test_framework Merge bitcoin/bitcoin#19521: Coinstats Index 2021-04-30 17:27:19 +02:00
.gitignore Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
combine_logs.py scripted-diff: Add missed copyright headers 2020-01-04 20:18:28 +02:00
combined_log_template.html Introduce combine_logs.py to combine log files from multiple bitcoinds. 2017-03-21 17:30:13 -04:00
create_cache.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
example_test.py doc: Improve setup_clean_chain documentation 2021-02-01 23:13:35 +01:00
feature_abortnode.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 2020-10-20 00:42:00 -07:00
feature_anchors.py test: add functional test for anchors.dat 2021-03-19 20:30:52 -03:00
feature_asmap.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
feature_assumevalid.py test: remove assert_blockchain_height 2021-02-08 16:56:46 +01:00
feature_backwards_compatibility.py Disable upgrades tests that require BDB if BDB is not compiled 2021-01-27 12:52:46 -05:00
feature_bip68_sequence.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
feature_block.py [tests] Recommend f-strings for formatting, update feature_block to use them 2020-11-09 17:53:50 +10:00
feature_blockfilterindex_prune.py test: Fix test cache issue 2021-04-23 09:48:56 +02:00
feature_blocksdir.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
feature_cltv.py test: check that _all_ invalid-CLTV txs are rejected after BIP65 activation 2021-03-31 21:30:25 +02:00
feature_coinstatsindex.py rpc: gettxoutsetinfo rejects hash_serialized_2 for specific height 2021-04-19 21:11:37 +02:00
feature_config_args.py test: Avoid connecting to real network when running tests 2021-02-21 11:02:58 +01:00
feature_csv_activation.py update docstring in feature_csv_activation.py 2021-04-18 22:05:14 +02:00
feature_dbcrash.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
feature_dersig.py rpc: Return wtxid from testmempoolaccept 2021-01-12 18:43:43 +01:00
feature_fee_estimation.py init: don't create a CBlockPolicyEstimator if we don't relay transactions 2020-12-03 12:56:37 +01:00
feature_filelock.py Have feature_filelock.py test both bdb and sqlite, depending on compiled 2021-01-27 12:52:46 -05:00
feature_help.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
feature_includeconf.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
feature_loadblock.py test: refactor functional tests to use restart_node 2020-06-22 12:58:14 +01:00
feature_logging.py test: refactor functional tests to use restart_node 2020-06-22 12:58:14 +01:00
feature_maxuploadtarget.py [refactor] clarify tests by referencing p2p objects directly 2020-09-10 07:37:14 -07:00
feature_minchainwork.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
feature_notifications.py test: Fix feature_notifications.py intermittent issue 2021-04-26 08:22:46 +02:00
feature_nulldummy.py test: use 327 fewer blocks in feature_nulldummy 2021-03-10 22:47:59 +01:00
feature_proxy.py init: introduce I2P connectivity options 2021-03-01 18:19:46 +01:00
feature_pruning.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 2020-10-20 00:42:00 -07:00
feature_rbf.py rpc: deprecate addresses and reqSigs from rpc outputs 2021-03-23 10:51:43 -04:00
feature_reindex.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
feature_segwit.py rpc: deprecate addresses and reqSigs from rpc outputs 2021-03-23 10:51:43 -04:00
feature_settings.py Merge #19624: Warn on unknown rw_settings 2020-10-19 11:30:49 +02:00
feature_shutdown.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
feature_signet.py signet: do not log signet startup messages for other chains 2020-10-01 11:25:42 +02:00
feature_taproot.py Correction for VerifyTaprootCommitment comments 2021-03-01 09:01:48 -05:00
feature_uacomment.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
feature_utxo_set_hash.py test: Use deterministic chain in utxo set hash test 2021-03-23 20:47:24 +01:00
feature_versionbits_warning.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
interface_bitcoin_cli.py Setup wallets for interface_bitcoin_cli.py 2021-01-27 12:52:46 -05:00
interface_http.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
interface_rest.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
interface_rpc.py Merge #18335: bitcoin-cli: print useful error if bitcoind rpc work queue exceeded 2021-03-19 20:52:16 +01:00
interface_zmq.py zmq test: fix sync-up by matching notification to generated block 2021-03-01 01:31:41 +01:00
mempool_accept.py rpc: Return wtxid from testmempoolaccept 2021-01-12 18:43:43 +01:00
mempool_compatibility.py test: run mempool_compatibility.py even with wallet disabled 2021-01-07 12:24:24 -06:00
mempool_expiry.py test: run mempool_expiry.py even with wallet disabled 2020-12-10 10:14:35 -06:00
mempool_limit.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
mempool_package_onemore.py rpc: deprecate addresses and reqSigs from rpc outputs 2021-03-23 10:51:43 -04:00
mempool_packages.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
mempool_persist.py rpc: Return total fee in mempool 2021-01-28 10:43:22 +01:00
mempool_reorg.py test: Remove raw-tx byte juggling in mempool_reorg 2020-04-25 19:36:02 -04:00
mempool_resurrect.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
mempool_spend_coinbase.py test: Speed up mempool_spend_coinbase.py 2021-04-23 09:56:02 +02:00
mempool_unbroadcast.py test: Replace use of (dis)?connect_nodes globals 2020-10-20 00:27:45 -07:00
mempool_updatefromblock.py refactor: test: use _ variable for unused loop counters 2020-08-06 18:39:33 +02:00
mining_basic.py test: Add test for -blockversion 2020-10-26 16:31:25 +01:00
mining_getblocktemplate_longpoll.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
mining_prioritisetransaction.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
p2p_add_connections.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
p2p_addr_relay.py test: Fix intermittent issue in p2p_addr_relay.py 2021-04-28 08:16:29 +02:00
p2p_addrv2_relay.py net: advertise support for ADDRv2 via new message 2020-10-09 16:42:50 +02:00
p2p_blockfilters.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
p2p_blocksonly.py test: Fix intermittent issue in p2p_addr_relay.py 2021-04-28 08:16:29 +02:00
p2p_compactblocks.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
p2p_disconnect_ban.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
p2p_dos_header_tree.py [refactor] clarify tests by referencing p2p objects directly 2020-09-10 07:37:14 -07:00
p2p_eviction.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
p2p_feefilter.py [test] no send feefilters when txrelay is turned off 2021-03-25 21:41:56 +01:00
p2p_filter.py test: Fix intermittent issue in p2p_addr_relay.py 2021-04-28 08:16:29 +02:00
p2p_fingerprint.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
p2p_getaddr_caching.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
p2p_getdata.py test: use explicit p2p objects where available 2020-09-26 10:48:54 +02:00
p2p_ibd_txrelay.py test: fix intermittent p2p_ibd_txrelay race, add test_framework.py#wait_until 2020-07-19 13:37:54 +02:00
p2p_invalid_block.py [refactor] clarify tests by referencing p2p objects directly 2020-09-10 07:37:14 -07:00
p2p_invalid_locator.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
p2p_invalid_messages.py p2p: Ignore version msgs after initial version msg 2020-11-19 08:07:16 +01:00
p2p_invalid_tx.py txorphanage: Move functions and data into class 2021-02-27 01:07:55 +10:00
p2p_leak.py test: bring p2p_leak.py up to date. 2021-03-03 00:16:16 +01:00
p2p_leak_tx.py test: add p2p_lock acquires in p2p_leak_tx.py 2020-10-12 00:22:16 +02:00
p2p_message_capture.py test: remove type: comments in favour of actual annotations 2021-02-08 13:24:44 +08:00
p2p_nobloomfilter_messages.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
p2p_node_network_limited.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
p2p_permissions.py [rpc] Remove deprecated "whitelisted" field from getpeerinfo 2020-12-26 13:30:54 -08:00
p2p_ping.py scripted-diff: Rename mininode to p2p 2020-08-21 15:52:20 +01:00
p2p_segwit.py test: Fix intermittent issue in p2p_segwit.py 2021-04-29 13:02:33 +02:00
p2p_sendheaders.py test: Update wait_until usage in tests not to use the one from utils 2020-08-26 18:01:59 +02:00
p2p_timeouts.py net: use peer=N instead of from=N in debug log 2021-01-28 16:04:04 +10:00
p2p_tx_download.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
p2p_unrequested_blocks.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 2020-10-20 00:42:00 -07:00
README.md doc: Improve setup_clean_chain documentation 2021-02-01 23:13:35 +01:00
rpc_addresses_deprecation.py rpc: deprecate addresses and reqSigs from rpc outputs 2021-03-23 10:51:43 -04:00
rpc_bind.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
rpc_blockchain.py rpc: Improve getblock error message for invalid data type. 2021-04-18 12:30:58 +08:00
rpc_createmultisig.py rpc: deprecate addresses and reqSigs from rpc outputs 2021-03-23 10:51:43 -04:00
rpc_decodescript.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
rpc_deprecated.py Remove deprecated bumpfee behavior 2021-01-08 18:58:58 -05:00
rpc_deriveaddresses.py tests: Use a default of supports_cli=True (instead of supports_cli=False) 2019-12-06 15:24:06 +00:00
rpc_dumptxoutset.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
rpc_estimatefee.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
rpc_fundrawtransaction.py rpc: deprecate addresses and reqSigs from rpc outputs 2021-03-23 10:51:43 -04:00
rpc_generate.py rpc: Assert that RPCArg names are equal to CRPCCommand ones (mining) 2020-08-14 12:37:19 +02:00
rpc_generateblock.py rpc: deprecate addresses and reqSigs from rpc outputs 2021-03-23 10:51:43 -04:00
rpc_getblockfilter.py test: check that getblockfilter RPC fails without block filter index 2021-01-20 01:55:24 +01:00
rpc_getblockstats.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
rpc_getchaintips.py test: Remove unused imports 2019-04-09 12:10:35 -04:00
rpc_getdescriptorinfo.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
rpc_help.py rpc: add external signer RPC files 2021-02-23 14:34:30 +01:00
rpc_invalid_address_message.py Use Bech32m encoding for v1+ segwit addresses 2021-03-16 10:48:36 -07:00
rpc_invalidateblock.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
rpc_misc.py Merge bitcoin/bitcoin#19521: Coinstats Index 2021-04-30 17:27:19 +02:00
rpc_named_arguments.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
rpc_net.py rpc: add network field to rpc getnodeaddresses 2021-04-07 12:57:07 +02:00
rpc_preciousblock.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
rpc_psbt.py rpc: deprecate addresses and reqSigs from rpc outputs 2021-03-23 10:51:43 -04:00
rpc_rawtransaction.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
rpc_scantxoutset.py wallet: Make -wallet setting not create wallets 2020-10-21 08:48:43 -04:00
rpc_setban.py test: add test for banning of non-IP addresses 2021-01-10 15:51:25 +01:00
rpc_signer.py Move external signer out of wallet module 2021-04-08 17:56:00 +02:00
rpc_signmessage.py test: check parameter validity in rpc_signmessage.py 2020-08-29 10:42:43 +02:00
rpc_signrawtransaction.py Test that signrawtx works when a signed CSV and CLTV inputs are present 2021-03-04 21:54:34 -05:00
rpc_txoutproof.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
rpc_uptime.py util: Disallow negative mocktime 2021-02-02 08:43:19 +00:00
rpc_users.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
rpc_whitelist.py test: Change filemode of rpc_whitelist.py 2019-12-27 21:19:44 +01:00
test-shell.md doc: Improve setup_clean_chain documentation 2021-02-01 23:13:35 +01:00
test_runner.py test: Add functional test for Coinstats index 2021-04-19 20:31:01 +02:00
tool_wallet.py Merge #20267: Disable and fix tests for when BDB is not compiled 2021-02-05 14:26:10 +01:00
wallet_abandonconflict.py scripted-diff: test: Replace uses of (dis)?connect_nodes global 2020-10-20 00:42:00 -07:00
wallet_address_types.py rpc: deprecate addresses and reqSigs from rpc outputs 2021-03-23 10:51:43 -04:00
wallet_avoidreuse.py rpc: deprecate addresses and reqSigs from rpc outputs 2021-03-23 10:51:43 -04:00
wallet_backup.py wallet: Make -wallet setting not create wallets 2020-10-21 08:48:43 -04:00
wallet_balance.py Merge #19893: test: Remove or explain syncwithvalidationinterfacequeue 2020-12-06 19:13:10 +01:00
wallet_basic.py qa: Test default include_mempool value of gettxout 2021-04-16 23:44:49 +01:00
wallet_bumpfee.py rpc: deprecate addresses and reqSigs from rpc outputs 2021-03-23 10:51:43 -04:00
wallet_coinbase_category.py Test coinbase category in wallet rpcs 2018-12-01 13:00:38 -05:00
wallet_create_tx.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_createwallet.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
wallet_descriptor.py Merge #19136: wallet: add parent_desc to getaddressinfo 2021-02-18 21:51:16 +13:00
wallet_disable.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_dump.py wallet: Make -wallet setting not create wallets 2020-10-21 08:48:43 -04:00
wallet_encryption.py doc: fix various typos 2021-01-04 12:31:31 +08:00
wallet_fallbackfee.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_groups.py test: use fewer blocks in wallet_groups and move sync call 2021-03-11 17:15:05 +01:00
wallet_hd.py rpc: deprecate addresses and reqSigs from rpc outputs 2021-03-23 10:51:43 -04:00
wallet_implicitsegwit.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
wallet_import_rescan.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_import_with_label.py Merge #17585: rpc: deprecate getaddressinfo label 2020-02-02 21:35:46 +13:00
wallet_importdescriptors.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_importmulti.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_importprunedfunds.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_keypool.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_keypool_topup.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_labels.py Use Bech32m encoding for v1+ segwit addresses 2021-03-16 10:48:36 -07:00
wallet_listdescriptors.py wallet, rpc: update listdescriptors response format 2021-03-09 09:04:35 +01:00
wallet_listreceivedby.py test: remove getaddressinfo label tests 2020-01-09 17:30:58 +01:00
wallet_listsinceblock.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_listtransactions.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_multiwallet.py wallet: Fix already-loading error message grammar 2021-02-04 00:19:11 +02:00
wallet_reorgsrestore.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_resendwallettransactions.py Merge #19893: test: Remove or explain syncwithvalidationinterfacequeue 2020-12-06 19:13:10 +01:00
wallet_send.py rpc: deprecate addresses and reqSigs from rpc outputs 2021-03-23 10:51:43 -04:00
wallet_signer.py Move external signer out of wallet module 2021-04-08 17:56:00 +02:00
wallet_startup.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_txn_clone.py rpc: deprecate addresses and reqSigs from rpc outputs 2021-03-23 10:51:43 -04:00
wallet_txn_doublespend.py test: Remove unused bug workaround 2021-02-16 16:28:40 +01:00
wallet_upgradewallet.py Require legacy wallet for wallet_upgradewallet.py 2021-01-27 12:52:46 -05:00
wallet_watchonly.py test: disallow sendtoaddress/sendmany when private keys disabled 2021-02-16 15:49:28 -05:00

Functional tests

Writing Functional Tests

Example test

The file test/functional/example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test/functional/test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The CI linter job also checks this, but possibly not in all cases.
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Use type hints in your code to improve code readability and to detect possible bugs earlier.
  • Avoid wildcard imports
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramework, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use f'{x}' for string formatting in preference to '{}'.format(x) or '%s' % x.

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • tool for tests for tools, eg tool_wallet.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • Use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Instead of inline comments or no test documentation at all, log the comments to the test log, e.g. self.log.info('Create enough transactions to fill a block'). Logs make the test code easier to read and the test logic easier to debug.
  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to True to initialize an empty blockchain and start from the Genesis block, rather than load a premined blockchain from cache with the default value of False. The cached data directories contain a 200-block pre-mined blockchain with the spendable mining rewards being split between four nodes. Each node has 25 mature block subsidies (25x50=1250 BTC) in its wallet. Using them is much more efficient than mining blocks in your test.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
  • Many of the core test framework classes such as CBlock and CTransaction don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • P2Ps can be used to test specific P2P protocol behavior. p2p.py contains test framework p2p objects and messages.py contains all the definitions for objects passed over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

P2PConnections can be used as such:

p2p_conn = node.add_p2p_connection(P2PInterface())
p2p_conn.send_and_ping(msg)

They can also be referenced by indexing into a TestNode's p2ps list, which contains the list of test framework p2p objects connected to itself (it does not include any TestNodes):

node.p2ps[0].sync_with_ping()

More examples can be found in p2p_unrequested_blocks.py, p2p_compactblocks.py.

Prototyping tests

The TestShell class exposes the BitcoinTestFramework functionality to interactive Python3 environments and can be used to prototype tests. This may be especially useful in a REPL environment with session logging utilities, such as IPython. The logs of such interactive sessions can later be adapted into permanent test cases.

Test framework modules

The following are useful modules for test developers. They are located in test/functional/test_framework/.

authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework.py

Base class for functional tests.

util.py

Generally useful functions.

p2p.py

Test objects for interacting with a bitcoind node over the p2p interface.

script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

key.py

Test-only secp256k1 elliptic curve implementation

blocktools.py

Helper functions for creating blocks and transactions.

Benchmarking with perf

An easy way to profile node performance during functional tests is provided for Linux platforms using perf.

Perf will sample the running node and will generate profile data in the node's datadir. The profile data can then be presented using perf report or a graphical tool like hotspot.

There are two ways of invoking perf: one is to use the --perf flag when running tests, which will profile each node during the entire test run: perf begins to profile when the node starts and ends when it shuts down. The other way is the use the profile_with_perf context manager, e.g.

with node.profile_with_perf("send-big-msgs"):
    # Perform activity on the node you're interested in profiling, e.g.:
    for _ in range(10000):
        node.p2ps[0].send_message(some_large_message)

To see useful textual output, run

perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less

See also: