mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-01-11 12:22:39 -03:00
cdaab90662
PR #22697 introduced a reproducible issue in commit 181a1207
that causes the
addrman tried table to fail consistency checks and significantly lose peer
entries when the `-asmap` configuration option is used.
The issue occurs on bitcoind restart due to an initialization order change
in `src/init.cpp` in that commit whereby CAddrman asmap is set after
deserializing `peers.dat`, rather than before.
Issue reported on the `#bitcoin-core-dev` IRC channel starting at
https://www.erisian.com.au/bitcoin-core-dev/log-2021-08-23.html#l-263.
```
addrman lost 22813 new and 2 tried addresses due to collisions or invalid addresses
ADDRMAN CONSISTENCY CHECK FAILED!!! err=-17
bitcoind: ./addrman.h:707: void CAddrMan::Check() const: Assertion `false' failed. Aborted
```
How to reproduce:
- `git checkout 181a1207` and recompile
- launch bitcoind with `-asmap` and `-checkaddrman=1` config options
- restart bitcoind
- bitcoind aborts on second call to `CAddrMan::Check()`
This commit adds a regression test to reproduce the case; it passes or fails
with the same error.
Co-authored-by: John Newbery <john@johnnewbery.com>
Co-authored-by: Martin Zumsande <mzumsande@gmail.com>
130 lines
5.3 KiB
Python
Executable file
130 lines
5.3 KiB
Python
Executable file
#!/usr/bin/env python3
|
|
# Copyright (c) 2020 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test asmap config argument for ASN-based IP bucketing.
|
|
|
|
Verify node behaviour and debug log when launching bitcoind in these cases:
|
|
|
|
1. `bitcoind` with no -asmap arg, using /16 prefix for IP bucketing
|
|
|
|
2. `bitcoind -asmap=<absolute path>`, using the unit test skeleton asmap
|
|
|
|
3. `bitcoind -asmap=<relative path>`, using the unit test skeleton asmap
|
|
|
|
4. `bitcoind -asmap/-asmap=` with no file specified, using the default asmap
|
|
|
|
5. `bitcoind -asmap` restart with an addrman containing new and tried entries
|
|
|
|
6. `bitcoind -asmap` with no file specified and a missing default asmap file
|
|
|
|
7. `bitcoind -asmap` with an empty (unparsable) default asmap file
|
|
|
|
The tests are order-independent.
|
|
|
|
"""
|
|
import os
|
|
import shutil
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
|
|
DEFAULT_ASMAP_FILENAME = 'ip_asn.map' # defined in src/init.cpp
|
|
ASMAP = '../../src/test/data/asmap.raw' # path to unit test skeleton asmap
|
|
VERSION = 'fec61fa21a9f46f3b17bdcd660d7f4cd90b966aad3aec593c99b35f0aca15853'
|
|
|
|
def expected_messages(filename):
|
|
return [f'Opened asmap file "{filename}" (59 bytes) from disk',
|
|
f'Using asmap version {VERSION} for IP bucketing']
|
|
|
|
class AsmapTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 1
|
|
self.extra_args = [["-checkaddrman=1"]] # Do addrman checks on all operations.
|
|
|
|
def fill_addrman(self, node_id):
|
|
"""Add 2 tried addresses to the addrman, followed by 2 new addresses."""
|
|
for addr, tried in [[0, True], [1, True], [2, False], [3, False]]:
|
|
self.nodes[node_id].addpeeraddress(address=f"101.{addr}.0.0", tried=tried, port=8333)
|
|
|
|
def test_without_asmap_arg(self):
|
|
self.log.info('Test bitcoind with no -asmap arg passed')
|
|
self.stop_node(0)
|
|
with self.node.assert_debug_log(['Using /16 prefix for IP bucketing']):
|
|
self.start_node(0)
|
|
|
|
def test_asmap_with_absolute_path(self):
|
|
self.log.info('Test bitcoind -asmap=<absolute path>')
|
|
self.stop_node(0)
|
|
filename = os.path.join(self.datadir, 'my-map-file.map')
|
|
shutil.copyfile(self.asmap_raw, filename)
|
|
with self.node.assert_debug_log(expected_messages(filename)):
|
|
self.start_node(0, [f'-asmap={filename}'])
|
|
os.remove(filename)
|
|
|
|
def test_asmap_with_relative_path(self):
|
|
self.log.info('Test bitcoind -asmap=<relative path>')
|
|
self.stop_node(0)
|
|
name = 'ASN_map'
|
|
filename = os.path.join(self.datadir, name)
|
|
shutil.copyfile(self.asmap_raw, filename)
|
|
with self.node.assert_debug_log(expected_messages(filename)):
|
|
self.start_node(0, [f'-asmap={name}'])
|
|
os.remove(filename)
|
|
|
|
def test_default_asmap(self):
|
|
shutil.copyfile(self.asmap_raw, self.default_asmap)
|
|
for arg in ['-asmap', '-asmap=']:
|
|
self.log.info(f'Test bitcoind {arg} (using default map file)')
|
|
self.stop_node(0)
|
|
with self.node.assert_debug_log(expected_messages(self.default_asmap)):
|
|
self.start_node(0, [arg])
|
|
os.remove(self.default_asmap)
|
|
|
|
def test_asmap_interaction_with_addrman_containing_entries(self):
|
|
self.log.info("Test bitcoind -asmap restart with addrman containing new and tried entries")
|
|
self.stop_node(0)
|
|
shutil.copyfile(self.asmap_raw, self.default_asmap)
|
|
self.start_node(0, ["-asmap", "-checkaddrman=1"])
|
|
self.fill_addrman(node_id=0)
|
|
self.restart_node(0, ["-asmap", "-checkaddrman=1"])
|
|
with self.node.assert_debug_log(
|
|
expected_msgs=[
|
|
"Addrman checks started: new 2, tried 2, total 4",
|
|
"Addrman checks completed successfully",
|
|
]
|
|
):
|
|
self.node.getnodeaddresses() # getnodeaddresses re-runs the addrman checks
|
|
os.remove(self.default_asmap)
|
|
|
|
def test_default_asmap_with_missing_file(self):
|
|
self.log.info('Test bitcoind -asmap with missing default map file')
|
|
self.stop_node(0)
|
|
msg = f"Error: Could not find asmap file \"{self.default_asmap}\""
|
|
self.node.assert_start_raises_init_error(extra_args=['-asmap'], expected_msg=msg)
|
|
|
|
def test_empty_asmap(self):
|
|
self.log.info('Test bitcoind -asmap with empty map file')
|
|
self.stop_node(0)
|
|
with open(self.default_asmap, "w", encoding="utf-8") as f:
|
|
f.write("")
|
|
msg = f"Error: Could not parse asmap file \"{self.default_asmap}\""
|
|
self.node.assert_start_raises_init_error(extra_args=['-asmap'], expected_msg=msg)
|
|
os.remove(self.default_asmap)
|
|
|
|
def run_test(self):
|
|
self.node = self.nodes[0]
|
|
self.datadir = os.path.join(self.node.datadir, self.chain)
|
|
self.default_asmap = os.path.join(self.datadir, DEFAULT_ASMAP_FILENAME)
|
|
self.asmap_raw = os.path.join(os.path.dirname(os.path.realpath(__file__)), ASMAP)
|
|
|
|
self.test_without_asmap_arg()
|
|
self.test_asmap_with_absolute_path()
|
|
self.test_asmap_with_relative_path()
|
|
self.test_default_asmap()
|
|
self.test_asmap_interaction_with_addrman_containing_entries()
|
|
self.test_default_asmap_with_missing_file()
|
|
self.test_empty_asmap()
|
|
|
|
|
|
if __name__ == '__main__':
|
|
AsmapTest().main()
|