MarcoFalke d759b5d26a Merge #15911: Use wallet RBF default for walletcreatefundedpsbt ... d6b3640ac7 [test] walletcreatefundedpsbt: check RBF is disabled when -walletrbf=0 (Sjors Provoost) 9ed062b568 [doc] rpc: remove "fallback to" from RBF default help (Sjors Provoost) 4fcb698bc2 [rpc] walletcreatefundedpsbt: use wallet default RBF (Sjors Provoost) Pull request description: The `walletcreatefundedpsbt` RPC call currently ignores `-walletrbf` and defaults to not use RBF. This PR fixes that. This PR also replaces UniValue in `ConstructTransaction` with a `bool` in preparation of moving this helper method out of the RPC codebase entirely. This may be a bit overkill, but does slightly simplify it. Fixes #15878 ACKs for top commit: achow101: Code Review ACK d6b3640ac7 l2a5b1: re-ACK d6b3640 MarcoFalke: ACK d6b3640ac7 Tree-SHA512: 55b9bccd1ef36b54f6b34793017dc0721103099ad3761b3b04862291ee13d6915915d4dbb1a8567924fa56e5e95dfe10eec070e06701610e70c87f8ea92b2a00		2019-08-02 08:53:39 -04:00
..
test	Merge #16277: [Tests] Suppress output in test_bitcoin for expected errors	2019-08-01 15:17:10 +02:00
coincontrol.cpp	extract min & max depth onto coin control	2019-07-22 15:23:21 -04:00
coincontrol.h	extract min & max depth onto coin control	2019-07-22 15:23:21 -04:00
coinselection.cpp	Introduce a Shuffle for FastRandomContext and use it in wallet and coinselection	2018-12-12 14:22:12 -08:00
coinselection.h	amount: Move CAmount CENT to unit test header	2018-09-17 14:34:56 -04:00
crypter.cpp	Remove CCryptoKeyStore and move all of it's functionality into CWallet	2019-07-09 16:20:18 -04:00
crypter.h	Remove CCryptoKeyStore and move all of it's functionality into CWallet	2019-07-09 16:20:18 -04:00
db.cpp	Merge #15588: Log the actual wallet file version and no longer publicly expose the "version" record	2019-07-27 22:45:31 +12:00
db.h	Merge #15588: Log the actual wallet file version and no longer publicly expose the "version" record	2019-07-27 22:45:31 +12:00
feebumper.cpp	Restrict lifetime of ReserveDestination to CWallet::CreateTransaction	2019-07-10 11:38:37 -04:00
feebumper.h	scripted-diff: Bump copyright headers in wallet	2019-05-06 14:05:52 -04:00
fees.cpp	[wallet] abort when attempting to fund a transaction above maxtxfee	2019-06-28 22:44:38 -04:00
fees.h	Remove uses of fee globals in wallet code	2019-02-22 15:43:02 -04:00
init.cpp	scripted-diff: Make translation bilingual	2019-07-24 16:33:20 +03:00
ismine.cpp	Move various SigningProviders to signingprovider.{cpp,h}	2019-07-09 16:20:18 -04:00
ismine.h	Change ismine to take a CWallet instead of CKeyStore	2019-06-19 18:06:30 -04:00
load.cpp	scripted-diff: Make translation bilingual	2019-07-24 16:33:20 +03:00
load.h	scripted-diff: Bump copyright headers in wallet	2019-05-06 14:05:52 -04:00
psbtwallet.cpp	Merge #15427: Add support for descriptors to utxoupdatepsbt	2019-07-02 16:53:22 +02:00
psbtwallet.h	Remove unused TransactionError constants	2019-02-14 10:32:02 -05:00
rpcdump.cpp	Merge #16301: Use CWallet::Import* functions in all import* RPCs	2019-07-26 15:19:24 -04:00
rpcwallet.cpp	Merge #15911: Use wallet RBF default for walletcreatefundedpsbt	2019-08-02 08:53:39 -04:00
rpcwallet.h	Merge #15870: wallet: Only fail rescan when blocks have actually been pruned	2019-05-16 11:18:27 -04:00
wallet.cpp	Merge #15906: [wallet] Move min_depth and max_depth to coin control	2019-07-31 12:11:51 +02:00
wallet.h	Merge #16502: wallet: Drop unused OldKey	2019-08-01 12:13:33 +08:00
walletdb.cpp	wallet: Drop unused OldKey	2019-07-31 18:35:46 +01:00
walletdb.h	Add setting as known type	2019-07-30 06:36:34 +01:00
wallettool.cpp	scripted-diff: Replace fprintf with tfm::format	2019-06-13 10:32:52 -04:00
wallettool.h	Move ismine to wallet module	2019-06-19 18:06:30 -04:00
walletutil.cpp	Merge #15870: wallet: Only fail rescan when blocks have actually been pruned	2019-05-16 11:18:27 -04:00
walletutil.h	wallet: Add WalletLocation utility class	2018-10-25 11:53:17 +01:00