W. J. van der Laan 7257e50dba Merge bitcoin/bitcoin#20833: rpc/validation: enable packages through testmempoolaccept ... 13650fe2e5 [policy] detect unsorted packages (glozow) 9ef643e21b [doc] add release note for package testmempoolaccept (glozow) c4259f4b7e [test] functional test for packages in RPCs (glozow) 9ede34a6f2 [rpc] allow multiple txns in testmempoolaccept (glozow) ae8e6df709 [policy] limit package sizes (glozow) c9e1a26d1f [fuzz] add ProcessNewPackage call in tx_pool fuzzer (glozow) 363e3d916c [test] unit tests for ProcessNewPackage (glozow) cd9a11ac96 [test] make submit optional in CreateValidMempoolTransaction (glozow) 2ef187941d [validation] package validation for test accepts (glozow) 578148ded6 [validation] explicit Success/Failure ctors for MempoolAcceptResult (glozow) b88d77aec5 [policy] Define packages (glozow) 249f43f3cc [refactor] add option to disable RBF (glozow) 897e348f59 [coins/mempool] extend CCoinsViewMemPool to track temporary coins (glozow) 42cf8b25df [validation] make CheckSequenceLocks context-free (glozow) Pull request description: This PR enables validation dry-runs of packages through the `testmempoolaccept` RPC. The expectation is that the results returned from `testmempoolaccept` are what you'd get from test-then-submitting each transaction individually, in that order (this means the package is expected to be sorted in topological order, for now at least). The validation is also atomic: in the case of failure, it immediately halts and may return "unfinished" `MempoolAcceptResult`s for transactions that weren't fully validated. The API for 1 transaction stays the same. **Motivation:** - This allows you to test validity for transaction chains (e.g. with multiple spending paths and where you don't want to broadcast yet); closes #18480. - It's also a first step towards package validation in a minimally invasive way. - The RPC commit happens to close #21074 by clarifying the "allowed" key. There are a few added restrictions on the packages, mostly to simplify the logic for areas that aren't critical to main package use cases: - No package can have conflicts, i.e. none of them can spend the same inputs, even if it would be a valid BIP125 replacement. - The package cannot conflict with the mempool, i.e. RBF is disabled. - The total count of the package cannot exceed 25 (the default descendant count limit), and total size cannot exceed 101KvB (the default descendant size limit). If you're looking for review comments and github isn't loading them, I have a gist compiling some topics of discussion [here](https://gist.github.com/glozow/c3acaf161c95bba491fce31585b2aaf7) ACKs for top commit: laanwj: Code review re-ACK 13650fe2e5 jnewbery: Code review ACK 13650fe2e5 ariard: ACK 13650fe Tree-SHA512: 8c5cbfa91a6c714e1c8710bb281d5ff1c5af36741872a7c5df6b24874d6272b4a09f816cb8a4c7de33ef8e1c2a2c252c0df5105b7802f70bc6ff821ed7cc1a2f		2021-05-27 22:40:24 +02:00
..
feerate.cpp	refactor: Make CFeeRate constructor architecture-independent	2021-05-18 07:13:25 +02:00
feerate.h	refactor: Make CFeeRate constructor architecture-independent	2021-05-18 07:13:25 +02:00
fees.cpp	Convert uses of double-serialization to {En,De}codeDouble	2021-05-24 16:15:05 -07:00
fees.h	refactor: Use C++17 std::array deduction for ALL_FEE_ESTIMATE_HORIZONS	2021-01-03 18:38:31 +01:00
packages.h	[policy] limit package sizes	2021-05-24 14:42:10 +01:00
policy.cpp	scripted-diff: Clarify that feerates are per virtual size	2021-05-01 09:42:50 +02:00
policy.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
rbf.cpp	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
rbf.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
settings.cpp	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
settings.h	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00