bitcoin/test/functional
MarcoFalke 67a72466e1
Merge #18247: test: Wait for both veracks in add_p2p_connection
faf1d04731 test: Remove redundant sync_with_ping after add_p2p_connection (MarcoFalke)
fa90647045 test: Wait for both veracks in add_p2p_connection (MarcoFalke)

Pull request description:

  This fixes the race in p2p_blocksonly

  E.g. https://travis-ci.org/MarcoFalke/bitcoin-core/jobs/657038844#L4500

  ```
   ...
   test  2020-03-01T20:58:28.825000Z TestFramework.mininode (DEBUG): Closed connection to: 127.0.0.1:11828
   node0 2020-03-01T20:58:28.825642Z [net] disconnecting peer=0
   node0 2020-03-01T20:58:28.825826Z [net] Cleared nodestate for peer=0
   node0 2020-03-01T20:58:28.875835Z [http] Received a POST request for / from 127.0.0.1:53448
   node0 2020-03-01T20:58:28.876067Z [httpworker.0] ThreadRPCServer method=getmempoolinfo user=__cookie__
   test  2020-03-01T20:58:28.877000Z TestFramework.mininode (DEBUG): Connecting to Bitcoin Node: 127.0.0.1:11828
   test  2020-03-01T20:58:28.878000Z TestFramework.mininode (DEBUG): Connected & Listening: 127.0.0.1:11828
   test  2020-03-01T20:58:28.878000Z TestFramework.mininode (DEBUG): Send message to 127.0.0.1:11828: msg_version(nVersion=70014 nServices=9 nTime=Sun Mar  1 20:58:28 2020 addrTo=CAddress(nServices=1 ip=127.0.0.1 port=11828) addrFrom=CAddress(nServices=1 ip=0.0.0.0 port=0) nNonce=0x164D5DEB952A4A0B strSubVer=b'/python-mininode-tester:0.0.3/' nStartingHeight=-1 nRelay=1)
   node0 2020-03-01T20:58:28.883808Z [net] Added connection peer=1
   node0 2020-03-01T20:58:28.883950Z [net] connection from 127.0.0.1:33798 accepted
   node0 2020-03-01T20:58:28.884300Z [msghand] received: version (116 bytes) peer=1
   node0 2020-03-01T20:58:28.884483Z [msghand] sending version (114 bytes) peer=1
   node0 2020-03-01T20:58:28.884700Z [msghand] send version message: version 70015, blocks=200, us=[::]:0, peer=1
   node0 2020-03-01T20:58:28.884765Z [msghand] sending verack (0 bytes) peer=1
   test  2020-03-01T20:58:28.885000Z TestFramework.mininode (DEBUG): Received message from 127.0.0.1:11828: msg_version(nVersion=70015 nServices=1033 nTime=Sun Mar  1 20:58:28 2020 addrTo=CAddress(nServices=0 ip=0.0.0.0 port=0) addrFrom=CAddress(nServices=1033 ip=0.0.0.0 port=0) nNonce=0x4A0F2F4C549B3399 strSubVer=b'/Satoshi:0.19.99(testnode0)/' nStartingHeight=200 nRelay=0)
   test  2020-03-01T20:58:28.885000Z TestFramework.mininode (DEBUG): Send message to 127.0.0.1:11828: msg_verack()
   test  2020-03-01T20:58:28.885000Z TestFramework.mininode (DEBUG): Received message from 127.0.0.1:11828: msg_verack()
   node0 2020-03-01T20:58:28.885004Z [msghand] receive version message: /python-mininode-tester:0.0.3/: version 70014, blocks=-1, us=127.0.0.1:11828, peer=1
   test  2020-03-01T20:58:28.886000Z TestFramework (INFO): Check that txs from rpc are not rejected and relayed to other peers
   node0 2020-03-01T20:58:28.886556Z [http] Received a POST request for / from 127.0.0.1:53448
   node0 2020-03-01T20:58:28.886783Z [httpworker.1] ThreadRPCServer method=getpeerinfo user=__cookie__
   node0 2020-03-01T20:58:28.889032Z [http] Received a POST request for / from 127.0.0.1:53448
   node0 2020-03-01T20:58:28.889294Z [httpworker.2] ThreadRPCServer method=testmempoolaccept user=__cookie__
   node0 2020-03-01T20:58:28.891655Z [http] Received a POST request for / from 127.0.0.1:53448
   node0 2020-03-01T20:58:28.891963Z [httpworker.3] ThreadRPCServer method=sendrawtransaction user=__cookie__
   node0 2020-03-01T20:58:28.893115Z [httpworker.3] Enqueuing TransactionAddedToMempool: txid=af34fc5ff9ea8babbd4083fbb79ffd2ad5aff1d6def803c07ca5aeed880bd60f wtxid=af34fc5ff9ea8babbd4083fbb79ffd2ad5aff1d6def803c07ca5aeed880bd60f
   node0 2020-03-01T20:58:28.893443Z [scheduler] TransactionAddedToMempool: txid=af34fc5ff9ea8babbd4083fbb79ffd2ad5aff1d6def803c07ca5aeed880bd60f wtxid=af34fc5ff9ea8babbd4083fbb79ffd2ad5aff1d6def803c07ca5aeed880bd60f
   node0 2020-03-01T20:58:28.894814Z [msghand] received: verack (0 bytes) peer=1
   node0 2020-03-01T20:58:28.894937Z [msghand] sending sendheaders (0 bytes) peer=1
   node0 2020-03-01T20:58:28.895087Z [msghand] sending sendcmpct (9 bytes) peer=1
   node0 2020-03-01T20:58:28.895235Z [msghand] sending sendcmpct (9 bytes) peer=1
   node0 2020-03-01T20:58:28.895430Z [msghand] sending ping (8 bytes) peer=1
   node0 2020-03-01T20:58:28.895896Z [msghand] initial getheaders (199) to peer=1 (startheight:-1)
   test  2020-03-01T20:58:28.896000Z TestFramework.mininode (DEBUG): Received message from 127.0.0.1:11828: msg_sendheaders()
   node0 2020-03-01T20:58:28.896016Z [msghand] sending getheaders (645 bytes) peer=1
   node0 2020-03-01T20:58:28.896607Z [msghand] sending feefilter (8 bytes) peer=1
   test  2020-03-01T20:58:28.897000Z TestFramework.mininode (DEBUG): Received message from 127.0.0.1:11828: msg_sendcmpct(announce=False, version=2)
   test  2020-03-01T20:58:28.897000Z TestFramework.mininode (DEBUG): Received message from 127.0.0.1:11828: msg_sendcmpct(announce=False, version=1)
   test  2020-03-01T20:58:28.897000Z TestFramework.mininode (DEBUG): Received message from 127.0.0.1:11828: msg_ping(nonce=f735096062d217b5)
   test  2020-03-01T20:58:28.897000Z TestFramework.mininode (DEBUG): Send message to 127.0.0.1:11828: msg_pong(nonce=f735096062d217b5)
   test  2020-03-01T20:58:28.897000Z TestFramework.mininode (DEBUG): Received message from 127.0.0.1:11828: msg_getheaders(locator=CBlockLocator(nVersion=70014 vHave=[48924041037103782797700918670732352379567180837453042168545380831411841797392, 28010422273815860773972769588722664110955084223364219183119416607410792753789, 5954376895683677137597080246740451260829355661937599865380797589540815086241, 14500403275336359851183244421245184901482464358719551678581030092830439955257, 17853919108052771837249729512111680264864054213441538187113939176285784834878, 28843166929059356839755035875664073555480989477... (msg truncated)
   test  2020-03-01T20:58:28.897000Z TestFramework.mininode (DEBUG): Received message from 127.0.0.1:11828: msg_feefilter(feerate=000003e8)
   node0 2020-03-01T20:58:28.898144Z [msghand] received: pong (8 bytes) peer=1
   node0 2020-03-01T20:59:28.338539Z [scheduler] Feeding 13446 bytes of dynamic environment data into RNG
   test  2020-03-01T20:59:28.908000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
                                             def test_function():
                                                 assert self.is_connected
                                                 if not self.last_message.get('tx'):
                                                     return False
                                                 return self.last_message['tx'].tx.rehash() == txid
                                     '''
   test  2020-03-01T20:59:28.908000Z TestFramework (ERROR): Assertion failed
                                     Traceback (most recent call last):
                                       File "/home/travis/build/MarcoFalke/bitcoin-core/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 112, in main
                                         self.run_test()
                                       File "/home/travis/build/MarcoFalke/bitcoin-core/build/bitcoin-x86_64-pc-linux-gnu/test/functional/p2p_blocksonly.py", line 57, in run_test
                                         self.nodes[0].p2p.wait_for_tx(txid)
                                       File "/home/travis/build/MarcoFalke/bitcoin-core/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/mininode.py", line 369, in wait_for_tx
                                         wait_until(test_function, timeout=timeout, lock=mininode_lock)
                                       File "/home/travis/build/MarcoFalke/bitcoin-core/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/util.py", line 234, in wait_until
                                         raise AssertionError("Predicate {} not true after {} seconds".format(predicate_source, timeout))
                                     AssertionError: Predicate ''''
                                             def test_function():
                                                 assert self.is_connected
                                                 if not self.last_message.get('tx'):
                                                     return False
                                                 return self.last_message['tx'].tx.rehash() == txid
                                     ''' not true after 60 seconds

ACKs for top commit:
  jonatack:
    ACK faf1d04

Tree-SHA512: 3b1a38a5c87d11c610eee0988f0c4af9bfcd978df9ac718ef611f663df2fd4a0eb04e077df5e940d15971bb2f22328fb6021cacccb6902f1e527f288ad2c4a2c
2020-04-01 05:08:41 +02:00
..
data test: Add bad-txns-*-toolarge test cases to invalid_txs 2020-03-03 12:42:52 -05:00
test_framework Merge #18247: test: Wait for both veracks in add_p2p_connection 2020-04-01 05:08:41 +02:00
.gitignore Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
combine_logs.py scripted-diff: Add missed copyright headers 2020-01-04 20:18:28 +02:00
combined_log_template.html Introduce combine_logs.py to combine log files from multiple bitcoinds. 2017-03-21 17:30:13 -04:00
create_cache.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
example_test.py [qa] Fix race condition in example_test.py 2019-07-25 10:32:07 -04:00
feature_abortnode.py ci: Run feature_block and feature_abortnode in valgrind 2020-03-22 10:12:40 -04:00
feature_asmap.py init: move asmap code earlier in init process 2020-03-04 14:54:30 +01:00
feature_assumevalid.py test: Bump rpc timeout in feature_assumevalid to avoid valgrind timeouts 2020-03-11 13:37:17 -04:00
feature_backwards_compatibility.py doc: Correct spelling errors in comments 2020-03-02 23:07:21 -08:00
feature_bip68_sequence.py Merge #17004: validation: Remove REJECT code from CValidationState 2019-10-24 10:49:45 +02:00
feature_block.py ci: Run feature_block and feature_abortnode in valgrind 2020-03-22 10:12:40 -04:00
feature_blocksdir.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
feature_cltv.py ci: Enable all functional tests in valgrind 2020-03-10 18:38:42 -04:00
feature_config_args.py Merge #17482: util: Disallow network-qualified command line options 2020-02-05 16:23:53 +01:00
feature_csv_activation.py test: check specific reject reasons in feature_csv_activation.py 2020-02-28 20:42:23 +01:00
feature_dbcrash.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
feature_dersig.py test: Bump timeouts to avoid valgrind failures 2020-03-14 22:15:52 -04:00
feature_fee_estimation.py Merge #13693: [test] Add coverage to estimaterawfee and estimatesmartfee 2020-03-11 15:55:28 -04:00
feature_filelock.py Merge #16681: Tests: Use self.chain instead of 'regtest' in all current tests 2020-02-04 20:55:26 +00:00
feature_help.py bump test timeouts so that functional tests run in valgrind 2020-01-25 15:51:35 +08:00
feature_includeconf.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
feature_loadblock.py Merge #16681: Tests: Use self.chain instead of 'regtest' in all current tests 2020-02-04 20:55:26 +00:00
feature_logging.py Merge #16681: Tests: Use self.chain instead of 'regtest' in all current tests 2020-02-04 20:55:26 +00:00
feature_maxuploadtarget.py test: Reduce unneeded whitelist permissions in tests 2020-02-26 00:00:29 +07:00
feature_minchainwork.py Changed functional tests which do not require wallets to run without 2018-09-17 08:25:10 -05:00
feature_notifications.py test: Check wallet name in -walletnotify script 2020-01-31 17:43:26 -05:00
feature_nulldummy.py test: Reduce unneeded whitelist permissions in tests 2020-02-26 00:00:29 +07:00
feature_proxy.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
feature_pruning.py Merge #16681: Tests: Use self.chain instead of 'regtest' in all current tests 2020-02-04 20:55:26 +00:00
feature_rbf.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
feature_reindex.py Changed functional tests which do not require wallets to run without 2018-09-17 08:25:10 -05:00
feature_segwit.py ci: Enable all functional tests in valgrind 2020-03-10 18:38:42 -04:00
feature_shutdown.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
feature_uacomment.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
feature_versionbits_warning.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
framework_test_script.py Add bn2vch test to functional tests 2020-03-18 13:54:01 -07:00
interface_bitcoin_cli.py Merge #17650: util: remove unwanted fields from bitcoin-cli -getinfo 2019-12-04 14:59:12 -05:00
interface_http.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
interface_rest.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
interface_rpc.py Merge #16681: Tests: Use self.chain instead of 'regtest' in all current tests 2020-02-04 20:55:26 +00:00
interface_zmq.py zmq: Fix due to invalid argument and multiple notifiers 2019-11-11 22:22:32 +00:00
mempool_accept.py test: Add bad-txns-*-toolarge test cases to invalid_txs 2020-03-03 12:42:52 -05:00
mempool_expiry.py add: test that transactions expire from mempool 2020-02-19 10:03:48 +01:00
mempool_limit.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
mempool_package_onemore.py test: re-enable CLI test support by using EncodeDecimal in json.dumps() 2019-12-09 15:14:20 -05:00
mempool_packages.py test: check custom descendant limit in mempool_packages.py 2020-02-27 00:24:33 +01:00
mempool_persist.py Merge #16681: Tests: Use self.chain instead of 'regtest' in all current tests 2020-02-04 20:55:26 +00:00
mempool_reorg.py test: Bump timeouts to avoid valgrind failures 2020-03-14 22:15:52 -04:00
mempool_resurrect.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
mempool_spend_coinbase.py qa: Run all tests even if wallet is not compiled 2018-09-10 17:53:21 -04:00
mining_basic.py Merge #16681: Tests: Use self.chain instead of 'regtest' in all current tests 2020-02-04 20:55:26 +00:00
mining_getblocktemplate_longpoll.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
mining_prioritisetransaction.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
p2p_blocksonly.py Disconnect peers violating blocks-only mode 2019-09-04 14:58:36 -04:00
p2p_compactblocks.py [Consensus] Bury segwit deployment 2019-08-14 15:52:52 -04:00
p2p_disconnect_ban.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
p2p_dos_header_tree.py test: Remove redundant sync_with_ping after add_p2p_connection 2020-03-31 17:03:24 -04:00
p2p_feefilter.py modify p2p_feefilter test to catch rounding error 2019-10-03 14:03:27 -04:00
p2p_filter.py test: add BIP37 'filterclear' test to p2p_filter.py 2020-03-31 11:14:48 +02:00
p2p_fingerprint.py Changed functional tests which do not require wallets to run without 2018-09-17 08:25:10 -05:00
p2p_invalid_block.py test: Reduce unneeded whitelist permissions in tests 2020-02-26 00:00:29 +07:00
p2p_invalid_locator.py Update copyright headers to 2018 2018-12-29 10:15:01 +01:00
p2p_invalid_messages.py test: Remove redundant sync_with_ping after add_p2p_connection 2020-03-31 17:03:24 -04:00
p2p_invalid_tx.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
p2p_leak.py test: Wait for both veracks in add_p2p_connection 2020-03-31 17:03:03 -04:00
p2p_leak_tx.py [tests] Test that nodes respond to getdata with notfound 2018-10-26 07:45:12 -04:00
p2p_mempool.py tests: Use explicit imports 2018-08-13 14:13:39 +02:00
p2p_node_network_limited.py scripted-diff: test: Replace connect_nodes_bi with connect_nodes 2019-09-17 13:08:21 -04:00
p2p_permissions.py net: Remove forcerelay of rejected txs 2020-02-11 07:44:12 -08:00
p2p_segwit.py Merge #18213: test: Fix race in p2p_segwit 2020-03-12 09:15:43 -04:00
p2p_sendheaders.py test: Remove unused imports 2019-04-09 12:10:35 -04:00
p2p_timeouts.py test: Wait for both veracks in add_p2p_connection 2020-03-31 17:03:03 -04:00
p2p_tx_download.py test: Use connect_nodes when connecting nodes in the test_framework 2019-09-17 13:08:17 -04:00
p2p_unrequested_blocks.py test: Remove unused imports 2019-04-09 12:10:35 -04:00
README.md Merge #17319: Tests: remove bignum module 2020-03-17 13:38:00 -04:00
rpc_bind.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
rpc_blockchain.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
rpc_createmultisig.py Output a descriptor in createmultisig and addmultisigaddress 2020-01-30 23:55:36 -05:00
rpc_decodescript.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
rpc_deprecated.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
rpc_deriveaddresses.py tests: Use a default of supports_cli=True (instead of supports_cli=False) 2019-12-06 15:24:06 +00:00
rpc_dumptxoutset.py test: replace 'regtest' leftovers by self.chain 2020-02-05 04:28:40 +01:00
rpc_estimatefee.py test: add executable flag for rpc_estimatefee.py 2020-03-22 23:20:35 +01:00
rpc_fundrawtransaction.py test: Reduce unneeded whitelist permissions in tests 2020-02-26 00:00:29 +07:00
rpc_getaddressinfo_label_deprecation.py test: getaddressinfo label deprecation test 2020-01-09 18:08:24 +01:00
rpc_getaddressinfo_labels_purpose_deprecation.py Merge #17585: rpc: deprecate getaddressinfo label 2020-02-02 21:35:46 +13:00
rpc_getblockfilter.py rpc: Add getblockfilter RPC method. 2019-04-06 12:10:55 -07:00
rpc_getblockstats.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
rpc_getchaintips.py test: Remove unused imports 2019-04-09 12:10:35 -04:00
rpc_getdescriptorinfo.py qa: Add getdescriptorinfo functional test 2020-03-10 08:14:04 +00:00
rpc_help.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
rpc_invalidateblock.py rpc: Add generatetodescriptor 2019-10-30 10:01:32 -04:00
rpc_misc.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
rpc_named_arguments.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
rpc_net.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
rpc_preciousblock.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
rpc_psbt.py Make AnalyzePSBT next role calculation simple, correct 2020-02-28 11:31:35 -05:00
rpc_rawtransaction.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
rpc_scantxoutset.py Merge #16681: Tests: Use self.chain instead of 'regtest' in all current tests 2020-02-04 20:55:26 +00:00
rpc_setban.py bump test timeouts so that functional tests run in valgrind 2020-01-25 15:51:35 +08:00
rpc_signmessage.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
rpc_signrawtransaction.py test: re-enable CLI test support by using EncodeDecimal in json.dumps() 2019-12-09 15:14:20 -05:00
rpc_txoutproof.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
rpc_uptime.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
rpc_users.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
rpc_whitelist.py test: Change filemode of rpc_whitelist.py 2019-12-27 21:19:44 +01:00
test-shell.md TestShell: Return self from setup() 2019-11-05 12:55:52 +01:00
test_runner.py Merge #18334: test: Add basic test for BIP 37 2020-03-30 15:28:02 -04:00
tool_wallet.py Merge #16681: Tests: Use self.chain instead of 'regtest' in all current tests 2020-02-04 20:55:26 +00:00
wallet_abandonconflict.py test: re-enable CLI test support by using EncodeDecimal in json.dumps() 2019-12-09 15:14:20 -05:00
wallet_address_types.py test: Reduce unneeded whitelist permissions in tests 2020-02-26 00:00:29 +07:00
wallet_avoidreuse.py test: Reduce unneeded whitelist permissions in tests 2020-02-26 00:00:29 +07:00
wallet_backup.py test: Reduce unneeded whitelist permissions in tests 2020-02-26 00:00:29 +07:00
wallet_balance.py test: re-enable CLI test support by using EncodeDecimal in json.dumps() 2019-12-09 15:14:20 -05:00
wallet_basic.py test: remove getaddressinfo label tests 2020-01-09 17:30:58 +01:00
wallet_bumpfee.py rpc: remove deprecated totalFee arg from RPC bumpfee 2020-03-26 17:54:18 +01:00
wallet_coinbase_category.py Test coinbase category in wallet rpcs 2018-12-01 13:00:38 -05:00
wallet_create_tx.py test: Add test for maxtxfee option 2019-07-10 11:58:46 +01:00
wallet_createwallet.py test: Bump walletpassphrase timeouts in wallet_createwallet to avoid valgrind timeouts 2020-03-11 13:23:59 -04:00
wallet_disable.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
wallet_dump.py bump test timeouts so that functional tests run in valgrind 2020-01-25 15:51:35 +08:00
wallet_encryption.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
wallet_fallbackfee.py qa: Run all tests even if wallet is not compiled 2018-09-10 17:53:21 -04:00
wallet_groups.py test: Bump timeouts to avoid valgrind failures 2020-03-14 22:15:52 -04:00
wallet_hd.py Merge #16681: Tests: Use self.chain instead of 'regtest' in all current tests 2020-02-04 20:55:26 +00:00
wallet_implicitsegwit.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
wallet_import_rescan.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
wallet_import_with_label.py Merge #17585: rpc: deprecate getaddressinfo label 2020-02-02 21:35:46 +13:00
wallet_importmulti.py test: remove getaddressinfo label tests 2020-01-09 17:30:58 +01:00
wallet_importprunedfunds.py rpc: Correctly name arguments 2018-11-13 14:24:40 -05:00
wallet_keypool.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
wallet_keypool_topup.py Tests: Use self.chain instead of 'regtest' in almost all current tests 2019-10-26 13:24:39 +02:00
wallet_labels.py Merge #17585: rpc: deprecate getaddressinfo label 2020-02-02 21:35:46 +13:00
wallet_listreceivedby.py test: remove getaddressinfo label tests 2020-01-09 17:30:58 +01:00
wallet_listsinceblock.py test: listsinceblock block height checks 2020-03-24 16:44:26 +01:00
wallet_listtransactions.py rpc: Expose block height of wallet transactions 2019-11-11 22:32:44 +00:00
wallet_multiwallet.py test: Bump timeouts to avoid valgrind failures 2020-03-14 22:15:52 -04:00
wallet_reorgsrestore.py test: re-enable CLI test support by using EncodeDecimal in json.dumps() 2019-12-09 15:14:20 -05:00
wallet_resendwallettransactions.py test: Add missing syncwithvalidationinterfacequeue 2020-02-29 04:04:27 +07:00
wallet_txn_clone.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
wallet_txn_doublespend.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
wallet_watchonly.py tests: Use a default of supports_cli=True (instead of supports_cli=False) 2019-12-06 15:24:06 +00:00
wallet_zapwallettxes.py qa: Run all tests even if wallet is not compiled 2018-09-10 17:53:21 -04:00

Functional tests

Writing Functional Tests

Example test

The file test/functional/example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test/functional/test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The Travis linter also checks this, but possibly not in all cases.
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Avoid wildcard imports
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramwork, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use '{}'.format(x) for string formatting, not '%s' % x.

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • tool for tests for tools, eg tool_wallet.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Instead of inline comments or no test documentation at all, log the comments to the test log, e.g. self.log.info('Create enough transactions to fill a block'). Logs make the test code easier to read and the test logic easier to debug.
  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to control whether or not to use the cached data directories. The cached data directories contain a 200-block pre-mined blockchain and wallets for four nodes. Each node has 25 mature blocks (25x50=1250 BTC) in its wallet.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
  • Many of the core test framework classes such as CBlock and CTransaction don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • messages.py contains all the definitions for objects that pass over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

  • Can be used to write tests where specific P2P protocol behavior is tested. Examples tests are p2p_unrequested_blocks.py, p2p_compactblocks.py.

Prototyping tests

The TestShell class exposes the BitcoinTestFramework functionality to interactive Python3 environments and can be used to prototype tests. This may be especially useful in a REPL environment with session logging utilities, such as IPython. The logs of such interactive sessions can later be adapted into permanent test cases.

Test framework modules

The following are useful modules for test developers. They are located in test/functional/test_framework/.

authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework.py

Base class for functional tests.

util.py

Generally useful functions.

mininode.py

Basic code to support P2P connectivity to a bitcoind.

script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

key.py

Test-only secp256k1 elliptic curve implementation

blocktools.py

Helper functions for creating blocks and transactions.

Benchmarking with perf

An easy way to profile node performance during functional tests is provided for Linux platforms using perf.

Perf will sample the running node and will generate profile data in the node's datadir. The profile data can then be presented using perf report or a graphical tool like hotspot.

There are two ways of invoking perf: one is to use the --perf flag when running tests, which will profile each node during the entire test run: perf begins to profile when the node starts and ends when it shuts down. The other way is the use the profile_with_perf context manager, e.g.

with node.profile_with_perf("send-big-msgs"):
    # Perform activity on the node you're interested in profiling, e.g.:
    for _ in range(10000):
        node.p2p.send_message(some_large_message)

To see useful textual output, run

perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less

See also: