mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-01-27 11:43:26 -03:00
1cf73fb8eb
8e35bf5906
scripted-diff: rename misbehavior members (John Newbery)1f96d2e673
[net processing] Move misbehavior tracking state to Peer (John Newbery)7cd4159ac8
[net processing] Add Peer (John Newbery)aba03359a6
[net processing] Remove CNodeState.name (John Newbery) Pull request description: We currently have two structures for per-peer data: - `CNode` in net, which should just contain connection layer data (eg socket, send/recv buffers, etc), but currently also contains some application layer data (eg tx/block inventory). - `CNodeState` in net processing, which contains p2p application layer data, but requires cs_main to be locked for access. This PR adds a third struct `Peer`, which is for p2p application layer data, and doesn't require cs_main. Eventually all application layer data from `CNode` should be moved to `Peer`, and any data that doesn't strictly require cs_main should be moved from `CNodeState` to `Peer` (probably all of `CNodeState` eventually). `Peer` objects are stored as shared pointers in a net processing global map `g_peer_map`, which is protected by `g_peer_mutex`. To use a `Peer` object, `g_peer_mutex` is locked, a copy of the shared pointer is taken, and the lock is released. Individual members of `Peer` are protected by different mutexes that guard related data. The lifetime of the `Peer` object is managed by the shared_ptr refcount. This PR adds the `Peer` object and moves the misbehaving data from `CNodeState` to `Peer`. This allows us to immediately remove 15 `LOCK(cs_main)` instances. For more motivation see #19398 ACKs for top commit: laanwj: Code review ACK8e35bf5906
troygiorshev: reACK8e35bf5906
via `git range-diff master 9510938 8e35bf5` theuni: ACK8e35bf5906
. jonatack: ACK8e35bf5906
keeping in mind Cory's comment (https://github.com/bitcoin/bitcoin/pull/19607#discussion_r470173964) for the follow-up Tree-SHA512: ad84a92b78fb34c9f43813ca3dfbc7282c887d55300ea2ce0994d134da3e0c7dbc44d54380e00b13bb75a57c28857ac3236bea9135467075d78026767a19e4b1
112 lines
4.9 KiB
C++
112 lines
4.9 KiB
C++
// Copyright (c) 2009-2010 Satoshi Nakamoto
|
|
// Copyright (c) 2009-2020 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#ifndef BITCOIN_NET_PROCESSING_H
|
|
#define BITCOIN_NET_PROCESSING_H
|
|
|
|
#include <consensus/params.h>
|
|
#include <net.h>
|
|
#include <sync.h>
|
|
#include <validationinterface.h>
|
|
|
|
class CChainParams;
|
|
class CTxMemPool;
|
|
class ChainstateManager;
|
|
|
|
extern RecursiveMutex cs_main;
|
|
extern RecursiveMutex g_cs_orphans;
|
|
|
|
/** Default for -maxorphantx, maximum number of orphan transactions kept in memory */
|
|
static const unsigned int DEFAULT_MAX_ORPHAN_TRANSACTIONS = 100;
|
|
/** Default number of orphan+recently-replaced txn to keep around for block reconstruction */
|
|
static const unsigned int DEFAULT_BLOCK_RECONSTRUCTION_EXTRA_TXN = 100;
|
|
static const bool DEFAULT_PEERBLOOMFILTERS = false;
|
|
static const bool DEFAULT_PEERBLOCKFILTERS = false;
|
|
/** Threshold for marking a node to be discouraged, e.g. disconnected and added to the discouragement filter. */
|
|
static const int DISCOURAGEMENT_THRESHOLD{100};
|
|
|
|
class PeerLogicValidation final : public CValidationInterface, public NetEventsInterface {
|
|
private:
|
|
CConnman& m_connman;
|
|
/** Pointer to this node's banman. May be nullptr - check existence before dereferencing. */
|
|
BanMan* const m_banman;
|
|
ChainstateManager& m_chainman;
|
|
CTxMemPool& m_mempool;
|
|
|
|
bool MaybeDiscourageAndDisconnect(CNode& pnode);
|
|
|
|
public:
|
|
PeerLogicValidation(CConnman& connman, BanMan* banman, CScheduler& scheduler, ChainstateManager& chainman, CTxMemPool& pool);
|
|
|
|
/**
|
|
* Overridden from CValidationInterface.
|
|
*/
|
|
void BlockConnected(const std::shared_ptr<const CBlock>& pblock, const CBlockIndex* pindexConnected) override;
|
|
void BlockDisconnected(const std::shared_ptr<const CBlock> &block, const CBlockIndex* pindex) override;
|
|
/**
|
|
* Overridden from CValidationInterface.
|
|
*/
|
|
void UpdatedBlockTip(const CBlockIndex *pindexNew, const CBlockIndex *pindexFork, bool fInitialDownload) override;
|
|
/**
|
|
* Overridden from CValidationInterface.
|
|
*/
|
|
void BlockChecked(const CBlock& block, const BlockValidationState& state) override;
|
|
/**
|
|
* Overridden from CValidationInterface.
|
|
*/
|
|
void NewPoWValidBlock(const CBlockIndex *pindex, const std::shared_ptr<const CBlock>& pblock) override;
|
|
|
|
/** Initialize a peer by adding it to mapNodeState and pushing a message requesting its version */
|
|
void InitializeNode(CNode* pnode) override;
|
|
/** Handle removal of a peer by updating various state and removing it from mapNodeState */
|
|
void FinalizeNode(NodeId nodeid, bool& fUpdateConnectionTime) override;
|
|
/**
|
|
* Process protocol messages received from a given node
|
|
*
|
|
* @param[in] pfrom The node which we have received messages from.
|
|
* @param[in] interrupt Interrupt condition for processing threads
|
|
*/
|
|
bool ProcessMessages(CNode* pfrom, std::atomic<bool>& interrupt) override;
|
|
/**
|
|
* Send queued protocol messages to be sent to a give node.
|
|
*
|
|
* @param[in] pto The node which we are sending messages to.
|
|
* @return True if there is more work to be done
|
|
*/
|
|
bool SendMessages(CNode* pto) override EXCLUSIVE_LOCKS_REQUIRED(pto->cs_sendProcessing);
|
|
|
|
/** Consider evicting an outbound peer based on the amount of time they've been behind our tip */
|
|
void ConsiderEviction(CNode& pto, int64_t time_in_seconds) EXCLUSIVE_LOCKS_REQUIRED(cs_main);
|
|
/** Evict extra outbound peers. If we think our tip may be stale, connect to an extra outbound */
|
|
void CheckForStaleTipAndEvictPeers(const Consensus::Params &consensusParams);
|
|
/** If we have extra outbound peers, try to disconnect the one with the oldest block announcement */
|
|
void EvictExtraOutboundPeers(int64_t time_in_seconds) EXCLUSIVE_LOCKS_REQUIRED(cs_main);
|
|
/** Retrieve unbroadcast transactions from the mempool and reattempt sending to peers */
|
|
void ReattemptInitialBroadcast(CScheduler& scheduler) const;
|
|
|
|
/** Process a single message from a peer. Public for fuzz testing */
|
|
void ProcessMessage(CNode& pfrom, const std::string& msg_type, CDataStream& vRecv,
|
|
const std::chrono::microseconds time_received, const CChainParams& chainparams,
|
|
const std::atomic<bool>& interruptMsgProc);
|
|
|
|
private:
|
|
int64_t m_stale_tip_check_time; //!< Next time to check for stale tip
|
|
|
|
};
|
|
|
|
struct CNodeStateStats {
|
|
int m_misbehavior_score = 0;
|
|
int nSyncHeight = -1;
|
|
int nCommonHeight = -1;
|
|
std::vector<int> vHeightInFlight;
|
|
};
|
|
|
|
/** Get statistics from node state */
|
|
bool GetNodeStateStats(NodeId nodeid, CNodeStateStats &stats);
|
|
|
|
/** Relay transaction to every node */
|
|
void RelayTransaction(const uint256& txid, const uint256& wtxid, const CConnman& connman) EXCLUSIVE_LOCKS_REQUIRED(cs_main);
|
|
|
|
#endif // BITCOIN_NET_PROCESSING_H
|