bitcoin/test/functional
MacroFake e4e201dfd9
Merge bitcoin/bitcoin#25290: [kernel 3a/n] Decouple CTxMemPool from ArgsManager
d1684beabe fees: Pass in a filepath instead of referencing gArgs (Carl Dong)
9a3d825c30 init: Remove redundant -*mempool*, -limit* queries (Carl Dong)
6c5c60c412 mempool: Use m_limit for UpdateTransactionsFromBlock (Carl Dong)
9e93b10301 node/ifaces: Use existing MemPoolLimits (Carl Dong)
38af2bcf35 mempoolaccept: Use limits from mempool in constructor (Carl Dong)
9333427014 mempool: Introduce (still-unused) MemPoolLimits (Carl Dong)
716bb5fbd3 scripted-diff: Rename anc/desc size limit vars to indicate SI unit (Carl Dong)
1ecc77321d scripted-diff: Rename DEFAULT_MEMPOOL_EXPIRY to indicate time unit (Carl Dong)
aa9141cd81 mempool: Pass in -mempoolexpiry instead of referencing gArgs (Carl Dong)
51c7a41a5e init: Only determine maxmempool once (Carl Dong)
386c9472c8 mempool: Make GetMinFee() with custom size protected (Carl Dong)
82f00de7a6 mempool: Pass in -maxmempool instead of referencing gArgs (Carl Dong)
f1941e8bfd pool: Add and use MemPoolOptions, ApplyArgsManOptions (Carl Dong)
0199bd35bb fuzz/rbf: Add missing TestingSetup (Carl Dong)
ccbaf546a6 scripted-diff: Rename DEFAULT_MAX_MEMPOOL_SIZE to indicate SI unit (Carl Dong)
fc02f77ca6 ArgsMan: Add Get*Arg functions returning optional (Carl Dong)

Pull request description:

  This is part of the `libbitcoinkernel` project: #24303, https://github.com/bitcoin/bitcoin/projects/18

  -----

  As mentioned in the Stage 1 Step 2 description of [the `libbitcoinkernel` project](https://github.com/bitcoin/bitcoin/issues/24303), `ArgsManager` will not be part of `libbitcoinkernel`. Therefore, it is important that we remove any dependence on `ArgsManager` by code that will be part of `libbitcoinkernel`. This is the first in a series of PRs aiming to achieve this.

  This PR removes `CTxMemPool+MempoolAccept`'s dependency on `ArgsManager` by introducing a `CTxMemPool::Options` struct, which is used to specify `CTxMemPool`'s various options at construction time.

  These options are:
  - `-maxmempool` -> `CTxMemPool::Options::max_size`
  - `-mempoolexpiry` -> `CTxMemPool::Options::expiry`
  - `-limitancestorcount` -> `CTxMemPool::Options::limits::ancestor_count`
  - `-limitancestorsize` -> `CTxMemPool::Options::limits::ancestor_size`
  - `-limitdescendantcount` -> `CTxMemPool::Options::limits::descendant_count`
  - `-limitdescendantsize` -> `CTxMemPool::Options::limits::descendant_size`

  More context can be gleaned from the commit messages. The important commits are:

  - 56eb479ded8bfb2ef635bb6f3b484f9d5952c70d "pool: Add and use MemPoolOptions, ApplyArgsManOptions"
  - a1e08b70f3068f4e8def1c630d8f50cd54da7832 "mempool: Pass in -maxmempool instead of referencing gArgs"
  - 6f4bf3ede5812b374828f08fc728ceded2f10024 "mempool: Pass in -mempoolexpiry instead of referencing gArgs"
  - 5958a7fe4806599fc620ee8c1a881ca10fa2dd16 "mempool: Introduce (still-unused) MemPoolLimits"

  Reviewers: Help needed in the following commits (see commit messages):
  - a1e08b70f3068f4e8def1c630d8f50cd54da7832 "mempool: Pass in -maxmempool instead of referencing gArgs"
  - 0695081a797e9a5d7787b78b0f8289dafcc6bff7 "node/ifaces: Use existing MemPoolLimits"

  Note to Reviewers: There are perhaps an infinite number of ways to architect `CTxMemPool::Options`, the current one tries to keep it simple, usable, and flexible. I hope we don't spend too much time arguing over the design here since that's not the point. In the case that you're 100% certain that a different design is strictly better than this one in every regard, please show us a fully-implemented branch.

  -----

  TODO:
  - [x] Use the more ergonomic `CTxMemPool::Options` where appropriate
  - [x] Doxygen comments for `ApplyArgsManOptions`, `MemPoolOptions`

  -----

  Questions for Reviewers:
  1. Should we use `std::chrono::seconds` for `CTxMemPool::Options::expiry` and `CTxMemPool::m_expiry` instead of an `int64_t`? Something else? (`std::chrono::hours`?)
  2. Should I merge `CTxMemPool::Limits` inside `CTxMemPool::Options`?

ACKs for top commit:
  MarcoFalke:
    ACK d1684beabe 🍜
  ryanofsky:
    Code review ACK d1684beabe. Just minor cleanups since last review, mostly switching to brace initialization

Tree-SHA512: 2c138e52d69f61c263f1c3648f01c801338a8f576762c815f478ef5148b8b2f51e91ded5c1be915e678c0b14f6cfba894b82afec58d999d39a7bb7c914736e0b
2022-06-29 09:13:31 +02:00
..
data tests: Test taproot fields for PSBT 2022-06-27 16:47:48 -04:00
mocks Check descriptors returned by external signers 2021-12-09 11:17:04 +01:00
test_framework test: Test signing psbts without explicitly having scripts 2022-06-27 16:48:04 -04:00
.gitignore
combine_logs.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
combined_log_template.html
create_cache.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
example_test.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_abortnode.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_addrman.py addrman: Log too low compat value 2022-02-25 14:16:32 +01:00
feature_anchors.py Merge bitcoin/bitcoin#23392: test: move check_node_connections to util 2021-11-29 13:51:27 +01:00
feature_asmap.py Merge bitcoin/bitcoin#23474: test: scripted-diff cleanups after generate* changes 2021-11-16 11:22:06 +08:00
feature_assumevalid.py test: refactor: take use of create_block txlist parameter 2021-11-17 15:45:30 +01:00
feature_backwards_compatibility.py test: previous releases: add v23.0 2022-05-06 10:00:47 +02:00
feature_bind_extra.py test: Fix out-of-range port collisions 2022-06-10 15:56:07 +02:00
feature_bind_port_discover.py net: only assume all local addresses if listening on any 2022-03-02 15:42:40 +01:00
feature_bind_port_externalip.py net: fix GetListenPort() to derive the proper port 2022-03-02 15:42:37 +01:00
feature_bip68_sequence.py test: refactor: take use of create_block txlist parameter 2021-11-17 15:45:30 +01:00
feature_block.py test: refactor: add constant for sequence number SEQUENCE_FINAL 2022-01-11 15:28:28 +01:00
feature_blocksdir.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_cltv.py Merge bitcoin/bitcoin#23508: Add getdeploymentinfo RPC 2022-01-28 08:46:03 +01:00
feature_coinstatsindex.py test: stop node before calling assert_start_raises_init_error 2022-04-29 22:50:26 +02:00
feature_config_args.py Merge bitcoin/bitcoin#24830: init: Allow -proxy="" setting values 2022-05-20 08:28:08 +01:00
feature_csv_activation.py test: MiniWallet: always rehash after signing (P2PK mode) 2022-04-22 15:06:44 +02:00
feature_dbcrash.py test: Return new_utxos from create_self_transfer_multi in MiniWallet 2022-06-27 11:07:34 +02:00
feature_dersig.py Merge bitcoin/bitcoin#23508: Add getdeploymentinfo RPC 2022-01-28 08:46:03 +01:00
feature_dirsymlinks.py test: Run symlink regression tests on Windows 2022-02-18 15:27:08 +01:00
feature_fee_estimation.py test: Return new_utxos from create_self_transfer_multi in MiniWallet 2022-06-27 11:07:34 +02:00
feature_filelock.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_help.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_includeconf.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_index_prune.py Bugfix: RPC/blockchain: pruneblockchain: Return the height of the actual last pruned block 2022-06-03 07:20:07 +00:00
feature_init.py test: Fix wait_for_debug_log UnicodeDecodeError 2022-06-07 20:54:37 +02:00
feature_loadblock.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_logging.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_maxtipage.py test: add functional test for -maxtipage parameter 2022-01-25 16:20:00 +01:00
feature_maxuploadtarget.py test: use MiniWallet for feature_maxuploadtarget.py 2022-03-11 16:14:48 +01:00
feature_minchainwork.py test: add coverage for non-hex value to -minimumchainwork 2022-05-31 08:23:38 -03:00
feature_notifications.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_nulldummy.py Merge bitcoin/bitcoin#23501: test: various feature_nulldummy.py improvements 2021-11-17 10:46:00 +01:00
feature_presegwit_node_upgrade.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_proxy.py test: Fix out-of-range port collisions 2022-06-10 15:56:07 +02:00
feature_pruning.py Bugfix: RPC/blockchain: pruneblockchain: Return the height of the actual last pruned block 2022-06-03 07:20:07 +00:00
feature_rbf.py test: Return new_utxos from create_self_transfer_multi in MiniWallet 2022-06-27 11:07:34 +02:00
feature_reindex.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_segwit.py test: Fix generate calls and comments in feature_segwit 2022-03-18 16:23:43 +01:00
feature_settings.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_shutdown.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
feature_signet.py test: Fail if connect_nodes fails 2022-06-22 09:15:33 +02:00
feature_startupnotify.py test: wait rather than assert presence of file in startupnotify test 2022-01-05 09:25:43 +08:00
feature_syscall_sandbox.py test: Properly skip feature_syscall_sandbox in valgrind 2022-02-04 16:33:05 +01:00
feature_taproot.py test: Remove previous release check 2022-04-21 14:58:55 +02:00
feature_txindex_compatibility.py Replace "can not" with "cannot" in docs, user messages, and tests 2022-02-21 19:07:29 +01:00
feature_uacomment.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
feature_unsupported_utxo_db.py Remove utxo db upgrade code 2022-03-10 13:05:29 +01:00
feature_utxo_set_hash.py Remove buggy and confusing IncrementExtraNonce 2022-04-01 11:00:42 +02:00
feature_versionbits_warning.py test, contrib, refactor: use with when opening a file 2022-04-27 20:04:33 -03:00
interface_bitcoin_cli.py test: fix test feature_coinstatsindex.py for descriptor wallets 2021-12-09 16:40:35 +01:00
interface_http.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
interface_rest.py test: compare /mempool/info response with getmempoolinfo RPC 2022-05-12 17:49:50 -03:00
interface_rpc.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
interface_usdt_coinselection.py test: Add test for coinselection tracepoints 2022-04-21 11:17:00 -04:00
interface_usdt_net.py test: net:in/out_message tracepoint tests 2022-02-20 14:59:12 +01:00
interface_usdt_utxocache.py test: fix failing test interface_usdt_utxocache.py 2022-06-27 19:40:28 +02:00
interface_usdt_validation.py test: validation:block_connected tracepoint test 2022-02-20 14:59:15 +01:00
interface_zmq.py [move only] remove is_wallet_compiled checks 2022-03-24 11:00:22 +01:00
mempool_accept.py test: Set maxfeerate=0 in MiniWallet sendrawtransaction() 2022-06-01 17:07:05 +02:00
mempool_accept_wtxid.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
mempool_compatibility.py Merge bitcoin/bitcoin#23474: test: scripted-diff cleanups after generate* changes 2021-11-16 11:22:06 +08:00
mempool_expiry.py scripted-diff: Rename DEFAULT_MEMPOOL_EXPIRY to indicate time unit 2022-06-28 15:42:40 -04:00
mempool_limit.py Merge bitcoin/bitcoin#25358: test: passing a value below 5 MB to -maxmempool should throw an error 2022-06-15 19:24:14 +02:00
mempool_package_limits.py test: Use generate* from TestFramework, not TestNode 2021-10-06 13:39:39 +02:00
mempool_package_onemore.py test: use MiniWallet for mempool_package_onemore.py 2022-03-22 18:44:27 +01:00
mempool_packages.py Add RPC to get mempool txs spending outputs 2022-05-05 14:56:48 +02:00
mempool_persist.py Merge bitcoin/bitcoin#23474: test: scripted-diff cleanups after generate* changes 2021-11-16 11:22:06 +08:00
mempool_reorg.py test: Return new_utxo from create_self_transfer in MiniWallet 2022-06-27 11:07:29 +02:00
mempool_resurrect.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
mempool_spend_coinbase.py test: Remove MiniWallet mempool_valid option 2022-06-13 18:09:16 +02:00
mempool_unbroadcast.py test: Remove from_node from create_self_transfer* MiniWallet helpers 2022-06-21 12:02:01 +02:00
mempool_updatefromblock.py [TESTS] Increase limitancestorcount in tournament RPC test to showcase improved algorithm 2021-12-08 23:07:56 -08:00
mining_basic.py test: use MiniWallet for mining_basic.py 2022-01-04 19:39:23 +01:00
mining_getblocktemplate_longpoll.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
mining_prioritisetransaction.py test: Remove from_node from create_self_transfer* MiniWallet helpers 2022-06-21 12:02:01 +02:00
p2p_add_connections.py scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
p2p_addr_relay.py Add tests for addr destination rotation 2022-03-13 16:54:43 +01:00
p2p_addrfetch.py test: use test_framework.p2p P2P_SERVICES in functional tests 2021-09-19 14:20:48 +02:00
p2p_addrv2_relay.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_block_sync.py Add functional test for block sync from inbound peers 2022-05-17 09:36:49 -04:00
p2p_blockfilters.py test: add coverage for unknown -blockfilterindex 2022-05-23 18:06:13 -03:00
p2p_blocksonly.py refactor: Introduce PeerManagerImpl::RejectIncomingTxs 2022-06-14 08:39:55 +02:00
p2p_compactblocks.py test: check for getblocktxn request with out-of-bounds tx index 2022-06-14 18:11:22 +02:00
p2p_compactblocks_blocksonly.py [net processing] Only advertise support for version 2 compact blocks 2022-05-15 15:37:56 -04:00
p2p_compactblocks_hb.py scripted-diff: Remove redundant sync_all and sync_blocks 2021-11-10 11:10:15 +01:00
p2p_disconnect_ban.py test: set ban after mocking time 2022-01-06 15:33:43 -03:00
p2p_dns_seeds.py [test] Test the delay before querying DNS seeds 2021-07-30 11:15:49 -07:00
p2p_dos_header_tree.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_eviction.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_feefilter.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_filter.py test: introduce getnewdestination helper for generating various address types 2021-12-26 12:10:52 +01:00
p2p_fingerprint.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_getaddr_caching.py test: Fix out-of-range port collisions 2022-06-10 15:56:07 +02:00
p2p_getdata.py test: use explicit p2p objects where available 2020-09-26 10:48:54 +02:00
p2p_i2p_ports.py test: ensure I2P ports are handled as expected 2021-07-09 11:19:37 +02:00
p2p_ibd_txrelay.py Merge bitcoin/bitcoin#21327: net_processing: ignore transactions while in IBD 2021-11-30 19:09:15 +01:00
p2p_invalid_block.py Remove GetAdjustedTime from init.cpp 2021-11-30 17:19:49 +01:00
p2p_invalid_locator.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_invalid_messages.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_invalid_tx.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_leak.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_leak_tx.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_message_capture.py test: Check msg type in msg capture is followed by zeros 2022-05-12 17:07:35 +02:00
p2p_nobloomfilter_messages.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
p2p_node_network_limited.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_permissions.py test: -whitebind and -bind with -listen=0 should throw an error 2022-06-22 15:22:25 -03:00
p2p_ping.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_segwit.py test: Remove from_node from create_self_transfer* MiniWallet helpers 2022-06-21 12:02:01 +02:00
p2p_sendheaders.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_timeouts.py scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
p2p_tx_download.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_unrequested_blocks.py test: Fix intermittent race in p2p_unrequested_blocks.py 2022-05-13 09:15:12 +02:00
README.md doc: Fix a link to test/lint/lint-python.py 2022-04-19 12:19:32 +02:00
rpc_bind.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
rpc_blockchain.py rpc: rename getdeploymentinfo status-next to status_next 2022-03-11 10:21:48 +01:00
rpc_createmultisig.py test: implement 'bech32m' mode for getnewdestination() helper 2022-06-14 13:37:18 +02:00
rpc_decodescript.py Replace "can not" with "cannot" in docs, user messages, and tests 2022-02-21 19:07:29 +01:00
rpc_deprecated.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
rpc_deriveaddresses.py tests: Use a default of supports_cli=True (instead of supports_cli=False) 2019-12-06 15:24:06 +00:00
rpc_dumptxoutset.py rpc: check fopen return code in dumptxoutset 2022-05-11 16:03:40 +02:00
rpc_estimatefee.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
rpc_fundrawtransaction.py test: fundrawtransaction preset input weight calculation 2022-05-18 08:25:08 +02:00
rpc_generate.py test: move-only: Move all generate* tests to a single file 2022-03-25 11:55:49 +01:00
rpc_getblockfilter.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
rpc_getblockfrompeer.py test: check pre-segwit peer error in getblockfrompeer RPC 2022-05-31 23:04:13 +02:00
rpc_getblockstats.py rpc: Quote user supplied strings in error messages 2021-12-13 15:18:35 +01:00
rpc_getchaintips.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
rpc_getdescriptorinfo.py rpc: Quote user supplied descriptor in error msg 2022-01-01 00:26:08 +13:00
rpc_help.py doc: Rework generate* doc 2022-02-21 11:02:20 +01:00
rpc_invalid_address_message.py Report encoding type in bech32 error message 2021-11-23 15:48:59 +13:00
rpc_invalidateblock.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
rpc_mempool_info.py test: Remove unused call to generate in rpc_mempool_info 2022-06-27 11:09:01 +02:00
rpc_misc.py util/check: Add CHECK_NONFATAL identity function, NONFATAL_UNREACHABLE AND UNREACHABLE macros 2022-04-16 15:07:41 +02:00
rpc_named_arguments.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
rpc_net.py Sanitize port in addpeeraddress() 2022-05-14 10:22:16 +02:00
rpc_packages.py scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
rpc_preciousblock.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
rpc_psbt.py test: Test signing psbts without explicitly having scripts 2022-06-27 16:48:04 -04:00
rpc_rawtransaction.py test: Remove from_node from create_self_transfer* MiniWallet helpers 2022-06-21 12:02:01 +02:00
rpc_scantxoutset.py test: use MiniWallet for rpc_scantxoutset.py 2021-12-26 15:52:45 +01:00
rpc_setban.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
rpc_signer.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
rpc_signmessagewithprivkey.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
rpc_signrawtransaction.py MOVEONLY: Move signrawtransactionwithwallet test 2022-05-30 16:25:17 +02:00
rpc_txoutproof.py Merge bitcoin/bitcoin#23474: test: scripted-diff cleanups after generate* changes 2021-11-16 11:22:06 +08:00
rpc_uptime.py Replace "can not" with "cannot" in docs, user messages, and tests 2022-02-21 19:07:29 +01:00
rpc_users.py Reject invalid rpcauth formats 2022-04-30 12:53:35 +02:00
rpc_whitelist.py test: Change filemode of rpc_whitelist.py 2019-12-27 21:19:44 +01:00
test-shell.md scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
test_runner.py Merge bitcoin/bitcoin#24171: p2p: Sync chain more readily from inbound peers during IBD 2022-06-02 22:35:05 +02:00
tool_signet_miner.py test: add test for signet miner script 2022-04-14 00:28:37 +02:00
tool_wallet.py wallettool: Check that the dumpfile checksum is the correct size 2021-12-26 12:33:23 -05:00
wallet_abandonconflict.py test: add more wallet conflicts assertions 2022-01-20 10:13:03 +01:00
wallet_address_types.py wallet: Strictly match tx change type to improve privacy 2021-12-17 07:59:39 +01:00
wallet_avoidreuse.py test: Test for disabling wallet flags 2022-04-14 14:42:34 -04:00
wallet_backup.py refactor: remove the wallet folder if the restore fails 2021-12-15 18:41:40 -03:00
wallet_balance.py [wallet] don't create long chains by default 2022-03-25 16:02:37 +00:00
wallet_basic.py Merge bitcoin/bitcoin#24502: wallet: don't create long chains by default 2022-03-25 17:16:13 +01:00
wallet_bumpfee.py [wallet] randomly generate change targets 2022-03-25 11:56:46 +00:00
wallet_coinbase_category.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
wallet_create_tx.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
wallet_createwallet.py tests: Do not always create a descriptor wallet in wallet_createwallet 2022-04-27 14:50:04 -04:00
wallet_crosschain.py tests: add tests for cross-chain wallet use prevention 2022-02-16 15:02:26 +02:00
wallet_descriptor.py doc: Update importaddress mention incompatibility with descriptor wallet 2022-06-14 20:54:45 +02:00
wallet_disable.py test: move-only: Move all generate* tests to a single file 2022-03-25 11:55:49 +01:00
wallet_dump.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
wallet_encryption.py Replace "can not" with "cannot" in docs, user messages, and tests 2022-02-21 19:07:29 +01:00
wallet_fallbackfee.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
wallet_groups.py wallet: Strictly match tx change type to improve privacy 2021-12-17 07:59:39 +01:00
wallet_hd.py wallet: Strictly match tx change type to improve privacy 2021-12-17 07:59:39 +01:00
wallet_implicitsegwit.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
wallet_import_rescan.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
wallet_import_with_label.py Merge #17585: rpc: deprecate getaddressinfo label 2020-02-02 21:35:46 +13:00
wallet_importdescriptors.py test: Remove unnecessary block mining from importdescriptors test 2022-06-26 16:34:11 +02:00
wallet_importmulti.py rpc: Add missing BlockUntilSyncedToCurrentChain to wallet RPCs 2021-12-03 11:13:00 +01:00
wallet_importprunedfunds.py test: check for importprunedfunds RPC errors 2022-03-09 16:16:07 +01:00
wallet_inactive_hdchains.py tests: Tests for inactive HD chains 2022-02-22 14:41:52 -05:00
wallet_keypool.py Create a tr() descriptor bech32m DescriptorScriptPubKeyMan by default 2021-11-16 12:20:13 -05:00
wallet_keypool_topup.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
wallet_labels.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
wallet_listdescriptors.py Create a tr() descriptor bech32m DescriptorScriptPubKeyMan by default 2021-11-16 12:20:13 -05:00
wallet_listreceivedby.py Merge bitcoin/bitcoin#25122: rpc: getreceivedbylabel, return early if no addresses were found in the address book 2022-05-23 12:15:14 -04:00
wallet_listsinceblock.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
wallet_listtransactions.py test: check for invalid listtransactions RPC parameters 2021-12-22 20:44:44 +01:00
wallet_multisig_descriptor_psbt.py Merge bitcoin/bitcoin#23474: test: scripted-diff cleanups after generate* changes 2021-11-16 11:22:06 +08:00
wallet_multiwallet.py refactor: replace boost::filesystem with std::filesystem 2022-02-03 18:35:52 +08:00
wallet_orphanedreward.py scripted-diff: Remove redundant sync_all and sync_blocks 2021-11-10 11:10:15 +01:00
wallet_reorgsrestore.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
wallet_resendwallettransactions.py scripted-diff: rename TxRelay members 2022-03-18 11:35:58 +00:00
wallet_send.py tests: Use descriptor that requires both legacy and segwit 2022-04-21 21:00:36 -04:00
wallet_sendall.py add tests for no recipient and using send_max while inputs are specified 2022-03-29 16:37:49 -04:00
wallet_signer.py Add sendall RPC née sweep 2022-03-29 16:37:47 -04:00
wallet_signmessagewithaddress.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
wallet_startup.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_taproot.py test: Test signing psbts without explicitly having scripts 2022-06-27 16:48:04 -04:00
wallet_timelock.py Replace "can not" with "cannot" in docs, user messages, and tests 2022-02-21 19:07:29 +01:00
wallet_transactiontime_rescan.py test: fix test wallet_transactiontime_rescan.py for descriptor wallets 2021-11-25 17:31:22 +01:00
wallet_txn_clone.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
wallet_txn_doublespend.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
wallet_upgradewallet.py tests: Test upgrading wallet with privkeys disabled 2022-02-22 13:52:40 -05:00
wallet_watchonly.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00

Functional tests

Writing Functional Tests

Example test

The file test/functional/example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test/functional/test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The CI linter job also checks this, but possibly not in all cases.
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Use type hints in your code to improve code readability and to detect possible bugs earlier.
  • Avoid wildcard imports
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramework, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use f'{x}' for string formatting in preference to '{}'.format(x) or '%s' % x.

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • tool for tests for tools, eg tool_wallet.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • Use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Instead of inline comments or no test documentation at all, log the comments to the test log, e.g. self.log.info('Create enough transactions to fill a block'). Logs make the test code easier to read and the test logic easier to debug.
  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to True to initialize an empty blockchain and start from the Genesis block, rather than load a premined blockchain from cache with the default value of False. The cached data directories contain a 200-block pre-mined blockchain with the spendable mining rewards being split between four nodes. Each node has 25 mature block subsidies (25x50=1250 BTC) in its wallet. Using them is much more efficient than mining blocks in your test.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
  • Many of the core test framework classes such as CBlock and CTransaction don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • P2Ps can be used to test specific P2P protocol behavior. p2p.py contains test framework p2p objects and messages.py contains all the definitions for objects passed over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

P2PConnections can be used as such:

p2p_conn = node.add_p2p_connection(P2PInterface())
p2p_conn.send_and_ping(msg)

They can also be referenced by indexing into a TestNode's p2ps list, which contains the list of test framework p2p objects connected to itself (it does not include any TestNodes):

node.p2ps[0].sync_with_ping()

More examples can be found in p2p_unrequested_blocks.py, p2p_compactblocks.py.

Prototyping tests

The TestShell class exposes the BitcoinTestFramework functionality to interactive Python3 environments and can be used to prototype tests. This may be especially useful in a REPL environment with session logging utilities, such as IPython. The logs of such interactive sessions can later be adapted into permanent test cases.

Test framework modules

The following are useful modules for test developers. They are located in test/functional/test_framework/.

authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework.py

Base class for functional tests.

util.py

Generally useful functions.

p2p.py

Test objects for interacting with a bitcoind node over the p2p interface.

script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

key.py

Test-only secp256k1 elliptic curve implementation

blocktools.py

Helper functions for creating blocks and transactions.

Benchmarking with perf

An easy way to profile node performance during functional tests is provided for Linux platforms using perf.

Perf will sample the running node and will generate profile data in the node's datadir. The profile data can then be presented using perf report or a graphical tool like hotspot.

There are two ways of invoking perf: one is to use the --perf flag when running tests, which will profile each node during the entire test run: perf begins to profile when the node starts and ends when it shuts down. The other way is the use the profile_with_perf context manager, e.g.

with node.profile_with_perf("send-big-msgs"):
    # Perform activity on the node you're interested in profiling, e.g.:
    for _ in range(10000):
        node.p2ps[0].send_message(some_large_message)

To see useful textual output, run

perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less

See also: