bitcoin/src/wallet
Samuel Dobson 652c45fdbb
Merge #15454: Remove the automatic creation and loading of the default wallet
d26f0648f1 Tell users how to load or create a wallet when no wallet is loaded (Andrew Chow)
1bee1e6269 Do not create default wallet (Andrew Chow)

Pull request description:

  Instead of automatically creating and loading a default wallet, users should instead explicitly create their wallet or load it on start.

  Builds on #19754 which provides the `load_on_startup` behavior for the GUI.

ACKs for top commit:
  jnewbery:
    Manual test and very light code review ACK d26f0648f1
  ryanofsky:
    Code review ACK d26f0648f1. Just suggested changes to first commit (reusing MakeWalletDatabase and adding release notes), no changes to second commit
  jonatack:
    ACK d26f0648f1 light code review, debug build, ran tests, did manual testing with testnet, rebased on master, on linux debian.

Tree-SHA512: 091d785aef64736f7df661c576e815a87f3d029cfa32f3a75ba86fc25795f10b022ab3ae15c5b61a10b8cee16f5650f15cd79cbd6127e5e3ccbef631966d3c30
2020-09-18 12:03:55 +12:00
..
test Do not create default wallet 2020-09-08 21:02:53 -04:00
bdb.cpp refactor: Pass wallet database into CWallet::Create 2020-09-03 12:24:32 -04:00
bdb.h refactor: Pass wallet database into CWallet::Create 2020-09-03 12:24:32 -04:00
coincontrol.cpp [rpc] walletcreatefundedpsbt: don't automatically append inputs 2020-03-12 13:07:17 +01:00
coincontrol.h [rpc] walletcreatefundedpsbt: don't automatically append inputs 2020-03-12 13:07:17 +01:00
coinselection.cpp Refactor OutputGroups to handle effective values, fees, and filtering 2020-08-11 14:25:02 -04:00
coinselection.h Refactor OutputGroups to handle effective values, fees, and filtering 2020-08-11 14:25:02 -04:00
context.cpp Remove g_rpc_chain global 2020-05-28 02:13:19 -04:00
context.h wallet: Pass unused args to StartWallets 2020-07-09 13:07:37 +02:00
crypter.cpp Fix occurences of c_str() used with size() to data() 2019-10-28 13:41:45 +01:00
crypter.h Convert wallet to new serialization 2020-05-24 10:34:52 -07:00
db.cpp refactor: Pass wallet database into CWallet::Create 2020-09-03 12:24:32 -04:00
db.h bugfix: make LoadWallet assigns status always 2020-09-10 00:47:31 +09:00
feebumper.cpp wallet: Remove trailing whitespace from potential translation strings 2020-05-01 07:41:32 -04:00
feebumper.h wallet: Avoid translating RPC errors when creating txs 2020-05-01 07:39:06 -04:00
fees.cpp Remove unused includes 2019-10-15 22:56:43 +00:00
fees.h Remove uses of fee globals in wallet code 2019-02-22 15:43:02 -04:00
init.cpp Do not create default wallet 2020-09-08 21:02:53 -04:00
ismine.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
load.cpp Do not create default wallet 2020-09-08 21:02:53 -04:00
load.h Do not create default wallet 2020-09-08 21:02:53 -04:00
rpcdump.cpp rpc: Assert that RPCArg names are equal to CRPCCommand ones (rpcdump) 2020-08-14 12:38:03 +02:00
rpcwallet.cpp [rpc] add send method 2020-09-10 13:44:53 +02:00
rpcwallet.h refactor: Combine GetWalletForJSONRPCRequest and EnsureWalletIsAvailable functions 2020-06-05 08:29:18 -04:00
salvage.cpp wallet: Remove path checking code from bitcoin-wallet tool 2020-09-03 12:24:32 -04:00
salvage.h wallettool: Have RecoverDatabaseFile return errors and warnings 2020-07-26 20:22:45 -04:00
scriptpubkeyman.cpp Merge #19046: Replace CWallet::Set* functions that use memonly with Add/Load variants 2020-07-11 23:08:54 +12:00
scriptpubkeyman.h Add missed thread safety annotations 2020-08-29 20:46:23 +03:00
wallet.cpp bugfix: make LoadWallet assigns status always 2020-09-10 00:47:31 +09:00
wallet.h Merge #19754: wallet, gui: Reload previously loaded wallets on startup 2020-09-03 18:24:32 +02:00
walletdb.cpp wallet: Remove path checking code from bitcoin-wallet tool 2020-09-03 12:24:32 -04:00
walletdb.h wallet: Remove path checking code from bitcoin-wallet tool 2020-09-03 12:24:32 -04:00
wallettool.cpp wallet: Remove path checking code from bitcoin-wallet tool 2020-09-03 12:24:32 -04:00
wallettool.h wallet: Remove path checking code from bitcoin-wallet tool 2020-09-03 12:24:32 -04:00
walletutil.cpp wallet: Add MakeDatabase function 2020-09-03 12:24:32 -04:00
walletutil.h Remove WalletLocation class 2020-09-03 12:24:32 -04:00