phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-01-26 11:13:23 -03:00
Code Issues Projects Releases Packages Wiki Activity Actions
bitcoin/src/interfaces
History
MarcoFalke a9f6428708
Merge bitcoin/bitcoin#23003: multiprocess: Make interfaces::Chain::isTaprootActive non-const 
7e88f61b28 multiprocess: Make interfaces::Chain::isTaprootActive non-const (Russell Yanofsky)

Pull request description:

  `interfaces::Chain` is an abstract class, so declaring the method const would be exposing internal implementation details of subclasses to interface callers. And specifically this doesn't work because the multiprocess implementation of the `interfaces::Chain::isTaprootActive` method can't be const because IPC connection state and request state is not constant during the call.

  ---

  This PR is part of the [process separation project](https://github.com/bitcoin/bitcoin/projects/10).

ACKs for top commit:
  jamesob:
    ACK 7e88f61b28

Tree-SHA512: 1c5ed89870aeb7170b9048c41299ab650dfa3d0978088e08c4c866fa0babb292722710b16f25540f26667220cb4747b1c256c4bd42893c552291eccc155346a3
2021-10-13 07:19:13 +02:00
..
chain.h Merge bitcoin/bitcoin#23003: multiprocess: Make interfaces::Chain::isTaprootActive non-const 2021-10-13 07:19:13 +02:00
echo.cpp multiprocess: Add echoipc RPC method and test 2021-04-23 03:02:50 -05:00
echo.h multiprocess: Add echoipc RPC method and test 2021-04-23 03:02:50 -05:00
handler.cpp scripted-diff: remove MakeUnique<T>() 2021-03-11 13:45:14 +08:00
handler.h scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
init.cpp multiprocess: Add echoipc RPC method and test 2021-04-23 03:02:50 -05:00
init.h multiprocess: Add echoipc RPC method and test 2021-04-23 03:02:50 -05:00
ipc.h Add ipc::Context and ipc::capnp::Context structs 2021-06-10 09:58:45 -05:00
node.h [MOVEONLY] consensus: move amount.h into consensus 2021-09-30 07:41:57 +08:00
README.md multiprocess: Add comments and documentation 2021-04-23 03:02:50 -05:00
wallet.h [MOVEONLY] consensus: move amount.h into consensus 2021-09-30 07:41:57 +08:00

README.md

Internal c++ interfaces

The following interfaces are defined here:

  • Chain — used by wallet to access blockchain and mempool state. Added in #14437, #14711, #15288, and #10973.

  • ChainClient — used by node to start & stop Chain clients. Added in #14437.

  • Node — used by GUI to start & stop bitcoin node. Added in #10244.

  • Wallet — used by GUI to access wallets. Added in #10244.

  • Handler — returned by handleEvent methods on interfaces above and used to manage lifetimes of event handlers.

  • Init — used by multiprocess code to access interfaces above on startup. Added in #19160.

  • Ipc — used by multiprocess code to access Init interface across processes. Added in #19160.

The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.