MarcoFalke b3ec1fe811 Merge #18890: test: disconnect_nodes should warn if nodes were already disconnected ... 34e641a564 test: Remove unnecessary disconnect_nodes call in rpc_psbt.py (Danny Lee) e6e7abd51a test: remove redundant two-way disconnect_nodes calls (Danny Lee) a9bd1f9adf test: warn if nodes not connected before disconnect_nodes (Danny Lee) Pull request description: There's no harm in calling `disconnect_nodes` for nodes that weren't connected (in this case it's a no-op). However, detecting this case and logging a warning can help ensure that tests are behaving as expected. In addition, since `disconnect_nodes` works bidirectionally, I removed all instances of this pattern: ``` disconnect_nodes(self.nodes[0], 1) disconnect_nodes(self.nodes[1], 0) ``` ACKs for top commit: MarcoFalke: review ACK 34e641a564 👔 amitiuttarwar: ACK 34e641a564. Thanks for this test improvement! Tree-SHA512: 344855ceb46c012d43c13d7c09f44d32dcb7645706d10ae1e4645d9edca54c6c6c13fee26b79480755cdfcdf39b4b5770b36bb03ce71ba002d5be8a27fe008af		2020-06-08 09:13:22 -04:00
..
__init__.py	Rename rpc-tests directory to functional	2017-03-20 10:40:31 -04:00
address.py	tests: implement base58_decode	2020-05-20 18:56:08 -03:00
authproxy.py	test: Try once more when RPC connection fails on Windows	2020-04-12 09:04:15 -04:00
blocktools.py	[test] CScriptNum Decode Check as Unit Tests	2020-06-03 07:18:01 -07:00
coverage.py	Update copyright headers to 2018	2018-07-27 07:15:02 -04:00
descriptors.py	Output a descriptor in createmultisig and addmultisigaddress	2020-01-30 23:55:36 -05:00
key.py	Add a --descriptors option to various tests	2020-04-23 13:59:48 -04:00
messages.py	[test] Add test for cfilters.	2020-05-26 17:38:26 -04:00
mininode.py	Merge #19044: net processing: Add support for getcfilters	2020-05-31 18:20:17 -04:00
netutil.py	scripted-diff: Update copyright in ./test	2019-03-02 10:58:35 -05:00
script.py	Merge #19082: test: Moved the CScriptNum asserts into the unit test in script.py	2020-06-04 17:28:55 +02:00
script_util.py	test: Remove unused, undocumented and misleading CScript.__add__	2020-04-22 09:00:56 -04:00
segwit_addr.py	Use BIP173 addresses in segwit.py test	2017-09-28 17:29:01 -07:00
siphash.py	Update copyright headers to 2018	2018-07-27 07:15:02 -04:00
socks5.py	scripted-diff: Update copyright in ./test	2019-03-02 10:58:35 -05:00
test_framework.py	Merge #18890: test: disconnect_nodes should warn if nodes were already disconnected	2020-06-08 09:13:22 -04:00
test_node.py	test: Fix intermittent ETIMEDOUT on FreeBSD	2020-05-19 19:12:41 -04:00
test_shell.py	TestShell: Return self from setup()	2019-11-05 12:55:52 +01:00
util.py	Merge #18890: test: disconnect_nodes should warn if nodes were already disconnected	2020-06-08 09:13:22 -04:00
wallet_util.py	add importdescriptors RPC and tests for native descriptor wallets	2020-04-23 13:59:48 -04:00