bitcoin/src/wallet
merge-script 80e6ad9e30
Some checks are pending
CI / test each commit (push) Waiting to run
CI / macOS 14 native, arm64, no depends, sqlite only, gui (push) Waiting to run
CI / macOS 14 native, arm64, fuzz (push) Waiting to run
CI / Windows native, VS 2022 (push) Waiting to run
CI / Windows native, fuzz, VS 2022 (push) Waiting to run
CI / Linux->Windows cross, no tests (push) Waiting to run
CI / Windows, test cross-built (push) Blocked by required conditions
CI / ASan + LSan + UBSan + integer, no depends, USDT (push) Waiting to run
Merge bitcoin/bitcoin#31250: wallet: Disable creating and loading legacy wallets
17bb63f9f9 wallet: Disallow loading legacy wallets (Ava Chow)
9f04e02ffa wallet: Disallow creating legacy wallets (Ava Chow)
6b247279b7 wallet: Disallow legacy wallet creation from the wallet tool (Ava Chow)
5e93b1fd6c bench: Remove WalletLoadingLegacy benchmark (Ava Chow)
56f959d829 wallet: Remove wallettool salvage (Ava Chow)
7a41c939f0 wallet: Remove -format and bdb from wallet tool's createfromdump (Ava Chow)
c847dee148 test: remove legacy wallet functional tests (Ava Chow)
20a9173717 test: Remove legacy wallet tests from wallet_reindex.py (Ava Chow)
446d480cb2 test: Remove legacy wallet tests from wallet_backwards_compatibility.py (Ava Chow)
aff80298d0 test: wallet_signer.py bdb will be removed (Ava Chow)
f94f9399ac test: Remove legacy wallet unit tests (Ava Chow)
d9ac9dbd8e tests, gui: Use descriptors watchonly wallet for watchonly test (Ava Chow)

Pull request description:

  To prepare for the deletion of legacy wallet code, disable creating or loading new legacy wallets.

  Tests for the legacy wallet specifically are deleted.

  Split from https://github.com/bitcoin/bitcoin/pull/28710

ACKs for top commit:
  Sjors:
    re-ACK 17bb63f9f9
  pablomartin4btc:
    re-ACK 17bb63f9f9
  laanwj:
    re-ACK 17bb63f9f9

Tree-SHA512: d7a86df1f71f12451b335f22f7c3f0394166ac3f8f5b81f6bbf0321026e2e8ed621576656c371d70e202df1be4410b2b1c1acb5d5f0c341e7b67aaa0ac792e7c
2025-04-25 13:11:24 +01:00
..
rpc Merge bitcoin/bitcoin#31250: wallet: Disable creating and loading legacy wallets 2025-04-25 13:11:24 +01:00
test Merge bitcoin/bitcoin#31250: wallet: Disable creating and loading legacy wallets 2025-04-25 13:11:24 +01:00
bdb.cpp scripted-diff: Bump copyright headers after std::span changes 2025-03-12 19:46:54 +01:00
bdb.h scripted-diff: Bump copyright headers after std::span changes 2025-03-12 19:46:54 +01:00
CMakeLists.txt wallet: Remove wallettool salvage 2025-04-23 12:10:30 -07:00
coincontrol.cpp wallet: Explicitly preserve scriptSig and scriptWitness in CreateTransaction 2023-12-08 17:12:19 -05:00
coincontrol.h [wallet, rpc]: add max_tx_weight to tx funding options 2024-06-27 15:31:21 +01:00
coinselection.cpp Remove unused variable assignment 2024-12-13 21:00:07 -06:00
coinselection.h Merge bitcoin/bitcoin#29523: Wallet: Add max_tx_weight to transaction funding options (take 2) 2024-07-17 18:27:59 -04:00
context.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
context.h interfaces: Add schedulerMockForward method so mockscheduler RPC can work across processes 2023-10-20 10:30:16 -04:00
crypter.cpp refactor: vector -> span in CCrypter 2024-08-28 19:09:51 +02:00
crypter.h refactor: vector -> span in CCrypter 2024-08-28 19:09:51 +02:00
db.cpp scripted-diff: Bump copyright headers after std::span changes 2025-03-12 19:46:54 +01:00
db.h wallet: Disallow loading legacy wallets 2025-04-23 12:11:56 -07:00
dump.cpp wallet: Remove -format and bdb from wallet tool's createfromdump 2025-04-23 12:10:30 -07:00
dump.h wallettool: Don't create CWallet when dumping DB 2023-12-19 16:54:06 -05:00
external_signer_scriptpubkeyman.cpp util: add TransactionError includes and namespace declarations 2024-05-16 10:16:08 -05:00
external_signer_scriptpubkeyman.h common: Add PSBTError enum 2024-05-16 10:16:08 -05:00
feebumper.cpp rpc: Allow fullrbf fee bump 2025-04-17 13:12:26 +02:00
feebumper.h rpc: bumpfee, improve doc for 'reduce_output' arg 2023-09-26 20:17:02 -03:00
fees.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
fees.h
init.cpp wallet: Disallow loading legacy wallets 2025-04-23 12:11:56 -07:00
interfaces.cpp gui: Use wallet name for wallet migration rather than WalletModel 2024-08-13 11:25:38 -04:00
load.cpp refactor: Delay translation of _() literals 2025-01-14 19:21:37 +01:00
load.h interfaces: Add schedulerMockForward method so mockscheduler RPC can work across processes 2023-10-20 10:30:16 -04:00
migrate.cpp scripted-diff: Use std::span over Span 2025-03-12 19:45:37 +01:00
migrate.h scripted-diff: Bump copyright headers after std::span changes 2025-03-12 19:46:54 +01:00
receive.cpp [clang-tidy] Enable the misc-no-recursion check 2024-04-07 14:04:45 +01:00
receive.h wallet: Add wallet/types.h for simple public enum and struct types 2023-04-11 15:52:25 -04:00
scriptpubkeyman.cpp removed duplicate calling of GetDescriptorScriptPubKeyMan 2025-03-24 17:27:27 +05:30
scriptpubkeyman.h removed duplicate calling of GetDescriptorScriptPubKeyMan 2025-03-24 17:27:27 +05:30
spend.cpp wallet: Replace "non-0" with "non-zero" in translatable error message 2025-03-04 16:29:43 +00:00
spend.h refactor: pass CRecipient to FundTransaction 2024-01-19 15:04:56 +01:00
sqlite.cpp scripted-diff: Bump copyright headers after std::span changes 2025-03-12 19:46:54 +01:00
sqlite.h scripted-diff: Bump copyright headers after std::span changes 2025-03-12 19:46:54 +01:00
transaction.cpp scripted-diff: wallet: s/TxStateConflicted/TxStateBlockConflicted 2024-03-14 17:38:39 -04:00
transaction.h util: Move util/string.h functions to util namespace 2024-05-16 10:16:08 -05:00
types.h scripted-diff: modernize outdated trait patterns - types 2025-02-21 10:41:27 +01:00
wallet.cpp Merge bitcoin/bitcoin#31250: wallet: Disable creating and loading legacy wallets 2025-04-25 13:11:24 +01:00
wallet.h removed duplicate calling of GetDescriptorScriptPubKeyMan 2025-03-24 17:27:27 +05:30
walletdb.cpp wallet: Disallow loading legacy wallets 2025-04-23 12:11:56 -07:00
walletdb.h wallet: Disallow loading legacy wallets 2025-04-23 12:11:56 -07:00
wallettool.cpp wallet: Disallow creating legacy wallets 2025-04-23 12:11:56 -07:00
wallettool.h
walletutil.cpp descriptors: Change Parse to return vector of descriptors 2024-08-08 12:47:22 -04:00
walletutil.h Merge bitcoin/bitcoin#22838: descriptors: Be able to specify change and receiving in a single descriptor string 2024-08-28 15:56:15 +01:00