bitcoin/src/rpc
MarcoFalke ac92ab6da5
Merge bitcoin/bitcoin#23113: Add warnings to createmultisig and addmultisig if using uncompressed keys
d5cab1a96d Add createmultisig and addmultisigaddress warnings release note (Samuel Dobson)
e46fc935aa Add warnings field to addmultisigaddress to warn about uncompressed keys (Samuel Dobson)
d1a9742623 Add warnings field to createmultisig to warn about uncompressed keys (Samuel Dobson)

Pull request description:

  Fixes #21368

  Currently, if there are any uncompressed keys when calling `AddAndGetMultisigDestination`, it will just default to a legacy address regardless of the chosen `address_type`. Rather than keeping this silent behaviour which may be confusing to users, we explicitly add a `warnings` field which will warn the user why their address format is different.

ACKs for top commit:
  achow101:
    ACK d5cab1a96d

Tree-SHA512: c2ac7f7689251bd4fcd8c26506f053921fbaf34c7a26a74e82ebc7f82cc0bd25407fd7954bf98365dcafa51fa45dcdbee6214320580ca69509690c3555e71cc0
2021-12-11 09:41:25 +01:00
..
blockchain.cpp Merge bitcoin/bitcoin#23280: init: Coalesce Chainstate loading sequence between {,non-}unittest codepaths 2021-12-10 17:17:43 +01:00
blockchain.h Merge bitcoin/bitcoin#20295: rpc: getblockfrompeer 2021-12-08 10:39:37 +01:00
client.cpp Merge bitcoin/bitcoin#20295: rpc: getblockfrompeer 2021-12-08 10:39:37 +01:00
client.h Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
external_signer.cpp doc: Fix RPC result documentation 2021-09-21 11:13:29 +02:00
mining.cpp scripted-diff: Use named args in RPC docs 2021-12-08 11:54:12 +01:00
mining.h rpc: create rpc/mining.h, hoist default max tries values to constant 2020-06-01 15:08:36 +02:00
misc.cpp Merge bitcoin/bitcoin#23113: Add warnings to createmultisig and addmultisig if using uncompressed keys 2021-12-11 09:41:25 +01:00
net.cpp Merge bitcoin/bitcoin#19499: p2p: Make timeout mockable and type safe, speed up test 2021-12-10 10:02:12 +01:00
protocol.h rpc: Add specific error code for "wallet already loaded" 2021-01-25 07:55:35 +01:00
rawtransaction.cpp Merge global xpubs in joinpsbts and combinepsbts 2021-12-10 08:29:47 -05:00
rawtransaction_util.cpp [MOVEONLY] consensus: move amount.h into consensus 2021-09-30 07:41:57 +08:00
rawtransaction_util.h Change SignTransaction's input_errors to use bilingual_str 2021-07-01 12:57:53 -04:00
register.h Move external signer out of wallet module 2021-04-08 17:56:00 +02:00
request.cpp refactor: Block unsafe fs::path std::string conversion calls 2021-10-05 11:10:47 -04:00
request.h Drop JSONRPCRequest constructors after #21366 2021-04-07 04:53:26 -04:00
server.cpp refactor: Block unsafe fs::path std::string conversion calls 2021-10-05 11:10:47 -04:00
server.h [MOVEONLY] consensus: move amount.h into consensus 2021-09-30 07:41:57 +08:00
server_util.cpp rpc: move Ensure* helpers to server_util.h 2021-12-02 13:15:32 +07:00
server_util.h rpc: move Ensure* helpers to server_util.h 2021-12-02 13:15:32 +07:00
util.cpp doc: Normalize RPC description whitespace 2021-12-08 19:43:24 +01:00
util.h refactor: Remove useless extern keyword 2021-05-10 09:09:24 +02:00