Ava Chow 011a895a82 Merge bitcoin/bitcoin#29015: kernel: Streamline util library ... c7376babd1 doc: Clarify distinction between util and common libraries in libraries.md (Ryan Ofsky) 4f74c59334 util: Move util/string.h functions to util namespace (Ryan Ofsky) 4d05d3f3b4 util: add TransactionError includes and namespace declarations (Ryan Ofsky) 680eafdc74 util: move fees.h and error.h to common/messages.h (Ryan Ofsky) 02e62c6c9a common: Add PSBTError enum (Ryan Ofsky) 0d44c44ae3 util: move error.h TransactionError enum to node/types.h (Ryan Ofsky) 9bcce2608d util: move spanparsing.h to script/parsing.h (Ryan Ofsky) 6dd2ad4792 util: move spanparsing.h Split functions to string.h (Ryan Ofsky) 23cc8ddff4 util: move HexStr and HexDigit from util to crypto (TheCharlatan) 6861f954f8 util: move util/message to common/signmessage (Ryan Ofsky) cc5f29fbea build: move memory_cleanse from util to crypto (Ryan Ofsky) 5b9309420c build: move chainparamsbase from util to common (Ryan Ofsky) ffa27af24d test: Add check-deps.sh script to check for unexpected library dependencies (Ryan Ofsky) Pull request description: Remove `fees.h`, `errors.h`, and `spanparsing.h` from the util library. Specifically: - Move `Split` functions from `util/spanparsing.h` to `util/string.h`, using `util` namespace for clarity. - Move remaining spanparsing functions to `script/parsing.h` since they are used for descriptor and miniscript parsing. - Combine `util/fees.h` and `util/errors.h` into `common/messages.h` so there is a place for simple functions that generate user messages to live, and these functions are not part of the util library. Motivation for this change is that the util library is a dependency of the kernel, and we should remove functionality from util that shouldn't be called by kernel code or kernel applications. These changes should also improve code organization and make functions easier to discover. Some of these same moves are (or were) part of #28690, but did not help with code organization, or made it worse, so it is better to move them and clean them up in the same PR so code only has to change one time. ACKs for top commit: achow101: ACK c7376babd1 TheCharlatan: Re-ACK c7376babd1 hebasto: re-ACK c7376babd1. Tree-SHA512: 5bcef16c1255463b1b69270548711e7ff78ca0dd34e300b95e3ca1ce52ceb34f83d9ddb2839e83800ba36b200de30396e504bbb04fa02c6d0c24a16d06ae523d		2024-06-12 17:12:54 -04:00
..
block.cpp	Drop CHashWriter	2023-11-14 08:45:32 +10:00
block.h	[validation] Cache merkle root and witness commitment checks	2024-02-27 14:19:15 +00:00
transaction.cpp	Merge bitcoin/bitcoin#29015: kernel: Streamline util library	2024-06-12 17:12:54 -04:00
transaction.h	refactor: Rename CTransaction::nVersion to version	2024-06-07 13:55:23 -04:00