mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-01-10 11:57:28 -03:00
3ab2520190
Parse platform strings with "-" or '.' correctly such as "linux-gnu" or "x86_64-linux-gnu.tar.gz" to download the matching files or file. String partition() is used to tolerate more dashes. Update `VERSION_EXAMPLE` with a new string parsed correctly now. Fix "-aarch64" interpreted as a release candidate due to sub-string "rc", causing all downloads to fail. Now "rc" must immediately follow first "-" to indicate an [-rc] string. Local variables `version_rc`, `version_os` renamed to `rc`, `platform`. If "-rcN" is specified, `platform` is reassigned to remove the '-rcN'. Changes are useful to only download one bitcoin core binary on slow connections. Making `verify.py pub` more intuitive, robust, and versatile. Closes #30145 When user types a platform string not found in any filename lets help and say the platform closest to what they typed in a `f"No files matched the platform specified. Did you mean: {closest_match}"` log. Improves UX when unaware how we name our files. Uses the difflib Python built-in which was already imported elsewhere. Update test.py to test single file verification verify-binaries/verify.py can accept an entire filename filter for its "-platform" parameter now so let us test that it succeeds and downloads and verifies only one file. `verify.py pub 22.0-x86_64-linux-gnu.tar.gz` should get and verify only the requested binary. It is placed before the existing <version> wide verification as it is a faster test and possibly easier to break. Update doc with examples now possible after bugfix Add example to show release candidates now work with "-platform" strings containing "-" and string provided can be from the middle of filename: `./contrib/verify-binaries/verify.py --json pub 23.0-rc5-linux-gnu` Change example 5 to not match example 3. New examples to show platform can now be provided specifically enough to download only a single binary down to its file extension: `./contrib/verify-binaries/verify.py pub 25.2-x86_64-linux` `./contrib/verify-binaries/verify.py pub 24.1-rc1-darwin` `./contrib/verify-binaries/verify.py pub 27.0-win64-setup.exe` This is the most common use if not verifying all files so users see it as the first example for "only download the binaries for a certain architecture and/or platform". Downloading one file is intuitively what most will think this meant and this change delivers on that expectation. Co-authored-by: stickies-v
74 lines
2.8 KiB
Python
Executable file
74 lines
2.8 KiB
Python
Executable file
#!/usr/bin/env python3
|
|
|
|
import json
|
|
import sys
|
|
import subprocess
|
|
from pathlib import Path
|
|
|
|
|
|
def main():
|
|
"""Tests ordered roughly from faster to slower."""
|
|
expect_code(run_verify("", "pub", '0.32'), 4, "Nonexistent version should fail")
|
|
expect_code(run_verify("", "pub", '0.32.awefa.12f9h'), 11, "Malformed version should fail")
|
|
expect_code(run_verify('--min-good-sigs 20', "pub", "22.0"), 9, "--min-good-sigs 20 should fail")
|
|
|
|
print("- testing verification (22.0-x86_64-linux-gnu.tar.gz)", flush=True)
|
|
_220_x86_64_linux_gnu = run_verify("--json", "pub", "22.0-x86_64-linux-gnu.tar.gz")
|
|
try:
|
|
result = json.loads(_220_x86_64_linux_gnu.stdout.decode())
|
|
except Exception:
|
|
print("failed on 22.0-x86_64-linux-gnu.tar.gz --json:")
|
|
print_process_failure(_220_x86_64_linux_gnu)
|
|
raise
|
|
|
|
expect_code(_220_x86_64_linux_gnu, 0, "22.0-x86_64-linux-gnu.tar.gz should succeed")
|
|
v = result['verified_binaries']
|
|
assert result['good_trusted_sigs']
|
|
assert len(v) == 1
|
|
assert v['bitcoin-22.0-x86_64-linux-gnu.tar.gz'] == '59ebd25dd82a51638b7a6bb914586201e67db67b919b2a1ff08925a7936d1b16'
|
|
|
|
print("- testing verification (22.0)", flush=True)
|
|
_220 = run_verify("--json", "pub", "22.0")
|
|
try:
|
|
result = json.loads(_220.stdout.decode())
|
|
except Exception:
|
|
print("failed on 22.0 --json:")
|
|
print_process_failure(_220)
|
|
raise
|
|
|
|
expect_code(_220, 0, "22.0 should succeed")
|
|
v = result['verified_binaries']
|
|
assert result['good_trusted_sigs']
|
|
assert v['bitcoin-22.0-aarch64-linux-gnu.tar.gz'] == 'ac718fed08570a81b3587587872ad85a25173afa5f9fbbd0c03ba4d1714cfa3e'
|
|
assert v['bitcoin-22.0-osx64.tar.gz'] == '2744d199c3343b2d94faffdfb2c94d75a630ba27301a70e47b0ad30a7e0155e9'
|
|
assert v['bitcoin-22.0-x86_64-linux-gnu.tar.gz'] == '59ebd25dd82a51638b7a6bb914586201e67db67b919b2a1ff08925a7936d1b16'
|
|
|
|
|
|
def run_verify(global_args: str, command: str, command_args: str) -> subprocess.CompletedProcess:
|
|
maybe_here = Path.cwd() / 'verify.py'
|
|
path = maybe_here if maybe_here.exists() else Path.cwd() / 'contrib' / 'verify-binaries' / 'verify.py'
|
|
|
|
if command == "pub":
|
|
command += " --cleanup"
|
|
|
|
return subprocess.run(
|
|
f"{path} {global_args} {command} {command_args}",
|
|
stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=True)
|
|
|
|
|
|
def expect_code(completed: subprocess.CompletedProcess, expected_code: int, msg: str):
|
|
if completed.returncode != expected_code:
|
|
print(f"{msg!r} failed: got code {completed.returncode}, expected {expected_code}")
|
|
print_process_failure(completed)
|
|
sys.exit(1)
|
|
else:
|
|
print(f"✓ {msg!r} passed")
|
|
|
|
|
|
def print_process_failure(completed: subprocess.CompletedProcess):
|
|
print(f"stdout:\n{completed.stdout.decode()}")
|
|
print(f"stderr:\n{completed.stderr.decode()}")
|
|
|
|
|
|
if __name__ == '__main__':
|
|
main()
|