bitcoin/src/test
fanquake 579c49b3a6
Merge bitcoin/bitcoin#28428: Hard-code version number value for CBlockLocator and CDiskBlockIndex
e73d2a8018 refactor: remove clientversion include from dbwrapper.h (Cory Fields)
4240a082b8 refactor: Use DataStream now that version/type are unused (Cory Fields)
f15f790618 Remove version/hashing options from CBlockLocator/CDiskBlockIndex (Cory Fields)

Pull request description:

  This is also a much simpler replacement for #28327.

  There are version fields in `CBlockLocator` and `CDiskBlockIndex` that have always been written but discarded when read.

  I intended to convert them to use SerParams as introduced by #25284, which [ended up looking like this](3e3af45165). However because we don't currently have any definition of what a hash value would mean for either one of those, and we've never assigned the version field any meaning, I think it's better to just not worry about them.

  If we ever need to assign meaning in the future, we can introduce `SerParams` as was done for `CAddress`.

  As for the dummy values chosen:

  `CDiskBlockIndex::DUMMY_VERSION` was easy as the highest ever client version, and I don't expect any objection there.

  `CBlockLocator::DUMMY_VERSION` is hard-coded to the higest _PROTOCOL_ version ever used. This is to avoid a sudden bump that would be visible on the network if CLIENT_VERSION were used instead. In the future, if we ever need to use the value, we can discard anything in the CLIENT_VERSION range (for a few years as needed), as it's quite a bit higher.

  While reviewing, I suggest looking at the throwaway `SerParams` commit above as it shows where the call-sites are. I believe that should be enough to convince one's self that hashing is never used.

ACKs for top commit:
  TheCharlatan:
    Re-ACK e73d2a8018
  ajtowns:
    reACK e73d2a8018

Tree-SHA512: 45b0dd7c2e918493e2ee92a8e35320ad17991cb8908cb811150a96c5fd584ce177c775baeeb8675a602c90b9ba9203b8cefc0a2a0c6a71078b1d9c2b41e1f3ba
2023-09-09 11:30:57 +01:00
..
data scripted-diff: Regenerate key_io data deterministically 2022-04-06 17:08:07 +02:00
fuzz Merge bitcoin/bitcoin#28196: BIP324 connection support 2023-09-08 10:24:03 +01:00
util net: add have_next_message argument to Transport::GetBytesToSend() 2023-09-07 08:53:45 -04:00
addrman_tests.cpp Use serialization parameters for CAddress serialization 2023-09-05 10:13:25 +02:00
allocator_tests.cpp refactor: Move system from util to common library 2023-05-20 12:08:13 +02:00
amount_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
argsman_tests.cpp refactor: Remove unused C-style casts 2023-07-24 15:32:00 +02:00
arith_uint256_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
banman_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
base32_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
base58_tests.cpp Remove unused raw-pointer read helper from univalue 2023-07-27 14:24:52 +02:00
base64_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
bech32_tests.cpp Make Bech32 LocateErrors return error list rather than using out-arg 2021-12-06 14:17:41 +13:00
bip32_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
bip324_tests.cpp crypto: Spanify EllSwiftPubKey constructor 2023-09-07 08:53:45 -04:00
blockchain_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
blockencodings_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
blockfilter_index_tests.cpp Clean up things that include script/standard.h 2023-08-14 17:38:27 -04:00
blockfilter_tests.cpp Remove unused includes from blockfilter.h 2023-08-17 18:28:15 +02:00
blockmanager_tests.cpp refactor: remove clientversion include from dbwrapper.h 2023-09-08 13:40:15 +00:00
bloom_tests.cpp refactor: Move system from util to common library 2023-05-20 12:08:13 +02:00
bswap_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
checkqueue_tests.cpp refactor: Replace string chain name constants with ChainTypes 2023-05-09 15:49:14 +02:00
coins_tests.cpp Clean up things that include script/standard.h 2023-08-14 17:38:27 -04:00
coinstatsindex_tests.cpp Move block-storage-related logic to ChainstateManager 2023-07-21 10:09:44 -04:00
compilerbug_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
compress_tests.cpp Clean up things that include script/standard.h 2023-08-14 17:38:27 -04:00
crypto_tests.cpp tests: miscellaneous hex / std::byte improvements 2023-08-17 15:31:56 -04:00
cuckoocache_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
dbwrapper_tests.cpp Merge bitcoin/bitcoin#26940: test: create random and coins utils, add amount helper, dedupe add_coin 2023-02-17 17:28:14 -05:00
denialofservice_tests.cpp net: add have_next_message argument to Transport::GetBytesToSend() 2023-09-07 08:53:45 -04:00
descriptor_tests.cpp wallet: accurately account for the size of the witness stack 2023-08-25 12:40:12 +02:00
flatfile_tests.cpp move-only: Extract common/args and common/config.cpp from util/system 2023-04-19 10:48:30 +02:00
fs_tests.cpp refactor: Move fs.* to util/fs.* 2023-03-23 12:55:18 +01:00
getarg_tests.cpp scripted-diff: move settings to common namespace 2023-05-30 17:26:51 +02:00
hash_tests.cpp refactor: use Span for SipHash::Write 2023-07-17 13:27:46 +02:00
headers_sync_chainwork_tests.cpp Add unit test for HeadersSyncState 2022-08-29 08:10:35 -04:00
httpserver_tests.cpp bugfix: rest: avoid segfault for invalid URI 2023-04-17 10:13:34 -03:00
i2p_tests.cpp move-only: Extract common/args and common/config.cpp from util/system 2023-04-19 10:48:30 +02:00
interfaces_tests.cpp Rename script/standard.{cpp/h} to script/solver.{cpp/h} 2023-08-14 17:39:49 -04:00
key_io_tests.cpp Remove unused raw-pointer read helper from univalue 2023-07-27 14:24:52 +02:00
key_tests.cpp Unit test for ellswift creation/decoding roundtrip 2023-06-23 14:22:39 -04:00
logging_tests.cpp refactor: fix unterminated LogPrintf()s 2023-08-03 17:52:24 +01:00
main.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
Makefile
mempool_tests.cpp refactor: Move system from util to common library 2023-05-20 12:08:13 +02:00
merkle_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
merkleblock_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
miner_tests.cpp Clean up things that include script/standard.h 2023-08-14 17:38:27 -04:00
miniminer_tests.cpp Remove unused includes from txmempool.h 2023-08-17 16:25:31 +02:00
miniscript_tests.cpp miniscript: introduce a helper to get the maximum witness size 2023-08-25 11:56:10 +02:00
minisketch_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
multisig_tests.cpp Merge bitcoin/bitcoin#24149: Signing support for Miniscript Descriptors 2023-02-16 10:01:33 +00:00
net_peer_eviction_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
net_tests.cpp net: detect wrong-network V1 talking to V2Transport 2023-09-07 09:04:55 -04:00
netbase_tests.cpp Use serialization parameters for CAddress serialization 2023-09-05 10:13:25 +02:00
orphanage_tests.cpp Clean up things that include script/standard.h 2023-08-14 17:38:27 -04:00
pmt_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
policy_fee_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
policyestimator_tests.cpp clang-tidy: Add performance-inefficient-vector-operation check 2023-03-26 20:17:55 +01:00
pool_tests.cpp Calculate memory usage correctly for unordered_maps that use PoolAllocator 2023-03-23 19:38:38 +01:00
pow_tests.cpp refactor: Replace string chain name constants with ChainTypes 2023-05-09 15:49:14 +02:00
prevector_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
raii_event_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
random_tests.cpp test: move remaining random test util code from setup_common to random 2023-06-14 08:28:33 -06:00
rbf_tests.cpp refactor: Move system from util to common library 2023-05-20 12:08:13 +02:00
README.md test: parse the command line arguments in unit tests 2022-01-11 11:53:30 +01:00
rest_tests.cpp Handle query string when parsing data format 2022-03-10 12:01:53 +01:00
result_tests.cpp refactor: Replace BResult with util::Result 2022-08-03 07:33:01 -04:00
reverselock_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
rpc_tests.cpp Remove unused raw-pointer read helper from univalue 2023-07-27 14:24:52 +02:00
sanity_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
scheduler_tests.cpp clang-tidy: Add performance-inefficient-vector-operation check 2023-03-26 20:17:55 +01:00
script_p2sh_tests.cpp clang-tidy: Add performance-inefficient-vector-operation check 2023-03-26 20:17:55 +01:00
script_parse_tests.cpp bitcoin-tx: Avoid treating overflow as OP_0 2021-10-11 09:17:28 +02:00
script_segwit_tests.cpp Unit tests for IsWitnessProgram and IsP2WSH. 2021-10-15 06:46:25 +02:00
script_standard_tests.cpp Rename script/standard.{cpp/h} to script/solver.{cpp/h} 2023-08-14 17:39:49 -04:00
script_tests.cpp Rename script/standard.{cpp/h} to script/solver.{cpp/h} 2023-08-14 17:39:49 -04:00
scriptnum10.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
scriptnum_tests.cpp
serfloat_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
serialize_tests.cpp test: add tests that exercise WithParams() 2023-09-05 10:13:41 +02:00
settings_tests.cpp scripted-diff: Following the C++ Standard rules for identifiers with _. 2023-06-20 10:23:08 +02:00
sighash_tests.cpp Remove unused raw-pointer read helper from univalue 2023-07-27 14:24:52 +02:00
sigopcount_tests.cpp Rename script/standard.{cpp/h} to script/solver.{cpp/h} 2023-08-14 17:39:49 -04:00
skiplist_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
sock_tests.cpp refactor: Move system from util to common library 2023-05-20 12:08:13 +02:00
streams_tests.cpp Remove unused legacy CHashVerifier 2023-09-05 10:13:50 +02:00
sync_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
system_tests.cpp refactor: remove in-code warning suppression 2023-06-29 14:41:33 +01:00
timedata_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
torcontrol_tests.cpp test: remove BasicTestingSetup from torcontrol unit tests 2021-05-28 19:14:09 +08:00
transaction_tests.cpp Rename script/standard.{cpp/h} to script/solver.{cpp/h} 2023-08-14 17:39:49 -04:00
translation_tests.cpp Extend bilingual_str support for tinyformat 2023-02-28 12:04:47 -05:00
txindex_tests.cpp Clean up things that include script/standard.h 2023-08-14 17:38:27 -04:00
txpackage_tests.cpp Clean up things that include script/standard.h 2023-08-14 17:38:27 -04:00
txreconciliation_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
txrequest_tests.cpp clang-tidy: Add performance-inefficient-vector-operation check 2023-03-26 20:17:55 +01:00
txvalidation_tests.cpp Clean up things that include script/standard.h 2023-08-14 17:38:27 -04:00
txvalidationcache_tests.cpp Clean up things that include script/standard.h 2023-08-14 17:38:27 -04:00
uint256_tests.cpp Use DataStream where possible 2023-01-26 10:44:05 +01:00
util_tests.cpp refactor: Move system from util to common library 2023-05-20 12:08:13 +02:00
util_threadnames_tests.cpp clang-tidy: Add performance-inefficient-vector-operation check 2023-03-26 20:17:55 +01:00
validation_block_tests.cpp Clean up things that include script/standard.h 2023-08-14 17:38:27 -04:00
validation_chainstate_tests.cpp Tighten requirements for adding elements to setBlockIndexCandidates 2023-07-24 16:23:38 -04:00
validation_chainstatemanager_tests.cpp assumeutxo cleanup: Move IsInitialBlockDownload & NotifyHeaderTip to ChainstateManager 2023-08-18 12:52:30 -04:00
validation_flush_tests.cpp Use PoolAllocator for CCoinsMap 2023-03-23 19:38:38 +01:00
validation_tests.cpp refactor: Replace string chain name constants with ChainTypes 2023-05-09 15:49:14 +02:00
validationinterface_tests.cpp test: Avoid intermittent issues due to async events in validationinterface_tests 2023-07-25 17:32:16 +02:00
versionbits_tests.cpp refactor: Replace string chain name constants with ChainTypes 2023-05-09 15:49:14 +02:00
xoroshiro128plusplus_tests.cpp Add xoroshiro128++ PRNG 2023-01-30 18:12:21 -05:00

Unit tests

The sources in this directory are unit test cases. Boost includes a unit testing framework, and since Bitcoin Core already uses Boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible).

The build system is set up to compile an executable called test_bitcoin that runs all of the unit tests. The main source file for the test library is found in util/setup_common.cpp.

Compiling/running unit tests

Unit tests will be automatically compiled if dependencies were met in ./configure and tests weren't explicitly disabled.

After configuring, they can be run with make check.

To run the unit tests manually, launch src/test/test_bitcoin. To recompile after a test file was modified, run make and then run the test again. If you modify a non-test file, use make -C src/test to recompile only what's needed to run the unit tests.

To add more unit tests, add BOOST_AUTO_TEST_CASE functions to the existing .cpp files in the test/ directory or add new .cpp files that implement new BOOST_AUTO_TEST_SUITE sections.

To run the GUI unit tests manually, launch src/qt/test/test_bitcoin-qt

To add more GUI unit tests, add them to the src/qt/test/ directory and the src/qt/test/test_main.cpp file.

Running individual tests

test_bitcoin accepts the command line arguments from the boost framework. For example, to run just the getarg_tests suite of tests:

test_bitcoin --log_level=all --run_test=getarg_tests

log_level controls the verbosity of the test framework, which logs when a test case is entered, for example. test_bitcoin also accepts the command line arguments accepted by bitcoind. Use -- to separate both types of arguments:

test_bitcoin --log_level=all --run_test=getarg_tests -- -printtoconsole=1

The -printtoconsole=1 after the two dashes redirects the debug log, which would normally go to a file in the test datadir (BasicTestingSetup::m_path_root), to the standard terminal output.

... or to run just the doubledash test:

test_bitcoin --run_test=getarg_tests/doubledash

Run test_bitcoin --help for the full list.

Adding test cases

To add a new unit test file to our test suite you need to add the file to src/Makefile.test.include. The pattern is to create one test file for each class or source file for which you want to create unit tests. The file naming convention is <source_filename>_tests.cpp and such files should wrap their tests in a test suite called <source_filename>_tests. For an example of this pattern, see uint256_tests.cpp.

Logging and debugging in unit tests

make check will write to a log file foo_tests.cpp.log and display this file on failure. For running individual tests verbosely, refer to the section above.

To write to logs from unit tests you need to use specific message methods provided by Boost. The simplest is BOOST_TEST_MESSAGE.

For debugging you can launch the test_bitcoin executable with gdb or lldb and start debugging, just like you would with any other program:

gdb src/test/test_bitcoin

Segmentation faults

If you hit a segmentation fault during a test run, you can diagnose where the fault is happening by running gdb ./src/test/test_bitcoin and then using the bt command within gdb.

Another tool that can be used to resolve segmentation faults is valgrind.

If for whatever reason you want to produce a core dump file for this fault, you can do that as well. By default, the boost test runner will intercept system errors and not produce a core file. To bypass this, add --catch_system_errors=no to the test_bitcoin arguments and ensure that your ulimits are set properly (e.g. ulimit -c unlimited).

Running the tests and hitting a segmentation fault should now produce a file called core (on Linux platforms, the file name will likely depend on the contents of /proc/sys/kernel/core_pattern).

You can then explore the core dump using

gdb src/test/test_bitcoin core

(gbd) bt  # produce a backtrace for where a segfault occurred