bitcoin/src/test
MarcoFalke 8f80092d78
Merge bitcoin/bitcoin#21563: net: Restrict period when cs_vNodes mutex is locked
8c8237a4a1 net, refactor: Fix style in CConnman::StopNodes (Hennadii Stepanov)
229ac1892d net: Combine two loops into one, and update comments (Hennadii Stepanov)
a3d090d110 net: Restrict period when cs_vNodes mutex is locked (Hennadii Stepanov)

Pull request description:

  This PR restricts the period when the `cs_vNodes` mutex is locked, prevents the only case when `cs_vNodes` could be locked before the `::cs_main`.

  This change makes the explicit locking of recursive mutexes in the explicit order redundant.

ACKs for top commit:
  jnewbery:
    utACK 8c8237a4a1
  vasild:
    ACK 8c8237a4a1
  ajtowns:
    utACK 8c8237a4a1 - logic seems sound
  MarcoFalke:
    review ACK 8c8237a4a1 👢

Tree-SHA512: a8277924339622b188b12d260a100adf5d82781634cf974320cf6007341f946a7ff40351137c2f5369aed0d318f38aac2d32965c9b619432440d722a4e78bb73
2021-04-25 10:08:57 +02:00
..
data [test] remove unnecessary OP_1s from invalid tests 2021-04-07 19:00:17 -07:00
fuzz Merge bitcoin/bitcoin#21563: net: Restrict period when cs_vNodes mutex is locked 2021-04-25 10:08:57 +02:00
util Change ClearDataDirPathCache() to ArgsManager.ClearPathCache(). 2021-04-18 12:07:00 +02:00
addrman_tests.cpp p2p, refactor: pass and use uint16_t CService::port as uint16_t 2021-03-16 19:52:31 +01:00
allocator_tests.cpp scripted-diff: remove MakeUnique<T>() 2021-03-11 13:45:14 +08:00
amount_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
arith_uint256_tests.cpp test: Move boost/stdlib includes last 2020-04-17 06:36:04 -04:00
base32_tests.cpp refactor: replace sizeof(a)/sizeof(a[0]) by std::size (C++17) 2021-01-31 17:35:16 +01:00
base58_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
base64_tests.cpp refactor: replace sizeof(a)/sizeof(a[0]) by std::size (C++17) 2021-01-31 17:35:16 +01:00
bech32_tests.cpp Add Bech32m test vectors 2021-03-15 17:26:39 -07:00
bip32_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
blockchain_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
blockencodings_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
blockfilter_index_tests.cpp miner: Add chainstate member to BlockAssembler 2021-03-24 15:40:56 -04:00
blockfilter_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
bloom_tests.cpp Treat CDataStream bytes as uint8_t 2020-11-23 21:19:50 +01:00
bswap_tests.cpp test: remove qt byteswap compattests 2021-03-29 11:12:26 +08:00
checkqueue_tests.cpp scripted-diff: remove MakeUnique<T>() 2021-03-11 13:45:14 +08:00
coins_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
compilerbug_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
compress_tests.cpp test: Fix outstanding -Wsign-compare errors 2020-05-08 11:18:43 -07:00
crypto_tests.cpp test: Add MuHash3072 unit tests 2020-12-21 19:57:28 +01:00
cuckoocache_tests.cpp refactor: replace Boost shared_mutex with std shared_mutex in cuckoocache tests 2021-02-02 12:35:40 +08:00
dbwrapper_tests.cpp scripted-diff: Modify unit tests to use the ArgsManager in the BasicTestingSetup class instead of implicitly relying on gArgs. 2021-04-18 11:59:28 +02:00
denialofservice_tests.cpp scripted-diff: Modify unit tests to use the ArgsManager in the BasicTestingSetup class instead of implicitly relying on gArgs. 2021-04-18 11:59:28 +02:00
descriptor_tests.cpp Clean up context dependent checks in descriptor parsing 2021-03-29 17:44:13 -07:00
flatfile_tests.cpp scripted-diff: Modify unit tests to use the ArgsManager in the BasicTestingSetup class instead of implicitly relying on gArgs. 2021-04-18 11:59:28 +02:00
fs_tests.cpp scripted-diff: Modify unit tests to use the ArgsManager in the BasicTestingSetup class instead of implicitly relying on gArgs. 2021-04-18 11:59:28 +02:00
getarg_tests.cpp scripted-diff: Replace m_args with m_local_args in getarg_tests.cpp 2021-04-18 11:59:28 +02:00
hash_tests.cpp refactor: replace sizeof(a)/sizeof(a[0]) by std::size (C++17) 2021-01-31 17:35:16 +01:00
i2p_tests.cpp test: add I2P test for a runaway SAM proxy 2021-03-16 14:58:38 +01:00
interfaces_tests.cpp test: Remove no longer needed MakeChain calls 2020-12-07 20:46:03 -05:00
key_io_tests.cpp test: signet network selection tests 2020-09-18 10:19:42 +09:00
key_tests.cpp Fix length of R check in test/key_tests.cpp:key_signature_tests 2020-11-25 18:07:37 +05:00
logging_tests.cpp test: Reset mocktime in the common setup 2021-04-14 17:38:07 +02:00
main.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
Makefile
mempool_tests.cpp test: Reset mocktime in the common setup 2021-04-14 17:38:07 +02:00
merkle_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
merkleblock_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
miner_tests.cpp miner: Add chainstate member to BlockAssembler 2021-03-24 15:40:56 -04:00
multisig_tests.cpp Make all SignatureChecker explicit about missing data 2021-03-15 17:29:39 -07:00
net_peer_eviction_tests.cpp Add unit test coverage for our onion peer eviction protection 2021-03-19 20:13:11 +01:00
net_tests.cpp test: Remove intermittently failing and not very meaningful BOOST_CHECK in cnetaddr_basic 2021-04-15 06:19:30 +00:00
netbase_tests.cpp test: add missing netaddress include headers 2021-03-16 19:52:37 +01:00
pmt_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
policy_fee_tests.cpp test: Add FeeFilterRounder test 2020-06-19 09:26:59 -04:00
policyestimator_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
pow_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
prevector_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
raii_event_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
random_tests.cpp Merge #18781: Add templated GetRandDuration<> 2020-05-15 08:58:49 -04:00
README.md doc: Explain new test logging 2020-03-31 17:11:47 -04:00
reverselock_tests.cpp sync: Improve CheckLastCritical() 2020-12-10 20:46:29 +02:00
rpc_tests.cpp test: Reset mocktime in the common setup 2021-04-14 17:38:07 +02:00
sanity_tests.cpp compat: remove memcpy -> memmove backwards compatibility alias 2021-03-10 14:31:10 +08:00
scheduler_tests.cpp refactor: remove boost::thread_group usage 2021-01-29 15:39:44 +08:00
script_p2sh_tests.cpp Make all SignatureChecker explicit about missing data 2021-03-15 17:29:39 -07:00
script_standard_tests.cpp Merge #20211: Use -Wswitch for TxoutType where possible 2021-02-11 11:48:12 +01:00
script_tests.cpp Make all SignatureChecker explicit about missing data 2021-03-15 17:29:39 -07:00
scriptnum10.h scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
scriptnum_tests.cpp refactor: replace sizeof(a)/sizeof(a[0]) by std::size (C++17) 2021-01-31 17:35:16 +01:00
serialize_tests.cpp Treat CDataStream bytes as uint8_t 2020-11-23 21:19:50 +01:00
settings_tests.cpp scripted-diff: Modify unit tests to use the ArgsManager in the BasicTestingSetup class instead of implicitly relying on gArgs. 2021-04-18 11:59:28 +02:00
sighash_tests.cpp refactor: replace sizeof(a)/sizeof(a[0]) by std::size (C++17) 2021-01-31 17:35:16 +01:00
sigopcount_tests.cpp Make all SignatureChecker explicit about missing data 2021-03-15 17:29:39 -07:00
skiplist_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
sock_tests.cpp test: add a test to ensure RecvUntilTerminator() limit works 2021-03-16 11:00:57 +01:00
streams_tests.cpp Merge #20464: refactor: Treat CDataStream bytes as uint8_t 2021-02-01 15:17:28 +01:00
sync_tests.cpp refactor: remove straggling boost::mutex usage 2021-01-26 15:57:28 +08:00
system_tests.cpp configure: add --enable-external-signer 2021-02-21 16:27:10 +01:00
timedata_tests.cpp Make GetWarnings() return bilingual_str 2020-06-10 15:01:20 +03:00
torcontrol_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
transaction_tests.cpp Merge bitcoin/bitcoin#21280: test: bug fix in transaction_tests 2021-04-19 11:26:42 +02:00
txindex_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
txrequest_tests.cpp Report and verify expirations 2020-10-12 12:14:53 -07:00
txvalidation_tests.cpp scripted-diff: Invoke ::AcceptToMemoryPool with chainstate 2021-02-18 14:49:06 -05:00
txvalidationcache_tests.cpp Merge #21202: [validation] Two small clang lock annotation improvements 2021-02-22 09:47:15 +01:00
uint256_tests.cpp uint256: Update constructors to c++11, make ONE static 2020-09-28 12:14:19 +10:00
util_tests.cpp Change ClearDataDirPathCache() to ArgsManager.ClearPathCache(). 2021-04-18 12:07:00 +02:00
util_threadnames_tests.cpp test: Set -logthreadnames in unit tests 2020-05-21 08:13:23 -04:00
validation_block_tests.cpp miner: Add chainstate member to BlockAssembler 2021-03-24 15:40:56 -04:00
validation_chainstate_tests.cpp sync: Use decltype(auto) return type for WITH_LOCK 2020-12-04 12:23:05 -05:00
validation_chainstatemanager_tests.cpp test: Remove option to make TestChain100Setup non-deterministic 2021-04-08 08:59:00 +02:00
validation_flush_tests.cpp Pass mempool reference to chainstate constructor 2020-08-28 10:42:04 +02:00
validation_tests.cpp test: Use compressed keys in TestChain100Setup 2021-04-08 08:58:44 +02:00
validationinterface_tests.cpp test: Remove const to work around compiler error on xenial 2020-05-14 18:40:57 +02:00
versionbits_tests.cpp test: Run versionbits_sanity for all chains 2021-04-17 11:29:50 +02:00

Unit tests

The sources in this directory are unit test cases. Boost includes a unit testing framework, and since Bitcoin Core already uses Boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible).

The build system is set up to compile an executable called test_bitcoin that runs all of the unit tests. The main source file for the test library is found in util/setup_common.cpp.

Compiling/running unit tests

Unit tests will be automatically compiled if dependencies were met in ./configure and tests weren't explicitly disabled.

After configuring, they can be run with make check.

To run the unit tests manually, launch src/test/test_bitcoin. To recompile after a test file was modified, run make and then run the test again. If you modify a non-test file, use make -C src/test to recompile only what's needed to run the unit tests.

To add more unit tests, add BOOST_AUTO_TEST_CASE functions to the existing .cpp files in the test/ directory or add new .cpp files that implement new BOOST_AUTO_TEST_SUITE sections.

To run the GUI unit tests manually, launch src/qt/test/test_bitcoin-qt

To add more GUI unit tests, add them to the src/qt/test/ directory and the src/qt/test/test_main.cpp file.

Running individual tests

test_bitcoin has some built-in command-line arguments; for example, to run just the getarg_tests verbosely:

test_bitcoin --log_level=all --run_test=getarg_tests -- DEBUG_LOG_OUT

log_level controls the verbosity of the test framework, which logs when a test case is entered, for example. The DEBUG_LOG_OUT after the two dashes redirects the debug log, which would normally go to a file in the test datadir (BasicTestingSetup::m_path_root), to the standard terminal output.

... or to run just the doubledash test:

test_bitcoin --run_test=getarg_tests/doubledash

Run test_bitcoin --help for the full list.

Adding test cases

To add a new unit test file to our test suite you need to add the file to src/Makefile.test.include. The pattern is to create one test file for each class or source file for which you want to create unit tests. The file naming convention is <source_filename>_tests.cpp and such files should wrap their tests in a test suite called <source_filename>_tests. For an example of this pattern, see uint256_tests.cpp.

Logging and debugging in unit tests

make check will write to a log file foo_tests.cpp.log and display this file on failure. For running individual tests verbosely, refer to the section above.

To write to logs from unit tests you need to use specific message methods provided by Boost. The simplest is BOOST_TEST_MESSAGE.

For debugging you can launch the test_bitcoin executable with gdbor lldb and start debugging, just like you would with any other program:

gdb src/test/test_bitcoin