bitcoin/src/test
laanwj 90e49c1ece
Merge bitcoin/bitcoin#24464: logging: Add severity level to logs
e11cdc9303  logging: Add log severity level to net.cpp (klementtan)
a8290649a6 logging: Add severity level to logs. (klementtan)

Pull request description:

  **Overview**: This PR introduces a new macro, `LogPrintLevel`, that allows developers to add logs with the severity level. Additionally, it will also print the log category if it is specified.

  Sample log:
  ```
  2022-03-04T16:41:15Z [opencon] [net:debug] trying connection XX.XX.XXX.XXX:YYYYY lastseen=2.7hrs
  ```

  **Motivation**: This feature was suggested in #20576 and I believe that it will bring the following benefits:
  * Allow for easier filtering of logs in `debug.log`
  * Can be extended to allow users to select the minimum level of logs they would like to view (not in the scope of this PR)

  **Details**:
  * New log format. `... [category:level]...`. ie:
    * Do not print category if `category == NONE`
    * Do not print level if `level == NONE`
    * If `category == NONE` and `level == NONE`, do not print any fields (current behaviour)
  * Previous logging functions:
    * `LogPrintf`:  no changes in log as it calls `LogPrintf_` with `category = NONE` and `level = NONE`
    * `LogPrint`: prints additional `[category]` field as it calls `LogPrintf_` with `category = category` and `level = NONE`
  * `net.cpp`: As a proof of concept, updated logs with obvious severity (ie prefixed with `Warning/Error:..`) to use the new logging with severity.

  **Testing**:
  * Compiling and running `bitcoind` with this PR should instantly display logs with the category name (ie `net/tor/...`)
  * Grepping for `net:debug` in `debug.log` should display the updated logs with severity level:
    <details>
    <summary>Code</summary>

    ```
    $ grep "net:debug" debug.log

    2022-03-04T16:41:15Z [opencon] [net:debug] trying connection XXX:YYY lastseen=2.7hrs
    2022-03-04T16:41:16Z [opencon] [net:debug] trying connection XXX:YYY lastseen=16.9hrs
    2022-03-04T16:41:17Z [opencon] [net:debug] trying connection XXX:YYY lastseen=93.2hrs
    2022-03-04T16:41:18Z [opencon] [net:debug] trying connection XXX:YYY lastseen=2.7hrs
    ```
    </details>

ACKs for top commit:
  laanwj:
    Code review and lightly tested ACK e11cdc9303

Tree-SHA512: 89a8c86667ccc0688e5acfdbd399aac1f5bec9f978a160e40b0210b0d9b8fdc338479583fc5bd2e2bc785821363f174f578d52136d228e8f638a20abbf0a568f
2022-05-24 19:32:45 +02:00
..
data scripted-diff: Regenerate key_io data deterministically 2022-04-06 17:08:07 +02:00
fuzz Merge bitcoin/bitcoin#24410: [kernel 2a/n] Split hashing/index GetUTXOStats codepaths, decouple from coinstatsindex 2022-05-24 14:43:00 +02:00
util Add ChainstateManager::m_adjusted_time_callback 2022-05-20 11:57:51 -04:00
addrman_tests.cpp [netgroupman] Add GetMappedAS() and GetGroup() 2022-04-20 14:35:52 +01:00
allocator_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
amount_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
arith_uint256_tests.cpp refactor tests to fix ubsan suppressions 2022-01-20 15:25:23 +01:00
banman_tests.cpp net: Drop only invalid entries when reading banlist.json 2021-12-14 18:58:45 +01:00
base32_tests.cpp Make DecodeBase{32,64} return optional instead of taking bool* 2022-04-27 14:12:55 +02:00
base58_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
base64_tests.cpp Make DecodeBase{32,64} return optional instead of taking bool* 2022-04-27 14:12:55 +02:00
bech32_tests.cpp Make Bech32 LocateErrors return error list rather than using out-arg 2021-12-06 14:17:41 +13:00
bip32_tests.cpp refactor: Use Span of std::byte in CExtKey::SetSeed 2022-04-27 19:53:37 +02:00
blockchain_tests.cpp
blockencodings_tests.cpp Remove fUseWTXID parameter from CBlockHeaderAndShortTxIDs constructor 2022-05-17 10:37:10 +01:00
blockfilter_index_tests.cpp Do not call global Params() when chainman is in scope 2022-05-18 18:46:48 +02:00
blockfilter_tests.cpp scripted-diff: Use getInt<T> over get_int/get_int64 2022-05-18 19:15:03 +02:00
bloom_tests.cpp Use spans of std::byte in serialize 2022-01-02 11:40:31 +01:00
bswap_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
checkqueue_tests.cpp refactor: use C++11 default initializers 2022-05-17 17:18:58 +01:00
coins_tests.cpp refactor: Remove defunct attributes.h includes 2022-05-21 13:54:33 -05:00
coinstatsindex_tests.cpp scripted-diff: Move src/kernel/coinstats to kernel:: 2022-05-23 14:53:35 -04:00
compilerbug_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
compress_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
crypto_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
cuckoocache_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
dbwrapper_tests.cpp refactor: use C++11 default initializers 2022-05-17 17:18:58 +01:00
denialofservice_tests.cpp Do not call global Params() when chainman is in scope 2022-05-18 18:46:48 +02:00
descriptor_tests.cpp refactor: Change * to & in MutableTransactionSignatureCreator 2022-05-04 11:49:29 +02:00
flatfile_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
fs_tests.cpp test: Correctly decode UTF-8 literal string paths 2022-03-03 14:12:07 -05:00
getarg_tests.cpp test: Remove boost::split from getarg_tests.cpp 2022-04-29 14:35:50 +02:00
hash_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
httpserver_tests.cpp Add GetQueryParameter helper function 2022-03-10 12:01:54 +01:00
i2p_tests.cpp scripted-diff: Replace GetDataDir() calls with gArgs.GetDataDirNet() calls 2021-05-24 10:29:58 +02:00
interfaces_tests.cpp Guard CBlockIndex::nStatus/nFile/nDataPos/nUndoPos by cs_main 2022-01-25 20:46:52 +01:00
key_io_tests.cpp refactor: Use Span of std::byte in CExtKey::SetSeed 2022-04-27 19:53:37 +02:00
key_tests.cpp refactor: use Span in random.* 2022-03-23 17:36:33 -05:00
logging_tests.cpp logging: Add severity level to logs. 2022-05-19 21:05:35 +08:00
main.cpp build: use header-only Boost unit test 2022-02-13 20:59:02 +00:00
Makefile
mempool_tests.cpp test: Split MempoolAncestryTests into two 2022-04-29 09:43:11 +02:00
merkle_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
merkleblock_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
miner_tests.cpp Add ChainstateManager::m_adjusted_time_callback 2022-05-20 11:57:51 -04:00
miniscript_tests.cpp miniscript: the 'd:' wrapper must not be 'u' 2022-04-18 16:03:29 +02:00
minisketch_tests.cpp Add src/node/* code to node:: namespace 2022-01-06 22:14:16 -05:00
multisig_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
net_peer_eviction_tests.cpp doc: Convert remaining comments to clang-tidy format 2022-04-06 15:37:07 +02:00
net_tests.cpp Merge bitcoin/bitcoin#24205: init, test: improve network reachability test coverage and safety 2022-03-24 21:17:46 +01:00
netbase_tests.cpp [netgroupman] Add GetMappedAS() and GetGroup() 2022-04-20 14:35:52 +01:00
orphanage_tests.cpp [tests] Move TxOrphange tests to orphange_tests.cpp 2022-04-25 08:37:01 +01:00
pmt_tests.cpp Remove not needed ArithToUint256 roundtrips in tests 2022-04-14 19:29:52 +02:00
policy_fee_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
policyestimator_tests.cpp
pow_tests.cpp refactor tests to fix ubsan suppressions 2022-01-20 15:25:23 +01:00
prevector_tests.cpp test, bench: make prevector and checkqueue swap member functions noexcept 2022-04-28 20:34:43 +02:00
raii_event_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
random_tests.cpp Merge bitcoin/bitcoin#24925: refactor: make GetRand a template, remove GetRandInt 2022-05-12 08:57:22 +02:00
README.md test: parse the command line arguments in unit tests 2022-01-11 11:53:30 +01:00
rest_tests.cpp Handle query string when parsing data format 2022-03-10 12:01:53 +01:00
reverselock_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
rpc_tests.cpp scripted-diff: Use getInt<T> over get_int/get_int64 2022-05-18 19:15:03 +02:00
sanity_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
scheduler_tests.cpp Switch scheduler to steady_clock 2022-05-10 10:54:54 +02:00
script_p2sh_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
script_parse_tests.cpp bitcoin-tx: Avoid treating overflow as OP_0 2021-10-11 09:17:28 +02:00
script_segwit_tests.cpp Unit tests for IsWitnessProgram and IsP2WSH. 2021-10-15 06:46:25 +02:00
script_standard_tests.cpp scripted-diff: Use getInt<T> over get_int/get_int64 2022-05-18 19:15:03 +02:00
script_tests.cpp Merge bitcoin/bitcoin#25153: scripted-diff: Use getInt<T> over get_int/get_int64 2022-05-19 16:32:56 +01:00
scriptnum10.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
scriptnum_tests.cpp refactor: replace sizeof(a)/sizeof(a[0]) by std::size (C++17) 2021-01-31 17:35:16 +01:00
serfloat_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
serialize_tests.cpp test: Fix Wambiguous-reversed-operator compiler warnings 2022-02-21 16:36:59 +01:00
settings_tests.cpp refactor: replace boost::filesystem with std::filesystem 2022-02-03 18:35:52 +08:00
sighash_tests.cpp scripted-diff: Use getInt<T> over get_int/get_int64 2022-05-18 19:15:03 +02:00
sigopcount_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
skiplist_tests.cpp refactor tests to fix ubsan suppressions 2022-01-20 15:25:23 +01:00
sock_tests.cpp net: flag relevant Sock methods with [[nodiscard]] 2021-04-13 17:26:20 +02:00
streams_tests.cpp test: Create fresh CDataStream each time 2022-02-03 20:16:41 +01:00
sync_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
system_tests.cpp build: Fix Boost.Process test for Boost 1.78 2022-03-21 16:52:27 +00:00
timedata_tests.cpp timedata: make it possible to reset the state 2022-03-02 15:40:30 +01:00
torcontrol_tests.cpp test: remove BasicTestingSetup from torcontrol unit tests 2021-05-28 19:14:09 +08:00
transaction_tests.cpp scripted-diff: Use getInt<T> over get_int/get_int64 2022-05-18 19:15:03 +02:00
txindex_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
txpackage_tests.cpp refactor: fixup named args in txpackage tests 2022-04-07 12:50:54 +01:00
txrequest_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
txvalidation_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
txvalidationcache_tests.cpp refactor: Change * to & in MutableTransactionSignatureCreator 2022-05-04 11:49:29 +02:00
uint256_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
util_tests.cpp Merge bitcoin/bitcoin#23595: util: Add ParseHex<std::byte>() helper 2022-05-20 10:47:30 +02:00
util_threadnames_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
validation_block_tests.cpp Do not pass CChainParams& to BlockAssembler constructor 2022-05-18 18:46:07 +02:00
validation_chainstate_tests.cpp Add ChainstateManager::m_adjusted_time_callback 2022-05-20 11:57:51 -04:00
validation_chainstatemanager_tests.cpp validation: default initialize and guard chainman members 2022-04-26 18:43:37 -04:00
validation_flush_tests.cpp Add src/node/* code to node:: namespace 2022-01-06 22:14:16 -05:00
validation_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
validationinterface_tests.cpp
versionbits_tests.cpp test: Slim down versionbits_tests.cpp 2022-05-13 13:39:16 +02:00

Unit tests

The sources in this directory are unit test cases. Boost includes a unit testing framework, and since Bitcoin Core already uses Boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible).

The build system is set up to compile an executable called test_bitcoin that runs all of the unit tests. The main source file for the test library is found in util/setup_common.cpp.

Compiling/running unit tests

Unit tests will be automatically compiled if dependencies were met in ./configure and tests weren't explicitly disabled.

After configuring, they can be run with make check.

To run the unit tests manually, launch src/test/test_bitcoin. To recompile after a test file was modified, run make and then run the test again. If you modify a non-test file, use make -C src/test to recompile only what's needed to run the unit tests.

To add more unit tests, add BOOST_AUTO_TEST_CASE functions to the existing .cpp files in the test/ directory or add new .cpp files that implement new BOOST_AUTO_TEST_SUITE sections.

To run the GUI unit tests manually, launch src/qt/test/test_bitcoin-qt

To add more GUI unit tests, add them to the src/qt/test/ directory and the src/qt/test/test_main.cpp file.

Running individual tests

test_bitcoin accepts the command line arguments from the boost framework. For example, to run just the getarg_tests suite of tests:

test_bitcoin --log_level=all --run_test=getarg_tests

log_level controls the verbosity of the test framework, which logs when a test case is entered, for example. test_bitcoin also accepts the command line arguments accepted by bitcoind. Use -- to separate both types of arguments:

test_bitcoin --log_level=all --run_test=getarg_tests -- -printtoconsole=1

The -printtoconsole=1 after the two dashes redirects the debug log, which would normally go to a file in the test datadir (BasicTestingSetup::m_path_root), to the standard terminal output.

... or to run just the doubledash test:

test_bitcoin --run_test=getarg_tests/doubledash

Run test_bitcoin --help for the full list.

Adding test cases

To add a new unit test file to our test suite you need to add the file to src/Makefile.test.include. The pattern is to create one test file for each class or source file for which you want to create unit tests. The file naming convention is <source_filename>_tests.cpp and such files should wrap their tests in a test suite called <source_filename>_tests. For an example of this pattern, see uint256_tests.cpp.

Logging and debugging in unit tests

make check will write to a log file foo_tests.cpp.log and display this file on failure. For running individual tests verbosely, refer to the section above.

To write to logs from unit tests you need to use specific message methods provided by Boost. The simplest is BOOST_TEST_MESSAGE.

For debugging you can launch the test_bitcoin executable with gdb or lldb and start debugging, just like you would with any other program:

gdb src/test/test_bitcoin

Segmentation faults

If you hit a segmentation fault during a test run, you can diagnose where the fault is happening by running gdb ./src/test/test_bitcoin and then using the bt command within gdb.

Another tool that can be used to resolve segmentation faults is valgrind.

If for whatever reason you want to produce a core dump file for this fault, you can do that as well. By default, the boost test runner will intercept system errors and not produce a core file. To bypass this, add --catch_system_errors=no to the test_bitcoin arguments and ensure that your ulimits are set properly (e.g. ulimit -c unlimited).

Running the tests and hitting a segmentation fault should now produce a file called core (on Linux platforms, the file name will likely depend on the contents of /proc/sys/kernel/core_pattern).

You can then explore the core dump using

gdb src/test/test_bitcoin core

(gbd) bt  # produce a backtrace for where a segfault occurred