Andrew Chow 51eebe082d Merge bitcoin/bitcoin#25368: doc: Update importaddress mention incompatibility with descriptor wallet ... e3609cdc01 doc: Update importaddress mention incompatibility with descriptor wallet (BrokenProgrammer) Pull request description: This is related to #25363 and offers a small update to the error messages from `EnsureLegacyScriptPubKeyMan` and `EnsureConstLegacyScriptPubKeyMan` to mention that they only are compatible with legacy wallets. The RPC documentation for `importaddress` is also updated to mention this as well as guide the user to the alternative `importdescriptors` for cases when using descriptor wallets. I'm thinking that we can introduce a "porting guide" document mentioned in #25363 in a separate PR since I would have to make myself more familiar with the subject before being able to tackle that. ACKs for top commit: laanwj: Code review ACK e3609cdc01 achow101: ACK e3609cdc01 Tree-SHA512: c7a924a7283fe59dc4e04c8c8fa034c15601f0b25eff09d975e98e2e8db5268ff470336b2d978d6916af9f782f9257b840d64bd15485b1742b4a8b8bfd0bb50f		2022-06-15 13:40:32 -04:00
..
rpc	doc: Update importaddress mention incompatibility with descriptor wallet	2022-06-14 20:54:45 +02:00
test	fuzz: coinselection, add missing fee rate.	2022-05-25 14:07:33 -03:00
bdb.cpp	scripted-diff: replace non-standard fixed width integer types (u_int... -> uint`...)	2022-05-12 15:44:24 +02:00
bdb.h	scripted-diff: replace non-standard fixed width integer types (u_int... -> uint`...)	2022-05-12 15:44:24 +02:00
coincontrol.cpp	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
coincontrol.h	wallet: add input weights to CCoinControl	2022-01-24 11:23:31 -05:00
coinselection.cpp	logging: Unconditionally log levels >= WARN	2022-05-25 11:26:15 +02:00
coinselection.h	Set effective_value when initializing a COutput	2022-05-21 11:25:54 -04:00
context.cpp	refactor: use C++11 default initializers	2022-05-17 17:18:58 +01:00
context.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
crypter.cpp	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
crypter.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
db.cpp	Replace use of ArgsManager with DatabaseOptions	2022-03-16 08:26:28 +01:00
db.h	Replace use of ArgsManager with DatabaseOptions	2022-03-16 08:26:28 +01:00
dump.cpp	Replace use of ArgsManager with DatabaseOptions	2022-03-16 08:26:28 +01:00
dump.h	Replace use of ArgsManager with DatabaseOptions	2022-03-16 08:26:28 +01:00
external_signer_scriptpubkeyman.cpp	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
external_signer_scriptpubkeyman.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
feebumper.cpp	wallet: CreateTransaction(): return out-params as (optional) struct	2022-05-16 17:46:34 +02:00
feebumper.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
fees.cpp	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
fees.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
init.cpp	scripted-diff: Avoid incompatibility with CMake AUTOUIC feature	2022-06-14 10:38:51 +02:00
interfaces.cpp	Merge bitcoin/bitcoin#25148: refactor: Remove NO_THREAD_SAFETY_ANALYSIS from non-test/benchmarking code	2022-05-18 16:23:43 +02:00
ismine.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
load.cpp	wallet: Postpone NotifyWalletLoaded() for encrypted wallets	2022-03-30 21:28:53 +02:00
load.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
receive.cpp	Add more proper thread safety annotations	2022-05-16 20:51:40 +02:00
receive.h	Add more proper thread safety annotations	2022-05-16 20:51:40 +02:00
salvage.cpp	Replace use of ArgsManager with DatabaseOptions	2022-03-16 08:26:28 +01:00
salvage.h	Replace use of ArgsManager with DatabaseOptions	2022-03-16 08:26:28 +01:00
scriptpubkeyman.cpp	Merge bitcoin/bitcoin#23304: wallet: Derive inactive HD chains in additional places	2022-03-02 09:35:07 +01:00
scriptpubkeyman.h	Merge bitcoin/bitcoin#23304: wallet: Derive inactive HD chains in additional places	2022-03-02 09:35:07 +01:00
spend.cpp	Merge bitcoin/bitcoin#25003: tracing: fix coin_selection:aps_create_tx_internal calling logic	2022-05-26 13:49:52 -04:00
spend.h	Set effective_value when initializing a COutput	2022-05-21 11:25:54 -04:00
sqlite.cpp	scripted-diff: Convert global Mutexes to GlobalMutexes	2022-05-21 01:23:23 +10:00
sqlite.h	Replace use of ArgsManager with DatabaseOptions	2022-03-16 08:26:28 +01:00
transaction.cpp	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
transaction.h	wallet: add GetWitnessHash()	2022-02-01 08:44:51 -03:00
wallet.cpp	Merge bitcoin/bitcoin#24931: Strengthen thread safety assertions	2022-06-10 16:42:53 +02:00
wallet.h	Add more proper thread safety annotations	2022-05-16 20:51:40 +02:00
walletdb.cpp	refactor: use C++11 default initializers	2022-05-17 17:18:58 +01:00
walletdb.h	Merge bitcoin/bitcoin#23304: wallet: Derive inactive HD chains in additional places	2022-03-02 09:35:07 +01:00
wallettool.cpp	Replace use of ArgsManager with DatabaseOptions	2022-03-16 08:26:28 +01:00
wallettool.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
walletutil.cpp	Use ArgsManager::GetPathArg() for "-walletdir" option	2022-02-09 19:31:23 +02:00
walletutil.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00