mirror of https://github.com/bitcoin/bitcoin.git synced 2025-01-10 20:03:34 -03:00

Bitcoin Core mirror and no, I don't give a fuck about Monero.

bitcoin c-plus-plus cryptocurrency cryptography p2p

Find a file

laanwj 7da4f65a00 Merge bitcoin/bitcoin#24818 : net: improve and address issues in makeseeds.py `c457fb144c` improve clarity and up max ipv6 ASNs (Baas) Pull request description: This PR attempts to address some of the areas of improvement raised in #17020 . Concretely, my proposed change is fairly minor but addresses the following changes to [`makeseeds.py`](https://github.com/bitcoin/bitcoin/blob/master/contrib/seeds/makeseeds.py): - Increase max seeds per ASN for IPv6 to 10 as recommended [here](https://github.com/bitcoin/bitcoin/pull/16999#issuecomment-536999544), while keeping max seeds per ASN for IPv4 at 2. - Bump `MIN_BLOCKS` to 730000. - Improved script clarity: added function types and more docs to functions, added progress indicator when performing ASN lookup, and change string formatting to better align with [bitcoin python style guidelines](https://github.com/bitcoin/bitcoin/blob/master/test/functional/README.md#style-guidelines) With the different ASN limits for IPv4 and IPv6, and the new minimum block requirement, the current stats look look like: ``` IPv4 IPv6 Onion Pass 470689 73238 0 Initial 470689 73238 0 Skip entries with invalid address 470689 73238 0 After removing duplicates 470688 73238 0 Skip entries from suspicious hosts 6098 1676 0 Enforce minimal number of blocks 5252 1443 0 Require service bit 1 3812 898 0 Require minimum uptime 3738 877 0 Require a known and recent user agent 3715 869 0 Filter out hosts with multiple bitcoin ports 512 512 0 Look up ASNs and limit results per ASN and per net ``` The new ASN max seeds of 10 allows for 512 IPv6 addresses to be included, up from the ~150 that was filtered by the previous version. While there is more to do for #17020 , these changes I think are fairly isolated from the rest and should make it a bit easier for others to get up to speed with what the functions in the script do. ACKs for top commit: laanwj: Concept and code review ACK `c457fb144c` Tree-SHA512: 3ed67868443cc50544e23b27e2341758c3a8866997b0dba47b137032d5e1a13428855daaeed682626ed471542b44435635178d54848a2cd6fe73777679428032		2022-04-15 10:31:02 +02:00
.github	doc: Remove label from good first issue template	2020-08-24 09:31:24 +02:00
.tx	qt: Update transifex resource blob to 23.0	2022-02-03 13:18:28 +01:00
build-aux/m4	build: stop overriding user CXXFLAGS	2022-04-03 19:36:17 +01:00
build_msvc	build: fix MSVC build after subtree update	2022-04-07 22:24:43 +01:00
ci	ci: Make log verbose in error case only	2022-04-14 13:44:29 +02:00
contrib	Merge bitcoin/bitcoin#24818 : net: improve and address issues in makeseeds.py	2022-04-15 10:31:02 +02:00
depends	depends: Add file-based logging for individual packages	2022-04-14 13:44:28 +02:00
doc	Update RPC argument and field naming guideline in developer notes	2022-04-08 15:46:05 +02:00
share	build: Fix `make deploy` for Windows when building out of source tree	2022-02-06 13:34:49 +02:00
src	Merge bitcoin/bitcoin#22052 : net: remove non-blocking bool from interface	2022-04-14 10:16:01 +02:00
test	Merge bitcoin/bitcoin#24559 : test: add test for signet miner script	2022-04-14 19:28:04 +02:00
.cirrus.yml	Merge bitcoin/bitcoin#24753 : ci: Add clang-tidy task	2022-04-06 10:10:41 +01:00
.editorconfig	ci: Drop AppVeyor CI integration	2021-09-07 06:12:53 +03:00
.gitattributes	Separate protocol versioning from clientversion	2014-10-29 00:24:40 -04:00
.gitignore	add ci/scratch dir to gitignore	2022-03-18 14:47:17 +01:00
.python-version	Bump minimum python version to 3.6	2020-11-09 17:53:47 +10:00
.style.yapf	test: .style.yapf: Set column_limit=160	2019-03-04 18:28:13 -05:00
autogen.sh	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
configure.ac	Merge bitcoin/bitcoin#24337 : build: Do not define `PROVIDE_FUZZ_MAIN_FUNCTION` macro unconditionally	2022-04-11 14:29:07 +01:00
CONTRIBUTING.md	doc: Add `guix` prefix for changes to reproducible builds	2022-03-09 11:35:17 +01:00
COPYING	doc: Update license year range to 2022	2022-01-03 04:48:41 +08:00
INSTALL.md	doc: Added hyperlink for doc/build	2021-09-09 19:53:12 +05:30
libbitcoinconsensus.pc.in	build: remove libcrypto as internal dependency in libbitcoinconsensus.pc	2019-11-19 15:03:44 +01:00
Makefile.am	test: add test for signet miner script	2022-04-14 00:28:37 +02:00
README.md	doc: Rework internal and external links	2021-02-17 09:18:46 +01:00
REVIEWERS	doc: update maintainer list in REVIEWERS	2022-02-25 11:46:26 +00:00
SECURITY.md	doc: Suggest `keys.openpgp.org` as keyserver in SECURITY.md	2021-11-08 12:22:04 +01:00

README.md

Bitcoin Core integration/staging tree

https://bitcoincore.org

For an immediately usable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/.

Further information about Bitcoin Core is available in the doc folder.

What is Bitcoin?

Bitcoin is an experimental digital currency that enables instant payments to anyone, anywhere in the world. Bitcoin uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Bitcoin Core is the name of open source software which enables the use of this currency.

For more information read the original Bitcoin whitepaper.

License

Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.

Development Process

The master branch is regularly built (see doc/build-*.md for instructions) and tested, but it is not guaranteed to be completely stable. Tags are created regularly from release branches to indicate new official, stable release versions of Bitcoin Core.

The https://github.com/bitcoin-core/gui repository is used exclusively for the development of the GUI. Its master branch is identical in all monotree repositories. Release branches and tags do not exist, so please do not fork that repository unless it is for development reasons.

The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.

Testing

Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.

Automated Testing

Developers are strongly encouraged to write unit tests for new code, and to submit new unit tests for old code. Unit tests can be compiled and run (assuming they weren't disabled in configure) with: make check. Further details on running and extending unit tests can be found in /src/test/README.md.

There are also regression and integration tests, written in Python. These tests can be run (if the test dependencies are installed) with: test/functional/test_runner.py

The CI (Continuous Integration) systems make sure that every pull request is built for Windows, Linux, and macOS, and that unit/sanity tests are run automatically.

Manual Quality Assurance (QA) Testing

Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.

Translations

Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.

Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.

Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.