mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-01-15 06:12:37 -03:00
2efdfb88aa
Before this change the send confirmation dialog would keep the Send option disabled. The Create Unsigned choice would actually send. This is potentially confusing. With this change the Create Unsigned button will not attempt to sign and always produce a PSBT. The Send button will attempt to sign, and only return a PSBT if more signatures are needed. When using an external signer, the Create Unsigned option only appears when PSBT controls are enabled in the wallet settings. This commit maintains the pre-existing behavior of filling the PSBT (without signing) even when not using an external signer. Closes #551 Co-authored-by: Jon Atack <jon@atack.com>
149 lines
5 KiB
C++
149 lines
5 KiB
C++
// Copyright (c) 2011-2021 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#ifndef BITCOIN_QT_SENDCOINSDIALOG_H
|
|
#define BITCOIN_QT_SENDCOINSDIALOG_H
|
|
|
|
#include <qt/walletmodel.h>
|
|
|
|
#include <QDialog>
|
|
#include <QMessageBox>
|
|
#include <QString>
|
|
#include <QTimer>
|
|
|
|
class ClientModel;
|
|
class PlatformStyle;
|
|
class SendCoinsEntry;
|
|
class SendCoinsRecipient;
|
|
enum class SynchronizationState;
|
|
namespace wallet {
|
|
class CCoinControl;
|
|
} // namespace wallet
|
|
|
|
namespace Ui {
|
|
class SendCoinsDialog;
|
|
}
|
|
|
|
QT_BEGIN_NAMESPACE
|
|
class QUrl;
|
|
QT_END_NAMESPACE
|
|
|
|
/** Dialog for sending bitcoins */
|
|
class SendCoinsDialog : public QDialog
|
|
{
|
|
Q_OBJECT
|
|
|
|
public:
|
|
explicit SendCoinsDialog(const PlatformStyle *platformStyle, QWidget *parent = nullptr);
|
|
~SendCoinsDialog();
|
|
|
|
void setClientModel(ClientModel *clientModel);
|
|
void setModel(WalletModel *model);
|
|
|
|
/** Set up the tab chain manually, as Qt messes up the tab chain by default in some cases (issue https://bugreports.qt-project.org/browse/QTBUG-10907).
|
|
*/
|
|
QWidget *setupTabChain(QWidget *prev);
|
|
|
|
void setAddress(const QString &address);
|
|
void pasteEntry(const SendCoinsRecipient &rv);
|
|
bool handlePaymentRequest(const SendCoinsRecipient &recipient);
|
|
|
|
public Q_SLOTS:
|
|
void clear();
|
|
void reject() override;
|
|
void accept() override;
|
|
SendCoinsEntry *addEntry();
|
|
void updateTabsAndLabels();
|
|
void setBalance(const interfaces::WalletBalances& balances);
|
|
|
|
Q_SIGNALS:
|
|
void coinsSent(const uint256& txid);
|
|
|
|
private:
|
|
Ui::SendCoinsDialog *ui;
|
|
ClientModel *clientModel;
|
|
WalletModel *model;
|
|
std::unique_ptr<wallet::CCoinControl> m_coin_control;
|
|
std::unique_ptr<WalletModelTransaction> m_current_transaction;
|
|
bool fNewRecipientAllowed;
|
|
bool fFeeMinimized;
|
|
const PlatformStyle *platformStyle;
|
|
|
|
// Copy PSBT to clipboard and offer to save it.
|
|
void presentPSBT(PartiallySignedTransaction& psbt);
|
|
// Process WalletModel::SendCoinsReturn and generate a pair consisting
|
|
// of a message and message flags for use in Q_EMIT message().
|
|
// Additional parameter msgArg can be used via .arg(msgArg).
|
|
void processSendCoinsReturn(const WalletModel::SendCoinsReturn &sendCoinsReturn, const QString &msgArg = QString());
|
|
void minimizeFeeSection(bool fMinimize);
|
|
// Format confirmation message
|
|
bool PrepareSendText(QString& question_string, QString& informative_text, QString& detailed_text);
|
|
/* Sign PSBT using external signer.
|
|
*
|
|
* @param[in,out] psbtx the PSBT to sign
|
|
* @param[in,out] mtx needed to attempt to finalize
|
|
* @param[in,out] complete whether the PSBT is complete (a successfully signed multisig transaction may not be complete)
|
|
*
|
|
* @returns false if any failure occurred, which may include the user rejection of a transaction on the device.
|
|
*/
|
|
bool signWithExternalSigner(PartiallySignedTransaction& psbt, CMutableTransaction& mtx, bool& complete);
|
|
void updateFeeMinimizedLabel();
|
|
void updateCoinControlState();
|
|
|
|
private Q_SLOTS:
|
|
void sendButtonClicked(bool checked);
|
|
void on_buttonChooseFee_clicked();
|
|
void on_buttonMinimizeFee_clicked();
|
|
void removeEntry(SendCoinsEntry* entry);
|
|
void useAvailableBalance(SendCoinsEntry* entry);
|
|
void updateDisplayUnit();
|
|
void coinControlFeatureChanged(bool);
|
|
void coinControlButtonClicked();
|
|
void coinControlChangeChecked(int);
|
|
void coinControlChangeEdited(const QString &);
|
|
void coinControlUpdateLabels();
|
|
void coinControlClipboardQuantity();
|
|
void coinControlClipboardAmount();
|
|
void coinControlClipboardFee();
|
|
void coinControlClipboardAfterFee();
|
|
void coinControlClipboardBytes();
|
|
void coinControlClipboardLowOutput();
|
|
void coinControlClipboardChange();
|
|
void updateFeeSectionControls();
|
|
void updateNumberOfBlocks(int count, const QDateTime& blockDate, double nVerificationProgress, bool headers, SynchronizationState sync_state);
|
|
void updateSmartFeeLabel();
|
|
|
|
Q_SIGNALS:
|
|
// Fired when a message should be reported to the user
|
|
void message(const QString &title, const QString &message, unsigned int style);
|
|
};
|
|
|
|
|
|
#define SEND_CONFIRM_DELAY 3
|
|
|
|
class SendConfirmationDialog : public QMessageBox
|
|
{
|
|
Q_OBJECT
|
|
|
|
public:
|
|
SendConfirmationDialog(const QString& title, const QString& text, const QString& informative_text = "", const QString& detailed_text = "", int secDelay = SEND_CONFIRM_DELAY, bool enable_send = true, bool always_show_unsigned = true, QWidget* parent = nullptr);
|
|
/* Returns QMessageBox::Cancel, QMessageBox::Yes when "Send" is
|
|
clicked and QMessageBox::Save when "Create Unsigned" is clicked. */
|
|
int exec() override;
|
|
|
|
private Q_SLOTS:
|
|
void countDown();
|
|
void updateButtons();
|
|
|
|
private:
|
|
QAbstractButton *yesButton;
|
|
QAbstractButton *m_psbt_button;
|
|
QTimer countDownTimer;
|
|
int secDelay;
|
|
QString confirmButtonText{tr("Send")};
|
|
bool m_enable_send;
|
|
QString m_psbt_button_text{tr("Create Unsigned")};
|
|
};
|
|
|
|
#endif // BITCOIN_QT_SENDCOINSDIALOG_H
|