bitcoin/src/test
fanquake 72f97289c4
Merge bitcoin/bitcoin#24343: Add descriptor_tests covering tr(), and fix minor bugs
0683f377e1 Add tr() descriptor unit tests (Pieter Wuille)
4b2e31a7ae Bugfix: make ToPrivateString work with x-only keys (Pieter Wuille)
18ad54c3b2 Bugfix: set x-only flag when inferring pk() inside tr() (Pieter Wuille)

Pull request description:

  This fixes two bugs in the current logic for `tr()` descriptors:
  * ToPrivateString does not always work, because the provided private key may mismatch the parity of the x-only public key.
  * The descriptors inferred for `pk()` inside `tr()` have the wrong x-only flag, leading to such descriptors generating the wrong scriptPubKey (roundtripping through ToString does fix it however, so this seems unobservable in the current code).

  These were discovered while adding unit tests to descriptor_tests that cover various aspects of `tr()` descriptors, which are now also added here.

ACKs for top commit:
  achow101:
    ACK 0683f377e1
  instagibbs:
    ACK 0683f377e1
  jonatack:
    Code review ACK 0683f377e1

Tree-SHA512: fc0e11b45da53054a108effff2029d67b64e508b160a6e22e00c98b506c39ec12ccc95afd21ea68a6c691eb62930afc7af18908f2fa3a954d102afdc67bc355a
2022-02-21 10:16:42 +00:00
..
data Test that OP_1-OP_16 (but not lower/higher) start witness programs 2022-02-10 08:51:48 +00:00
fuzz fuzz: Split script formatting from script fuzz target 2022-02-15 12:19:34 +01:00
util Require CBlockIndex::GetBlockPos() to hold mutex cs_main 2022-01-25 20:43:12 +01:00
addrman_tests.cpp test: addrman unit tests: override-able check ratio 2022-01-11 12:08:42 +01:00
allocator_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
amount_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
arith_uint256_tests.cpp refactor tests to fix ubsan suppressions 2022-01-20 15:25:23 +01:00
banman_tests.cpp net: Drop only invalid entries when reading banlist.json 2021-12-14 18:58:45 +01:00
base32_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
base58_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
base64_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
bech32_tests.cpp Make Bech32 LocateErrors return error list rather than using out-arg 2021-12-06 14:17:41 +13:00
bip32_tests.cpp refactor: Take Span in SetSeed 2021-11-01 14:20:56 +01:00
blockchain_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
blockencodings_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
blockfilter_index_tests.cpp Add src/node/* code to node:: namespace 2022-01-06 22:14:16 -05:00
blockfilter_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
bloom_tests.cpp Use spans of std::byte in serialize 2022-01-02 11:40:31 +01:00
bswap_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
checkqueue_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
coins_tests.cpp test: Avoid testing negative block heights 2022-02-02 15:32:06 +01:00
coinstatsindex_tests.cpp Add src/node/* code to node:: namespace 2022-01-06 22:14:16 -05:00
compilerbug_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
compress_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
crypto_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
cuckoocache_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
dbwrapper_tests.cpp util: Work around libstdc++ create_directories issue 2022-02-17 12:30:11 +01:00
denialofservice_tests.cpp net: use Sock in CNode 2022-01-28 06:41:09 +01:00
descriptor_tests.cpp Add tr() descriptor unit tests 2022-02-15 18:34:02 -05:00
flatfile_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
fs_tests.cpp test: Add fs_tests/create_directories unit test 2022-02-17 12:30:59 +01:00
getarg_tests.cpp util: Add ArgsManager::GetPathArg() function 2022-02-09 19:31:16 +02:00
hash_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
i2p_tests.cpp scripted-diff: Replace GetDataDir() calls with gArgs.GetDataDirNet() calls 2021-05-24 10:29:58 +02:00
interfaces_tests.cpp Guard CBlockIndex::nStatus/nFile/nDataPos/nUndoPos by cs_main 2022-01-25 20:46:52 +01:00
key_io_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
key_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
logging_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
main.cpp build: use header-only Boost unit test 2022-02-13 20:59:02 +00:00
Makefile
mempool_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
merkle_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
merkleblock_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
miner_tests.cpp Extract CTxIn::MAX_SEQUENCE_NONFINAL constant 2022-01-26 15:10:44 +01:00
minisketch_tests.cpp Add src/node/* code to node:: namespace 2022-01-06 22:14:16 -05:00
multisig_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
net_peer_eviction_tests.cpp scripted-diff: Rename touched member variables 2021-12-13 13:32:08 +01:00
net_tests.cpp Merge bitcoin/bitcoin#23604: Use Sock in CNode 2022-02-04 09:24:17 +01:00
netbase_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
pmt_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
policy_fee_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
policyestimator_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
pow_tests.cpp refactor tests to fix ubsan suppressions 2022-01-20 15:25:23 +01:00
prevector_tests.cpp refactor tests to fix ubsan suppressions 2022-01-20 15:25:23 +01:00
raii_event_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
random_tests.cpp Merge #18781: Add templated GetRandDuration<> 2020-05-15 08:58:49 -04:00
README.md test: parse the command line arguments in unit tests 2022-01-11 11:53:30 +01:00
reverselock_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
rpc_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
sanity_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
scheduler_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
script_p2sh_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
script_parse_tests.cpp bitcoin-tx: Avoid treating overflow as OP_0 2021-10-11 09:17:28 +02:00
script_standard_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
script_tests.cpp refactor: replace boost::filesystem with std::filesystem 2022-02-03 18:35:52 +08:00
scriptnum10.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
scriptnum_tests.cpp refactor: replace sizeof(a)/sizeof(a[0]) by std::size (C++17) 2021-01-31 17:35:16 +01:00
serfloat_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
serialize_tests.cpp Remove broken and unused CDataStream methods 2022-02-03 20:16:50 +01:00
settings_tests.cpp refactor: replace boost::filesystem with std::filesystem 2022-02-03 18:35:52 +08:00
sighash_tests.cpp refactor tests to fix ubsan suppressions 2022-01-20 15:25:23 +01:00
sigopcount_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
skiplist_tests.cpp refactor tests to fix ubsan suppressions 2022-01-20 15:25:23 +01:00
sock_tests.cpp net: flag relevant Sock methods with [[nodiscard]] 2021-04-13 17:26:20 +02:00
streams_tests.cpp test: Create fresh CDataStream each time 2022-02-03 20:16:41 +01:00
sync_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
system_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
timedata_tests.cpp Make GetWarnings() return bilingual_str 2020-06-10 15:01:20 +03:00
torcontrol_tests.cpp test: remove BasicTestingSetup from torcontrol unit tests 2021-05-28 19:14:09 +08:00
transaction_tests.cpp refactor tests to fix ubsan suppressions 2022-01-20 15:25:23 +01:00
txindex_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
txpackage_tests.cpp [unit test] package parents are a mix 2022-01-17 13:00:19 +00:00
txrequest_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
txvalidation_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
txvalidationcache_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
uint256_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
util_tests.cpp Re-enable util_datadir check disabled in #20744 2022-02-04 09:09:09 -05:00
util_threadnames_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
validation_block_tests.cpp Add src/node/* code to node:: namespace 2022-01-06 22:14:16 -05:00
validation_chainstate_tests.cpp test: Load genesis block to allow flush 2022-01-05 16:16:21 +01:00
validation_chainstatemanager_tests.cpp Require CBlockIndex::IsAssumedValid() to hold cs_main 2022-01-25 20:43:25 +01:00
validation_flush_tests.cpp Add src/node/* code to node:: namespace 2022-01-06 22:14:16 -05:00
validation_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
validationinterface_tests.cpp test: Remove const to work around compiler error on xenial 2020-05-14 18:40:57 +02:00
versionbits_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00

Unit tests

The sources in this directory are unit test cases. Boost includes a unit testing framework, and since Bitcoin Core already uses Boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible).

The build system is set up to compile an executable called test_bitcoin that runs all of the unit tests. The main source file for the test library is found in util/setup_common.cpp.

Compiling/running unit tests

Unit tests will be automatically compiled if dependencies were met in ./configure and tests weren't explicitly disabled.

After configuring, they can be run with make check.

To run the unit tests manually, launch src/test/test_bitcoin. To recompile after a test file was modified, run make and then run the test again. If you modify a non-test file, use make -C src/test to recompile only what's needed to run the unit tests.

To add more unit tests, add BOOST_AUTO_TEST_CASE functions to the existing .cpp files in the test/ directory or add new .cpp files that implement new BOOST_AUTO_TEST_SUITE sections.

To run the GUI unit tests manually, launch src/qt/test/test_bitcoin-qt

To add more GUI unit tests, add them to the src/qt/test/ directory and the src/qt/test/test_main.cpp file.

Running individual tests

test_bitcoin accepts the command line arguments from the boost framework. For example, to run just the getarg_tests suite of tests:

test_bitcoin --log_level=all --run_test=getarg_tests

log_level controls the verbosity of the test framework, which logs when a test case is entered, for example. test_bitcoin also accepts the command line arguments accepted by bitcoind. Use -- to separate both types of arguments:

test_bitcoin --log_level=all --run_test=getarg_tests -- -printtoconsole=1

The -printtoconsole=1 after the two dashes redirects the debug log, which would normally go to a file in the test datadir (BasicTestingSetup::m_path_root), to the standard terminal output.

... or to run just the doubledash test:

test_bitcoin --run_test=getarg_tests/doubledash

Run test_bitcoin --help for the full list.

Adding test cases

To add a new unit test file to our test suite you need to add the file to src/Makefile.test.include. The pattern is to create one test file for each class or source file for which you want to create unit tests. The file naming convention is <source_filename>_tests.cpp and such files should wrap their tests in a test suite called <source_filename>_tests. For an example of this pattern, see uint256_tests.cpp.

Logging and debugging in unit tests

make check will write to a log file foo_tests.cpp.log and display this file on failure. For running individual tests verbosely, refer to the section above.

To write to logs from unit tests you need to use specific message methods provided by Boost. The simplest is BOOST_TEST_MESSAGE.

For debugging you can launch the test_bitcoin executable with gdb or lldb and start debugging, just like you would with any other program:

gdb src/test/test_bitcoin

Segmentation faults

If you hit a segmentation fault during a test run, you can diagnose where the fault is happening by running gdb ./src/test/test_bitcoin and then using the bt command within gdb.

Another tool that can be used to resolve segmentation faults is valgrind.

If for whatever reason you want to produce a core dump file for this fault, you can do that as well. By default, the boost test runner will intercept system errors and not produce a core file. To bypass this, add --catch_system_errors=no to the test_bitcoin arguments and ensure that your ulimits are set properly (e.g. ulimit -c unlimited).

Running the tests and hitting a segmentation fault should now produce a file called core (on Linux platforms, the file name will likely depend on the contents of /proc/sys/kernel/core_pattern).

You can then explore the core dump using

gdb src/test/test_bitcoin core

(gbd) bt  # produce a backtrace for where a segfault occurred