fanquake 265492723a Merge #18297: build: Use pkg-config in BITCOIN_QT_CONFIGURE for all hosts including Windows ... 8a26848c46 build: Fix m4 escaping (Hennadii Stepanov) 9123ec15db build: Remove extra tokens warning (Hennadii Stepanov) fded4f48c3 build: Remove duplicated QT_STATICPLUGIN define (Hennadii Stepanov) 05a93d5d96 build: Fix indentation in bitcoin_qt.m4 (Hennadii Stepanov) ddbb419310 build: Use pkg-config in BITCOIN_QT_CONFIGURE for all hosts (Hennadii Stepanov) 492971de35 build: Fix mingw pkgconfig file and dependency naming (Hennadii Stepanov) Pull request description: This PR makes `bitcoin_qt.m4` to use `pkg-config` for all hosts and removes non-pkg-config paths from it. This is a step towards the idea which was clear [stated](https://github.com/bitcoin/bitcoin/pull/8314#issue-76644643) by Cory Fields: > I believe the consensus is to treat Windows like the others and require pkg-config across the board. We can drop all of the non-pkg-config paths, and simply AC_REQUIRE(PKG_PROG_PKG_CONFIG) There are two unsolved problems with this PR. If depends is built with `DEBUG=1` the `configure` script fails to pickup Qt: - for macOS host (similar to, but not the same as #16391) - for Windows host (regression) The fix is ~on its way~ submitted in #18298 (as a followup). Also this PR picks some small improvements from #17820. ACKs for top commit: theuni: Code review ACK 8a26848c46 dongcarl: Code Review ACK 8a26848c46 laanwj: Code review ACK 8a26848c46 Tree-SHA512: 3b25990934b939121983df7707997b31d61063b1207d909f539d69494c7cb85212f353092956d09ecffebb9fef28b869914dd1216a596d102fcb9744bb5487f7		2020-06-13 15:41:39 +08:00
..
m4	Merge #18297: build: Use pkg-config in BITCOIN_QT_CONFIGURE for all hosts including Windows	2020-06-13 15:41:39 +08:00