mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-01-12 12:52:35 -03:00
abf5d16c24
Change getheaders messages so that we wait up to 2 minutes for a response to a prior getheaders message before issuing a new one. Also change the handling of the getheaders message sent in response to a block INV, so that we no longer use the hashstop variable (including the hash stop will just mean that if our peer's headers chain is longer, then we won't learn it, so there's no benefit to using hashstop). Also, now respond to a getheaders during IBD with an empty headers message (rather than nothing) -- this better conforms to the intent of the new logic that it's better to not ignore a peer's getheaders message, even if you have nothing to give. This also avoids a lot of functional tests breaking. p2p_segwit.py is modified to use this same strategy, as the test logic (of expecting a getheaders after a block inv) would otherwise be broken.
118 lines
5.1 KiB
Python
Executable file
118 lines
5.1 KiB
Python
Executable file
#!/usr/bin/env python3
|
|
# Copyright (c) 2017-2021 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test logic for setting nMinimumChainWork on command line.
|
|
|
|
Nodes don't consider themselves out of "initial block download" until
|
|
their active chain has more work than nMinimumChainWork.
|
|
|
|
Nodes don't download blocks from a peer unless the peer's best known block
|
|
has more work than nMinimumChainWork.
|
|
|
|
While in initial block download, nodes won't relay blocks to their peers, so
|
|
test that this parameter functions as intended by verifying that block relay
|
|
only succeeds past a given node once its nMinimumChainWork has been exceeded.
|
|
"""
|
|
|
|
import time
|
|
|
|
from test_framework.p2p import P2PInterface, msg_getheaders
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import assert_equal
|
|
|
|
# 2 hashes required per regtest block (with no difficulty adjustment)
|
|
REGTEST_WORK_PER_BLOCK = 2
|
|
|
|
class MinimumChainWorkTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = True
|
|
self.num_nodes = 3
|
|
|
|
self.extra_args = [[], ["-minimumchainwork=0x65"], ["-minimumchainwork=0x65"]]
|
|
self.node_min_work = [0, 101, 101]
|
|
|
|
def setup_network(self):
|
|
# This test relies on the chain setup being:
|
|
# node0 <- node1 <- node2
|
|
# Before leaving IBD, nodes prefer to download blocks from outbound
|
|
# peers, so ensure that we're mining on an outbound peer and testing
|
|
# block relay to inbound peers.
|
|
self.setup_nodes()
|
|
for i in range(self.num_nodes-1):
|
|
self.connect_nodes(i+1, i)
|
|
|
|
# Set clock of node2 2 days ahead, to keep it in IBD during this test.
|
|
self.nodes[2].setmocktime(int(time.time()) + 48*60*60)
|
|
|
|
def run_test(self):
|
|
# Start building a chain on node0. node2 shouldn't be able to sync until node1's
|
|
# minchainwork is exceeded
|
|
starting_chain_work = REGTEST_WORK_PER_BLOCK # Genesis block's work
|
|
self.log.info(f"Testing relay across node 1 (minChainWork = {self.node_min_work[1]})")
|
|
|
|
starting_blockcount = self.nodes[2].getblockcount()
|
|
|
|
num_blocks_to_generate = int((self.node_min_work[1] - starting_chain_work) / REGTEST_WORK_PER_BLOCK)
|
|
self.log.info(f"Generating {num_blocks_to_generate} blocks on node0")
|
|
hashes = self.generate(self.nodes[0], num_blocks_to_generate, sync_fun=self.no_op)
|
|
|
|
self.log.info(f"Node0 current chain work: {self.nodes[0].getblockheader(hashes[-1])['chainwork']}")
|
|
|
|
# Sleep a few seconds and verify that node2 didn't get any new blocks
|
|
# or headers. We sleep, rather than sync_blocks(node0, node1) because
|
|
# it's reasonable either way for node1 to get the blocks, or not get
|
|
# them (since they're below node1's minchainwork).
|
|
time.sleep(3)
|
|
|
|
self.log.info("Verifying node 2 has no more blocks than before")
|
|
self.log.info(f"Blockcounts: {[n.getblockcount() for n in self.nodes]}")
|
|
# Node2 shouldn't have any new headers yet, because node1 should not
|
|
# have relayed anything.
|
|
assert_equal(len(self.nodes[2].getchaintips()), 1)
|
|
assert_equal(self.nodes[2].getchaintips()[0]['height'], 0)
|
|
|
|
assert self.nodes[1].getbestblockhash() != self.nodes[0].getbestblockhash()
|
|
assert_equal(self.nodes[2].getblockcount(), starting_blockcount)
|
|
|
|
self.log.info("Check that getheaders requests to node2 are ignored")
|
|
peer = self.nodes[2].add_p2p_connection(P2PInterface())
|
|
msg = msg_getheaders()
|
|
msg.locator.vHave = [int(self.nodes[2].getbestblockhash(), 16)]
|
|
msg.hashstop = 0
|
|
peer.send_and_ping(msg)
|
|
time.sleep(5)
|
|
assert ("headers" not in peer.last_message or len(peer.last_message["headers"].headers) == 0)
|
|
|
|
self.log.info("Generating one more block")
|
|
self.generate(self.nodes[0], 1)
|
|
|
|
self.log.info("Verifying nodes are all synced")
|
|
|
|
# Because nodes in regtest are all manual connections (eg using
|
|
# addnode), node1 should not have disconnected node0. If not for that,
|
|
# we'd expect node1 to have disconnected node0 for serving an
|
|
# insufficient work chain, in which case we'd need to reconnect them to
|
|
# continue the test.
|
|
|
|
self.sync_all()
|
|
self.log.info(f"Blockcounts: {[n.getblockcount() for n in self.nodes]}")
|
|
|
|
self.log.info("Test that getheaders requests to node2 are not ignored")
|
|
peer.send_and_ping(msg)
|
|
assert "headers" in peer.last_message
|
|
|
|
# Verify that node2 is in fact still in IBD (otherwise this test may
|
|
# not be exercising the logic we want!)
|
|
assert_equal(self.nodes[2].getblockchaininfo()['initialblockdownload'], True)
|
|
|
|
self.log.info("Test -minimumchainwork with a non-hex value")
|
|
self.stop_node(0)
|
|
self.nodes[0].assert_start_raises_init_error(
|
|
["-minimumchainwork=test"],
|
|
expected_msg='Error: Invalid non-hex (test) minimum chain work value specified',
|
|
)
|
|
|
|
|
|
if __name__ == '__main__':
|
|
MinimumChainWorkTest().main()
|