bitcoin/src/test
glozow bdfe27c9d2
Merge bitcoin/bitcoin#26933: mempool: disallow txns under min relay fee, even in packages
bf77fc9cb4 [test] mempool full in package accept (glozow)
b51ebccc28 [validation] set PackageValidationState when mempool full (glozow)
563a2ee4f5 [policy] disallow transactions under min relay fee, even in packages (glozow)
c4554fe894 [test] package cpfp bumps parents <mempoolminfee but >=minrelaytxfee (glozow)
ac463e87df [test util] mock mempool minimum feerate (glozow)

Pull request description:

  Part of package relay, see #27463.

  Note that this still allows packages to bump transactions that are below the dynamic mempool minimum feerate, which means this still solves the "mempool is congested and my presigned 1sat/vB tx is screwed" problem for all transactions.

  On master, the package policy (only accessible through regtest-only RPC submitpackage) allows 0-fee (or otherwise below min relay feerate) transactions if they are bumped by a child. However, with default package limits, we don't yet have a DoS-resistant way of ensuring these transactions remain bumped throughout their time in the mempool. Primarily, the fee-bumping child may later be replaced by another transaction that doesn't bump the parent(s). The parent(s) could potentially stay bumped by other transactions, but not enough to ever be selected by the `BlockAssembler` (due to `blockmintxfee`).

  For example, (tested [here](https://github.com/glozow/bitcoin/commits/26933-motivation)):
  - The mempool accepts 24 below-minrelayfeerate transactions ("0-fee parents"), all bumped by a single high-fee transaction ("the fee-bumping child"). The fee-bumping child also spends a confirmed UTXO.
  - Two additional children are added to each 0-fee parent. These children each pay a feerate slightly above the minimum relay feerate (e.g. 1.9sat/vB) such that, for each 0-fee parent, the total fees of its two children divided by the total size of the children and parent is above the minimum relay feerate.
  - If a block template is built now, all transactions would be selected.
  - A transaction replaces the the fee-bumping child, spending only the confirmed UTXO and not any of the outputs from the 0-fee parents.
   - The 0-fee parents now each have 2 children. Their descendant feerates are above minrelayfeerate, which means that they remain in the mempool, even if the mempool evicts all below-minrelayfeerate packages.
   - If a block template is built now, none of the 0-fee parents or their children would be selected.
   - Even more low-feerate descendants can be added to these below-minrelayfeerate packages and they will not be evicted until they expire or the mempool reaches capacity.

  Unless we have a DoS-resistant way of ensuring package CPFP-bumped transactions are always bumped, allowing package CPFP to bump below-minrelayfeerate transactions can result in these problematic situations. See #27018 which proposes a partial solution with some limitations, and contains discussion about potential improvements to eviction strategy. While no adequate solution exists, for now, avoid these situations by requiring all transactions to meet min relay feerate.

ACKs for top commit:
  ajtowns:
    reACK bf77fc9cb4
  instagibbs:
    re-ACK bf77fc9cb4

Tree-SHA512: 28940f41493a9e280b010284316fb8caf1ed7b2090ba9a4ef8a3b2eafc5933601074b142f4f7d4e3c6c4cce99d3146f5c8e1393d9406c6f2070dd41c817985c9
2023-04-26 11:18:09 +01:00
..
data scripted-diff: Regenerate key_io data deterministically 2022-04-06 17:08:07 +02:00
fuzz Merge bitcoin/bitcoin#27464: fuzz: re-enable prioritisetransaction & analyzepsbt RPC 2023-04-21 11:53:23 +01:00
util Merge bitcoin/bitcoin#26933: mempool: disallow txns under min relay fee, even in packages 2023-04-26 11:18:09 +01:00
addrman_tests.cpp test: prevent intermittent failures 2023-04-20 19:16:36 -07:00
allocator_tests.cpp clang-tidy: Add performance-inefficient-vector-operation check 2023-03-26 20:17:55 +01:00
amount_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
argsman_tests.cpp move-only: Extract common/args and common/config.cpp from util/system 2023-04-19 10:48:30 +02:00
arith_uint256_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
banman_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
base32_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
base58_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
base64_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
bech32_tests.cpp Make Bech32 LocateErrors return error list rather than using out-arg 2021-12-06 14:17:41 +13:00
bip32_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
blockchain_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
blockencodings_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
blockfilter_index_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
blockfilter_tests.cpp Use DataStream where possible 2023-01-26 10:44:05 +01:00
blockmanager_tests.cpp Move ::nPruneTarget into BlockManager 2023-03-15 15:33:12 +01:00
bloom_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
bswap_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
checkqueue_tests.cpp move-only: Extract common/args and common/config.cpp from util/system 2023-04-19 10:48:30 +02:00
coins_tests.cpp Use PoolAllocator for CCoinsMap 2023-03-23 19:38:38 +01:00
coinstatsindex_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
compilerbug_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
compress_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
crypto_tests.cpp Merge bitcoin/bitcoin#26940: test: create random and coins utils, add amount helper, dedupe add_coin 2023-02-17 17:28:14 -05:00
cuckoocache_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
dbwrapper_tests.cpp Merge bitcoin/bitcoin#26940: test: create random and coins utils, add amount helper, dedupe add_coin 2023-02-17 17:28:14 -05:00
denialofservice_tests.cpp move-only: Extract common/args and common/config.cpp from util/system 2023-04-19 10:48:30 +02:00
descriptor_tests.cpp Merge bitcoin/bitcoin#24149: Signing support for Miniscript Descriptors 2023-02-16 10:01:33 +00:00
flatfile_tests.cpp move-only: Extract common/args and common/config.cpp from util/system 2023-04-19 10:48:30 +02:00
fs_tests.cpp refactor: Move fs.* to util/fs.* 2023-03-23 12:55:18 +01:00
getarg_tests.cpp move-only: Extract common/args and common/config.cpp from util/system 2023-04-19 10:48:30 +02:00
hash_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
headers_sync_chainwork_tests.cpp Add unit test for HeadersSyncState 2022-08-29 08:10:35 -04:00
httpserver_tests.cpp bugfix: rest: avoid segfault for invalid URI 2023-04-17 10:13:34 -03:00
i2p_tests.cpp move-only: Extract common/args and common/config.cpp from util/system 2023-04-19 10:48:30 +02:00
interfaces_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
key_io_tests.cpp test, build: Separate read_json function into its own module 2023-01-27 09:26:29 +00:00
key_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
logging_tests.cpp Use steady clock for logging timer 2023-01-31 18:48:50 +01:00
main.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
Makefile
mempool_tests.cpp refactor: add kernel/cs_main.* 2023-01-05 09:05:14 +00:00
merkle_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
merkleblock_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
miner_tests.cpp Merge bitcoin/bitcoin#23897: refactor: Move calculation logic out from CheckSequenceLocksAtTip() 2023-02-28 16:53:02 +00:00
miniscript_tests.cpp ci: use clang-16 in tidy task 2023-04-05 11:43:42 +01:00
minisketch_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
multisig_tests.cpp Merge bitcoin/bitcoin#24149: Signing support for Miniscript Descriptors 2023-02-16 10:01:33 +00:00
net_peer_eviction_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
net_tests.cpp move-only: Extract common/args and common/config.cpp from util/system 2023-04-19 10:48:30 +02:00
netbase_tests.cpp Merge bitcoin/bitcoin#25619: net: avoid overriding non-virtual ToString() in CService and use better naming 2023-02-17 13:34:40 -05:00
orphanage_tests.cpp Merge bitcoin/bitcoin#26940: test: create random and coins utils, add amount helper, dedupe add_coin 2023-02-17 17:28:14 -05:00
pmt_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
policy_fee_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
policyestimator_tests.cpp clang-tidy: Add performance-inefficient-vector-operation check 2023-03-26 20:17:55 +01:00
pool_tests.cpp Calculate memory usage correctly for unordered_maps that use PoolAllocator 2023-03-23 19:38:38 +01:00
pow_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
prevector_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
raii_event_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
random_tests.cpp move-only: Extract common/args and common/config.cpp from util/system 2023-04-19 10:48:30 +02:00
rbf_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
README.md test: parse the command line arguments in unit tests 2022-01-11 11:53:30 +01:00
rest_tests.cpp Handle query string when parsing data format 2022-03-10 12:01:53 +01:00
result_tests.cpp refactor: Replace BResult with util::Result 2022-08-03 07:33:01 -04:00
reverselock_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
rpc_tests.cpp test: add cases to JSON parsing 2023-01-18 12:24:06 +00:00
sanity_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
scheduler_tests.cpp clang-tidy: Add performance-inefficient-vector-operation check 2023-03-26 20:17:55 +01:00
script_p2sh_tests.cpp clang-tidy: Add performance-inefficient-vector-operation check 2023-03-26 20:17:55 +01:00
script_parse_tests.cpp bitcoin-tx: Avoid treating overflow as OP_0 2021-10-11 09:17:28 +02:00
script_segwit_tests.cpp Unit tests for IsWitnessProgram and IsP2WSH. 2021-10-15 06:46:25 +02:00
script_standard_tests.cpp Merge bitcoin/bitcoin#25877: refactor: Do not use CScript for tapleaf scripts until the tapleaf version is known 2023-01-19 17:51:21 -05:00
script_tests.cpp refactor: Move fs.* to util/fs.* 2023-03-23 12:55:18 +01:00
scriptnum10.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
scriptnum_tests.cpp
serfloat_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
serialize_tests.cpp refactor: Remove unused CDataStream SerializeMany constructor 2023-01-30 13:04:50 +01:00
settings_tests.cpp move-only: Extract common/args and common/config.cpp from util/system 2023-04-19 10:48:30 +02:00
sighash_tests.cpp Create InsecureRandMoneyAmount() test util helper 2023-02-09 15:03:36 -08:00
sigopcount_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
skiplist_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
sock_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
streams_tests.cpp refactor: Move fs.* to util/fs.* 2023-03-23 12:55:18 +01:00
sync_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
system_tests.cpp build: Re-enable external signer on Windows 2023-01-06 10:53:36 +00:00
timedata_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
torcontrol_tests.cpp test: remove BasicTestingSetup from torcontrol unit tests 2021-05-28 19:14:09 +08:00
transaction_tests.cpp refactor: Make move semantics explicit for callers 2023-03-21 13:04:01 +00:00
translation_tests.cpp Extend bilingual_str support for tinyformat 2023-02-28 12:04:47 -05:00
txindex_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
txpackage_tests.cpp [policy] disallow transactions under min relay fee, even in packages 2023-04-17 09:53:59 +01:00
txreconciliation_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
txrequest_tests.cpp clang-tidy: Add performance-inefficient-vector-operation check 2023-03-26 20:17:55 +01:00
txvalidation_tests.cpp scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
txvalidationcache_tests.cpp refactor: add kernel/cs_main.* 2023-01-05 09:05:14 +00:00
uint256_tests.cpp Use DataStream where possible 2023-01-26 10:44:05 +01:00
util_tests.cpp refactor: don't avoid sys/types.h on when building for Windows 2023-04-03 14:44:48 +01:00
util_threadnames_tests.cpp clang-tidy: Add performance-inefficient-vector-operation check 2023-03-26 20:17:55 +01:00
validation_block_tests.cpp clang-tidy: Add performance-inefficient-vector-operation check 2023-03-26 20:17:55 +01:00
validation_chainstate_tests.cpp De-duplicate add_coin methods to a test util helper 2023-02-09 15:03:36 -08:00
validation_chainstatemanager_tests.cpp test: Fix intermittent failure in ChainStateManager tests 2023-03-27 15:47:32 -04:00
validation_flush_tests.cpp Use PoolAllocator for CCoinsMap 2023-03-23 19:38:38 +01:00
validation_tests.cpp doc: update references to kernel/chainparams.cpp 2023-04-18 11:02:05 +01:00
validationinterface_tests.cpp move-only: Extract common/args and common/config.cpp from util/system 2023-04-19 10:48:30 +02:00
versionbits_tests.cpp Move random test util code from setup_common to random 2023-02-06 12:26:04 -08:00
xoroshiro128plusplus_tests.cpp Add xoroshiro128++ PRNG 2023-01-30 18:12:21 -05:00

Unit tests

The sources in this directory are unit test cases. Boost includes a unit testing framework, and since Bitcoin Core already uses Boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible).

The build system is set up to compile an executable called test_bitcoin that runs all of the unit tests. The main source file for the test library is found in util/setup_common.cpp.

Compiling/running unit tests

Unit tests will be automatically compiled if dependencies were met in ./configure and tests weren't explicitly disabled.

After configuring, they can be run with make check.

To run the unit tests manually, launch src/test/test_bitcoin. To recompile after a test file was modified, run make and then run the test again. If you modify a non-test file, use make -C src/test to recompile only what's needed to run the unit tests.

To add more unit tests, add BOOST_AUTO_TEST_CASE functions to the existing .cpp files in the test/ directory or add new .cpp files that implement new BOOST_AUTO_TEST_SUITE sections.

To run the GUI unit tests manually, launch src/qt/test/test_bitcoin-qt

To add more GUI unit tests, add them to the src/qt/test/ directory and the src/qt/test/test_main.cpp file.

Running individual tests

test_bitcoin accepts the command line arguments from the boost framework. For example, to run just the getarg_tests suite of tests:

test_bitcoin --log_level=all --run_test=getarg_tests

log_level controls the verbosity of the test framework, which logs when a test case is entered, for example. test_bitcoin also accepts the command line arguments accepted by bitcoind. Use -- to separate both types of arguments:

test_bitcoin --log_level=all --run_test=getarg_tests -- -printtoconsole=1

The -printtoconsole=1 after the two dashes redirects the debug log, which would normally go to a file in the test datadir (BasicTestingSetup::m_path_root), to the standard terminal output.

... or to run just the doubledash test:

test_bitcoin --run_test=getarg_tests/doubledash

Run test_bitcoin --help for the full list.

Adding test cases

To add a new unit test file to our test suite you need to add the file to src/Makefile.test.include. The pattern is to create one test file for each class or source file for which you want to create unit tests. The file naming convention is <source_filename>_tests.cpp and such files should wrap their tests in a test suite called <source_filename>_tests. For an example of this pattern, see uint256_tests.cpp.

Logging and debugging in unit tests

make check will write to a log file foo_tests.cpp.log and display this file on failure. For running individual tests verbosely, refer to the section above.

To write to logs from unit tests you need to use specific message methods provided by Boost. The simplest is BOOST_TEST_MESSAGE.

For debugging you can launch the test_bitcoin executable with gdb or lldb and start debugging, just like you would with any other program:

gdb src/test/test_bitcoin

Segmentation faults

If you hit a segmentation fault during a test run, you can diagnose where the fault is happening by running gdb ./src/test/test_bitcoin and then using the bt command within gdb.

Another tool that can be used to resolve segmentation faults is valgrind.

If for whatever reason you want to produce a core dump file for this fault, you can do that as well. By default, the boost test runner will intercept system errors and not produce a core file. To bypass this, add --catch_system_errors=no to the test_bitcoin arguments and ensure that your ulimits are set properly (e.g. ulimit -c unlimited).

Running the tests and hitting a segmentation fault should now produce a file called core (on Linux platforms, the file name will likely depend on the contents of /proc/sys/kernel/core_pattern).

You can then explore the core dump using

gdb src/test/test_bitcoin core

(gbd) bt  # produce a backtrace for where a segfault occurred