mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-04-29 14:59:39 -04:00
Some checks are pending
CI / test each commit (push) Waiting to run
CI / macOS 14 native, arm64, no depends, sqlite only, gui (push) Waiting to run
CI / macOS 14 native, arm64, fuzz (push) Waiting to run
CI / Windows native, VS 2022 (push) Waiting to run
CI / Windows native, fuzz, VS 2022 (push) Waiting to run
CI / Linux->Windows cross, no tests (push) Waiting to run
CI / Windows, test cross-built (push) Blocked by required conditions
CI / ASan + LSan + UBSan + integer, no depends, USDT (push) Waiting to run
05117e6e17
rpc: clarify longpoll behavior (Sjors Provoost)5315278e7c
Have createNewBlock() wait for a tip (Sjors Provoost)64a2795fd4
rpc: handle shutdown during long poll and wait methods (Sjors Provoost)a3bf43343f
rpc: drop unneeded IsRPCRunning() guards (Sjors Provoost)f9cf8bd0ab
Handle negative timeout for waitTipChanged() (Sjors Provoost) Pull request description: This PR prevents Mining interface methods from sometimes crashing when called during startup before a tip is connected. It also makes other improvements like making more RPC methods usable from the GUI. Specifically this PR: - Adds an `Assume` check to disallow passing negative timeout values to `Mining::waitTipChanged` - Makes `waitfornewblock`, `waitforblock` and `waitforblockheight` RPC methods usable from the GUI when `-server=1` is not set. - Changes `Mining::waitTipChanged` to return `optional<BlockRef>` instead of `BlockRef` and return `nullopt` instead of crashing if there is a timeout or if the node is shut down before a tip is connected. - Changes `Mining::waitTipChanged` to not time out before a tip is connected, so it is convenient and safe to call during startup, and only returns `nullopt` on early shutdowns. - Changes `Mining::createNewBlock` to block and wait for a tip to be connected if it is called on startup instead of crashing. Also documents that it will return null on early shutdowns. This allows `waitNext()` (added in https://github.com/bitcoin/bitcoin/pull/31283) to safely assume `TipBlock()` isn't `null`, not even during a scenario of early shutdown. Finally this PR clarifies long poll behaviour, mostly by adding code comments, but also through an early `break`. ACKs for top commit: achow101: ACK05117e6e17
ryanofsky: Code review ACK05117e6e17
, just updated a commit message since last review TheCharlatan: ACK05117e6e17
vasild: ACK05117e6e17
Tree-SHA512: 277c285a6e73dfff88fd379298190b264254996f98b93c91c062986ab35c2aa5e1fbfec4cd71d7b29dc2d68e33f252b5cfc501345f54939d6bd78599b71fec04
127 lines
4.5 KiB
C++
127 lines
4.5 KiB
C++
// Copyright (c) 2024 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#ifndef BITCOIN_INTERFACES_MINING_H
|
|
#define BITCOIN_INTERFACES_MINING_H
|
|
|
|
#include <consensus/amount.h> // for CAmount
|
|
#include <interfaces/types.h> // for BlockRef
|
|
#include <node/types.h> // for BlockCreateOptions, BlockWaitOptions
|
|
#include <primitives/block.h> // for CBlock, CBlockHeader
|
|
#include <primitives/transaction.h> // for CTransactionRef
|
|
#include <stdint.h> // for int64_t
|
|
#include <uint256.h> // for uint256
|
|
#include <util/time.h> // for MillisecondsDouble
|
|
|
|
#include <memory> // for unique_ptr, shared_ptr
|
|
#include <optional> // for optional
|
|
#include <vector> // for vector
|
|
|
|
namespace node {
|
|
struct NodeContext;
|
|
} // namespace node
|
|
|
|
class BlockValidationState;
|
|
class CScript;
|
|
|
|
namespace interfaces {
|
|
|
|
//! Block template interface
|
|
class BlockTemplate
|
|
{
|
|
public:
|
|
virtual ~BlockTemplate() = default;
|
|
|
|
virtual CBlockHeader getBlockHeader() = 0;
|
|
// Block contains a dummy coinbase transaction that should not be used.
|
|
virtual CBlock getBlock() = 0;
|
|
|
|
// Fees per transaction, not including coinbase transaction.
|
|
virtual std::vector<CAmount> getTxFees() = 0;
|
|
// Sigop cost per transaction, not including coinbase transaction.
|
|
virtual std::vector<int64_t> getTxSigops() = 0;
|
|
|
|
virtual CTransactionRef getCoinbaseTx() = 0;
|
|
virtual std::vector<unsigned char> getCoinbaseCommitment() = 0;
|
|
virtual int getWitnessCommitmentIndex() = 0;
|
|
|
|
/**
|
|
* Compute merkle path to the coinbase transaction
|
|
*
|
|
* @return merkle path ordered from the deepest
|
|
*/
|
|
virtual std::vector<uint256> getCoinbaseMerklePath() = 0;
|
|
|
|
/**
|
|
* Construct and broadcast the block.
|
|
*
|
|
* @returns if the block was processed, independent of block validity
|
|
*/
|
|
virtual bool submitSolution(uint32_t version, uint32_t timestamp, uint32_t nonce, CTransactionRef coinbase) = 0;
|
|
|
|
/**
|
|
* Waits for fees in the next block to rise, a new tip or the timeout.
|
|
*
|
|
* @param[in] options Control the timeout (default forever) and by how much total fees
|
|
* for the next block should rise (default infinite).
|
|
*
|
|
* @returns a new BlockTemplate or nothing if the timeout occurs.
|
|
*
|
|
* On testnet this will additionally return a template with difficulty 1 if
|
|
* the tip is more than 20 minutes old.
|
|
*/
|
|
virtual std::unique_ptr<BlockTemplate> waitNext(const node::BlockWaitOptions options = {}) = 0;
|
|
};
|
|
|
|
//! Interface giving clients (RPC, Stratum v2 Template Provider in the future)
|
|
//! ability to create block templates.
|
|
class Mining
|
|
{
|
|
public:
|
|
virtual ~Mining() = default;
|
|
|
|
//! If this chain is exclusively used for testing
|
|
virtual bool isTestChain() = 0;
|
|
|
|
//! Returns whether IBD is still in progress.
|
|
virtual bool isInitialBlockDownload() = 0;
|
|
|
|
//! Returns the hash and height for the tip of this chain
|
|
virtual std::optional<BlockRef> getTip() = 0;
|
|
|
|
/**
|
|
* Waits for the connected tip to change. During node initialization, this will
|
|
* wait until the tip is connected (regardless of `timeout`).
|
|
*
|
|
* @param[in] current_tip block hash of the current chain tip. Function waits
|
|
* for the chain tip to differ from this.
|
|
* @param[in] timeout how long to wait for a new tip (default is forever)
|
|
*
|
|
* @retval BlockRef hash and height of the current chain tip after this call.
|
|
* @retval std::nullopt if the node is shut down.
|
|
*/
|
|
virtual std::optional<BlockRef> waitTipChanged(uint256 current_tip, MillisecondsDouble timeout = MillisecondsDouble::max()) = 0;
|
|
|
|
/**
|
|
* Construct a new block template.
|
|
*
|
|
* During node initialization, this will wait until the tip is connected.
|
|
*
|
|
* @param[in] options options for creating the block
|
|
* @retval BlockTemplate a block template.
|
|
* @retval std::nullptr if the node is shut down.
|
|
*/
|
|
virtual std::unique_ptr<BlockTemplate> createNewBlock(const node::BlockCreateOptions& options = {}) = 0;
|
|
|
|
//! Get internal node context. Useful for RPC and testing,
|
|
//! but not accessible across processes.
|
|
virtual node::NodeContext* context() { return nullptr; }
|
|
};
|
|
|
|
//! Return implementation of Mining interface.
|
|
std::unique_ptr<Mining> MakeMining(node::NodeContext& node);
|
|
|
|
} // namespace interfaces
|
|
|
|
#endif // BITCOIN_INTERFACES_MINING_H
|