bitcoin/src/test
Ava Chow 9b9752217f
Merge bitcoin/bitcoin#31570: test: descriptor: fix test for MaxSatisfactionWeight
b29d68f942 test: descriptor: fix test for `MaxSatisfactionWeight` (brunoerg)

Pull request description:

  To get the maximum size of a satisfaction for a descriptor with no max sig, the parameter `use_max_sig` should be false.

ACKs for top commit:
  fjahr:
    utACK b29d68f942
  achow101:
    ACK b29d68f942
  tdb3:
    re ACK b29d68f942
  furszy:
    utACK b29d68f942

Tree-SHA512: 8559718d126e60ce21a34183f74d227546108b43e3897e49622d6677ed9e7707caa962fd811d8787bd4dafc48a0e779ef11050d5990293faa2f91ded4aaa4f4b
2024-12-30 15:04:51 -05:00
..
data refactor: Rename CTransaction::nVersion to version 2024-06-07 13:55:23 -04:00
fuzz fuzz: Fix misplaced SeedRand::ZEROS 2024-12-18 12:10:58 +01:00
util Merge bitcoin/bitcoin#31540: refactor: std::span compat fixes 2024-12-30 14:05:55 -05:00
addrman_tests.cpp test: addrman: tried 3 times and never a success so isTerrible=true 2024-11-19 17:37:24 -03:00
allocator_tests.cpp refactor: Move system from util to common library 2023-05-20 12:08:13 +02:00
amount_tests.cpp test: Add tests for CFeeRate multiplication operator 2023-12-11 16:27:58 -05:00
argsman_tests.cpp testnet: Introduce Testnet4 2024-08-06 01:38:10 +02:00
arith_uint256_tests.cpp test: move uint256_tests/operator_with_self to arith_uint256_tests 2024-09-06 17:36:28 +02:00
banman_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
base32_tests.cpp refactor: Remove Span operator==, Use std::ranges::equal 2024-08-13 07:44:31 +02:00
base58_tests.cpp refactor: Hand-replace some ParseHex -> ""_hex 2024-08-28 19:11:59 +02:00
base64_tests.cpp refactor: Remove Span operator==, Use std::ranges::equal 2024-08-13 07:44:31 +02:00
bech32_tests.cpp
bip32_tests.cpp tidy: modernize-use-emplace 2023-10-12 11:27:19 +02:00
bip324_tests.cpp Merge bitcoin/bitcoin#30571: test: [refactor] Use m_rng directly 2024-08-28 16:56:32 +01:00
blockchain_tests.cpp scripted-diff: Modernize naming of nChainTx and nTxCount 2024-08-04 14:24:43 +02:00
blockencodings_tests.cpp Apply mempool changeset transactions directly into the mempool 2024-11-13 13:26:56 -05:00
blockfilter_index_tests.cpp test: drop scriptPubKeyIn arg from CreateNewBlock 2024-12-04 12:46:33 +07:00
blockfilter_tests.cpp refactor: Replace ParseHashStr with FromHex 2024-07-24 17:40:18 +02:00
blockmanager_tests.cpp refactor: Split up NodeContext shutdown_signal and shutdown_request 2024-10-01 09:10:54 +02:00
bloom_tests.cpp scripted-diff: Replace ParseHex[<std::byte>]("str") -> "str"_hex[_u8] 2024-08-28 19:11:59 +02:00
bswap_tests.cpp serialization: detect byteswap builtins without autoconf tests 2024-02-28 13:42:38 +00:00
checkqueue_tests.cpp [checkqueue] support user-defined return type through std::optional 2024-12-02 16:25:13 -05:00
cluster_linearize_tests.cpp clusterlin: remove Cluster type 2024-10-07 13:49:36 -04:00
CMakeLists.txt cmake: Link bitcoin_consensus as a library 2024-12-15 15:37:14 +00:00
coins_tests.cpp test, refactor: Compact ccoins_access and ccoins_spend 2024-12-02 14:49:45 +01:00
coinscachepair_tests.cpp coins, refactor: Remove direct GetFlags access 2024-12-02 13:52:34 +01:00
coinstatsindex_tests.cpp refactor: Split up NodeContext shutdown_signal and shutdown_request 2024-10-01 09:10:54 +02:00
common_url_tests.cpp test: Add two more urlDecode tests 2024-04-26 08:33:56 +02:00
compilerbug_tests.cpp
compress_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
crypto_tests.cpp scripted-diff: Replace ParseHex[<std::byte>]("str") -> "str"_hex[_u8] 2024-08-28 19:11:59 +02:00
cuckoocache_tests.cpp refactor: Fix remaining clang-tidy performance-inefficient-vector errors 2024-11-25 20:09:44 +01:00
dbwrapper_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
denialofservice_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
descriptor_tests.cpp test: descriptor: fix test for MaxSatisfactionWeight 2024-12-27 17:55:58 -03:00
disconnected_transactions.cpp [test] DisconnectedBlockTransactions::DynamicMemoryUsage 2023-10-19 16:14:36 +01:00
feefrac_tests.cpp clusterlin: add DepGraph::RemoveTransactions and support for holes in DepGraph 2024-10-07 13:49:35 -04:00
flatfile_tests.cpp serialize: Drop useless version param from GetSerializeSize() 2023-11-16 11:14:13 +10:00
fs_tests.cpp Merge bitcoin/bitcoin#29040: refactor: Remove pre-C++20 code, fs::path cleanup 2023-12-14 16:46:54 -05:00
getarg_tests.cpp util: Move util/string.h functions to util namespace 2024-05-16 10:16:08 -05:00
hash_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
headers_sync_chainwork_tests.cpp tidy: modernize-use-emplace 2023-10-12 11:27:19 +02:00
httpserver_tests.cpp bugfix: rest: avoid segfault for invalid URI 2023-04-17 10:13:34 -03:00
i2p_tests.cpp test: [refactor] Pass TestOpts 2024-07-08 16:11:15 +02:00
interfaces_tests.cpp Rename script/standard.{cpp/h} to script/solver.{cpp/h} 2023-08-14 17:39:49 -04:00
ipc_test.capnp multiprocess: Add serialization code for BlockValidationState 2024-09-23 16:03:04 -04:00
ipc_test.cpp Update libmultiprocess library 2024-10-16 12:13:27 -04:00
ipc_test.h multiprocess: Add serialization code for BlockValidationState 2024-09-23 16:03:04 -04:00
ipc_test_types.h multiprocess: Add serialization code for BlockValidationState 2024-09-23 16:03:04 -04:00
ipc_tests.cpp multiprocess: Add unit tests for connect, serve, and listen functions 2024-09-06 09:08:10 -04:00
key_io_tests.cpp refactor: Remove Span operator==, Use std::ranges::equal 2024-08-13 07:44:31 +02:00
key_tests.cpp refactor: Hand-replace some ParseHex -> ""_hex 2024-08-28 19:11:59 +02:00
logging_tests.cpp log: Enforce trailing newline, Remove redundant m_started_new_line 2024-10-01 11:31:39 +02:00
main.cpp test: test_bitcoin: allow -testdatadir=<datadir> 2024-03-07 10:11:45 -07:00
mempool_tests.cpp Apply mempool changeset transactions directly into the mempool 2024-11-13 13:26:56 -05:00
merkle_tests.cpp Rename merkle branch to path 2024-12-17 10:12:31 +07:00
merkleblock_tests.cpp refactor: remove TxidFromString 2024-07-31 16:47:39 +01:00
miner_tests.cpp test: drop scriptPubKeyIn arg from CreateNewBlock 2024-12-04 12:46:33 +07:00
miniminer_tests.cpp Apply mempool changeset transactions directly into the mempool 2024-11-13 13:26:56 -05:00
miniscript_tests.cpp refactor: Drop deprecated space in operator""_mst 2024-11-11 12:14:08 +01:00
minisketch_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
multisig_tests.cpp refactor: move SignSignature helpers to test utils 2024-09-04 21:06:09 +02:00
net_peer_connection_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
net_peer_eviction_tests.cpp random: drop ad-hoc Shuffle in favor of std::shuffle 2024-07-06 09:06:36 -04:00
net_tests.cpp scripted-diff: get rid of remaining "command" terminology in protocol.{h,cpp} 2024-10-26 23:44:15 +02:00
netbase_tests.cpp Accept "in" and "out" flags to -whitelist to allow whitelisting manual connections 2024-02-28 10:05:56 -03:00
node_warnings_tests.cpp introduce and use the generalized node::Warnings interface 2024-06-13 11:20:48 +01:00
orphanage_tests.cpp test: add check that large txs aren't put into orphanage 2024-09-03 22:23:48 +02:00
peerman_tests.cpp test: drop scriptPubKeyIn arg from CreateNewBlock 2024-12-04 12:46:33 +07:00
pmt_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
policy_fee_tests.cpp [net processing] FeeFilterRounder doesn't own a FastRandomContext 2023-10-04 13:16:52 +01:00
policyestimator_tests.cpp Apply mempool changeset transactions directly into the mempool 2024-11-13 13:26:56 -05:00
pool_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
pow_tests.cpp refactor: Enforce lowercase hex digits for consteval uint256 2024-08-28 19:09:51 +02:00
prevector_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
raii_event_tests.cpp test: Drop no longer needed workarounds 2024-09-08 09:05:39 +01:00
random_tests.cpp random: drop ad-hoc Shuffle in favor of std::shuffle 2024-07-06 09:06:36 -04:00
rbf_tests.cpp Move CalculateChunksForRBF() to the mempool changeset 2024-11-13 13:27:01 -05:00
README.md Unit test runner documentation fix and improvements 2024-09-13 08:54:51 -06:00
rest_tests.cpp
result_tests.cpp Merge bitcoin/bitcoin#31306: ci: Update Clang in "tidy" job 2024-12-08 16:30:38 +00:00
reverselock_tests.cpp
rpc_tests.cpp refactor: Fix remaining clang-tidy performance-inefficient-vector errors 2024-11-25 20:09:44 +01:00
sanity_tests.cpp Revert "time: add runtime sanity check" 2024-03-18 16:01:08 +01:00
scheduler_tests.cpp scripted-diff: Rename SingleThreadedSchedulerClient to SerialTaskRunner 2024-02-15 14:43:14 +01:00
script_p2sh_tests.cpp [checkqueue] support user-defined return type through std::optional 2024-12-02 16:25:13 -05:00
script_parse_tests.cpp
script_segwit_tests.cpp
script_standard_tests.cpp scripted-diff: Replace ParseHex[<std::byte>]("str") -> "str"_hex[_u8] 2024-08-28 19:11:59 +02:00
script_tests.cpp refactor: Specify const in std::span constructor, where needed 2024-12-19 14:41:23 +01:00
scriptnum10.h
scriptnum_tests.cpp
serfloat_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
serialize_tests.cpp refactor: Specify const in std::span constructor, where needed 2024-12-19 14:41:23 +01:00
settings_tests.cpp util: Move util/string.h functions to util namespace 2024-05-16 10:16:08 -05:00
sighash_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
sigopcount_tests.cpp refactor: Rename CTransaction::nVersion to version 2024-06-07 13:55:23 -04:00
skiplist_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
sock_tests.cpp test: improve sock_tests/move_assignment 2023-08-28 14:32:17 +02:00
span_tests.cpp Fix CI-detected codespell warnings 2024-02-23 23:01:07 +01:00
streams_tests.cpp streams: cache file position within AutoFile 2024-09-13 07:35:41 -04:00
sync_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
system_tests.cpp scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h 2024-10-10 12:22:12 +02:00
timeoffsets_tests.cpp refactor: remove warnings globals 2024-06-13 11:20:49 +01:00
torcontrol_tests.cpp
transaction_tests.cpp [checkqueue] support user-defined return type through std::optional 2024-12-02 16:25:13 -05:00
translation_tests.cpp Extend bilingual_str support for tinyformat 2023-02-28 12:04:47 -05:00
txdownload_tests.cpp Merge bitcoin/bitcoin#31269: validation: Remove RECENT_CONSENSUS_CHANGE validation result 2024-11-14 09:43:47 +00:00
txindex_tests.cpp refactor: Split up NodeContext shutdown_signal and shutdown_request 2024-10-01 09:10:54 +02:00
txpackage_tests.cpp Merge bitcoin/bitcoin#31096: Package validation: accept packages of size 1 2024-12-03 17:46:23 -05:00
txreconciliation_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
txrequest_tests.cpp refactor: Avoid std::string format strings 2024-11-14 12:44:13 +01:00
txvalidation_tests.cpp Merge bitcoin/bitcoin#31279: policy: ephemeral dust followups 2024-11-25 13:47:44 -05:00
txvalidationcache_tests.cpp Merge bitcoin/bitcoin#30407: test: [refactor] Pass TestOpts 2024-07-15 17:21:55 +01:00
uint256_tests.cpp Merge bitcoin/bitcoin#30618: test: support std::optional in BOOST_CHECK_* and increase FromUserHex fuzz feature coverage 2024-09-12 12:36:37 -04:00
util_string_tests.cpp test: Add missing %c character test 2024-12-06 21:56:17 +01:00
util_tests.cpp util: Implement ParseISO8601DateTime based on C++20 2024-12-02 08:21:32 +01:00
util_threadnames_tests.cpp Merge bitcoin/bitcoin#29015: kernel: Streamline util library 2024-06-12 17:12:54 -04:00
util_trace_tests.cpp tracing: only prepare tracepoint args if attached 2024-10-28 14:27:47 +01:00
validation_block_tests.cpp test: drop scriptPubKeyIn arg from CreateNewBlock 2024-12-04 12:46:33 +07:00
validation_chainstate_tests.cpp Ensure m_tip_block is never ZERO 2024-12-17 10:19:00 +07:00
validation_chainstatemanager_tests.cpp refactor: Split up NodeContext shutdown_signal and shutdown_request 2024-10-01 09:10:54 +02:00
validation_flush_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
validation_tests.cpp scripted-diff: Replace uint256S("str") -> uint256{"str"} 2024-08-05 14:51:48 +02:00
validationinterface_tests.cpp scripted-diff: Rename MainSignals to ValidationSignals 2024-02-15 14:45:51 +01:00
versionbits_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00

Unit tests

The sources in this directory are unit test cases. Boost includes a unit testing framework, and since Bitcoin Core already uses Boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible).

The build system is set up to compile an executable called test_bitcoin that runs all of the unit tests. The main source file for the test library is found in util/setup_common.cpp.

The examples in this document assume the build directory is named build. You'll need to adapt them if you named it differently.

Compiling/running unit tests

Unit tests will be automatically compiled if dependencies were met during the generation of the Bitcoin Core build system and tests weren't explicitly disabled.

The unit tests can be run with ctest --test-dir build, which includes unit tests from subtrees.

Run test_bitcoin --list_content for the full list of tests.

To run the unit tests manually, launch build/src/test/test_bitcoin. To recompile after a test file was modified, run cmake --build build and then run the test again. If you modify a non-test file, use cmake --build build --target test_bitcoin to recompile only what's needed to run the unit tests.

To add more unit tests, add BOOST_AUTO_TEST_CASE functions to the existing .cpp files in the test/ directory or add new .cpp files that implement new BOOST_AUTO_TEST_SUITE sections.

To run the GUI unit tests manually, launch build/src/qt/test/test_bitcoin-qt

To add more GUI unit tests, add them to the src/qt/test/ directory and the src/qt/test/test_main.cpp file.

Running individual tests

The test_bitcoin runner accepts command line arguments from the Boost framework. To see the list of arguments that may be passed, run:

test_bitcoin --help

For example, to run only the tests in the getarg_tests file, with full logging:

build/src/test/test_bitcoin --log_level=all --run_test=getarg_tests

or

build/src/test/test_bitcoin -l all -t getarg_tests

or to run only the doubledash test in getarg_tests

build/src/test/test_bitcoin --run_test=getarg_tests/doubledash

The --log_level= (or -l) argument controls the verbosity of the test output.

The test_bitcoin runner also accepts some of the command line arguments accepted by bitcoind. Use -- to separate these sets of arguments:

build/src/test/test_bitcoin --log_level=all --run_test=getarg_tests -- -printtoconsole=1

The -printtoconsole=1 after the two dashes sends debug logging, which normally goes only to debug.log within the data directory, to the standard terminal output as well.

Running test_bitcoin creates a temporary working (data) directory with a randomly generated pathname within test_common bitcoin/, which in turn is within the system's temporary directory (see temp_directory_path). This data directory looks like a simplified form of the standard bitcoind data directory. Its content will vary depending on the test, but it will always have a debug.log file, for example.

The location of the temporary data directory can be specified with the -testdatadir option. This can make debugging easier. The directory path used is the argument path appended with /test_common bitcoin/<test-name>/datadir. The directory path is created if necessary. Specifying this argument also causes the data directory not to be removed after the last test. This is useful for looking at what the test wrote to debug.log after it completes, for example. (The directory is removed at the start of the next test run, so no leftover state is used.)

$ build/src/test/test_bitcoin --run_test=getarg_tests/doubledash -- -testdatadir=/somewhere/mydatadir
Test directory (will not be deleted): "/somewhere/mydatadir/test_common bitcoin/getarg_tests/doubledash/datadir"
Running 1 test case...

*** No errors detected
$ ls -l '/somewhere/mydatadir/test_common bitcoin/getarg_tests/doubledash/datadir'
total 8
drwxrwxr-x 2 admin admin 4096 Nov 27 22:45 blocks
-rw-rw-r-- 1 admin admin 1003 Nov 27 22:45 debug.log

If you run an entire test suite, such as --run_test=getarg_tests, or all the test suites (by not specifying --run_test), a separate directory will be created for each individual test.

Adding test cases

To add a new unit test file to our test suite, you need to add the file to either src/test/CMakeLists.txt or src/wallet/test/CMakeLists.txt for wallet-related tests. The pattern is to create one test file for each class or source file for which you want to create unit tests. The file naming convention is <source_filename>_tests.cpp and such files should wrap their tests in a test suite called <source_filename>_tests. For an example of this pattern, see uint256_tests.cpp.

Logging and debugging in unit tests

ctest --test-dir build will write to the log file build/Testing/Temporary/LastTest.log. You can additionally use the --output-on-failure option to display logs of the failed tests automatically on failure. For running individual tests verbosely, refer to the section above.

To write to logs from unit tests you need to use specific message methods provided by Boost. The simplest is BOOST_TEST_MESSAGE.

For debugging you can launch the test_bitcoin executable with gdb or lldb and start debugging, just like you would with any other program:

gdb build/src/test/test_bitcoin

Segmentation faults

If you hit a segmentation fault during a test run, you can diagnose where the fault is happening by running gdb ./build/src/test/test_bitcoin and then using the bt command within gdb.

Another tool that can be used to resolve segmentation faults is valgrind.

If for whatever reason you want to produce a core dump file for this fault, you can do that as well. By default, the boost test runner will intercept system errors and not produce a core file. To bypass this, add --catch_system_errors=no to the test_bitcoin arguments and ensure that your ulimits are set properly (e.g. ulimit -c unlimited).

Running the tests and hitting a segmentation fault should now produce a file called core (on Linux platforms, the file name will likely depend on the contents of /proc/sys/kernel/core_pattern).

You can then explore the core dump using

gdb build/src/test/test_bitcoin core

(gdb) bt  # produce a backtrace for where a segfault occurred