mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-01-10 20:03:34 -03:00
c340503b67
The test framework's p2p implementation currently sends out it's VERSION message immediately after an inbound connection (i.e. TestNode outbound connection) is made. This doesn't follow the usual protocol flow where the initiator sends a version first, and the responders processes that and only then responds with its own version message. Change that accordingly by only sending immediate VERSION message for outbound connections (or after v2 handshake for v2 connections, respectively), and sending out VERSION messages as response for incoming VERSION messages (i.e. in the function `on_version`) for inbound connections. Note that some of the overruled `on_version` methods in functional tests needed to be changed to send the version explicitly.
235 lines
11 KiB
Python
Executable file
235 lines
11 KiB
Python
Executable file
#!/usr/bin/env python3
|
|
# Copyright (c) 2022 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test SENDTXRCNCL message
|
|
"""
|
|
|
|
from test_framework.messages import (
|
|
msg_sendtxrcncl,
|
|
msg_verack,
|
|
msg_version,
|
|
msg_wtxidrelay,
|
|
NODE_BLOOM,
|
|
)
|
|
from test_framework.p2p import (
|
|
P2PInterface,
|
|
P2P_SERVICES,
|
|
P2P_SUBVERSION,
|
|
P2P_VERSION,
|
|
)
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import assert_equal
|
|
|
|
class PeerNoVerack(P2PInterface):
|
|
def __init__(self, wtxidrelay=True):
|
|
super().__init__(wtxidrelay=wtxidrelay)
|
|
|
|
def on_version(self, message):
|
|
# Avoid sending verack in response to version.
|
|
# When calling add_p2p_connection, wait_for_verack=False must be set (see
|
|
# comment in add_p2p_connection).
|
|
self.send_version()
|
|
if message.nVersion >= 70016 and self.wtxidrelay:
|
|
self.send_message(msg_wtxidrelay())
|
|
|
|
class SendTxrcnclReceiver(P2PInterface):
|
|
def __init__(self):
|
|
super().__init__()
|
|
self.sendtxrcncl_msg_received = None
|
|
|
|
def on_sendtxrcncl(self, message):
|
|
self.sendtxrcncl_msg_received = message
|
|
|
|
|
|
class P2PFeelerReceiver(SendTxrcnclReceiver):
|
|
def on_version(self, message):
|
|
# feeler connections can not send any message other than their own version
|
|
self.send_version()
|
|
|
|
|
|
class PeerTrackMsgOrder(P2PInterface):
|
|
def __init__(self):
|
|
super().__init__()
|
|
self.messages = []
|
|
|
|
def on_message(self, message):
|
|
super().on_message(message)
|
|
self.messages.append(message)
|
|
|
|
def create_sendtxrcncl_msg():
|
|
sendtxrcncl_msg = msg_sendtxrcncl()
|
|
sendtxrcncl_msg.version = 1
|
|
sendtxrcncl_msg.salt = 2
|
|
return sendtxrcncl_msg
|
|
|
|
class SendTxRcnclTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 1
|
|
self.extra_args = [['-txreconciliation']]
|
|
|
|
def run_test(self):
|
|
# Check everything concerning *sending* SENDTXRCNCL
|
|
# First, *sending* to *inbound*.
|
|
self.log.info('SENDTXRCNCL sent to an inbound')
|
|
peer = self.nodes[0].add_p2p_connection(SendTxrcnclReceiver(), send_version=True, wait_for_verack=True)
|
|
assert peer.sendtxrcncl_msg_received
|
|
assert_equal(peer.sendtxrcncl_msg_received.version, 1)
|
|
self.nodes[0].disconnect_p2ps()
|
|
|
|
self.log.info('SENDTXRCNCL should be sent before VERACK')
|
|
peer = self.nodes[0].add_p2p_connection(PeerTrackMsgOrder(), send_version=True, wait_for_verack=True)
|
|
peer.wait_for_verack()
|
|
verack_index = [i for i, msg in enumerate(peer.messages) if msg.msgtype == b'verack'][0]
|
|
sendtxrcncl_index = [i for i, msg in enumerate(peer.messages) if msg.msgtype == b'sendtxrcncl'][0]
|
|
assert sendtxrcncl_index < verack_index
|
|
self.nodes[0].disconnect_p2ps()
|
|
|
|
self.log.info('SENDTXRCNCL on pre-WTXID version should not be sent')
|
|
peer = self.nodes[0].add_p2p_connection(SendTxrcnclReceiver(), send_version=False, wait_for_verack=False)
|
|
pre_wtxid_version_msg = msg_version()
|
|
pre_wtxid_version_msg.nVersion = 70015
|
|
pre_wtxid_version_msg.strSubVer = P2P_SUBVERSION
|
|
pre_wtxid_version_msg.nServices = P2P_SERVICES
|
|
pre_wtxid_version_msg.relay = 1
|
|
peer.send_message(pre_wtxid_version_msg)
|
|
peer.wait_for_verack()
|
|
assert not peer.sendtxrcncl_msg_received
|
|
self.nodes[0].disconnect_p2ps()
|
|
|
|
self.log.info('SENDTXRCNCL for fRelay=false should not be sent')
|
|
peer = self.nodes[0].add_p2p_connection(SendTxrcnclReceiver(), send_version=False, wait_for_verack=False)
|
|
no_txrelay_version_msg = msg_version()
|
|
no_txrelay_version_msg.nVersion = P2P_VERSION
|
|
no_txrelay_version_msg.strSubVer = P2P_SUBVERSION
|
|
no_txrelay_version_msg.nServices = P2P_SERVICES
|
|
no_txrelay_version_msg.relay = 0
|
|
peer.send_message(no_txrelay_version_msg)
|
|
peer.wait_for_verack()
|
|
assert not peer.sendtxrcncl_msg_received
|
|
self.nodes[0].disconnect_p2ps()
|
|
|
|
self.log.info('SENDTXRCNCL for fRelay=false should not be sent (with NODE_BLOOM offered)')
|
|
self.restart_node(0, ["-peerbloomfilters", "-txreconciliation"])
|
|
peer = self.nodes[0].add_p2p_connection(SendTxrcnclReceiver(), send_version=False, wait_for_verack=False)
|
|
no_txrelay_version_msg = msg_version()
|
|
no_txrelay_version_msg.nVersion = P2P_VERSION
|
|
no_txrelay_version_msg.strSubVer = P2P_SUBVERSION
|
|
no_txrelay_version_msg.nServices = P2P_SERVICES
|
|
no_txrelay_version_msg.relay = 0
|
|
peer.send_message(no_txrelay_version_msg)
|
|
peer.wait_for_verack()
|
|
assert peer.nServices & NODE_BLOOM != 0
|
|
assert not peer.sendtxrcncl_msg_received
|
|
self.nodes[0].disconnect_p2ps()
|
|
|
|
# Now, *sending* to *outbound*.
|
|
self.log.info('SENDTXRCNCL sent to an outbound')
|
|
peer = self.nodes[0].add_outbound_p2p_connection(
|
|
SendTxrcnclReceiver(), wait_for_verack=True, p2p_idx=0, connection_type="outbound-full-relay")
|
|
assert peer.sendtxrcncl_msg_received
|
|
assert_equal(peer.sendtxrcncl_msg_received.version, 1)
|
|
self.nodes[0].disconnect_p2ps()
|
|
|
|
self.log.info('SENDTXRCNCL should not be sent if block-relay-only')
|
|
peer = self.nodes[0].add_outbound_p2p_connection(
|
|
SendTxrcnclReceiver(), wait_for_verack=True, p2p_idx=0, connection_type="block-relay-only")
|
|
assert not peer.sendtxrcncl_msg_received
|
|
self.nodes[0].disconnect_p2ps()
|
|
|
|
self.log.info("SENDTXRCNCL should not be sent if feeler")
|
|
peer = self.nodes[0].add_outbound_p2p_connection(P2PFeelerReceiver(), p2p_idx=0, connection_type="feeler")
|
|
assert not peer.sendtxrcncl_msg_received
|
|
self.nodes[0].disconnect_p2ps()
|
|
|
|
self.log.info("SENDTXRCNCL should not be sent if addrfetch")
|
|
peer = self.nodes[0].add_outbound_p2p_connection(
|
|
SendTxrcnclReceiver(), wait_for_verack=True, p2p_idx=0, connection_type="addr-fetch")
|
|
assert not peer.sendtxrcncl_msg_received
|
|
self.nodes[0].disconnect_p2ps()
|
|
|
|
self.log.info('SENDTXRCNCL not sent if -txreconciliation flag is not set')
|
|
self.restart_node(0, [])
|
|
peer = self.nodes[0].add_p2p_connection(SendTxrcnclReceiver(), send_version=True, wait_for_verack=True)
|
|
assert not peer.sendtxrcncl_msg_received
|
|
self.nodes[0].disconnect_p2ps()
|
|
|
|
self.log.info('SENDTXRCNCL not sent if blocksonly is set')
|
|
self.restart_node(0, ["-txreconciliation", "-blocksonly"])
|
|
peer = self.nodes[0].add_p2p_connection(SendTxrcnclReceiver(), send_version=True, wait_for_verack=True)
|
|
assert not peer.sendtxrcncl_msg_received
|
|
self.nodes[0].disconnect_p2ps()
|
|
|
|
# Check everything concerning *receiving* SENDTXRCNCL
|
|
# First, receiving from *inbound*.
|
|
self.restart_node(0, ["-txreconciliation"])
|
|
self.log.info('valid SENDTXRCNCL received')
|
|
peer = self.nodes[0].add_p2p_connection(PeerNoVerack(), send_version=True, wait_for_verack=False)
|
|
with self.nodes[0].assert_debug_log(["received: sendtxrcncl"]):
|
|
peer.send_message(create_sendtxrcncl_msg())
|
|
self.log.info('second SENDTXRCNCL triggers a disconnect')
|
|
with self.nodes[0].assert_debug_log(["(sendtxrcncl received from already registered peer); disconnecting"]):
|
|
peer.send_message(create_sendtxrcncl_msg())
|
|
peer.wait_for_disconnect()
|
|
|
|
self.restart_node(0, [])
|
|
self.log.info('SENDTXRCNCL if no txreconciliation supported is ignored')
|
|
peer = self.nodes[0].add_p2p_connection(PeerNoVerack(), send_version=True, wait_for_verack=False)
|
|
with self.nodes[0].assert_debug_log(['ignored, as our node does not have txreconciliation enabled']):
|
|
peer.send_message(create_sendtxrcncl_msg())
|
|
self.nodes[0].disconnect_p2ps()
|
|
|
|
self.restart_node(0, ["-txreconciliation"])
|
|
|
|
self.log.info('SENDTXRCNCL with version=0 triggers a disconnect')
|
|
sendtxrcncl_low_version = create_sendtxrcncl_msg()
|
|
sendtxrcncl_low_version.version = 0
|
|
peer = self.nodes[0].add_p2p_connection(PeerNoVerack(), send_version=True, wait_for_verack=False)
|
|
with self.nodes[0].assert_debug_log(["txreconciliation protocol violation"]):
|
|
peer.send_message(sendtxrcncl_low_version)
|
|
peer.wait_for_disconnect()
|
|
|
|
self.log.info('SENDTXRCNCL with version=2 is valid')
|
|
sendtxrcncl_higher_version = create_sendtxrcncl_msg()
|
|
sendtxrcncl_higher_version.version = 2
|
|
peer = self.nodes[0].add_p2p_connection(PeerNoVerack(), send_version=True, wait_for_verack=False)
|
|
with self.nodes[0].assert_debug_log(['Register peer=1']):
|
|
peer.send_message(sendtxrcncl_higher_version)
|
|
self.nodes[0].disconnect_p2ps()
|
|
|
|
self.log.info('unexpected SENDTXRCNCL is ignored')
|
|
peer = self.nodes[0].add_p2p_connection(PeerNoVerack(), send_version=False, wait_for_verack=False)
|
|
old_version_msg = msg_version()
|
|
old_version_msg.nVersion = 70015
|
|
old_version_msg.strSubVer = P2P_SUBVERSION
|
|
old_version_msg.nServices = P2P_SERVICES
|
|
old_version_msg.relay = 1
|
|
peer.send_message(old_version_msg)
|
|
with self.nodes[0].assert_debug_log(['Ignore unexpected txreconciliation signal']):
|
|
peer.send_message(create_sendtxrcncl_msg())
|
|
self.nodes[0].disconnect_p2ps()
|
|
|
|
self.log.info('sending SENDTXRCNCL after sending VERACK triggers a disconnect')
|
|
peer = self.nodes[0].add_p2p_connection(P2PInterface())
|
|
with self.nodes[0].assert_debug_log(["sendtxrcncl received after verack"]):
|
|
peer.send_message(create_sendtxrcncl_msg())
|
|
peer.wait_for_disconnect()
|
|
|
|
self.log.info('SENDTXRCNCL without WTXIDRELAY is ignored (recon state is erased after VERACK)')
|
|
peer = self.nodes[0].add_p2p_connection(PeerNoVerack(wtxidrelay=False), send_version=True, wait_for_verack=False)
|
|
with self.nodes[0].assert_debug_log(['Forget txreconciliation state of peer']):
|
|
peer.send_message(create_sendtxrcncl_msg())
|
|
peer.send_message(msg_verack())
|
|
self.nodes[0].disconnect_p2ps()
|
|
|
|
# Now, *receiving* from *outbound*.
|
|
self.log.info('SENDTXRCNCL if block-relay-only triggers a disconnect')
|
|
peer = self.nodes[0].add_outbound_p2p_connection(
|
|
PeerNoVerack(), wait_for_verack=False, p2p_idx=0, connection_type="block-relay-only")
|
|
with self.nodes[0].assert_debug_log(["we indicated no tx relay; disconnecting"]):
|
|
peer.send_message(create_sendtxrcncl_msg())
|
|
peer.wait_for_disconnect()
|
|
|
|
|
|
if __name__ == '__main__':
|
|
SendTxRcnclTest().main()
|