phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-01-26 19:23:26 -03:00
Code Issues Projects Releases Packages Wiki Activity Actions
bitcoin/ci/test
History
fanquake c9ed9927bb
Merge bitcoin/bitcoin#24132: build: Bump minimum Qt version to 5.11.3 
956f7322f6 build: Bump minimum Qt version to 5.11.3 (Hennadii Stepanov)
e22d10b936 ci: Switch from bionic to buster (Hennadii Stepanov)

Pull request description:

  The current minimum Qt version is 5.9.5 which has been set in bitcoin/bitcoin#21286.

  Distro support:
  - centos 7 -- unsupported since bitcoin/bitcoin#23511
  - centos 8 -- [5.15.2](http://mirror.centos.org/centos/8/AppStream/x86_64/os/Packages/qt5-qtbase-5.15.2-3.el8.x86_64.rpm)
  - buster -- [5.11.3](https://packages.debian.org/buster/libqt5core5a)
  - bullseye  -- [5.15.2](https://packages.debian.org/bullseye/libqt5core5a)
  - _bionic_ -- [5.9.5](https://packages.ubuntu.com/bionic/libqt5core5a)
  - focal -- [5.12.8](https://packages.ubuntu.com/focal/libqt5core5a)

  As another Ubuntu LTS is coming soon, it seems unreasonable to stick to Qt 5.9 which support [ended](https://www.qt.io/blog/2017/06/07/renewed-qt-support-services) on 2020-05-31. Anyway, it's still possible to build Bitcoin Core GUI with depends on bionic system.

  Bumping the minimum Qt version allows to make code safer and more reliable, e.g.:
  - functor-parameter overload of [`QMetaObject::invokeMethod`](https://doc.qt.io/qt-5/qmetaobject.html#invokeMethod-4)
  - fixed https://bugreports.qt.io/browse/QTBUG-10907

  An example of the patch using the functor-overload of `QMetaObject::invokeMethod`:
  ```diff
  --- a/src/qt/walletmodel.cpp
  +++ b/src/qt/walletmodel.cpp
  @@ -349,7 +349,7 @@ bool WalletModel::changePassphrase(const SecureString &oldPass, const SecureStri
   static void NotifyUnload(WalletModel* walletModel)
   {
       qDebug() << "NotifyUnload";
  -    bool invoked = QMetaObject::invokeMethod(walletModel, "unload");
  +    bool invoked = QMetaObject::invokeMethod(walletModel, &WalletModel::unload);
       assert(invoked);
   }

  ```
  It uses the same new syntax as signal-slot connection with compile-time check. Also see bitcoin/bitcoin#16348.

  This PR is intended to be merged early [after](https://github.com/bitcoin/bitcoin/issues/22969) branching `23.x` off.

ACKs for top commit:
  MarcoFalke:
    cr ACK 956f7322f6
  fanquake:
    ACK 956f7322f6

Tree-SHA512: 3d652bcdcd990ce785ad412ed70234d4f27743895e535a53ed44b35d4afc3052e066c4c84f417e30bc53d0a3dd9ebed62444c57b7c765cb1e9aa687fbf866877
2022-03-07 14:53:23 +00:00
..
00_setup_env.sh scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
00_setup_env_android.sh scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
00_setup_env_arm.sh scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
00_setup_env_i686_centos.sh ci: Bump CentOS 8 image 2022-02-01 10:13:25 +01:00
00_setup_env_i686_multiprocess.sh scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
00_setup_env_mac.sh build: use macOS 11 SDK (Xcode 12.2) 2022-01-26 17:28:16 +08:00
00_setup_env_mac_host.sh scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
00_setup_env_native_asan.sh build: use header-only Boost unit test 2022-02-13 20:59:02 +00:00
00_setup_env_native_fuzz.sh Merge bitcoin/bitcoin#24292: Revert "ci: Run fuzzer task for the master branch only" 2022-02-21 13:12:36 +00:00
00_setup_env_native_fuzz_with_msan.sh ci: add missing sqlite_cflags to MSAN fuzz job 2022-02-18 14:10:59 +00:00
00_setup_env_native_fuzz_with_valgrind.sh Merge bitcoin/bitcoin#24292: Revert "ci: Run fuzzer task for the master branch only" 2022-02-21 13:12:36 +00:00
00_setup_env_native_msan.sh ci: remove boost_cxxflags from MSAN CIs 2022-02-18 14:07:55 +00:00
00_setup_env_native_nowallet_libbitcoinkernel.sh ci: Build bitcoin-chainstate 2022-02-14 14:54:01 -05:00
00_setup_env_native_qt5.sh Merge bitcoin/bitcoin#24132: build: Bump minimum Qt version to 5.11.3 2022-03-07 14:53:23 +00:00
00_setup_env_native_tsan.sh Merge bitcoin/bitcoin#23912: Insert and bump copyright headers 2021-12-31 12:08:49 +01:00
00_setup_env_native_valgrind.sh build: use header-only Boost unit test 2022-02-13 20:59:02 +00:00
00_setup_env_s390x.sh test: Exclude broken feature_init for now 2022-02-04 16:33:36 +01:00
00_setup_env_win64.sh Merge bitcoin/bitcoin#24397: build: Fix Boost.Process check for Boost 1.73 and older 2022-02-28 14:06:16 +01:00
04_install.sh scripted-diff: Rename DOCKER_EXEC to CI_EXEC 2022-02-01 10:14:53 +01:00
05_before_script.sh ci: Drop no longer needed update-alternatives 2022-02-02 19:29:01 +02:00
06_script_a.sh ci: Force --enable-external-signer to prevent future regressions 2022-02-22 14:27:30 +02:00
06_script_b.sh scripted-diff: Rename DOCKER_EXEC to CI_EXEC 2022-02-01 10:14:53 +01:00
wrap-qemu.sh scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
wrap-valgrind.sh scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
wrap-wine.sh scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00