mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-04-29 14:59:39 -04:00
Instead of having a single NodeContext::shutdown member that is used both to request shutdowns and check if they have been requested, use separate members for each. Benefits of this change: 1. Should make code a little clearer and easier to search because it is easier to see which parts of code are triggering shutdowns and which parts are just checking to see if they were triggered. 2. Makes it possible for init.cpp to specify additional code to run when a shutdown is requested, like signalling the m_tip_block_cv condition variable. Motivation for this change was to remove hacky NodeContext argument and m_tip_block_cv access from the StopRPC function, so StopRPC can just be concerned with RPC functionality, not other node functionality.
201 lines
8.9 KiB
C++
201 lines
8.9 KiB
C++
// Copyright (c) 2022 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include <chain.h>
|
|
#include <chainparams.h>
|
|
#include <clientversion.h>
|
|
#include <node/blockstorage.h>
|
|
#include <node/context.h>
|
|
#include <node/kernel_notifications.h>
|
|
#include <script/solver.h>
|
|
#include <primitives/block.h>
|
|
#include <util/chaintype.h>
|
|
#include <validation.h>
|
|
|
|
#include <boost/test/unit_test.hpp>
|
|
#include <test/util/logging.h>
|
|
#include <test/util/setup_common.h>
|
|
|
|
using node::BLOCK_SERIALIZATION_HEADER_SIZE;
|
|
using node::BlockManager;
|
|
using node::KernelNotifications;
|
|
using node::MAX_BLOCKFILE_SIZE;
|
|
|
|
// use BasicTestingSetup here for the data directory configuration, setup, and cleanup
|
|
BOOST_FIXTURE_TEST_SUITE(blockmanager_tests, BasicTestingSetup)
|
|
|
|
BOOST_AUTO_TEST_CASE(blockmanager_find_block_pos)
|
|
{
|
|
const auto params {CreateChainParams(ArgsManager{}, ChainType::MAIN)};
|
|
KernelNotifications notifications{Assert(m_node.shutdown_request), m_node.exit_status, *Assert(m_node.warnings)};
|
|
const BlockManager::Options blockman_opts{
|
|
.chainparams = *params,
|
|
.blocks_dir = m_args.GetBlocksDirPath(),
|
|
.notifications = notifications,
|
|
};
|
|
BlockManager blockman{*Assert(m_node.shutdown_signal), blockman_opts};
|
|
// simulate adding a genesis block normally
|
|
BOOST_CHECK_EQUAL(blockman.SaveBlockToDisk(params->GenesisBlock(), 0).nPos, BLOCK_SERIALIZATION_HEADER_SIZE);
|
|
// simulate what happens during reindex
|
|
// simulate a well-formed genesis block being found at offset 8 in the blk00000.dat file
|
|
// the block is found at offset 8 because there is an 8 byte serialization header
|
|
// consisting of 4 magic bytes + 4 length bytes before each block in a well-formed blk file.
|
|
const FlatFilePos pos{0, BLOCK_SERIALIZATION_HEADER_SIZE};
|
|
blockman.UpdateBlockInfo(params->GenesisBlock(), 0, pos);
|
|
// now simulate what happens after reindex for the first new block processed
|
|
// the actual block contents don't matter, just that it's a block.
|
|
// verify that the write position is at offset 0x12d.
|
|
// this is a check to make sure that https://github.com/bitcoin/bitcoin/issues/21379 does not recur
|
|
// 8 bytes (for serialization header) + 285 (for serialized genesis block) = 293
|
|
// add another 8 bytes for the second block's serialization header and we get 293 + 8 = 301
|
|
FlatFilePos actual{blockman.SaveBlockToDisk(params->GenesisBlock(), 1)};
|
|
BOOST_CHECK_EQUAL(actual.nPos, BLOCK_SERIALIZATION_HEADER_SIZE + ::GetSerializeSize(TX_WITH_WITNESS(params->GenesisBlock())) + BLOCK_SERIALIZATION_HEADER_SIZE);
|
|
}
|
|
|
|
BOOST_FIXTURE_TEST_CASE(blockmanager_scan_unlink_already_pruned_files, TestChain100Setup)
|
|
{
|
|
// Cap last block file size, and mine new block in a new block file.
|
|
const auto& chainman = Assert(m_node.chainman);
|
|
auto& blockman = chainman->m_blockman;
|
|
const CBlockIndex* old_tip{WITH_LOCK(chainman->GetMutex(), return chainman->ActiveChain().Tip())};
|
|
WITH_LOCK(chainman->GetMutex(), blockman.GetBlockFileInfo(old_tip->GetBlockPos().nFile)->nSize = MAX_BLOCKFILE_SIZE);
|
|
CreateAndProcessBlock({}, GetScriptForRawPubKey(coinbaseKey.GetPubKey()));
|
|
|
|
// Prune the older block file, but don't unlink it
|
|
int file_number;
|
|
{
|
|
LOCK(chainman->GetMutex());
|
|
file_number = old_tip->GetBlockPos().nFile;
|
|
blockman.PruneOneBlockFile(file_number);
|
|
}
|
|
|
|
const FlatFilePos pos(file_number, 0);
|
|
|
|
// Check that the file is not unlinked after ScanAndUnlinkAlreadyPrunedFiles
|
|
// if m_have_pruned is not yet set
|
|
WITH_LOCK(chainman->GetMutex(), blockman.ScanAndUnlinkAlreadyPrunedFiles());
|
|
BOOST_CHECK(!blockman.OpenBlockFile(pos, true).IsNull());
|
|
|
|
// Check that the file is unlinked after ScanAndUnlinkAlreadyPrunedFiles
|
|
// once m_have_pruned is set
|
|
blockman.m_have_pruned = true;
|
|
WITH_LOCK(chainman->GetMutex(), blockman.ScanAndUnlinkAlreadyPrunedFiles());
|
|
BOOST_CHECK(blockman.OpenBlockFile(pos, true).IsNull());
|
|
|
|
// Check that calling with already pruned files doesn't cause an error
|
|
WITH_LOCK(chainman->GetMutex(), blockman.ScanAndUnlinkAlreadyPrunedFiles());
|
|
|
|
// Check that the new tip file has not been removed
|
|
const CBlockIndex* new_tip{WITH_LOCK(chainman->GetMutex(), return chainman->ActiveChain().Tip())};
|
|
BOOST_CHECK_NE(old_tip, new_tip);
|
|
const int new_file_number{WITH_LOCK(chainman->GetMutex(), return new_tip->GetBlockPos().nFile)};
|
|
const FlatFilePos new_pos(new_file_number, 0);
|
|
BOOST_CHECK(!blockman.OpenBlockFile(new_pos, true).IsNull());
|
|
}
|
|
|
|
BOOST_FIXTURE_TEST_CASE(blockmanager_block_data_availability, TestChain100Setup)
|
|
{
|
|
// The goal of the function is to return the first not pruned block in the range [upper_block, lower_block].
|
|
LOCK(::cs_main);
|
|
auto& chainman = m_node.chainman;
|
|
auto& blockman = chainman->m_blockman;
|
|
const CBlockIndex& tip = *chainman->ActiveTip();
|
|
|
|
// Function to prune all blocks from 'last_pruned_block' down to the genesis block
|
|
const auto& func_prune_blocks = [&](CBlockIndex* last_pruned_block)
|
|
{
|
|
LOCK(::cs_main);
|
|
CBlockIndex* it = last_pruned_block;
|
|
while (it != nullptr && it->nStatus & BLOCK_HAVE_DATA) {
|
|
it->nStatus &= ~BLOCK_HAVE_DATA;
|
|
it = it->pprev;
|
|
}
|
|
};
|
|
|
|
// 1) Return genesis block when all blocks are available
|
|
BOOST_CHECK_EQUAL(blockman.GetFirstBlock(tip, BLOCK_HAVE_DATA), chainman->ActiveChain()[0]);
|
|
BOOST_CHECK(blockman.CheckBlockDataAvailability(tip, *chainman->ActiveChain()[0]));
|
|
|
|
// 2) Check lower_block when all blocks are available
|
|
CBlockIndex* lower_block = chainman->ActiveChain()[tip.nHeight / 2];
|
|
BOOST_CHECK(blockman.CheckBlockDataAvailability(tip, *lower_block));
|
|
|
|
// Prune half of the blocks
|
|
int height_to_prune = tip.nHeight / 2;
|
|
CBlockIndex* first_available_block = chainman->ActiveChain()[height_to_prune + 1];
|
|
CBlockIndex* last_pruned_block = first_available_block->pprev;
|
|
func_prune_blocks(last_pruned_block);
|
|
|
|
// 3) The last block not pruned is in-between upper-block and the genesis block
|
|
BOOST_CHECK_EQUAL(blockman.GetFirstBlock(tip, BLOCK_HAVE_DATA), first_available_block);
|
|
BOOST_CHECK(blockman.CheckBlockDataAvailability(tip, *first_available_block));
|
|
BOOST_CHECK(!blockman.CheckBlockDataAvailability(tip, *last_pruned_block));
|
|
}
|
|
|
|
BOOST_AUTO_TEST_CASE(blockmanager_flush_block_file)
|
|
{
|
|
KernelNotifications notifications{Assert(m_node.shutdown_request), m_node.exit_status, *Assert(m_node.warnings)};
|
|
node::BlockManager::Options blockman_opts{
|
|
.chainparams = Params(),
|
|
.blocks_dir = m_args.GetBlocksDirPath(),
|
|
.notifications = notifications,
|
|
};
|
|
BlockManager blockman{*Assert(m_node.shutdown_signal), blockman_opts};
|
|
|
|
// Test blocks with no transactions, not even a coinbase
|
|
CBlock block1;
|
|
block1.nVersion = 1;
|
|
CBlock block2;
|
|
block2.nVersion = 2;
|
|
CBlock block3;
|
|
block3.nVersion = 3;
|
|
|
|
// They are 80 bytes header + 1 byte 0x00 for vtx length
|
|
constexpr int TEST_BLOCK_SIZE{81};
|
|
|
|
// Blockstore is empty
|
|
BOOST_CHECK_EQUAL(blockman.CalculateCurrentUsage(), 0);
|
|
|
|
// Write the first block to a new location.
|
|
FlatFilePos pos1{blockman.SaveBlockToDisk(block1, /*nHeight=*/1)};
|
|
|
|
// Write second block
|
|
FlatFilePos pos2{blockman.SaveBlockToDisk(block2, /*nHeight=*/2)};
|
|
|
|
// Two blocks in the file
|
|
BOOST_CHECK_EQUAL(blockman.CalculateCurrentUsage(), (TEST_BLOCK_SIZE + BLOCK_SERIALIZATION_HEADER_SIZE) * 2);
|
|
|
|
// First two blocks are written as expected
|
|
// Errors are expected because block data is junk, thrown AFTER successful read
|
|
CBlock read_block;
|
|
BOOST_CHECK_EQUAL(read_block.nVersion, 0);
|
|
{
|
|
ASSERT_DEBUG_LOG("ReadBlockFromDisk: Errors in block header");
|
|
BOOST_CHECK(!blockman.ReadBlockFromDisk(read_block, pos1));
|
|
BOOST_CHECK_EQUAL(read_block.nVersion, 1);
|
|
}
|
|
{
|
|
ASSERT_DEBUG_LOG("ReadBlockFromDisk: Errors in block header");
|
|
BOOST_CHECK(!blockman.ReadBlockFromDisk(read_block, pos2));
|
|
BOOST_CHECK_EQUAL(read_block.nVersion, 2);
|
|
}
|
|
|
|
// During reindex, the flat file block storage will not be written to.
|
|
// UpdateBlockInfo will, however, update the blockfile metadata.
|
|
// Verify this behavior by attempting (and failing) to write block 3 data
|
|
// to block 2 location.
|
|
CBlockFileInfo* block_data = blockman.GetBlockFileInfo(0);
|
|
BOOST_CHECK_EQUAL(block_data->nBlocks, 2);
|
|
blockman.UpdateBlockInfo(block3, /*nHeight=*/3, /*pos=*/pos2);
|
|
// Metadata is updated...
|
|
BOOST_CHECK_EQUAL(block_data->nBlocks, 3);
|
|
// ...but there are still only two blocks in the file
|
|
BOOST_CHECK_EQUAL(blockman.CalculateCurrentUsage(), (TEST_BLOCK_SIZE + BLOCK_SERIALIZATION_HEADER_SIZE) * 2);
|
|
|
|
// Block 2 was not overwritten:
|
|
blockman.ReadBlockFromDisk(read_block, pos2);
|
|
BOOST_CHECK_EQUAL(read_block.nVersion, 2);
|
|
}
|
|
|
|
BOOST_AUTO_TEST_SUITE_END()
|